mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: eliminate duplicate code exposing process APIs (#15824)

Browse source
This commit is contained in:
Milan Burda 2018-11-28 17:08:17 +01:00 • committed by Shelley Vohr
parent d7d4b8638d
commit 07f8f5f95a
4 changed files with 40 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

11
atom/common/api/atom_bindings.h
View file

@ -17,6 +17,10 @@
#include "uv.h" // NOLINT(build/include)
#include "v8/include/v8.h"
namespace mate {
class Dictionary;
}
namespace memory_instrumentation {
class GlobalMemoryDump;
}
@ -43,8 +47,14 @@ class AtomBindings {
// Should be called when a node::Environment has been destroyed.
void EnvironmentDestroyed(node::Environment* env);
static void BindProcess(v8::Isolate* isolate,
mate::Dictionary* process,
base::ProcessMetrics* metrics);
static void Log(const base::string16& message);
static void Crash();
private:
static void Hang();
static v8::Local<v8::Value> GetHeapStatistics(v8::Isolate* isolate);
static v8::Local<v8::Value> GetCreationTime(v8::Isolate* isolate);
@ -57,7 +67,6 @@ class AtomBindings {
static bool TakeHeapSnapshot(v8::Isolate* isolate,
const base::FilePath& file_path);
private:
void ActivateUVLoop(v8::Isolate* isolate);
static void OnCallNextTick(uv_async_t* handle);