mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: crash when showin item in folder on DevTools (#33024)

Browse source
This commit is contained in:
Shelley Vohr 2022-03-08 11:40:25 -08:00 committed by GitHub
parent b96f15bfc2
commit 076bc58b2a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
shell/browser/ui/inspectable_web_contents.cc
View file

@ -175,6 +175,10 @@ GURL GetDevToolsURL(bool can_dock) {
return GURL(url_string); return GURL(url_string);
} }
void OnOpenItemComplete(const base::FilePath& path, const std::string& result) {
platform_util::ShowItemInFolder(path);
}
constexpr base::TimeDelta kInitialBackoffDelay = base::Milliseconds(250); constexpr base::TimeDelta kInitialBackoffDelay = base::Milliseconds(250);
constexpr base::TimeDelta kMaxBackoffDelay = base::Seconds(10); constexpr base::TimeDelta kMaxBackoffDelay = base::Seconds(10);
@ -737,9 +741,8 @@ void InspectableWebContents::ShowItemInFolder(
return; return;
base::FilePath path = base::FilePath::FromUTF8Unsafe(file_system_path); base::FilePath path = base::FilePath::FromUTF8Unsafe(file_system_path);
platform_util::OpenPath(path.DirName(),
// Pass empty callback here; we can ignore errors base::BindOnce(&OnOpenItemComplete, path));
platform_util::OpenPath(path, platform_util::OpenCallback());
} }
void InspectableWebContents::SaveToFile(const std::string& url, void InspectableWebContents::SaveToFile(const std::string& url,