mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Leak the Node environment when context is released

Browse source
This commit is contained in:
Cheng Zhao 2017-07-24 14:56:56 +09:00
parent 25f168cecb
commit 0719650315
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
atom/renderer/atom_renderer_client.cc
View file

@ -132,7 +132,12 @@ void AtomRendererClient::WillReleaseScriptContext(
node_bindings_->set_uv_env(nullptr); node_bindings_->set_uv_env(nullptr);
// Destroy the node environment. // Destroy the node environment.
node::FreeEnvironment(env); // This is disabled because pending async tasks may still use the environment
// and would cause crashes later. Node does not seem to clear all async tasks
// when the environment is destroyed.
// node::FreeEnvironment(env);
// AtomBindings is tracking node environments.
atom_bindings_->EnvironmentDestroyed(env); atom_bindings_->EnvironmentDestroyed(env);
} }