mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: make intermediates work with 'select-client-certificate' (#29552)

Browse source
This commit is contained in:
David Sanders 2021-06-07 06:40:43 -07:00 • committed by GitHub
commit 070f25db54
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

12
shell/browser/api/electron_api_app.cc
View file

@ -536,10 +536,16 @@ void OnClientCertificateSelected(
if (!certs.empty()) { if (!certs.empty()) {
scoped_refptr<net::X509Certificate> cert(certs[0].get()); scoped_refptr<net::X509Certificate> cert(certs[0].get());
for (auto& identity : *identities) { for (auto& identity : *identities) {
if (cert->EqualsExcludingChain(identity->certificate())) { scoped_refptr<net::X509Certificate> identity_cert =
identity->certificate();
// Since |cert| was recreated from |data|, it won't include any
// intermediates. That's fine for checking equality, but once a match is
// found then |identity_cert| should be used since it will include the
// intermediates which would otherwise be lost.
if (cert->EqualsExcludingChain(identity_cert.get())) {
net::ClientCertIdentity::SelfOwningAcquirePrivateKey( net::ClientCertIdentity::SelfOwningAcquirePrivateKey(
std::move(identity), std::move(identity), base::BindRepeating(&GotPrivateKey, delegate,
base::BindRepeating(&GotPrivateKey, delegate, std::move(cert))); std::move(identity_cert)));
break; break;
} }
} }