From 06d7a51a586fda203db91e21963c8fe15fb368d3 Mon Sep 17 00:00:00 2001 From: John Kleinschmidt Date: Mon, 28 Jul 2025 13:37:05 -0400 Subject: [PATCH] ci: fixup mac runners (#47877) ci: make sure camera and bluetooth are available on macos ci: turn off spotlight indexing --- .github/actions/free-space-macos/action.yml | 5 ++++- .github/workflows/pipeline-segment-electron-test.yml | 2 ++ spec/chromium-spec.ts | 5 +++-- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/actions/free-space-macos/action.yml b/.github/actions/free-space-macos/action.yml index cf6b2d3bcaa8..efdea79f1ed5 100644 --- a/.github/actions/free-space-macos/action.yml +++ b/.github/actions/free-space-macos/action.yml @@ -6,6 +6,8 @@ runs: - name: Free Space on MacOS shell: bash run: | + echo "Disk usage before cleanup:" + df -h sudo mkdir -p $TMPDIR/del-target tmpify() { @@ -73,4 +75,5 @@ runs: # lipo off some huge binaries arm64 versions to save space strip_universal_deep $(xcode-select -p)/../SharedFrameworks - # strip_arm_deep /System/Volumes/Data/Library/Developer/CommandLineTools/usr \ No newline at end of file + # strip_arm_deep /System/Volumes/Data/Library/Developer/CommandLineTools/usr + sudo mdutil -a -i off diff --git a/.github/workflows/pipeline-segment-electron-test.yml b/.github/workflows/pipeline-segment-electron-test.yml index d9adbb0c7ef7..54da0faa6ad0 100644 --- a/.github/workflows/pipeline-segment-electron-test.yml +++ b/.github/workflows/pipeline-segment-electron-test.yml @@ -104,6 +104,8 @@ jobs: "'kTCCServiceCamera','/usr/local/opt/runner/provisioner/provisioner',1,2,4,1,NULL,NULL,0,'UNUSED',NULL,0,1687786159" "'kTCCServiceBluetoothAlways','/usr/local/opt/runner/provisioner/provisioner',1,2,4,1,NULL,NULL,0,'UNUSED',NULL,0,1687786159" "'kTCCServiceAppleEvents','/usr/local/opt/runner/provisioner/provisioner',1,2,4,1,NULL,NULL,0,'UNUSED',NULL,0,1687786159" + "'kTCCServiceCamera',' /opt/hca/hosted-compute-agent',1,2,4,1,NULL,NULL,0,'UNUSED',NULL,0,1687786159" + "'kTCCServiceBluetoothAlways',' /opt/hca/hosted-compute-agent',1,2,4,1,NULL,NULL,0,'UNUSED',NULL,0,1687786159" ) for values in "${userValuesArray[@]}"; do # Sonoma and higher have a few extra values diff --git a/spec/chromium-spec.ts b/spec/chromium-spec.ts index e066294969dc..1003c0b079f2 100644 --- a/spec/chromium-spec.ts +++ b/spec/chromium-spec.ts @@ -3106,7 +3106,7 @@ describe('iframe using HTML fullscreen API while window is OS-fullscreened', () }); }); -ifdescribe(process.platform !== 'darwin' || process.arch !== 'arm64')('navigator.serial', () => { +describe('navigator.serial', () => { let w: BrowserWindow; before(async () => { w = new BrowserWindow({ @@ -3130,6 +3130,7 @@ ifdescribe(process.platform !== 'darwin' || process.arch !== 'arm64')('navigator }); it('does not return a port if select-serial-port event is not defined', async () => { + // Take screenshot to verify the test is running w.loadFile(path.join(fixturesPath, 'pages', 'blank.html')); const port = await getPorts(); expect(port).to.equal(notFoundError); @@ -3646,7 +3647,7 @@ ifdescribe((process.platform !== 'linux' || app.isUnityRunning()))('navigator.se }); }); -ifdescribe(process.platform !== 'darwin' || process.arch !== 'arm64')('navigator.bluetooth', () => { +describe('navigator.bluetooth', () => { let w: BrowserWindow; before(async () => { w = new BrowserWindow({