refactor: make node Buffers more friendly to base::span
/ std::span
(#46724)
* refactor: add electron::Buffer namespace; move the Buffer as_byte_span() into it * feat: add electron::Buffer::Copy() a span-friendly version of node::Buffer::Copy() * refactor: use electron::Buffer::Copy() in electron_api_base_window.cc * refactor: use electron::Buffer::Copy() in electron_api_data_pipe_holder.cc * refactor: use electron::Buffer::Copy() in electron_api_safe_storage.cc * refactor: use electron::Buffer::Copy() in electron_api_clipboard.cc * refactor: use electron::Buffer::Copy() in osr_converter.cc * refactor: use electron::Buffer::Copy() in electron_api_native_image.cc * refactor: use electron::Buffer::Copy() in net_converter.cc * refactor: use electron::Buffer::Copy() in electron_api_web_contents.cc * refactor: make NewEmptyBuffer() return a Local<Value>
This commit is contained in:
parent
1976e935e7
commit
06a99d6770
10 changed files with 93 additions and 72 deletions
|
@ -53,11 +53,23 @@ node::Environment* CreateEnvironment(v8::Isolate* isolate,
|
|||
node::EnvironmentFlags::Flags env_flags,
|
||||
std::string_view process_type = "");
|
||||
|
||||
} // namespace electron::util
|
||||
|
||||
namespace electron::Buffer {
|
||||
|
||||
// Convenience function to view a Node buffer's data as a base::span().
|
||||
// Analogous to base::as_byte_span()
|
||||
[[nodiscard]] base::span<uint8_t> as_byte_span(
|
||||
v8::Local<v8::Value> node_buffer);
|
||||
|
||||
} // namespace electron::util
|
||||
// span-friendly version of node::Buffer::Copy()
|
||||
[[nodiscard]] v8::MaybeLocal<v8::Object> Copy(v8::Isolate* isolate,
|
||||
base::span<const char> data);
|
||||
|
||||
// span-friendly version of node::Buffer::Copy()
|
||||
[[nodiscard]] v8::MaybeLocal<v8::Object> Copy(v8::Isolate* isolate,
|
||||
base::span<const uint8_t> data);
|
||||
|
||||
} // namespace electron::Buffer
|
||||
|
||||
#endif // ELECTRON_SHELL_COMMON_NODE_UTIL_H_
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue