From 0646cbfba6f55641d3f74f75fbc125ddfefde031 Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Tue, 1 Oct 2024 13:51:06 -0500 Subject: [PATCH] fix: -Wunsafe-buffer-usage warnings in WebFrameRenderer::ExecuteJavaScript() (#44075) Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr --- shell/renderer/api/electron_api_web_frame.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/shell/renderer/api/electron_api_web_frame.cc b/shell/renderer/api/electron_api_web_frame.cc index 2750e17a435..5424994f51e 100644 --- a/shell/renderer/api/electron_api_web_frame.cc +++ b/shell/renderer/api/electron_api_web_frame.cc @@ -9,6 +9,7 @@ #include #include +#include "base/containers/span.h" #include "base/memory/memory_pressure_listener.h" #include "base/strings/utf_string_conversions.h" #include "components/spellcheck/renderer/spellcheck.h" @@ -653,7 +654,7 @@ class WebFrameRenderer final : public gin::Wrappable, std::move(completion_callback)); render_frame->GetWebFrame()->RequestExecuteScript( - blink::DOMWrapperWorld::kMainWorldId, base::make_span(&source, 1u), + blink::DOMWrapperWorld::kMainWorldId, base::span_from_ref(source), has_user_gesture ? blink::mojom::UserActivationOption::kActivate : blink::mojom::UserActivationOption::kDoNotActivate, blink::mojom::EvaluationTiming::kSynchronous,