mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Merge pull request #8616 from electron/renew-symbol-trick

Browse source 
Simplify the trick used for referencing symbols
This commit is contained in:
Cheng Zhao 2017-02-08 07:56:28 +09:00 • committed by GitHub
commit 0643d98d99
2 changed files with 39 additions and 55 deletions
Download patch file Download diff file Expand all files Collapse all files

38
atom/node/osfhandle.cc
View file

@ -6,6 +6,22 @@
#include <io.h>
#define U_I18N_IMPLEMENTATION
#include "third_party/icu/source/common/unicode/ubidi.h"
#include "third_party/icu/source/common/unicode/uchar.h"
#include "third_party/icu/source/common/unicode/uidna.h"
#include "third_party/icu/source/common/unicode/unistr.h"
#include "third_party/icu/source/common/unicode/unorm.h"
#include "third_party/icu/source/common/unicode/urename.h"
#include "third_party/icu/source/common/unicode/ustring.h"
#include "third_party/icu/source/i18n/unicode/measfmt.h"
#include "third_party/icu/source/i18n/unicode/translit.h"
#include "third_party/icu/source/i18n/unicode/ucsdet.h"
#include "third_party/icu/source/i18n/unicode/ulocdata.h"
#include "third_party/icu/source/i18n/unicode/uregex.h"
#include "third_party/icu/source/i18n/unicode/uspoof.h"
#include "third_party/icu/source/i18n/unicode/usearch.h"
#include "v8-profiler.h"
#include "v8-inspector.h"
@ -21,12 +37,30 @@ int close(int fd) {
void ReferenceSymbols() {
// Following symbols are used by electron.exe but got stripped by compiler,
// for some reason, adding them to ForceSymbolReferences does not work,
// probably because of VC++ bugs.
// by using the symbols we can force compiler to keep the objects in node.dll,
// thus electron.exe can link with the exported symbols.
// v8_profiler symbols:
v8::TracingCpuProfiler::Create(nullptr);
// v8_inspector symbols:
reinterpret_cast<v8_inspector::V8InspectorSession*>(nullptr)->
canDispatchMethod(v8_inspector::StringView());
reinterpret_cast<v8_inspector::V8InspectorClient*>(nullptr)->unmuteMetrics(0);
// icu symbols:
u_errorName(U_ZERO_ERROR);
ubidi_setPara(nullptr, nullptr, 0, 0, nullptr, nullptr);
ucsdet_getName(nullptr, nullptr);
uidna_openUTS46(UIDNA_CHECK_BIDI, nullptr);
ulocdata_close(nullptr);
unorm_normalize(nullptr, 0, UNORM_NFC, 0, nullptr, 0, nullptr);
uregex_matches(nullptr, 0, nullptr);
uspoof_open(nullptr);
usearch_setPattern(nullptr, nullptr, 0, nullptr);
usearch_setPattern(nullptr, nullptr, 0, nullptr);
UMeasureFormatWidth width = UMEASFMT_WIDTH_WIDE;
UErrorCode status = U_ZERO_ERROR;
icu::MeasureFormat format(icu::Locale::getRoot(), width, status);
reinterpret_cast<icu::Transliterator*>(nullptr)->clone();
}
} // namespace node