mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: use noop ShouldAbortOnUncaughtException cb (#25772)

Browse source
This commit is contained in:
Shelley Vohr 2020-10-06 11:16:49 -07:00 • committed by GitHub
parent 5be9dcad46
commit 0632d59da0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
shell/common/node_bindings.cc
View file

@ -430,6 +430,12 @@ node::Environment* NodeBindings::CreateEnvironment(
// crash message and location to CrashReports. // crash message and location to CrashReports.
is.fatal_error_callback = V8FatalErrorCallback; is.fatal_error_callback = V8FatalErrorCallback;
// We don't want to abort either in the renderer or browser processes.
// We already listen for uncaught exceptions and handle them there.
is.should_abort_on_uncaught_exception_callback = [](v8::Isolate*) {
return false;
};
if (browser_env_ == BrowserEnvironment::BROWSER) { if (browser_env_ == BrowserEnvironment::BROWSER) {
// Node.js requires that microtask checkpoints be explicitly invoked. // Node.js requires that microtask checkpoints be explicitly invoked.
is.policy = v8::MicrotasksPolicy::kExplicit; is.policy = v8::MicrotasksPolicy::kExplicit;