mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

extrapolate removeExtraParameter into new method

Browse source
This commit is contained in:
Shelley Vohr 2017-10-30 23:12:04 -04:00
parent 603060f051
commit 06075c4499
No known key found for this signature in database
GPG key ID: F13993A75599653C
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
atom/common/api/atom_api_crash_reporter.cc
View file

@ -31,11 +31,11 @@ struct Converter<CrashReporter::UploadReportResult> {
namespace {
void SetExtraParameter(const std::string& key, mate::Arguments* args) {
std::string value;
if (args->GetNext(&value))
void SetExtraParameter(const std::string& key, const std::string& value) {
CrashReporter::GetInstance()->SetExtraParameter(key, value);
else
}
void RemoveExtraParameter(const std::string& key) {
CrashReporter::GetInstance()->RemoveExtraParameter(key);
}
@ -46,6 +46,7 @@ void Initialize(v8::Local<v8::Object> exports, v8::Local<v8::Value> unused,
auto reporter = base::Unretained(CrashReporter::GetInstance());
dict.SetMethod("start", base::Bind(&CrashReporter::Start, reporter));
dict.SetMethod("setExtraParameter", &SetExtraParameter);
dict.SetMethod("removeExtraParameter", &SetExtraParameter);
dict.SetMethod("getUploadedReports",
base::Bind(&CrashReporter::GetUploadedReports, reporter));
dict.SetMethod("setUploadToServer",