mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: delegate to PrintViewManagerBase on failed print (#34893)

Browse source 
fix: delegate to PrintViewManagerBase on failed print
This commit is contained in:
Shelley Vohr 2022-07-19 14:46:08 +02:00 committed by GitHub
parent eb8c9452cb
commit 05d4966251
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
shell/browser/printing/print_view_manager_electron.cc
View file

@ -163,12 +163,23 @@ void PrintViewManagerElectron::ScriptedPrint(
} }
void PrintViewManagerElectron::ShowInvalidPrinterSettingsError() { void PrintViewManagerElectron::ShowInvalidPrinterSettingsError() {
if (headless_jobs_.size() == 0) {
PrintViewManagerBase::ShowInvalidPrinterSettingsError();
return;
}
ReleaseJob(INVALID_PRINTER_SETTINGS); ReleaseJob(INVALID_PRINTER_SETTINGS);
} }
void PrintViewManagerElectron::PrintingFailed( void PrintViewManagerElectron::PrintingFailed(
int32_t cookie, int32_t cookie,
printing::mojom::PrintFailureReason reason) { printing::mojom::PrintFailureReason reason) {
auto entry = std::find(headless_jobs_.begin(), headless_jobs_.end(), cookie);
if (entry == headless_jobs_.end()) {
PrintViewManagerBase::PrintingFailed(cookie, reason);
return;
}
ReleaseJob(reason == printing::mojom::PrintFailureReason::kInvalidPageRange ReleaseJob(reason == printing::mojom::PrintFailureReason::kInvalidPageRange
? PAGE_COUNT_EXCEEDED ? PAGE_COUNT_EXCEEDED
: PRINTING_FAILED); : PRINTING_FAILED);