mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix getFavcion api in webview to return dataUrl

Browse source
This commit is contained in:
deepak1556 2015-04-25 09:00:24 +05:30
parent 36819e2638
commit 05be71e9bc
5 changed files with 13 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

8
atom/renderer/lib/web-view/web-view.coffee
View file

@ -236,7 +236,6 @@ registerWebViewElement = ->
methods = [
"getUrl"
"getTitle"
"getFavicon"
"isLoading"
"isWaitingForResponse"
"stop"
@ -277,6 +276,13 @@ registerWebViewElement = ->
remote.getGuestWebContents(internal.guestInstanceId)[m] args...
proto[m] = createHandler m for m in methods
# Return dataUrl instead of nativeImage.
proto.getFavicon = (args...) ->
internal = v8Util.getHiddenValue this, 'internal'
return unless internal
favicon = remote.getGuestWebContents(internal.guestInstanceId)['getFavicon'] args...
favicon.toDataUrl()
window.WebView = webFrame.registerEmbedderCustomElement 'webview',
prototype: proto