From f5699ad3a6cb3ada6f057501fba68073cba915f8 Mon Sep 17 00:00:00 2001 From: Milan Burda Date: Tue, 7 Jun 2016 10:42:46 +0200 Subject: [PATCH] Document 'zoom' role + add missing menu items (Delete / Paste and Match Style / Zoom) --- default_app/main.js | 27 +++++++++++++++++++++++++-- docs/api/menu-item.md | 1 + docs/api/menu.md | 27 +++++++++++++++++++++++++-- 3 files changed, 51 insertions(+), 4 deletions(-) diff --git a/default_app/main.js b/default_app/main.js index 37f69cd93b89..4bf4dac14ecd 100644 --- a/default_app/main.js +++ b/default_app/main.js @@ -80,6 +80,15 @@ app.once('ready', () => { accelerator: 'CmdOrCtrl+V', role: 'paste' }, + { + label: 'Paste and Match Style', + accelerator: 'Shift+Command+V', + role: 'pasteandmatchstyle' + }, + { + label: 'Delete', + role: 'delete' + }, { label: 'Select All', accelerator: 'CmdOrCtrl+A', @@ -210,7 +219,21 @@ app.once('ready', () => { } ] }) - template[3].submenu.push( + template[3].submenu = [ + { + label: 'Close', + accelerator: 'CmdOrCtrl+W', + role: 'close' + }, + { + label: 'Minimize', + accelerator: 'CmdOrCtrl+M', + role: 'minimize' + }, + { + label: 'Zoom', + role: 'zoom' + }, { type: 'separator' }, @@ -218,7 +241,7 @@ app.once('ready', () => { label: 'Bring All to Front', role: 'front' } - ) + ] } const menu = Menu.buildFromTemplate(template) diff --git a/docs/api/menu-item.md b/docs/api/menu-item.md index c12b14cc0bc5..e53e98e0e347 100644 --- a/docs/api/menu-item.md +++ b/docs/api/menu-item.md @@ -59,6 +59,7 @@ On OS X `role` can also have following additional values: * `hideothers` - Map to the `hideOtherApplications` action * `unhide` - Map to the `unhideAllApplications` action * `front` - Map to the `arrangeInFront` action +* `zoom` - Map to the `performZoom` action * `window` - The submenu is a "Window" menu * `help` - The submenu is a "Help" menu * `services` - The submenu is a "Services" menu diff --git a/docs/api/menu.md b/docs/api/menu.md index 2b555fd83d60..7f0783c1b272 100644 --- a/docs/api/menu.md +++ b/docs/api/menu.md @@ -66,6 +66,15 @@ const template = [ accelerator: 'CmdOrCtrl+V', role: 'paste' }, + { + label: 'Paste and Match Style', + accelerator: 'Shift+Command+V', + role: 'pasteandmatchstyle' + }, + { + label: 'Delete', + role: 'delete' + }, { label: 'Select All', accelerator: 'CmdOrCtrl+A', @@ -174,7 +183,21 @@ if (process.platform === 'darwin') { ] }); // Window menu. - template[3].submenu.push( + template[3].submenu = [ + { + label: 'Close', + accelerator: 'CmdOrCtrl+W', + role: 'close' + }, + { + label: 'Minimize', + accelerator: 'CmdOrCtrl+M', + role: 'minimize' + }, + { + label: 'Zoom', + role: 'zoom' + }, { type: 'separator' }, @@ -182,7 +205,7 @@ if (process.platform === 'darwin') { label: 'Bring All to Front', role: 'front' } - ); + ]; } const menu = Menu.buildFromTemplate(template);