mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Address @jkleinsc's 2018-03-21 comments

Browse source
This commit is contained in:
Charles Kerr 2018-04-13 16:10:53 -05:00 committed by GitHub
parent 35a512310a
commit 03d119d539
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
docs/development/releasing.md
View file

@ -207,7 +207,7 @@ release
$ npm run release -- --validateRelease $ npm run release -- --validateRelease
``` ```
## Merge temporary branch ## Merge temporary branch (pre-2-0-x branches only)
Once the release builds have finished, merge the `release` branch back into Once the release builds have finished, merge the `release` branch back into
the source release branch using the `merge-release` script. the source release branch using the `merge-release` script.
If the branch cannot be successfully merged back this script will automatically If the branch cannot be successfully merged back this script will automatically
@ -252,7 +252,7 @@ Removing old .npmrc (default)
Activating .npmrc "electron" Activating .npmrc "electron"
``` ```
The Electron account's credentials are stored in LastPass under the entry The Electron account's credentials are kept by GitHub.
"Electron - NPM" for the URL "https://www.npmjs.com/login". "Electron - NPM" for the URL "https://www.npmjs.com/login".
```sh ```sh
$ npm login $ npm login
@ -268,8 +268,11 @@ electron
$ npm run publish-to-npm $ npm run publish-to-npm
``` ```
Note: the `publish-to-npm` script may have trouble with Node 7 or higher. If Note: In general you should be using the latest Node during this
you have trouble, try running with an older version of Node, e.g. a 6.x LTS. process; however, older versions of the `publish-to-npm` script
may have trouble with Node 7 or higher. If you have trouble with
this in an older branch, try running with an older version of Node,
e.g. a 6.x LTS.
[the releases page]: https://github.com/electron/electron/releases [the releases page]: https://github.com/electron/electron/releases
[this bump commit]: https://github.com/electron/electron/commit/78ec1b8f89b3886b856377a1756a51617bc33f5a [this bump commit]: https://github.com/electron/electron/commit/78ec1b8f89b3886b856377a1756a51617bc33f5a