mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: fix typos in comments (#29401)

Browse source
This commit is contained in:
David Sanders 2021-05-31 18:42:38 -07:00 • committed by GitHub
commit 038359a7d8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
shell/browser/api/electron_api_web_request.cc
View file

@ -387,7 +387,7 @@ void WebRequest::SetListener(Event event,
std::set<std::string> filter_patterns; std::set<std::string> filter_patterns;
gin::Dictionary dict(args->isolate()); gin::Dictionary dict(args->isolate());
if (args->GetNext(&arg) && !arg->IsFunction()) { if (args->GetNext(&arg) && !arg->IsFunction()) {
// Note that gin treats Function as Dictionary when doing convertions, so we // Note that gin treats Function as Dictionary when doing conversions, so we
// have to explicitly check if the argument is Function before trying to // have to explicitly check if the argument is Function before trying to
// convert it to Dictionary. // convert it to Dictionary.
if (gin::ConvertFromV8(args->isolate(), arg, &dict)) { if (gin::ConvertFromV8(args->isolate(), arg, &dict)) {

2
shell/browser/ui/accelerator_util.h
View file

@ -23,7 +23,7 @@ typedef std::map<ui::Accelerator, MenuItem> AcceleratorTable;
bool StringToAccelerator(const std::string& description, bool StringToAccelerator(const std::string& description,
ui::Accelerator* accelerator); ui::Accelerator* accelerator);
// Generate a table that contains memu model's accelerators and command ids. // Generate a table that contains menu model's accelerators and command ids.
void GenerateAcceleratorTable(AcceleratorTable* table, void GenerateAcceleratorTable(AcceleratorTable* table,
electron::ElectronMenuModel* model); electron::ElectronMenuModel* model);

4
shell/common/gin_helper/callback.h
View file

@ -14,7 +14,7 @@
#include "shell/common/gin_helper/function_template.h" #include "shell/common/gin_helper/function_template.h"
#include "shell/common/gin_helper/locker.h" #include "shell/common/gin_helper/locker.h"
#include "shell/common/gin_helper/microtasks_scope.h" #include "shell/common/gin_helper/microtasks_scope.h"
// Implements safe convertions between JS functions and base::RepeatingCallback. // Implements safe conversions between JS functions and base::RepeatingCallback.
namespace gin_helper { namespace gin_helper {
@ -110,7 +110,7 @@ struct V8FunctionInvoker<ReturnType(ArgTypes...)> {
} }
}; };
// Helper to pass a C++ funtion to JavaScript. // Helper to pass a C++ function to JavaScript.
using Translater = base::RepeatingCallback<void(gin::Arguments* args)>; using Translater = base::RepeatingCallback<void(gin::Arguments* args)>;
v8::Local<v8::Value> CreateFunctionFromTranslater(v8::Isolate* isolate, v8::Local<v8::Value> CreateFunctionFromTranslater(v8::Isolate* isolate,
const Translater& translater, const Translater& translater,

2
shell/common/gin_helper/function_template.h
View file

@ -96,7 +96,7 @@ bool GetNextArgument(gin::Arguments* args,
} }
// Support base::Optional as output, which would be empty and do not throw error // Support base::Optional as output, which would be empty and do not throw error
// when convertion to T fails. // when conversion to T fails.
template <typename T> template <typename T>
bool GetNextArgument(gin::Arguments* args, bool GetNextArgument(gin::Arguments* args,
int create_flags, int create_flags,