mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

linux: Put "uploads.log" under "/tmp/ProductName Crashes/"

Browse source
This commit is contained in:
Cheng Zhao 2014-11-11 13:30:06 +08:00
parent f13d8407ee
commit 02bcdc1c19
3 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
atom/common/crash_reporter/crash_reporter_linux.cc
View file

@ -17,6 +17,7 @@
#include "base/logging.h" #include "base/logging.h"
#include "base/process/memory.h" #include "base/process/memory.h"
#include "base/memory/singleton.h" #include "base/memory/singleton.h"
#include "base/strings/stringprintf.h"
#include "vendor/breakpad/src/client/linux/handler/exception_handler.h" #include "vendor/breakpad/src/client/linux/handler/exception_handler.h"
#include "vendor/breakpad/src/common/linux/linux_libc_support.h" #include "vendor/breakpad/src/common/linux/linux_libc_support.h"
@ -81,6 +82,10 @@ void CrashReporterLinux::EnableCrashDumping(const std::string& product_name) {
base::FilePath dumps_path(dump_dir); base::FilePath dumps_path(dump_dir);
base::CreateDirectory(dumps_path); base::CreateDirectory(dumps_path);
std::string log_file = base::StringPrintf(
"%s/%s", dump_dir.c_str(), "uploads.log");
strncpy(g_crash_log_path, log_file.c_str(), sizeof(g_crash_log_path));
MinidumpDescriptor minidump_descriptor(dumps_path.value()); MinidumpDescriptor minidump_descriptor(dumps_path.value());
minidump_descriptor.set_size_limit(kMaxMinidumpFileSize); minidump_descriptor.set_size_limit(kMaxMinidumpFileSize);

4
atom/common/crash_reporter/linux/crash_dump_handler.cc
View file

@ -441,7 +441,7 @@ void HandleCrashReportId(const char* buf, size_t bytes_read,
my_uint64tos(time_str, time, time_len); my_uint64tos(time_str, time, time_len);
const int kLogOpenFlags = O_CREAT | O_WRONLY | O_APPEND | O_CLOEXEC; const int kLogOpenFlags = O_CREAT | O_WRONLY | O_APPEND | O_CLOEXEC;
int log_fd = sys_open("/tmp/uploads.log", kLogOpenFlags, 0600); int log_fd = sys_open(g_crash_log_path, kLogOpenFlags, 0600);
if (log_fd > 0) { if (log_fd > 0) {
sys_write(log_fd, time_str, time_len); sys_write(log_fd, time_str, time_len);
sys_write(log_fd, ",", 1); sys_write(log_fd, ",", 1);
@ -454,6 +454,8 @@ void HandleCrashReportId(const char* buf, size_t bytes_read,
} // namespace } // namespace
char g_crash_log_path[256];
void HandleCrashDump(const BreakpadInfo& info) { void HandleCrashDump(const BreakpadInfo& info) {
int dumpfd; int dumpfd;
bool keep_fd = false; bool keep_fd = false;

3
atom/common/crash_reporter/linux/crash_dump_handler.h
View file

@ -34,6 +34,9 @@ void HandleCrashDump(const BreakpadInfo& info);
size_t WriteLog(const char* buf, size_t nbytes); size_t WriteLog(const char* buf, size_t nbytes);
size_t WriteNewline(); size_t WriteNewline();
// Global variable storing the path of upload log.
extern char g_crash_log_path[256];
} // namespace crash_reporter } // namespace crash_reporter
#endif // ATOM_COMMON_CRASH_REPORTER_LINUX_CRASH_DUMP_HANDLER_H_ #endif // ATOM_COMMON_CRASH_REPORTER_LINUX_CRASH_DUMP_HANDLER_H_