mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix crash when requesting invalid url

Browse source
This commit is contained in:
Cheng Zhao 2015-08-13 21:21:23 +08:00
parent 741c8f3d98
commit 02714d466c
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
atom/browser/net/url_request_fetch_job.cc
View file

@ -96,6 +96,14 @@ void URLRequestFetchJob::StartAsync(scoped_ptr<base::Value> options) {
dict->GetString("referrer", &referrer); dict->GetString("referrer", &referrer);
dict->Get("session", &session); dict->Get("session", &session);
// Check if URL is valid.
GURL formated_url(url);
if (!formated_url.is_valid()) {
NotifyStartError(net::URLRequestStatus(
net::URLRequestStatus::FAILED, net::ERR_INVALID_URL));
return;
}
// Use |request|'s method if |method| is not specified. // Use |request|'s method if |method| is not specified.
net::URLFetcher::RequestType request_type; net::URLFetcher::RequestType request_type;
if (method.empty()) if (method.empty())
@ -103,7 +111,7 @@ void URLRequestFetchJob::StartAsync(scoped_ptr<base::Value> options) {
else else
request_type = GetRequestType(method); request_type = GetRequestType(method);
fetcher_ = net::URLFetcher::Create(GURL(url), request_type, this); fetcher_ = net::URLFetcher::Create(formated_url, request_type, this);
fetcher_->SaveResponseWithWriter(make_scoped_ptr(new ResponsePiper(this))); fetcher_->SaveResponseWithWriter(make_scoped_ptr(new ResponsePiper(this)));
// When |session| is set to |null| we use a new request context for fetch job. // When |session| is set to |null| we use a new request context for fetch job.