mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: NSWindow crash happening on macos 10.9 (#15660)

Browse source
This commit is contained in:
Nitish Sakhawalkar 2018-11-10 05:53:35 -08:00 • committed by Alexey Kuzmin
commit 025aa49f67
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
atom/browser/native_window_mac.mm
View file

@ -517,6 +517,11 @@ void NativeWindowMac::Close() {
} }
void NativeWindowMac::CloseImmediately() { void NativeWindowMac::CloseImmediately() {
// Retain the child window before closing it. If the last reference to the
// NSWindow goes away inside -[NSWindow close], then bad stuff can happen.
// See e.g. http://crbug.com/616701.
base::scoped_nsobject<NSWindow> child_window(window_,
base::scoped_policy::RETAIN);
[window_ close]; [window_ close];
} }