mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 2

fix: modernize-use-nodiscard clang-tidy warnings (#44808)

Browse source
This commit is contained in:
Charles Kerr 2024-11-25 09:48:28 -06:00 • committed by GitHub
parent 7e7010dacf
commit 024fee4e44
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 14 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

2
shell/renderer/api/electron_api_spell_check_client.cc
View file

@ -58,7 +58,7 @@ class SpellCheckClient::SpellcheckRequest {
SpellcheckRequest& operator=(const SpellcheckRequest&) = delete;
~SpellcheckRequest() = default;
const std::u16string& text() const { return text_; }
[[nodiscard]] const std::u16string& text() const { return text_; }
blink::WebTextCheckingCompletion* completion() { return completion_.get(); }
std::vector<Word>& wordlist() { return word_list_; }

2
shell/renderer/renderer_client_base.cc
View file

@ -132,7 +132,7 @@ class ChromePdfInternalPluginDelegate final
~ChromePdfInternalPluginDelegate() override = default;
// `pdf::PdfInternalPluginDelegate`:
bool IsAllowedOrigin(const url::Origin& origin) const override {
[[nodiscard]] bool IsAllowedOrigin(const url::Origin& origin) const override {
return origin.scheme() == extensions::kExtensionScheme &&
origin.host() == extension_misc::kPdfExtensionId;
}