fix: modernize-use-nodiscard clang-tidy warnings (#44808)
This commit is contained in:
parent
7e7010dacf
commit
024fee4e44
9 changed files with 14 additions and 14 deletions
|
@ -150,7 +150,7 @@ class BufferDataSource : public mojo::DataPipeProducer::DataSource {
|
|||
|
||||
private:
|
||||
// mojo::DataPipeProducer::DataSource:
|
||||
uint64_t GetLength() const override { return buffer_.size(); }
|
||||
[[nodiscard]] uint64_t GetLength() const override { return buffer_.size(); }
|
||||
ReadResult Read(uint64_t offset, base::span<char> buffer) override {
|
||||
ReadResult result;
|
||||
if (offset <= buffer_.size()) {
|
||||
|
|
|
@ -38,12 +38,12 @@ class ElectronPermissionMessageProvider
|
|||
const ElectronPermissionMessageProvider&) = delete;
|
||||
|
||||
// PermissionMessageProvider implementation.
|
||||
extensions::PermissionMessages GetPermissionMessages(
|
||||
[[nodiscard]] extensions::PermissionMessages GetPermissionMessages(
|
||||
const extensions::PermissionIDSet& permissions) const override {
|
||||
return extensions::PermissionMessages();
|
||||
}
|
||||
|
||||
bool IsPrivilegeIncrease(
|
||||
[[nodiscard]] bool IsPrivilegeIncrease(
|
||||
const extensions::PermissionSet& granted_permissions,
|
||||
const extensions::PermissionSet& requested_permissions,
|
||||
extensions::Manifest::Type extension_type) const override {
|
||||
|
@ -52,7 +52,7 @@ class ElectronPermissionMessageProvider
|
|||
return false;
|
||||
}
|
||||
|
||||
extensions::PermissionIDSet GetAllPermissionIDs(
|
||||
[[nodiscard]] extensions::PermissionIDSet GetAllPermissionIDs(
|
||||
const extensions::PermissionSet& permissions,
|
||||
extensions::Manifest::Type extension_type) const override {
|
||||
return extensions::PermissionIDSet();
|
||||
|
|
|
@ -54,7 +54,7 @@ struct OffscreenReleaseHolderMonitor {
|
|||
holder_ = nullptr;
|
||||
}
|
||||
|
||||
bool IsTextureReleased() const { return holder_ == nullptr; }
|
||||
[[nodiscard]] bool IsTextureReleased() const { return holder_ == nullptr; }
|
||||
|
||||
v8::Persistent<v8::Value>* CreatePersistent(v8::Isolate* isolate,
|
||||
v8::Local<v8::Value> value) {
|
||||
|
|
|
@ -88,7 +88,7 @@ class RefCountedGlobal
|
|||
RefCountedGlobal(v8::Isolate* isolate, v8::Local<v8::Value> value)
|
||||
: handle_(isolate, value.As<T>()) {}
|
||||
|
||||
bool IsAlive() const { return !handle_.IsEmpty(); }
|
||||
[[nodiscard]] bool IsAlive() const { return !handle_.IsEmpty(); }
|
||||
|
||||
v8::Local<T> NewHandle(v8::Isolate* isolate) const {
|
||||
return v8::Local<T>::New(isolate, handle_);
|
||||
|
|
|
@ -18,7 +18,7 @@ class HeapSnapshotOutputStream : public v8::OutputStream {
|
|||
DCHECK(file_);
|
||||
}
|
||||
|
||||
bool IsComplete() const { return is_complete_; }
|
||||
[[nodiscard]] bool IsComplete() const { return is_complete_; }
|
||||
|
||||
// v8::OutputStream
|
||||
int GetChunkSize() override { return 65536; }
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue