mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

refactor: remove deprecated ToInternalValue() (#40980)

Browse source 
* refactor: do not use deprecated ToInternalValue() in ElectronExtensionLoader::FinishExtensionLoad()

* refactor: do not use deprecated ToInternalValue() in NotificationPresenterWin::SaveIconToFilesystem()

* chore: rename temp variable to now_usec for clarity
This commit is contained in:
Charles Kerr 2024-01-17 09:17:43 -06:00 committed by GitHub
parent 6803624576
commit 021592200e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
shell/browser/extensions/electron_extension_loader.cc
View file

@ -148,10 +148,11 @@ void ElectronExtensionLoader::FinishExtensionLoad(
ExtensionPrefs::ScopedDictionaryUpdate update( ExtensionPrefs::ScopedDictionaryUpdate update(
extension_prefs, extension.get()->id(), extension_prefs, extension.get()->id(),
extensions::pref_names::kPrefPreferences); extensions::pref_names::kPrefPreferences);
auto preference = update.Create(); auto preference = update.Create();
const base::Time install_time = base::Time::Now(); const int64_t now_usec =
preference->SetString( base::Time::Now().since_origin().InMicroseconds();
"install_time", base::NumberToString(install_time.ToInternalValue())); preference->SetString("install_time", base::NumberToString(now_usec));
} }
} }

5
shell/browser/notifications/win/notification_presenter_win.cc
View file

@ -14,6 +14,7 @@
#include "base/files/file_util.h" #include "base/files/file_util.h"
#include "base/hash/md5.h" #include "base/hash/md5.h"
#include "base/logging.h" #include "base/logging.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/utf_string_conversions.h" #include "base/strings/utf_string_conversions.h"
#include "base/time/time.h" #include "base/time/time.h"
#include "base/win/windows_version.h" #include "base/win/windows_version.h"
@ -75,8 +76,8 @@ std::wstring NotificationPresenterWin::SaveIconToFilesystem(
if (origin.is_valid()) { if (origin.is_valid()) {
filename = base::MD5String(origin.spec()) + ".png"; filename = base::MD5String(origin.spec()) + ".png";
} else { } else {
base::TimeTicks now = base::TimeTicks::Now(); const int64_t now_usec = base::Time::Now().since_origin().InMicroseconds();
filename = std::to_string(now.ToInternalValue()) + ".png"; filename = base::NumberToString(now_usec) + ".png";
} }
ScopedAllowBlockingForElectron allow_blocking; ScopedAllowBlockingForElectron allow_blocking;