mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test: disable flaky linux arm/arm64 crash test case (#36094)

Browse source 
test: disable failing linux arm/arm64 crash test case
This commit is contained in:
John Kleinschmidt 2022-10-20 18:06:06 -04:00 committed by GitHub
parent 7921fec761
commit 0158077bec
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
spec/crash-spec.ts
View file

@ -31,6 +31,22 @@ const runFixtureAndEnsureCleanExit = (args: string[]) => {
}); });
}; };
const shouldRunCase = (crashCase: string) => {
switch (crashCase) {
// TODO(jkleinsc) fix this flaky test on Windows 32-bit
case 'quit-on-crashed-event': {
return (process.platform !== 'win32' || process.arch !== 'ia32');
}
// TODO(jkleinsc) fix this test on Linux on arm/arm64
case 'js-execute-iframe': {
return (process.platform !== 'linux' || (process.arch !== 'arm64' && process.arch !== 'arm'));
}
default: {
return true;
}
}
};
describe('crash cases', () => { describe('crash cases', () => {
afterEach(() => { afterEach(() => {
for (const child of children) { for (const child of children) {
@ -42,8 +58,7 @@ describe('crash cases', () => {
const cases = fs.readdirSync(fixturePath); const cases = fs.readdirSync(fixturePath);
for (const crashCase of cases) { for (const crashCase of cases) {
// TODO(jkleinsc) fix this flaky test on Windows 32-bit ifit(shouldRunCase(crashCase))(`the "${crashCase}" case should not crash`, () => {
ifit(process.platform !== 'win32' || process.arch !== 'ia32' || crashCase !== 'quit-on-crashed-event')(`the "${crashCase}" case should not crash`, () => {
const fixture = path.resolve(fixturePath, crashCase); const fixture = path.resolve(fixturePath, crashCase);
const argsFile = path.resolve(fixture, 'electron.args'); const argsFile = path.resolve(fixture, 'electron.args');
const args = [fixture]; const args = [fixture];