mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: prefer member initializers in asar structs (#43883)

Browse source 
prefactor: prefer member initializers in asar::Archive

prefactor: prefer member initializers in asar::Archive::FileInfo

prefactor: prefer member initializers in asar::IntegrityPayload
This commit is contained in:
Charles Kerr 2024-09-24 00:37:18 -05:00 • committed by GitHub
parent 33d7c9ac3e
commit 01330805cb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 11 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

16
shell/common/asar/archive.h
View file

@ -31,9 +31,9 @@ struct IntegrityPayload {
IntegrityPayload();
~IntegrityPayload();
IntegrityPayload(const IntegrityPayload& other);
HashAlgorithm algorithm;
HashAlgorithm algorithm = HashAlgorithm::kNone;
std::string hash;
uint32_t block_size;
uint32_t block_size = 0U;
std::vector<std::string> blocks;
};
@ -44,10 +44,10 @@ class Archive {
struct FileInfo {
FileInfo();
~FileInfo();
bool unpacked;
bool executable;
uint32_t size;
uint64_t offset;
bool unpacked = false;
bool executable = false;
uint32_t size = 0U;
uint64_t offset = 0U;
std::optional<IntegrityPayload> integrity;
};
@ -100,10 +100,10 @@ class Archive {
base::FilePath path() const { return path_; }
private:
bool initialized_;
bool initialized_ = false;
bool header_validated_ = false;
const base::FilePath path_;
base::File file_;
base::File file_{base::File::FILE_OK};
int fd_ = -1;
uint32_t header_size_ = 0;
std::optional<base::Value::Dict> header_;