mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Don't separate node bindings into renderer and browser part.

Browse source 
Since we are going to use embeding thread to implement message
integration on all platforms, we do not need to separate renderer and
browser anymore.
This commit is contained in:
Cheng Zhao 2013-07-22 16:05:35 +08:00
parent bc62d8c2c5
commit 008b8d404d
11 changed files with 64 additions and 123 deletions
Download patch file Download diff file Expand all files Collapse all files

2
browser/atom_browser_main_parts.cc
View file

@ -20,7 +20,7 @@ AtomBrowserMainParts* AtomBrowserMainParts::self_ = NULL;
AtomBrowserMainParts::AtomBrowserMainParts()
: atom_bindings_(new AtomBrowserBindings),
browser_(new Browser),
node_bindings_(NodeBindings::CreateInBrowser()) {
node_bindings_(NodeBindings::Create(true)) {
DCHECK(!self_) << "Cannot have two AtomBrowserMainParts";
self_ = this;
}

27
browser/node_bindings_browser_win.cc
View file

@ -1,27 +0,0 @@
// Copyright (c) 2013 GitHub, Inc. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "browser/node_bindings_browser_win.h"
namespace atom {
NodeBindingsBrowserWin::NodeBindingsBrowserWin()
: NodeBindings(true) {
}
NodeBindingsBrowserWin::~NodeBindingsBrowserWin() {
}
void NodeBindingsBrowserWin::PrepareMessageLoop() {
}
void NodeBindingsBrowserWin::RunMessageLoop() {
}
// static
NodeBindings* NodeBindings::CreateInBrowser() {
return new NodeBindingsBrowserWin();
}
} // namespace atom

27
browser/node_bindings_browser_win.h
View file

@ -1,27 +0,0 @@
// Copyright (c) 2013 GitHub, Inc. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef ATOM_BROWSER_NODE_BINDINGS_BROWSER_WIN_H_
#define ATOM_BROWSER_NODE_BINDINGS_BROWSER_WIN_H_
#include "base/compiler_specific.h"
#include "common/node_bindings.h"
namespace atom {
class NodeBindingsBrowserWin : public NodeBindings {
public:
NodeBindingsBrowserWin();
virtual ~NodeBindingsBrowserWin();
virtual void PrepareMessageLoop() OVERRIDE;
virtual void RunMessageLoop() OVERRIDE;
private:
DISALLOW_COPY_AND_ASSIGN(NodeBindingsBrowserWin);
};
} // namespace atom
#endif // ATOM_BROWSER_NODE_BINDINGS_BROWSER_WIN_H_