chore: add/fix interface comments for sections of methods (#42566)
This commit is contained in:
parent
18abeb3add
commit
003c32331d
46 changed files with 58 additions and 13 deletions
|
@ -30,10 +30,9 @@ class ElectronMainDelegate : public content::ContentMainDelegate {
|
||||||
ElectronMainDelegate(const ElectronMainDelegate&) = delete;
|
ElectronMainDelegate(const ElectronMainDelegate&) = delete;
|
||||||
ElectronMainDelegate& operator=(const ElectronMainDelegate&) = delete;
|
ElectronMainDelegate& operator=(const ElectronMainDelegate&) = delete;
|
||||||
|
|
||||||
base::StringPiece GetBrowserV8SnapshotFilename() override;
|
|
||||||
|
|
||||||
protected:
|
protected:
|
||||||
// content::ContentMainDelegate:
|
// content::ContentMainDelegate:
|
||||||
|
base::StringPiece GetBrowserV8SnapshotFilename() override;
|
||||||
std::optional<int> BasicStartupComplete() override;
|
std::optional<int> BasicStartupComplete() override;
|
||||||
void PreSandboxStartup() override;
|
void PreSandboxStartup() override;
|
||||||
void SandboxInitialized(const std::string& process_type) override;
|
void SandboxInitialized(const std::string& process_type) override;
|
||||||
|
|
|
@ -36,7 +36,7 @@ class AutoUpdater : public gin::Wrappable<AutoUpdater>,
|
||||||
AutoUpdater();
|
AutoUpdater();
|
||||||
~AutoUpdater() override;
|
~AutoUpdater() override;
|
||||||
|
|
||||||
// Delegate implementations.
|
// auto_updater::Delegate:
|
||||||
void OnError(const std::string& message) override;
|
void OnError(const std::string& message) override;
|
||||||
void OnError(const std::string& message,
|
void OnError(const std::string& message,
|
||||||
const int code,
|
const int code,
|
||||||
|
|
|
@ -18,6 +18,7 @@ class MenuMac : public Menu {
|
||||||
explicit MenuMac(gin::Arguments* args);
|
explicit MenuMac(gin::Arguments* args);
|
||||||
~MenuMac() override;
|
~MenuMac() override;
|
||||||
|
|
||||||
|
// Menu
|
||||||
void PopupAt(BaseWindow* window,
|
void PopupAt(BaseWindow* window,
|
||||||
int x,
|
int x,
|
||||||
int y,
|
int y,
|
||||||
|
|
|
@ -21,6 +21,7 @@ class MenuViews : public Menu {
|
||||||
~MenuViews() override;
|
~MenuViews() override;
|
||||||
|
|
||||||
protected:
|
protected:
|
||||||
|
// Menu
|
||||||
void PopupAt(BaseWindow* window,
|
void PopupAt(BaseWindow* window,
|
||||||
int x,
|
int x,
|
||||||
int y,
|
int y,
|
||||||
|
|
|
@ -155,6 +155,7 @@ class JSLayoutManager : public views::LayoutManagerBase {
|
||||||
: layout_callback_(std::move(layout_callback)) {}
|
: layout_callback_(std::move(layout_callback)) {}
|
||||||
~JSLayoutManager() override {}
|
~JSLayoutManager() override {}
|
||||||
|
|
||||||
|
// views::LayoutManagerBase
|
||||||
views::ProposedLayout CalculateProposedLayout(
|
views::ProposedLayout CalculateProposedLayout(
|
||||||
const views::SizeBounds& size_bounds) const override {
|
const views::SizeBounds& size_bounds) const override {
|
||||||
v8::Isolate* isolate = JavascriptEnvironment::GetIsolate();
|
v8::Isolate* isolate = JavascriptEnvironment::GetIsolate();
|
||||||
|
|
|
@ -170,7 +170,9 @@ class WebContents : public ExclusiveAccessContext,
|
||||||
void Close(std::optional<gin_helper::Dictionary> options);
|
void Close(std::optional<gin_helper::Dictionary> options);
|
||||||
base::WeakPtr<WebContents> GetWeakPtr() { return weak_factory_.GetWeakPtr(); }
|
base::WeakPtr<WebContents> GetWeakPtr() { return weak_factory_.GetWeakPtr(); }
|
||||||
|
|
||||||
|
// BackgroundThrottlingSource
|
||||||
bool GetBackgroundThrottling() const override;
|
bool GetBackgroundThrottling() const override;
|
||||||
|
|
||||||
void SetBackgroundThrottling(bool allowed);
|
void SetBackgroundThrottling(bool allowed);
|
||||||
int GetProcessID() const;
|
int GetProcessID() const;
|
||||||
base::ProcessId GetOSProcessID() const;
|
base::ProcessId GetOSProcessID() const;
|
||||||
|
@ -345,6 +347,7 @@ class WebContents : public ExclusiveAccessContext,
|
||||||
const base::FilePath& file_path);
|
const base::FilePath& file_path);
|
||||||
v8::Local<v8::Promise> GetProcessMemoryInfo(v8::Isolate* isolate);
|
v8::Local<v8::Promise> GetProcessMemoryInfo(v8::Isolate* isolate);
|
||||||
|
|
||||||
|
// content::WebContentsDelegate:
|
||||||
bool HandleContextMenu(content::RenderFrameHost& render_frame_host,
|
bool HandleContextMenu(content::RenderFrameHost& render_frame_host,
|
||||||
const content::ContextMenuParams& params) override;
|
const content::ContextMenuParams& params) override;
|
||||||
|
|
||||||
|
|
|
@ -46,11 +46,12 @@ class FrameSubscriber : private content::WebContentsObserver,
|
||||||
void AttachToHost(content::RenderWidgetHost* host);
|
void AttachToHost(content::RenderWidgetHost* host);
|
||||||
void DetachFromHost();
|
void DetachFromHost();
|
||||||
|
|
||||||
|
// content::WebContentsObserver
|
||||||
void RenderFrameCreated(content::RenderFrameHost* render_frame_host) override;
|
void RenderFrameCreated(content::RenderFrameHost* render_frame_host) override;
|
||||||
void PrimaryPageChanged(content::Page& page) override;
|
void PrimaryPageChanged(content::Page& page) override;
|
||||||
void RenderViewDeleted(content::RenderViewHost* host) override;
|
void RenderViewDeleted(content::RenderViewHost* host) override;
|
||||||
|
|
||||||
// viz::mojom::FrameSinkVideoConsumer implementation.
|
// viz::mojom::FrameSinkVideoConsumer
|
||||||
void OnFrameCaptured(
|
void OnFrameCaptured(
|
||||||
::media::mojom::VideoBufferHandlePtr data,
|
::media::mojom::VideoBufferHandlePtr data,
|
||||||
::media::mojom::VideoFrameInfoPtr info,
|
::media::mojom::VideoFrameInfoPtr info,
|
||||||
|
|
|
@ -30,6 +30,8 @@ class GPUInfoEnumerator final : public gpu::GPUInfo::Enumerator {
|
||||||
public:
|
public:
|
||||||
GPUInfoEnumerator();
|
GPUInfoEnumerator();
|
||||||
~GPUInfoEnumerator() override;
|
~GPUInfoEnumerator() override;
|
||||||
|
|
||||||
|
// gpu::GPUInfo::Enumerator
|
||||||
void AddInt64(const char* name, int64_t value) override;
|
void AddInt64(const char* name, int64_t value) override;
|
||||||
void AddInt(const char* name, int value) override;
|
void AddInt(const char* name, int value) override;
|
||||||
void AddString(const char* name, const std::string& value) override;
|
void AddString(const char* name, const std::string& value) override;
|
||||||
|
|
|
@ -31,6 +31,7 @@ class GPUInfoManager : private content::GpuDataManagerObserver {
|
||||||
void FetchBasicInfo(gin_helper::Promise<base::Value> promise);
|
void FetchBasicInfo(gin_helper::Promise<base::Value> promise);
|
||||||
|
|
||||||
private:
|
private:
|
||||||
|
// content::GpuDataManagerObserver
|
||||||
void OnGpuInfoUpdate() override;
|
void OnGpuInfoUpdate() override;
|
||||||
|
|
||||||
base::Value::Dict EnumerateGPUInfo(gpu::GPUInfo gpu_info) const;
|
base::Value::Dict EnumerateGPUInfo(gpu::GPUInfo gpu_info) const;
|
||||||
|
|
|
@ -51,7 +51,6 @@ class BrowserProcessImpl : public BrowserProcess {
|
||||||
|
|
||||||
static void ApplyProxyModeFromCommandLine(ValueMapPrefStore* pref_store);
|
static void ApplyProxyModeFromCommandLine(ValueMapPrefStore* pref_store);
|
||||||
|
|
||||||
BuildState* GetBuildState() override;
|
|
||||||
void PostEarlyInitialization();
|
void PostEarlyInitialization();
|
||||||
void PreCreateThreads();
|
void PreCreateThreads();
|
||||||
void PreMainMessageLoopRun();
|
void PreMainMessageLoopRun();
|
||||||
|
@ -68,6 +67,8 @@ class BrowserProcessImpl : public BrowserProcess {
|
||||||
}
|
}
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
|
// BrowserProcess
|
||||||
|
BuildState* GetBuildState() override;
|
||||||
void EndSession() override {}
|
void EndSession() override {}
|
||||||
void FlushLocalStateAndReply(base::OnceClosure reply) override {}
|
void FlushLocalStateAndReply(base::OnceClosure reply) override {}
|
||||||
bool IsShuttingDown() override;
|
bool IsShuttingDown() override;
|
||||||
|
|
|
@ -30,6 +30,7 @@ class AutofillDriver : public mojom::ElectronAutofillDriver {
|
||||||
mojo::PendingAssociatedReceiver<mojom::ElectronAutofillDriver>
|
mojo::PendingAssociatedReceiver<mojom::ElectronAutofillDriver>
|
||||||
pending_receiver);
|
pending_receiver);
|
||||||
|
|
||||||
|
// mojom::ElectronAutofillDriver
|
||||||
void ShowAutofillPopup(const gfx::RectF& bounds,
|
void ShowAutofillPopup(const gfx::RectF& bounds,
|
||||||
const std::vector<std::u16string>& values,
|
const std::vector<std::u16string>& values,
|
||||||
const std::vector<std::u16string>& labels) override;
|
const std::vector<std::u16string>& labels) override;
|
||||||
|
|
|
@ -135,6 +135,8 @@ class LinuxUiGetterImpl : public ui::LinuxUiGetter {
|
||||||
public:
|
public:
|
||||||
LinuxUiGetterImpl() = default;
|
LinuxUiGetterImpl() = default;
|
||||||
~LinuxUiGetterImpl() override = default;
|
~LinuxUiGetterImpl() override = default;
|
||||||
|
|
||||||
|
// ui::LinuxUiGetter
|
||||||
ui::LinuxUiTheme* GetForWindow(aura::Window* window) override {
|
ui::LinuxUiTheme* GetForWindow(aura::Window* window) override {
|
||||||
return GetForProfile(nullptr);
|
return GetForProfile(nullptr);
|
||||||
}
|
}
|
||||||
|
|
|
@ -19,8 +19,8 @@ class ElectronNavigationThrottle : public content::NavigationThrottle {
|
||||||
ElectronNavigationThrottle& operator=(const ElectronNavigationThrottle&) =
|
ElectronNavigationThrottle& operator=(const ElectronNavigationThrottle&) =
|
||||||
delete;
|
delete;
|
||||||
|
|
||||||
|
// content::NavigationThrottle
|
||||||
ElectronNavigationThrottle::ThrottleCheckResult WillStartRequest() override;
|
ElectronNavigationThrottle::ThrottleCheckResult WillStartRequest() override;
|
||||||
|
|
||||||
ElectronNavigationThrottle::ThrottleCheckResult WillRedirectRequest()
|
ElectronNavigationThrottle::ThrottleCheckResult WillRedirectRequest()
|
||||||
override;
|
override;
|
||||||
|
|
||||||
|
|
|
@ -91,6 +91,8 @@ class ExtensionActionFunction : public ExtensionFunction {
|
||||||
protected:
|
protected:
|
||||||
ExtensionActionFunction();
|
ExtensionActionFunction();
|
||||||
~ExtensionActionFunction() override;
|
~ExtensionActionFunction() override;
|
||||||
|
|
||||||
|
// ExtensionFunction
|
||||||
ResponseAction Run() override;
|
ResponseAction Run() override;
|
||||||
|
|
||||||
virtual ResponseAction RunExtensionAction() = 0;
|
virtual ResponseAction RunExtensionAction() = 0;
|
||||||
|
|
|
@ -17,7 +17,7 @@ class ElectronManagementAPIDelegate : public extensions::ManagementAPIDelegate {
|
||||||
ElectronManagementAPIDelegate();
|
ElectronManagementAPIDelegate();
|
||||||
~ElectronManagementAPIDelegate() override;
|
~ElectronManagementAPIDelegate() override;
|
||||||
|
|
||||||
// ManagementAPIDelegate.
|
// extensions::ManagementAPIDelegate
|
||||||
bool LaunchAppFunctionDelegate(
|
bool LaunchAppFunctionDelegate(
|
||||||
const extensions::Extension* extension,
|
const extensions::Extension* extension,
|
||||||
content::BrowserContext* context) const override;
|
content::BrowserContext* context) const override;
|
||||||
|
|
|
@ -21,6 +21,7 @@ class ElectronExtensionsBrowserAPIProvider
|
||||||
ElectronExtensionsBrowserAPIProvider& operator=(
|
ElectronExtensionsBrowserAPIProvider& operator=(
|
||||||
const ElectronExtensionsBrowserAPIProvider&) = delete;
|
const ElectronExtensionsBrowserAPIProvider&) = delete;
|
||||||
|
|
||||||
|
// ExtensionsBrowserAPIProvider
|
||||||
void RegisterExtensionFunctions(ExtensionFunctionRegistry* registry) override;
|
void RegisterExtensionFunctions(ExtensionFunctionRegistry* registry) override;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|
|
@ -17,7 +17,7 @@ class ElectronKioskDelegate : public extensions::KioskDelegate {
|
||||||
ElectronKioskDelegate();
|
ElectronKioskDelegate();
|
||||||
~ElectronKioskDelegate() override;
|
~ElectronKioskDelegate() override;
|
||||||
|
|
||||||
// KioskDelegate overrides:
|
// extensions::KioskDelegate
|
||||||
bool IsAutoLaunchedKioskApp(const extensions::ExtensionId& id) const override;
|
bool IsAutoLaunchedKioskApp(const extensions::ExtensionId& id) const override;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|
|
@ -185,6 +185,7 @@ class NativeWindowClientView : public views::ClientView {
|
||||||
NativeWindowClientView(const NativeWindowClientView&) = delete;
|
NativeWindowClientView(const NativeWindowClientView&) = delete;
|
||||||
NativeWindowClientView& operator=(const NativeWindowClientView&) = delete;
|
NativeWindowClientView& operator=(const NativeWindowClientView&) = delete;
|
||||||
|
|
||||||
|
// views::ClientView
|
||||||
views::CloseRequestResult OnWindowCloseRequested() override {
|
views::CloseRequestResult OnWindowCloseRequested() override {
|
||||||
window_->NotifyWindowCloseButtonClicked();
|
window_->NotifyWindowCloseButtonClicked();
|
||||||
return views::CloseRequestResult::kCannotClose;
|
return views::CloseRequestResult::kCannotClose;
|
||||||
|
|
|
@ -25,6 +25,7 @@ class AsarFileValidator : public mojo::FilteredDataSource::Filter {
|
||||||
AsarFileValidator(const AsarFileValidator&) = delete;
|
AsarFileValidator(const AsarFileValidator&) = delete;
|
||||||
AsarFileValidator& operator=(const AsarFileValidator&) = delete;
|
AsarFileValidator& operator=(const AsarFileValidator&) = delete;
|
||||||
|
|
||||||
|
// mojo::FilteredDataSource::Filter
|
||||||
void OnRead(base::span<char> buffer,
|
void OnRead(base::span<char> buffer,
|
||||||
mojo::FileDataSource::ReadResult* result) override;
|
mojo::FileDataSource::ReadResult* result) override;
|
||||||
|
|
||||||
|
|
|
@ -16,6 +16,7 @@ class NotificationPresenterLinux : public NotificationPresenter {
|
||||||
~NotificationPresenterLinux() override;
|
~NotificationPresenterLinux() override;
|
||||||
|
|
||||||
private:
|
private:
|
||||||
|
// NotificationPresenter
|
||||||
Notification* CreateNotificationObject(
|
Notification* CreateNotificationObject(
|
||||||
NotificationDelegate* delegate) override;
|
NotificationDelegate* delegate) override;
|
||||||
};
|
};
|
||||||
|
|
|
@ -21,6 +21,7 @@ class NotificationPresenterMac : public NotificationPresenter {
|
||||||
~NotificationPresenterMac() override;
|
~NotificationPresenterMac() override;
|
||||||
|
|
||||||
private:
|
private:
|
||||||
|
// NotificationPresenter
|
||||||
Notification* CreateNotificationObject(
|
Notification* CreateNotificationObject(
|
||||||
NotificationDelegate* delegate) override;
|
NotificationDelegate* delegate) override;
|
||||||
|
|
||||||
|
|
|
@ -53,6 +53,7 @@ class NotificationDelegateImpl final : public electron::NotificationDelegate {
|
||||||
NotificationDelegateImpl(const NotificationDelegateImpl&) = delete;
|
NotificationDelegateImpl(const NotificationDelegateImpl&) = delete;
|
||||||
NotificationDelegateImpl& operator=(const NotificationDelegateImpl&) = delete;
|
NotificationDelegateImpl& operator=(const NotificationDelegateImpl&) = delete;
|
||||||
|
|
||||||
|
// electron::NotificationDelegate
|
||||||
void NotificationDestroyed() override { delete this; }
|
void NotificationDestroyed() override { delete this; }
|
||||||
|
|
||||||
void NotificationClick() override {
|
void NotificationClick() override {
|
||||||
|
|
|
@ -41,6 +41,7 @@ class NotificationPresenterWin : public NotificationPresenter {
|
||||||
std::wstring SaveIconToFilesystem(const SkBitmap& icon, const GURL& origin);
|
std::wstring SaveIconToFilesystem(const SkBitmap& icon, const GURL& origin);
|
||||||
|
|
||||||
private:
|
private:
|
||||||
|
// NotificationPresenter
|
||||||
Notification* CreateNotificationObject(
|
Notification* CreateNotificationObject(
|
||||||
NotificationDelegate* delegate) override;
|
NotificationDelegate* delegate) override;
|
||||||
|
|
||||||
|
|
|
@ -120,12 +120,17 @@ class ToastEventHandler : public RuntimeClass<RuntimeClassFlags<ClassicCom>,
|
||||||
ToastEventHandler(const ToastEventHandler&) = delete;
|
ToastEventHandler(const ToastEventHandler&) = delete;
|
||||||
ToastEventHandler& operator=(const ToastEventHandler&) = delete;
|
ToastEventHandler& operator=(const ToastEventHandler&) = delete;
|
||||||
|
|
||||||
|
// DesktopToastActivatedEventHandler
|
||||||
IFACEMETHODIMP Invoke(
|
IFACEMETHODIMP Invoke(
|
||||||
ABI::Windows::UI::Notifications::IToastNotification* sender,
|
ABI::Windows::UI::Notifications::IToastNotification* sender,
|
||||||
IInspectable* args) override;
|
IInspectable* args) override;
|
||||||
|
|
||||||
|
// DesktopToastDismissedEventHandler
|
||||||
IFACEMETHODIMP Invoke(
|
IFACEMETHODIMP Invoke(
|
||||||
ABI::Windows::UI::Notifications::IToastNotification* sender,
|
ABI::Windows::UI::Notifications::IToastNotification* sender,
|
||||||
ABI::Windows::UI::Notifications::IToastDismissedEventArgs* e) override;
|
ABI::Windows::UI::Notifications::IToastDismissedEventArgs* e) override;
|
||||||
|
|
||||||
|
// DesktopToastFailedEventHandler
|
||||||
IFACEMETHODIMP Invoke(
|
IFACEMETHODIMP Invoke(
|
||||||
ABI::Windows::UI::Notifications::IToastNotification* sender,
|
ABI::Windows::UI::Notifications::IToastNotification* sender,
|
||||||
ABI::Windows::UI::Notifications::IToastFailedEventArgs* e) override;
|
ABI::Windows::UI::Notifications::IToastFailedEventArgs* e) override;
|
||||||
|
|
|
@ -63,6 +63,7 @@ class OffScreenHostDisplayClient : public viz::HostDisplayClient {
|
||||||
void SetActive(bool active);
|
void SetActive(bool active);
|
||||||
|
|
||||||
private:
|
private:
|
||||||
|
// viz::HostDisplayClient
|
||||||
#if BUILDFLAG(IS_MAC)
|
#if BUILDFLAG(IS_MAC)
|
||||||
void OnDisplayReceivedCALayerParams(
|
void OnDisplayReceivedCALayerParams(
|
||||||
const gfx::CALayerParams& ca_layer_params) override;
|
const gfx::CALayerParams& ca_layer_params) override;
|
||||||
|
|
|
@ -135,6 +135,7 @@ class ElectronDelegatedFrameHostClient
|
||||||
ElectronDelegatedFrameHostClient& operator=(
|
ElectronDelegatedFrameHostClient& operator=(
|
||||||
const ElectronDelegatedFrameHostClient&) = delete;
|
const ElectronDelegatedFrameHostClient&) = delete;
|
||||||
|
|
||||||
|
// content::DelegatedFrameHostClient
|
||||||
ui::Layer* DelegatedFrameHostGetLayer() const override {
|
ui::Layer* DelegatedFrameHostGetLayer() const override {
|
||||||
return view_->root_layer();
|
return view_->root_layer();
|
||||||
}
|
}
|
||||||
|
|
|
@ -121,7 +121,6 @@ class OffScreenRenderWidgetHostView
|
||||||
#endif // BUILDFLAG(IS_MAC)
|
#endif // BUILDFLAG(IS_MAC)
|
||||||
|
|
||||||
// content::RenderWidgetHostViewBase:
|
// content::RenderWidgetHostViewBase:
|
||||||
|
|
||||||
void UpdateFrameSinkIdRegistration() override;
|
void UpdateFrameSinkIdRegistration() override;
|
||||||
void InvalidateLocalSurfaceIdAndAllocationGroup() override;
|
void InvalidateLocalSurfaceIdAndAllocationGroup() override;
|
||||||
void ResetFallbackToFirstNavigationSurface() override;
|
void ResetFallbackToFirstNavigationSurface() override;
|
||||||
|
|
|
@ -29,6 +29,7 @@ class ElectronSerialDelegate : public content::SerialDelegate,
|
||||||
ElectronSerialDelegate(const ElectronSerialDelegate&) = delete;
|
ElectronSerialDelegate(const ElectronSerialDelegate&) = delete;
|
||||||
ElectronSerialDelegate& operator=(const ElectronSerialDelegate&) = delete;
|
ElectronSerialDelegate& operator=(const ElectronSerialDelegate&) = delete;
|
||||||
|
|
||||||
|
// content::SerialDelegate:
|
||||||
std::unique_ptr<content::SerialChooser> RunChooser(
|
std::unique_ptr<content::SerialChooser> RunChooser(
|
||||||
content::RenderFrameHost* frame,
|
content::RenderFrameHost* frame,
|
||||||
std::vector<blink::mojom::SerialPortFilterPtr> filters,
|
std::vector<blink::mojom::SerialPortFilterPtr> filters,
|
||||||
|
|
|
@ -137,6 +137,7 @@ class FileChooserDialog : public ui::SelectFileDialog::Listener {
|
||||||
RunOpenDialogImpl(settings);
|
RunOpenDialogImpl(settings);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// ui::SelectFileDialog::Listener
|
||||||
void FileSelected(const ui::SelectedFileInfo& file,
|
void FileSelected(const ui::SelectedFileInfo& file,
|
||||||
int index,
|
int index,
|
||||||
void* params) override {
|
void* params) override {
|
||||||
|
|
|
@ -242,6 +242,7 @@ class InspectableWebContents::NetworkResourceLoader
|
||||||
response_headers_ = response_head.headers;
|
response_headers_ = response_head.headers;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// network::SimpleURLLoaderStreamConsumer
|
||||||
void OnDataReceived(base::StringPiece chunk,
|
void OnDataReceived(base::StringPiece chunk,
|
||||||
base::OnceClosure resume) override {
|
base::OnceClosure resume) override {
|
||||||
bool encoded = !base::IsStringUTF8(chunk);
|
bool encoded = !base::IsStringUTF8(chunk);
|
||||||
|
|
|
@ -182,6 +182,7 @@ class GtkMessageBox : private NativeWindowObserver {
|
||||||
Show();
|
Show();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// NativeWindowObserver
|
||||||
void OnWindowClosed() override {
|
void OnWindowClosed() override {
|
||||||
parent_->RemoveObserver(this);
|
parent_->RemoveObserver(this);
|
||||||
parent_ = nullptr;
|
parent_ = nullptr;
|
||||||
|
|
|
@ -21,6 +21,7 @@ class TrayIconCocoa : public TrayIcon {
|
||||||
TrayIconCocoa();
|
TrayIconCocoa();
|
||||||
~TrayIconCocoa() override;
|
~TrayIconCocoa() override;
|
||||||
|
|
||||||
|
// TrayIcon
|
||||||
void SetImage(const gfx::Image& image) override;
|
void SetImage(const gfx::Image& image) override;
|
||||||
void SetPressedImage(const gfx::Image& image) override;
|
void SetPressedImage(const gfx::Image& image) override;
|
||||||
void SetToolTip(const std::string& tool_tip) override;
|
void SetToolTip(const std::string& tool_tip) override;
|
||||||
|
|
|
@ -73,6 +73,7 @@ class AutofillPopupView : public views::WidgetDelegateView,
|
||||||
|
|
||||||
int GetSelectedLine() { return selected_line_.value_or(-1); }
|
int GetSelectedLine() { return selected_line_.value_or(-1); }
|
||||||
|
|
||||||
|
// views::WidgetDelegateView implementation.
|
||||||
void WriteDragDataForView(views::View*,
|
void WriteDragDataForView(views::View*,
|
||||||
const gfx::Point&,
|
const gfx::Point&,
|
||||||
ui::OSExchangeData*) override;
|
ui::OSExchangeData*) override;
|
||||||
|
|
|
@ -21,6 +21,7 @@ class MenuModelAdapter : public views::MenuModelAdapter {
|
||||||
MenuModelAdapter& operator=(const MenuModelAdapter&) = delete;
|
MenuModelAdapter& operator=(const MenuModelAdapter&) = delete;
|
||||||
|
|
||||||
protected:
|
protected:
|
||||||
|
// views::MenuModelAdapter
|
||||||
bool GetAccelerator(int id, ui::Accelerator* accelerator) const override;
|
bool GetAccelerator(int id, ui::Accelerator* accelerator) const override;
|
||||||
|
|
||||||
private:
|
private:
|
||||||
|
|
|
@ -34,9 +34,9 @@ class SubmenuButton : public views::MenuButton {
|
||||||
|
|
||||||
char16_t accelerator() const { return accelerator_; }
|
char16_t accelerator() const { return accelerator_; }
|
||||||
|
|
||||||
|
// views::MenuButton:
|
||||||
void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
|
void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
|
||||||
|
|
||||||
// views::MenuButton:
|
|
||||||
void PaintButtonContents(gfx::Canvas* canvas) override;
|
void PaintButtonContents(gfx::Canvas* canvas) override;
|
||||||
|
|
||||||
private:
|
private:
|
||||||
|
|
|
@ -35,7 +35,7 @@ class WinCaptionButton : public views::Button {
|
||||||
WinCaptionButton(const WinCaptionButton&) = delete;
|
WinCaptionButton(const WinCaptionButton&) = delete;
|
||||||
WinCaptionButton& operator=(const WinCaptionButton&) = delete;
|
WinCaptionButton& operator=(const WinCaptionButton&) = delete;
|
||||||
|
|
||||||
// // views::Button:
|
// views::Button:
|
||||||
gfx::Size CalculatePreferredSize(
|
gfx::Size CalculatePreferredSize(
|
||||||
const views::SizeBounds& available_size) const override;
|
const views::SizeBounds& available_size) const override;
|
||||||
void OnPaintBackground(gfx::Canvas* canvas) override;
|
void OnPaintBackground(gfx::Canvas* canvas) override;
|
||||||
|
|
|
@ -29,6 +29,7 @@ class ElectronDesktopWindowTreeHostWin : public views::DesktopWindowTreeHostWin,
|
||||||
const ElectronDesktopWindowTreeHostWin&) = delete;
|
const ElectronDesktopWindowTreeHostWin&) = delete;
|
||||||
|
|
||||||
protected:
|
protected:
|
||||||
|
// views::DesktopWindowTreeHostWin:
|
||||||
bool PreHandleMSG(UINT message,
|
bool PreHandleMSG(UINT message,
|
||||||
WPARAM w_param,
|
WPARAM w_param,
|
||||||
LPARAM l_param,
|
LPARAM l_param,
|
||||||
|
|
|
@ -15,6 +15,7 @@ class ElectronWebAuthenticationDelegate
|
||||||
public:
|
public:
|
||||||
~ElectronWebAuthenticationDelegate() override;
|
~ElectronWebAuthenticationDelegate() override;
|
||||||
|
|
||||||
|
// content::WebAuthenticationDelegate
|
||||||
bool SupportsResidentKeys(
|
bool SupportsResidentKeys(
|
||||||
content::RenderFrameHost* render_frame_host) override;
|
content::RenderFrameHost* render_frame_host) override;
|
||||||
};
|
};
|
||||||
|
|
|
@ -75,6 +75,8 @@ class CallbackHolderBase {
|
||||||
DisposeObserver(gin::PerIsolateData* per_isolate_data,
|
DisposeObserver(gin::PerIsolateData* per_isolate_data,
|
||||||
CallbackHolderBase* holder);
|
CallbackHolderBase* holder);
|
||||||
~DisposeObserver() override;
|
~DisposeObserver() override;
|
||||||
|
|
||||||
|
// gin::PerIsolateData::DisposeObserver
|
||||||
void OnBeforeDispose(v8::Isolate* isolate) override;
|
void OnBeforeDispose(v8::Isolate* isolate) override;
|
||||||
void OnDisposed() override;
|
void OnDisposed() override;
|
||||||
|
|
||||||
|
|
|
@ -15,6 +15,7 @@ class NodeBindingsLinux : public NodeBindings {
|
||||||
explicit NodeBindingsLinux(BrowserEnvironment browser_env);
|
explicit NodeBindingsLinux(BrowserEnvironment browser_env);
|
||||||
|
|
||||||
private:
|
private:
|
||||||
|
// NodeBindings
|
||||||
void PollEvents() override;
|
void PollEvents() override;
|
||||||
|
|
||||||
// Epoll to poll for uv's backend fd.
|
// Epoll to poll for uv's backend fd.
|
||||||
|
|
|
@ -15,6 +15,7 @@ class NodeBindingsMac : public NodeBindings {
|
||||||
explicit NodeBindingsMac(BrowserEnvironment browser_env);
|
explicit NodeBindingsMac(BrowserEnvironment browser_env);
|
||||||
|
|
||||||
private:
|
private:
|
||||||
|
// NodeBindings
|
||||||
void PollEvents() override;
|
void PollEvents() override;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|
|
@ -15,6 +15,7 @@ class NodeBindingsWin : public NodeBindings {
|
||||||
explicit NodeBindingsWin(BrowserEnvironment browser_env);
|
explicit NodeBindingsWin(BrowserEnvironment browser_env);
|
||||||
|
|
||||||
private:
|
private:
|
||||||
|
// NodeBindings
|
||||||
void PollEvents() override;
|
void PollEvents() override;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|
|
@ -49,6 +49,7 @@ class DeleteFileProgressSink : public IFileOperationProgressSink {
|
||||||
virtual ~DeleteFileProgressSink() = default;
|
virtual ~DeleteFileProgressSink() = default;
|
||||||
|
|
||||||
private:
|
private:
|
||||||
|
// IFileOperationProgressSink
|
||||||
ULONG STDMETHODCALLTYPE AddRef(void) override;
|
ULONG STDMETHODCALLTYPE AddRef(void) override;
|
||||||
ULONG STDMETHODCALLTYPE Release(void) override;
|
ULONG STDMETHODCALLTYPE Release(void) override;
|
||||||
HRESULT STDMETHODCALLTYPE QueryInterface(REFIID riid,
|
HRESULT STDMETHODCALLTYPE QueryInterface(REFIID riid,
|
||||||
|
|
|
@ -32,6 +32,7 @@ class ElectronApiServiceImpl : public mojom::ElectronRenderer,
|
||||||
|
|
||||||
void BindTo(mojo::PendingReceiver<mojom::ElectronRenderer> receiver);
|
void BindTo(mojo::PendingReceiver<mojom::ElectronRenderer> receiver);
|
||||||
|
|
||||||
|
// mojom::ElectronRenderer
|
||||||
void Message(bool internal,
|
void Message(bool internal,
|
||||||
const std::string& channel,
|
const std::string& channel,
|
||||||
blink::CloneableMessage arguments) override;
|
blink::CloneableMessage arguments) override;
|
||||||
|
@ -50,7 +51,7 @@ class ElectronApiServiceImpl : public mojom::ElectronRenderer,
|
||||||
mojo::ScopedMessagePipeHandle* interface_pipe) override;
|
mojo::ScopedMessagePipeHandle* interface_pipe) override;
|
||||||
|
|
||||||
private:
|
private:
|
||||||
// RenderFrameObserver implementation.
|
// content::RenderFrameObserver
|
||||||
void DidCreateDocumentElement() override;
|
void DidCreateDocumentElement() override;
|
||||||
void OnDestruct() override;
|
void OnDestruct() override;
|
||||||
|
|
||||||
|
|
|
@ -25,7 +25,7 @@ class ElectronRendererPepperHostFactory : public ppapi::host::HostFactory {
|
||||||
ElectronRendererPepperHostFactory& operator=(
|
ElectronRendererPepperHostFactory& operator=(
|
||||||
const ElectronRendererPepperHostFactory&) = delete;
|
const ElectronRendererPepperHostFactory&) = delete;
|
||||||
|
|
||||||
// HostFactory.
|
// ppapi::host::HostFactory
|
||||||
std::unique_ptr<ppapi::host::ResourceHost> CreateResourceHost(
|
std::unique_ptr<ppapi::host::ResourceHost> CreateResourceHost(
|
||||||
ppapi::host::PpapiHost* host,
|
ppapi::host::PpapiHost* host,
|
||||||
PP_Resource resource,
|
PP_Resource resource,
|
||||||
|
|
|
@ -26,6 +26,7 @@ class ElectronContentUtilityClient : public content::ContentUtilityClient {
|
||||||
ElectronContentUtilityClient& operator=(const ElectronContentUtilityClient&) =
|
ElectronContentUtilityClient& operator=(const ElectronContentUtilityClient&) =
|
||||||
delete;
|
delete;
|
||||||
|
|
||||||
|
// content::ContentUtilityClient
|
||||||
void ExposeInterfacesToBrowser(mojo::BinderMap* binders) override;
|
void ExposeInterfacesToBrowser(mojo::BinderMap* binders) override;
|
||||||
void RegisterMainThreadServices(mojo::ServiceFactory& services) override;
|
void RegisterMainThreadServices(mojo::ServiceFactory& services) override;
|
||||||
void RegisterIOThreadServices(mojo::ServiceFactory& services) override;
|
void RegisterIOThreadServices(mojo::ServiceFactory& services) override;
|
||||||
|
|
Loading…
Reference in a new issue