mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: remove deprecated GetAs methods (#13425)

Browse source 
* refactor: remove deprecated GetAs methods

* restructure URLRequestAsyncAsarJob on win

* fix: add string conversion header
This commit is contained in:
Shelley Vohr 2018-06-27 14:52:48 -07:00 • committed by GitHub
parent fa0704665f
commit 003a92e099
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 22 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

5
atom/browser/browser_mac.mm
View file

@ -336,10 +336,9 @@ void Browser::SetAboutPanelOptions(const base::DictionaryValue& options) {
for (base::DictionaryValue::Iterator iter(options); !iter.IsAtEnd();
iter.Advance()) {
std::string key = iter.key();
std::string value;
if (!key.empty() && iter.value().GetAsString(&value)) {
if (!key.empty() && iter.value().is_string()) {
key[0] = base::ToUpperASCII(key[0]);
about_panel_options_.SetString(key, value);
about_panel_options_.SetString(key, iter.value().GetString());
}
}
}