2020-03-20 20:28:31 +00:00
|
|
|
import { webFrame } from 'electron';
|
|
|
|
import { ipcRendererInternal } from '@electron/internal/renderer/ipc-renderer-internal';
|
2020-10-13 21:11:06 +00:00
|
|
|
import { IPC_MESSAGES } from '@electron/internal/common/ipc-messages';
|
2018-09-22 12:28:50 +00:00
|
|
|
|
2020-03-20 20:28:31 +00:00
|
|
|
let shouldLog: boolean | null = null;
|
2018-02-03 14:50:12 +00:00
|
|
|
|
2020-03-20 20:28:31 +00:00
|
|
|
const { platform, execPath, env } = process;
|
2019-06-02 20:03:03 +00:00
|
|
|
|
2018-02-03 14:50:12 +00:00
|
|
|
/**
|
|
|
|
* This method checks if a security message should be logged.
|
|
|
|
* It does so by determining whether we're running as Electron,
|
|
|
|
* which indicates that a developer is currently looking at the
|
|
|
|
* app.
|
|
|
|
*
|
|
|
|
* @returns {boolean} - Should we log?
|
|
|
|
*/
|
2019-02-17 01:06:30 +00:00
|
|
|
const shouldLogSecurityWarnings = function (): boolean {
|
2018-02-03 14:50:12 +00:00
|
|
|
if (shouldLog !== null) {
|
2020-03-20 20:28:31 +00:00
|
|
|
return shouldLog;
|
2018-02-03 14:50:12 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
switch (platform) {
|
|
|
|
case 'darwin':
|
|
|
|
shouldLog = execPath.endsWith('MacOS/Electron') ||
|
2020-03-20 20:28:31 +00:00
|
|
|
execPath.includes('Electron.app/Contents/Frameworks/');
|
|
|
|
break;
|
2018-02-03 14:50:12 +00:00
|
|
|
case 'freebsd':
|
|
|
|
case 'linux':
|
2020-03-20 20:28:31 +00:00
|
|
|
shouldLog = execPath.endsWith('/electron');
|
|
|
|
break;
|
2018-02-03 14:50:12 +00:00
|
|
|
case 'win32':
|
2020-03-20 20:28:31 +00:00
|
|
|
shouldLog = execPath.endsWith('\\electron.exe');
|
|
|
|
break;
|
2018-02-03 14:50:12 +00:00
|
|
|
default:
|
2020-03-20 20:28:31 +00:00
|
|
|
shouldLog = false;
|
2018-02-03 14:50:12 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if ((env && env.ELECTRON_DISABLE_SECURITY_WARNINGS) ||
|
|
|
|
(window && window.ELECTRON_DISABLE_SECURITY_WARNINGS)) {
|
2020-03-20 20:28:31 +00:00
|
|
|
shouldLog = false;
|
2018-02-03 14:50:12 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if ((env && env.ELECTRON_ENABLE_SECURITY_WARNINGS) ||
|
|
|
|
(window && window.ELECTRON_ENABLE_SECURITY_WARNINGS)) {
|
2020-03-20 20:28:31 +00:00
|
|
|
shouldLog = true;
|
2018-02-03 14:50:12 +00:00
|
|
|
}
|
|
|
|
|
2020-03-20 20:28:31 +00:00
|
|
|
return shouldLog;
|
|
|
|
};
|
2018-02-03 14:50:12 +00:00
|
|
|
|
|
|
|
/**
|
2018-08-08 01:40:21 +00:00
|
|
|
* Checks if the current window is remote.
|
2018-02-03 14:50:12 +00:00
|
|
|
*
|
|
|
|
* @returns {boolean} - Is this a remote protocol?
|
|
|
|
*/
|
|
|
|
const getIsRemoteProtocol = function () {
|
|
|
|
if (window && window.location && window.location.protocol) {
|
2020-03-20 20:28:31 +00:00
|
|
|
return /^(http|ftp)s?/gi.test(window.location.protocol);
|
2018-02-03 14:50:12 +00:00
|
|
|
}
|
2020-03-20 20:28:31 +00:00
|
|
|
};
|
2018-02-03 14:50:12 +00:00
|
|
|
|
2019-07-02 10:36:50 +00:00
|
|
|
/**
|
|
|
|
* Checks if the current window is from localhost.
|
|
|
|
*
|
|
|
|
* @returns {boolean} - Is current window from localhost?
|
|
|
|
*/
|
|
|
|
const isLocalhost = function () {
|
|
|
|
if (!window || !window.location) {
|
2020-03-20 20:28:31 +00:00
|
|
|
return false;
|
2019-07-02 10:36:50 +00:00
|
|
|
}
|
|
|
|
|
2020-03-20 20:28:31 +00:00
|
|
|
return window.location.hostname === 'localhost';
|
|
|
|
};
|
2019-07-02 10:36:50 +00:00
|
|
|
|
2018-02-03 14:50:12 +00:00
|
|
|
/**
|
|
|
|
* Tries to determine whether a CSP without `unsafe-eval` is set.
|
|
|
|
*
|
|
|
|
* @returns {boolean} Is a CSP with `unsafe-eval` set?
|
|
|
|
*/
|
2020-10-01 15:59:52 +00:00
|
|
|
const isUnsafeEvalEnabled: () => Promise<boolean> = function () {
|
|
|
|
// Call _executeJavaScript to bypass the world-safe deprecation warning
|
2021-01-29 20:41:59 +00:00
|
|
|
return webFrame._executeJavaScript(`(${(() => {
|
2019-03-14 19:08:54 +00:00
|
|
|
try {
|
2021-01-25 01:31:25 +00:00
|
|
|
eval(window.trustedTypes.emptyScript); // eslint-disable-line no-eval
|
2019-03-14 19:08:54 +00:00
|
|
|
} catch {
|
2020-03-20 20:28:31 +00:00
|
|
|
return false;
|
2019-03-14 19:08:54 +00:00
|
|
|
}
|
2020-03-20 20:28:31 +00:00
|
|
|
return true;
|
|
|
|
}).toString()})()`, false);
|
|
|
|
};
|
2018-02-03 14:50:12 +00:00
|
|
|
|
2018-10-03 19:36:12 +00:00
|
|
|
const moreInformation = `\nFor more information and help, consult
|
2019-06-18 16:59:02 +00:00
|
|
|
https://electronjs.org/docs/tutorial/security.\nThis warning will not show up
|
2020-03-20 20:28:31 +00:00
|
|
|
once the app is packaged.`;
|
2018-10-03 19:36:12 +00:00
|
|
|
|
2018-02-03 14:50:12 +00:00
|
|
|
/**
|
2018-10-03 19:36:12 +00:00
|
|
|
* #1 Only load secure content
|
2018-02-03 14:50:12 +00:00
|
|
|
*
|
2018-10-03 19:36:12 +00:00
|
|
|
* Checks the loaded resources on the current page and logs a
|
|
|
|
* message about all resources loaded over HTTP or FTP.
|
2018-02-03 14:50:12 +00:00
|
|
|
*/
|
2018-10-03 19:36:12 +00:00
|
|
|
const warnAboutInsecureResources = function () {
|
|
|
|
if (!window || !window.performance || !window.performance.getEntriesByType) {
|
2020-03-20 20:28:31 +00:00
|
|
|
return;
|
2018-02-03 14:50:12 +00:00
|
|
|
}
|
|
|
|
|
2018-10-03 19:36:12 +00:00
|
|
|
const resources = window.performance
|
|
|
|
.getEntriesByType('resource')
|
|
|
|
.filter(({ name }) => /^(http|ftp):/gi.test(name || ''))
|
2019-07-02 10:36:50 +00:00
|
|
|
.filter(({ name }) => new URL(name).hostname !== 'localhost')
|
2018-10-03 19:36:12 +00:00
|
|
|
.map(({ name }) => `- ${name}`)
|
2020-03-20 20:28:31 +00:00
|
|
|
.join('\n');
|
2018-02-03 14:50:12 +00:00
|
|
|
|
2018-10-03 19:36:12 +00:00
|
|
|
if (!resources || resources.length === 0) {
|
2020-03-20 20:28:31 +00:00
|
|
|
return;
|
2018-10-03 19:36:12 +00:00
|
|
|
}
|
2018-02-03 14:50:12 +00:00
|
|
|
|
2018-10-03 19:36:12 +00:00
|
|
|
const warning = `This renderer process loads resources using insecure
|
2019-06-17 21:21:30 +00:00
|
|
|
protocols. This exposes users of this app to unnecessary security risks.
|
2019-06-18 16:59:02 +00:00
|
|
|
Consider loading the following resources over HTTPS or FTPS. \n${resources}
|
2020-03-20 20:28:31 +00:00
|
|
|
\n${moreInformation}`;
|
2018-02-03 14:50:12 +00:00
|
|
|
|
2018-10-03 19:36:12 +00:00
|
|
|
console.warn('%cElectron Security Warning (Insecure Resources)',
|
2020-03-20 20:28:31 +00:00
|
|
|
'font-weight: bold;', warning);
|
|
|
|
};
|
2018-02-03 14:50:12 +00:00
|
|
|
|
2018-10-03 19:36:12 +00:00
|
|
|
/**
|
|
|
|
* #2 on the checklist: Disable the Node.js integration in all renderers that
|
|
|
|
* display remote content
|
|
|
|
*
|
|
|
|
* Logs a warning message about Node integration.
|
|
|
|
*/
|
2019-02-17 01:06:30 +00:00
|
|
|
const warnAboutNodeWithRemoteContent = function (nodeIntegration: boolean) {
|
2020-03-20 20:28:31 +00:00
|
|
|
if (!nodeIntegration || isLocalhost()) return;
|
2018-02-03 14:50:12 +00:00
|
|
|
|
2018-10-03 19:36:12 +00:00
|
|
|
if (getIsRemoteProtocol()) {
|
|
|
|
const warning = `This renderer process has Node.js integration enabled
|
|
|
|
and attempted to load remote content from '${window.location}'. This
|
2020-03-20 20:28:31 +00:00
|
|
|
exposes users of this app to severe security risks.\n${moreInformation}`;
|
2018-02-03 14:50:12 +00:00
|
|
|
|
2018-10-03 19:36:12 +00:00
|
|
|
console.warn('%cElectron Security Warning (Node.js Integration with Remote Content)',
|
2020-03-20 20:28:31 +00:00
|
|
|
'font-weight: bold;', warning);
|
2018-10-03 19:36:12 +00:00
|
|
|
}
|
2020-03-20 20:28:31 +00:00
|
|
|
};
|
2018-02-03 14:50:12 +00:00
|
|
|
|
2018-10-03 19:36:12 +00:00
|
|
|
// Currently missing since it has ramifications and is still experimental:
|
|
|
|
// #3 Enable context isolation in all renderers that display remote content
|
|
|
|
//
|
|
|
|
// Currently missing since we can't easily programmatically check for those cases:
|
|
|
|
// #4 Use ses.setPermissionRequestHandler() in all sessions that load remote content
|
2018-02-03 14:50:12 +00:00
|
|
|
|
2018-10-03 19:36:12 +00:00
|
|
|
/**
|
|
|
|
* #5 on the checklist: Do not disable websecurity
|
|
|
|
*
|
|
|
|
* Logs a warning message about disabled webSecurity.
|
|
|
|
*/
|
2019-02-17 01:06:30 +00:00
|
|
|
const warnAboutDisabledWebSecurity = function (webPreferences?: Electron.WebPreferences) {
|
2020-03-20 20:28:31 +00:00
|
|
|
if (!webPreferences || webPreferences.webSecurity !== false) return;
|
2018-02-03 14:50:12 +00:00
|
|
|
|
2018-10-03 19:36:12 +00:00
|
|
|
const warning = `This renderer process has "webSecurity" disabled. This
|
2020-03-20 20:28:31 +00:00
|
|
|
exposes users of this app to severe security risks.\n${moreInformation}`;
|
2018-10-03 19:36:12 +00:00
|
|
|
|
|
|
|
console.warn('%cElectron Security Warning (Disabled webSecurity)',
|
2020-03-20 20:28:31 +00:00
|
|
|
'font-weight: bold;', warning);
|
|
|
|
};
|
2018-10-03 19:36:12 +00:00
|
|
|
|
|
|
|
/**
|
|
|
|
* #6 on the checklist: Define a Content-Security-Policy and use restrictive
|
|
|
|
* rules (i.e. script-src 'self')
|
|
|
|
*
|
|
|
|
* Logs a warning message about unset or insecure CSP
|
|
|
|
*/
|
|
|
|
const warnAboutInsecureCSP = function () {
|
|
|
|
isUnsafeEvalEnabled().then((enabled) => {
|
2020-03-20 20:28:31 +00:00
|
|
|
if (!enabled) return;
|
2018-10-03 19:36:12 +00:00
|
|
|
|
|
|
|
const warning = `This renderer process has either no Content Security
|
|
|
|
Policy set or a policy with "unsafe-eval" enabled. This exposes users of
|
2020-03-20 20:28:31 +00:00
|
|
|
this app to unnecessary security risks.\n${moreInformation}`;
|
2018-10-03 19:36:12 +00:00
|
|
|
|
|
|
|
console.warn('%cElectron Security Warning (Insecure Content-Security-Policy)',
|
2020-03-20 20:28:31 +00:00
|
|
|
'font-weight: bold;', warning);
|
2020-12-07 18:58:00 +00:00
|
|
|
}).catch(() => {});
|
2020-03-20 20:28:31 +00:00
|
|
|
};
|
2018-10-03 19:36:12 +00:00
|
|
|
|
|
|
|
/**
|
2019-06-17 21:21:30 +00:00
|
|
|
* #7 on the checklist: Do not set allowRunningInsecureContent to true
|
2018-10-03 19:36:12 +00:00
|
|
|
*
|
|
|
|
* Logs a warning message about disabled webSecurity.
|
|
|
|
*/
|
2019-02-17 01:06:30 +00:00
|
|
|
const warnAboutInsecureContentAllowed = function (webPreferences?: Electron.WebPreferences) {
|
2020-03-20 20:28:31 +00:00
|
|
|
if (!webPreferences || !webPreferences.allowRunningInsecureContent) return;
|
2018-10-03 19:36:12 +00:00
|
|
|
|
|
|
|
const warning = `This renderer process has "allowRunningInsecureContent"
|
|
|
|
enabled. This exposes users of this app to severe security risks.\n
|
2020-03-20 20:28:31 +00:00
|
|
|
${moreInformation}`;
|
2018-10-03 19:36:12 +00:00
|
|
|
|
|
|
|
console.warn('%cElectron Security Warning (allowRunningInsecureContent)',
|
2020-03-20 20:28:31 +00:00
|
|
|
'font-weight: bold;', warning);
|
|
|
|
};
|
2018-10-03 19:36:12 +00:00
|
|
|
|
|
|
|
/**
|
2019-06-17 21:21:30 +00:00
|
|
|
* #8 on the checklist: Do not enable experimental features
|
2018-10-03 19:36:12 +00:00
|
|
|
*
|
|
|
|
* Logs a warning message about experimental features.
|
|
|
|
*/
|
2019-02-17 01:06:30 +00:00
|
|
|
const warnAboutExperimentalFeatures = function (webPreferences?: Electron.WebPreferences) {
|
2018-10-03 19:36:12 +00:00
|
|
|
if (!webPreferences || (!webPreferences.experimentalFeatures)) {
|
2020-03-20 20:28:31 +00:00
|
|
|
return;
|
2018-10-03 19:36:12 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
const warning = `This renderer process has "experimentalFeatures" enabled.
|
|
|
|
This exposes users of this app to some security risk. If you do not need
|
2020-03-20 20:28:31 +00:00
|
|
|
this feature, you should disable it.\n${moreInformation}`;
|
2018-10-03 19:36:12 +00:00
|
|
|
|
|
|
|
console.warn('%cElectron Security Warning (experimentalFeatures)',
|
2020-03-20 20:28:31 +00:00
|
|
|
'font-weight: bold;', warning);
|
|
|
|
};
|
2018-10-03 19:36:12 +00:00
|
|
|
|
|
|
|
/**
|
2019-06-17 21:21:30 +00:00
|
|
|
* #9 on the checklist: Do not use enableBlinkFeatures
|
2018-10-03 19:36:12 +00:00
|
|
|
*
|
|
|
|
* Logs a warning message about enableBlinkFeatures
|
|
|
|
*/
|
2019-02-17 01:06:30 +00:00
|
|
|
const warnAboutEnableBlinkFeatures = function (webPreferences?: Electron.WebPreferences) {
|
|
|
|
if (!webPreferences ||
|
2020-03-20 15:12:18 +00:00
|
|
|
!Object.prototype.hasOwnProperty.call(webPreferences, 'enableBlinkFeatures') ||
|
2019-02-17 01:06:30 +00:00
|
|
|
(webPreferences.enableBlinkFeatures && webPreferences.enableBlinkFeatures.length === 0)) {
|
2020-03-20 20:28:31 +00:00
|
|
|
return;
|
2018-10-03 19:36:12 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
const warning = `This renderer process has additional "enableBlinkFeatures"
|
|
|
|
enabled. This exposes users of this app to some security risk. If you do not
|
2020-03-20 20:28:31 +00:00
|
|
|
need this feature, you should disable it.\n${moreInformation}`;
|
2018-10-03 19:36:12 +00:00
|
|
|
|
|
|
|
console.warn('%cElectron Security Warning (enableBlinkFeatures)',
|
2020-03-20 20:28:31 +00:00
|
|
|
'font-weight: bold;', warning);
|
|
|
|
};
|
2018-10-03 19:36:12 +00:00
|
|
|
|
|
|
|
/**
|
2019-06-17 21:21:30 +00:00
|
|
|
* #10 on the checklist: Do Not Use allowpopups
|
2018-10-03 19:36:12 +00:00
|
|
|
*
|
|
|
|
* Logs a warning message about allowed popups
|
|
|
|
*/
|
|
|
|
const warnAboutAllowedPopups = function () {
|
|
|
|
if (document && document.querySelectorAll) {
|
2020-03-20 20:28:31 +00:00
|
|
|
const domElements = document.querySelectorAll('[allowpopups]');
|
2018-10-03 19:36:12 +00:00
|
|
|
|
|
|
|
if (!domElements || domElements.length === 0) {
|
2020-03-20 20:28:31 +00:00
|
|
|
return;
|
2018-02-03 14:50:12 +00:00
|
|
|
}
|
|
|
|
|
2018-10-03 19:36:12 +00:00
|
|
|
const warning = `A <webview> has "allowpopups" set to true. This exposes
|
|
|
|
users of this app to some security risk, since popups are just
|
|
|
|
BrowserWindows. If you do not need this feature, you should disable it.\n
|
2020-03-20 20:28:31 +00:00
|
|
|
${moreInformation}`;
|
2018-02-03 14:50:12 +00:00
|
|
|
|
2018-10-03 19:36:12 +00:00
|
|
|
console.warn('%cElectron Security Warning (allowpopups)',
|
2020-03-20 20:28:31 +00:00
|
|
|
'font-weight: bold;', warning);
|
2018-10-03 19:36:12 +00:00
|
|
|
}
|
2020-03-20 20:28:31 +00:00
|
|
|
};
|
2018-02-03 14:50:12 +00:00
|
|
|
|
2018-10-03 19:36:12 +00:00
|
|
|
// Currently missing since we can't easily programmatically check for it:
|
2019-06-17 21:21:30 +00:00
|
|
|
// #11 Verify WebView Options Before Creation
|
|
|
|
// #12 Disable or limit navigation
|
|
|
|
// #13 Disable or limit creation of new windows
|
|
|
|
// #14 Do not use `openExternal` with untrusted content
|
|
|
|
|
|
|
|
// #15 on the checklist: Disable the `remote` module
|
|
|
|
// Logs a warning message about the remote module
|
|
|
|
|
|
|
|
const warnAboutRemoteModuleWithRemoteContent = function (webPreferences?: Electron.WebPreferences) {
|
2020-03-20 20:28:31 +00:00
|
|
|
if (!webPreferences || isLocalhost()) return;
|
|
|
|
const remoteModuleEnabled = webPreferences.enableRemoteModule != null ? !!webPreferences.enableRemoteModule : true;
|
|
|
|
if (!remoteModuleEnabled) return;
|
2019-06-17 21:21:30 +00:00
|
|
|
|
|
|
|
if (getIsRemoteProtocol()) {
|
|
|
|
const warning = `This renderer process has "enableRemoteModule" enabled
|
|
|
|
and attempted to load remote content from '${window.location}'. This
|
2020-03-20 20:28:31 +00:00
|
|
|
exposes users of this app to unnecessary security risks.\n${moreInformation}`;
|
2019-06-17 21:21:30 +00:00
|
|
|
|
|
|
|
console.warn('%cElectron Security Warning (enableRemoteModule)',
|
2020-03-20 20:28:31 +00:00
|
|
|
'font-weight: bold;', warning);
|
2019-06-17 21:21:30 +00:00
|
|
|
}
|
2020-03-20 20:28:31 +00:00
|
|
|
};
|
2019-06-17 21:21:30 +00:00
|
|
|
|
|
|
|
// Currently missing since we can't easily programmatically check for it:
|
|
|
|
// #16 Filter the `remote` module
|
2018-10-03 19:36:12 +00:00
|
|
|
|
2019-02-17 01:06:30 +00:00
|
|
|
const logSecurityWarnings = function (
|
|
|
|
webPreferences: Electron.WebPreferences | undefined, nodeIntegration: boolean
|
|
|
|
) {
|
2020-03-20 20:28:31 +00:00
|
|
|
warnAboutNodeWithRemoteContent(nodeIntegration);
|
|
|
|
warnAboutDisabledWebSecurity(webPreferences);
|
|
|
|
warnAboutInsecureResources();
|
|
|
|
warnAboutInsecureContentAllowed(webPreferences);
|
|
|
|
warnAboutExperimentalFeatures(webPreferences);
|
|
|
|
warnAboutEnableBlinkFeatures(webPreferences);
|
|
|
|
warnAboutInsecureCSP();
|
|
|
|
warnAboutAllowedPopups();
|
|
|
|
warnAboutRemoteModuleWithRemoteContent(webPreferences);
|
|
|
|
};
|
2018-02-03 14:50:12 +00:00
|
|
|
|
2019-06-17 17:57:09 +00:00
|
|
|
const getWebPreferences = async function () {
|
2019-02-06 17:53:29 +00:00
|
|
|
try {
|
2020-10-13 21:11:06 +00:00
|
|
|
return ipcRendererInternal.invoke<Electron.WebPreferences>(IPC_MESSAGES.BROWSER_GET_LAST_WEB_PREFERENCES);
|
2019-02-06 17:53:29 +00:00
|
|
|
} catch (error) {
|
2020-03-20 20:28:31 +00:00
|
|
|
console.warn(`getLastWebPreferences() failed: ${error}`);
|
2018-02-03 14:50:12 +00:00
|
|
|
}
|
2020-03-20 20:28:31 +00:00
|
|
|
};
|
2018-02-03 14:50:12 +00:00
|
|
|
|
2019-02-17 01:06:30 +00:00
|
|
|
export function securityWarnings (nodeIntegration: boolean) {
|
2019-06-17 17:57:09 +00:00
|
|
|
const loadHandler = async function () {
|
2018-10-03 19:36:12 +00:00
|
|
|
if (shouldLogSecurityWarnings()) {
|
2020-03-20 20:28:31 +00:00
|
|
|
const webPreferences = await getWebPreferences();
|
|
|
|
logSecurityWarnings(webPreferences, nodeIntegration);
|
2018-10-03 19:36:12 +00:00
|
|
|
}
|
2020-03-20 20:28:31 +00:00
|
|
|
};
|
|
|
|
window.addEventListener('load', loadHandler, { once: true });
|
2018-02-03 14:50:12 +00:00
|
|
|
}
|