electron/patches/v8/add_realloc.patch

47 lines
1.8 KiB
Diff
Raw Normal View History

From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Shelley Vohr <shelley.vohr@gmail.com>
Date: Mon, 22 Oct 2018 10:47:11 -0700
Subject: add_realloc.patch
Blink overrides ArrayBuffer's allocator with its own one, while Node simply
uses malloc and free, so we need to use v8's allocator in Node. As part of the
10.6.0 upgrade, we needed to make SerializerDelegate accept an allocator
argument in its constructor, and override ReallocateBufferMemory and
FreeBufferMemory to use the allocator. We cannot simply allocate and then memcpy
when we override ReallocateBufferMemory, so we therefore need to implement
Realloc on the v8 side.
diff --git a/include/v8.h b/include/v8.h
2021-03-04 23:46:13 +00:00
index 7cb19bbede03db217b2283ad0ff0df84aafdd168..b869480cddda91242738786d9ffdc24c3d7ac7dd 100644
--- a/include/v8.h
+++ b/include/v8.h
2021-03-04 23:46:13 +00:00
@@ -5355,6 +5355,13 @@ class V8_EXPORT ArrayBuffer : public Object {
*/
virtual void* AllocateUninitialized(size_t length) = 0;
+ /**
+ * Free the memory block of size |length|, pointed to by |data|.
+ * That memory must be previously allocated by |Allocate| and not yet freed
+ * with a call to |Free| or |Realloc|
+ */
+ virtual void* Realloc(void* data, size_t length);
+
/**
* Free the memory block of size |length|, pointed to by |data|.
* That memory is guaranteed to be previously allocated by |Allocate|.
2019-05-21 17:05:21 +00:00
diff --git a/src/api/api.cc b/src/api/api.cc
2021-03-04 23:46:13 +00:00
index 6c6813995f74f1b0c3527d55848bfeb1bbb31a26..3575e9e1a594abdc2a443667f8889bcb27b605ac 100644
2019-05-21 17:05:21 +00:00
--- a/src/api/api.cc
+++ b/src/api/api.cc
2021-03-04 23:46:13 +00:00
@@ -315,6 +315,10 @@ void V8::SetSnapshotDataBlob(StartupData* snapshot_blob) {
i::V8::SetSnapshotBlob(snapshot_blob);
}
+void* v8::ArrayBuffer::Allocator::Realloc(void* data, size_t length) {
+ UNIMPLEMENTED();
+}
+
namespace {
class ArrayBufferAllocator : public v8::ArrayBuffer::Allocator {