2018-10-24 18:24:11 +00:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
2019-06-12 19:34:07 +00:00
|
|
|
From: Shelley Vohr <shelley.vohr@gmail.com>
|
|
|
|
Date: Fri, 7 Jun 2019 13:59:37 -0700
|
2019-08-24 01:14:23 +00:00
|
|
|
Subject: printing.patch
|
2018-10-24 18:24:11 +00:00
|
|
|
|
|
|
|
Add changeset that was previously applied to sources in chromium_src. The
|
|
|
|
majority of changes originally come from these PRs:
|
|
|
|
* https://github.com/electron/electron/pull/1835
|
|
|
|
* https://github.com/electron/electron/pull/8596
|
|
|
|
|
2019-06-12 19:34:07 +00:00
|
|
|
This patch also fixes callback for manual user cancellation and success.
|
|
|
|
|
2020-06-22 17:35:10 +00:00
|
|
|
diff --git a/chrome/browser/printing/print_job.cc b/chrome/browser/printing/print_job.cc
|
2021-05-14 01:21:36 +00:00
|
|
|
index cbe686c86aab691efeca9d104575711fd46037d5..26362670d68e8a6b3297678931ea43a240ae9391 100644
|
2020-06-22 17:35:10 +00:00
|
|
|
--- a/chrome/browser/printing/print_job.cc
|
|
|
|
+++ b/chrome/browser/printing/print_job.cc
|
chore: bump chromium to 92.0.4475.0 (master) (#28462)
* chore: bump chromium in DEPS to 91.0.4464.0
* chore: rebuild chromium/dcheck.patch with import-patches -3
Mechanical only; no code changes
* chore: remove content_browser_main_loop.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2725153
The function being patched (BrowserMainLoop::MainMessageLoopRun()) no
longer exists.
NB: if removing this introduces regressions the likely fix will be to
add a similar patch for ShellBrowserMainParts::WillRunMainMessageLoop()
which has similar code and was added at the same time this was removed.
* chore: rebuild chromium/put_back_deleted_colors_for_autofill.patch with import-patches -3
Mechanical only; no code changes
* chore: rebuild chromium/disable_color_correct_rendering.patch with import-patches -3
Mechanical only; no code changes
* chore: rebuild chromium/eat_allow_disabling_blink_scheduler_throttling_per_renderview.patch with patch
Mechanical only; no code changes
* chore: rebuild chromium/gpu_notify_when_dxdiag_request_fails.patch with import-patches -3
Mechanical only; no code changes
* chore: rebuild chromium/ui_gtk_public_header.patch manually
no code changes
* chore: rebuild chromium/web_contents.patch with import-patches -3
Mechanical only; no code changes
* chore: remove v8/skip_global_registration_of_shared_arraybuffer_backing_stores.patch
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2763874
This patch has been merged upstream
* chore: export patches
* chore: update add_trustedauthclient_to_urlloaderfactory.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2757969
Sync with removal of render_frame_id_
* chore: sync chromium/put_back_deleted_colors_for_autofill.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2785841
SkColorFromColorId() no longer takes theme, scheme args
* chore: sync chromium/put_back_deleted_colors_for_autofill.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2772143
Change new calls to GetDarkSchemeColor to fit our patched call signature
* chore: update add_trustedauthclient_to_urlloaderfactory.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2757969
Sync with removal of render_frame_id_ in our mojom
* chore: update chromium/frame_host_manager.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2740008
UrlInfo ctor now takes UrlInfo::OriginIsolationRequest instead of a bool
* chore: update chromium/revert_remove_contentrendererclient_shouldfork.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2755314
Upstream has removed `history_list_length_` which we were comparing to 0
to calculate our `is_initial_navigation` bool when calling ShouldFork().
ShouldFork() is ours and none of the code paths actually use that param,
so this commit removes it altogether.
* chore: update permissions_to_register
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2789074
Replace all uses of APIPermission::ID enum with Mojo type
* refactor: update return type of PreMainMessageLoopRun()
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2725153
Used to return void; now returns an int errorcode.
Note: 2725153 also has some nice doc updates about Browser's "stages"
* refactor: sync ElectronBrowserMainParts to MainParts changes
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2725153
RunMainMessageLoopParts has been replaced with WillRunMainMessageLoop
so `BrowserMainLoop::result_code_` is no longer available to us for our
exit_code_ pointer.
This variable held a dual role: (1) of course, hold the exit code, but
also (2) was a nullptr before the message loop was ready, indicating to
anyone calling SetExitCode() that we were still in startup and could
just exit() without any extra steps. exit_code_ still fulfills these two
roles but is now a base::Optional.
* chore: update ElectronBrowserMainParts::PreDefaultMainMessageLoopRun
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2725153
BrowserMainParts::BrowsePreDefaultMainMesssageLoopRun() has been
removed; move that work to the new WillRunMainMessageLoop().
* refactor: stop using CallbackList; it has been removed.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2785973
* refactor: update use of threadpools.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2773408
The upstream code is still in flux (e.g. reverts and re-lands) but the
tl;dr for this commit is (1) include thread_pool.h if you're using it
and (2) don't instantiate pools directly.
* refactor: remove routing_id from CreateLoaderAndStart
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2762858
NB: One logic branch in ProxyingURLLoaderFactory::CreateLoaderAndStart
calls std::make_unique<InProgressRequest>, which needs a routing_id.
This PR uses the member field `routing_id_` since there's no longer one
being passed into CreateLoaderAndStart.
* refactor: sync to upstream ParittionOptions churn
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2771318
PartitionOptions' enums have changed.
* refactor: update Manifest::Location usage
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2771320
tldr: s/Manifest::FOO/ManifestLocation::kFoo/
* chore: bump chromium in DEPS to 91.0.4465.0
* update patches
* refactor: update extensions::Manifest to upstream
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2771320
- extensions::Manifest::COMPONENT
+ extensions::mojom::ManifestLocation::kExternalComponent
* refactor: sync with upstream UrlInfo ctor changes
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2740008
UrlInfo ctor now takes UrlInfo::OriginIsolationRequest instead of a bool
* chore: update invocation of convert_protocol_to_json.py
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2792623
python3 is being used in parts of the upstream build, but the copy of
convert_protocol_to_json.py invoked in v8/third_party/inspector_protocol
is not python3-friendly. Node has a py2+3-friendly version of it in its
tools directory, so call it instead.
* chore: use extensions::mojom::APIPermissionID
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2791122
tldr:
- extensions::APIPermission::kFoo
+ extensions::mojom::APIPermissionID::kFoo
* chore: Remove support for TLS1.0/1.1 in SSLVersionMin policy
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2765737
Remove TLS v1.0 & 1.1 from our SSLProtocolVersionFromString() function.
This is the same change made upstream at
https://chromium-review.googlesource.com/c/chromium/src/+/2765737/8/chrome/browser/ssl/ssl_config_service_manager_pref.cc
* fixup! chore: update ElectronBrowserMainParts::PreDefaultMainMessageLoopRun
* chore: Use IDType for permission change subscriptions.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2791431
tldr: {Subscribe,Unsubscribe}PermissionStatusChange's tag type used to
be an int; now it's the new SubscriptionId type (which is an IdType64).
* chore: sync PowerMonitor code to upstream refactor
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2752635
tldr: PowerMonitor has been split into PowerStateObserver,
PowerSuspendObserver, and PowerThermalObserver to reduce number of tasks
posted to consumers who only need notifications for one of those things
instead of all of them.
* chore: use PartitionOptions's new Cookies field
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2771318
* Revert "refactor: remove routing_id from CreateLoaderAndStart"
This reverts commit 8c9773b87a3c84f9073a47089eb2b6889d745245.
8c9773b was only a partial fix; reverting to start & try again.
* update patches
* chore: bump chromium in DEPS to 91.0.4466.0
* chore: update chromium/accelerator.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2795472
tldr: sync patch with upstream renamed variable & macro names.
* chore: update chromium/gtk_visibility.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2796200
tldr: no code changes; just updating the diff to apply cleanly.
note: ooh upstream Wayland hacking!
* chore: update chromium/picture-in-picture.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2710023
tldr: no code changes; just updating the diff to apply cleanly.
* chore: update chromium/worker_feat_add_hook_to_notify_script_ready.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2775573
tldr: no code changes; just updating the diff to apply cleanly.
* chore: export_all_patches
* chore: update chromium/feat_add_set_theme_source_to_allow_apps_to.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2796511
tldr: NotifyObservers has been renamed to NotifyOnNativeThemeUpdated,
so update the invocation in our patch.
* chore: update ElectronBrowserClient w/upstream API
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2797454
tldr: GetDevToolsManagerDelegate() was returning an owned raw pointer.
Replaced it with CreateDevToolsManagerDelegate() which uses unique_ptr<>.
* chore: handle new content::PermissionType::FILE_HANDLING in toV8()
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2762201
`file-handling` string confirmed in https://chromium-review.googlesource.com/c/chromium/src/+/2762201/18/chrome/browser/ui/webui/settings/site_settings_helper.cc
* refactor: remove routing_id from CreateLoaderAndStart pt 1
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2762858
Part 1: the easiest ones
* 2796724: Support Python3
https://chromium-review.googlesource.com/c/infra/luci/python-adb/+/2796724
* chore: bump chromium in DEPS to 91.0.4468.0
* 2668974: WebShare: Implement SharingServicePicker
https://chromium-review.googlesource.com/c/chromium/src/+/2668974
* 2802766: Apply modernize-make-unique to media/
https://chromium-review.googlesource.com/c/chromium/src/+/2802766
* 2802823: Apply modernize-make-unique to gpu/
https://chromium-review.googlesource.com/c/chromium/src/+/2802823
* 2803041: Apply modernize-make-unique to remaining files
https://chromium-review.googlesource.com/c/chromium/src/+/2803041
* 2798873: Convert GtkKeyBindingsHandler build checks to runtime checks
https://chromium-review.googlesource.com/c/chromium/src/+/2798873
* 2733595: [ch-r] Parse ACCEPT_CH H2/3 frame and restart with new headers if needed
https://chromium-review.googlesource.com/c/chromium/src/+/2733595
* chore: update patch indices
* 2795107: Remove unused PermissionRequest IDs.
https://chromium-review.googlesource.com/c/chromium/src/+/2795107
* chore: bump chromium in DEPS to 91.0.4469.0
* chore: fixup patch indices
* chore: bump chromium in DEPS to 91.0.4469.5
* PiP 1.5: Add microphone, camera, and hang up buttons to the PiP window
https://chromium-review.googlesource.com/c/chromium/src/+/2710023
* fixup! refactor: remove routing_id from CreateLoaderAndStart
* refactor: use URLLoaderNetworkServiceObserver for auth requests from SimpleURLLoader
* fixup! chore: fixup patch indices
* 2724817: Expand scope of wasm-eval to all URLs
https://chromium-review.googlesource.com/c/chromium/src/+/2724817
* Fixup patch after rebase
* chore: bump chromium in DEPS to 91.0.4472.0
* 2797341: [ozone/x11] Enabled the global shortcut listener.
https://chromium-review.googlesource.com/c/chromium/src/+/2797341
* 2805553: Reland Add GTK ColorMixers to ColorPipeline P1
https://chromium-review.googlesource.com/c/chromium/src/+/2805553
* 2804366: PiP 1.5: Label back to tab button with origin and center it
https://chromium-review.googlesource.com/c/chromium/src/+/2804366
* 2784730: Fix crash on AX mode change in NativeViewHost without a Widget
https://chromium-review.googlesource.com/c/chromium/src/+/2784730
* chore: update patch indices
* 2810174: Add PdfAnnotationsEnabled policy.
https://chromium-review.googlesource.com/c/chromium/src/+/2810174
* 2807829: Allow capturers to indicate if they want a WakeLock or not.
https://chromium-review.googlesource.com/c/chromium/src/+/2807829
* chore: bump chromium in DEPS to 92.0.4473.0
* chore: bump chromium in DEPS to 92.0.4474.0
* chore: bump chromium in DEPS to 92.0.4475.0
* chore: update patches
* chore: updates patches
* chore: update is_media_key patch to handle new ozone impl
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2797341
* fix: ExecuteJavascript requests now need to be flagged as non-bf-aware
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2787195
* chore: icon_util_x11 is now icon_util_linux
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2791362
* build: update sysroots
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2628496
* build: fix missing symbols on linux build
* use_ozone and use_x11 are not exclusive
* new button view to build for pip
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2797341
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2804366
* chore: fix broken gtk_util color patch
* chore: remove patch conflict
* build: update linux manifests
* chore: build bttlb on all platforms for pip
* chore: add thread_pool include for views delegate win
* chore: fix lint
* chore: add node patches for V8 changes
* build: add missing base include on windows
* fix: update frame host manager patch for new state transitions
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2714464
* chore: update windows zip manifests
* chore: update mac zip manifests
* chore: fix patch linting
* refactor: implement missing URLLoaderNetworkServiceObserver methods
It is against The Mojo Rules to leave hanging callbacks. These always
have to be called.
Refs: https://github.com/electron/electron/commit/186528aab9f8e29d658f07d220bb7f627980edda
* spec: fix locale test on local linux
* fix: pass the exit code correctly in new PreMainMessageLoopRun
Refs: https://github.com/electron/electron/commit/2622e91c4493ceb032e2f80cb484885bb8f97475
* fix: ensure we early-exit when request_handler_ is not provided
Refs: https://github.com/electron/electron/commit/93077afbfb6db248a0c0cc447d7ad2c9ccfda1d5
* fix: strongly set result_code in the BrowserMainLoop
* fix: invalid usage of non-targetted PostTask
You must always either use a host threadpool or specify a target
thread. In this case we did neither after this refactor.
Refs: https://github.com/electron/electron/pull/28462/commits/4e33ee0ad35a710bd34641cb0376bdee6aea2d1f
* chore: fix gn check
* chore: remove stray .rej files in patch
* chore: add mojo error code to url loader failure
* build: ensure CI is truthy in arm test env
* fix: handle windowCaptureMacV2 being enabled when fetching media source id
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2709931
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
2021-04-15 17:44:35 +00:00
|
|
|
@@ -349,18 +349,25 @@ void PrintJob::StartPdfToEmfConversion(
|
2020-09-30 18:42:57 +00:00
|
|
|
// seems to work with the fix for this bug applied.
|
|
|
|
const PrintSettings& settings = document()->settings();
|
|
|
|
bool print_text_with_gdi =
|
|
|
|
- settings.print_text_with_gdi() && !settings.printer_is_xps() &&
|
|
|
|
+#if defined(OS_WIN)
|
|
|
|
+ settings.is_modifiable()
|
|
|
|
+#else
|
|
|
|
+ settings.print_text_with_gdi()
|
|
|
|
+#endif
|
|
|
|
+ && !settings.printer_is_xps() &&
|
|
|
|
base::FeatureList::IsEnabled(::features::kGdiTextPrinting);
|
|
|
|
|
2020-06-22 17:35:10 +00:00
|
|
|
// TODO(thestig): Figure out why crbug.com/1083911 occurred, which is likely
|
|
|
|
// because |web_contents| was null. As a result, this section has many more
|
|
|
|
// pointer checks to avoid crashing.
|
|
|
|
+#if 0
|
|
|
|
content::WebContents* web_contents = worker_->GetWebContents();
|
|
|
|
content::BrowserContext* context =
|
|
|
|
web_contents ? web_contents->GetBrowserContext() : nullptr;
|
|
|
|
PrefService* prefs =
|
|
|
|
context ? Profile::FromBrowserContext(context)->GetPrefs() : nullptr;
|
|
|
|
- bool print_with_reduced_rasterization = PrintWithReducedRasterization(prefs);
|
|
|
|
+#endif
|
|
|
|
+ bool print_with_reduced_rasterization = PrintWithReducedRasterization(nullptr);
|
|
|
|
|
|
|
|
using RenderMode = PdfRenderSettings::Mode;
|
|
|
|
RenderMode mode;
|
2018-10-13 01:57:04 +00:00
|
|
|
diff --git a/chrome/browser/printing/print_job_worker.cc b/chrome/browser/printing/print_job_worker.cc
|
2021-05-14 01:21:36 +00:00
|
|
|
index f2ba13cb21d66c2067264086926341e8490b1b84..29dc7c84c22d9aa7bf0711467fa98b16c89683c1 100644
|
2018-10-13 01:57:04 +00:00
|
|
|
--- a/chrome/browser/printing/print_job_worker.cc
|
|
|
|
+++ b/chrome/browser/printing/print_job_worker.cc
|
2020-12-14 18:57:36 +00:00
|
|
|
@@ -22,7 +22,6 @@
|
2018-10-13 01:57:04 +00:00
|
|
|
#include "chrome/browser/browser_process.h"
|
|
|
|
#include "chrome/browser/chrome_notification_types.h"
|
|
|
|
#include "chrome/browser/printing/print_job.h"
|
|
|
|
-#include "chrome/grit/generated_resources.h"
|
2019-10-28 22:12:35 +00:00
|
|
|
#include "components/crash/core/common/crash_keys.h"
|
2019-01-12 01:00:43 +00:00
|
|
|
#include "content/public/browser/browser_task_traits.h"
|
2018-10-13 01:57:04 +00:00
|
|
|
#include "content/public/browser/browser_thread.h"
|
2020-12-14 18:57:36 +00:00
|
|
|
@@ -30,6 +29,7 @@
|
2018-10-13 01:57:04 +00:00
|
|
|
#include "content/public/browser/render_frame_host.h"
|
2019-01-12 01:00:43 +00:00
|
|
|
#include "content/public/browser/web_contents.h"
|
2019-10-28 22:12:35 +00:00
|
|
|
#include "printing/backend/print_backend.h"
|
2019-01-12 01:00:43 +00:00
|
|
|
+#include "electron/grit/electron_resources.h"
|
|
|
|
#include "printing/print_job_constants.h"
|
|
|
|
#include "printing/printed_document.h"
|
|
|
|
#include "printing/printing_utils.h"
|
2021-05-14 01:21:36 +00:00
|
|
|
@@ -242,16 +242,21 @@ void PrintJobWorker::UpdatePrintSettings(base::Value new_settings,
|
|
|
|
#endif // defined(OS_LINUX) && defined(USE_CUPS)
|
2019-10-28 22:12:35 +00:00
|
|
|
}
|
|
|
|
|
2020-04-13 23:39:26 +00:00
|
|
|
- PrintingContext::Result result;
|
|
|
|
{
|
|
|
|
#if defined(OS_WIN)
|
|
|
|
// Blocking is needed here because Windows printer drivers are oftentimes
|
|
|
|
// not thread-safe and have to be accessed on the UI thread.
|
|
|
|
base::ScopedAllowBlocking allow_blocking;
|
|
|
|
#endif
|
|
|
|
- result = printing_context_->UpdatePrintSettings(std::move(new_settings));
|
|
|
|
+ // Reset settings from previous print job
|
|
|
|
+ printing_context_->ResetSettings();
|
|
|
|
+ PrintingContext::Result get_default_result = printing_context_->UseDefaultSettings();
|
|
|
|
+ if (get_default_result == PrintingContext::Result::OK) {
|
|
|
|
+ PrintingContext::Result update_result =
|
|
|
|
+ printing_context_->UpdatePrintSettings(std::move(new_settings));
|
|
|
|
+ GetSettingsDone(std::move(callback), update_result);
|
|
|
|
+ }
|
|
|
|
}
|
2019-08-07 14:47:24 +00:00
|
|
|
- GetSettingsDone(std::move(callback), result);
|
|
|
|
}
|
|
|
|
|
2020-12-14 18:57:36 +00:00
|
|
|
#if BUILDFLAG(IS_CHROMEOS_ASH)
|
2021-05-14 01:21:36 +00:00
|
|
|
@@ -267,6 +272,13 @@ void PrintJobWorker::UpdatePrintSettingsFromPOD(
|
2019-06-12 19:34:07 +00:00
|
|
|
|
|
|
|
void PrintJobWorker::GetSettingsDone(SettingsCallback callback,
|
|
|
|
PrintingContext::Result result) {
|
|
|
|
+ if (result == PrintingContext::CANCEL) {
|
|
|
|
+ print_job_->PostTask(
|
|
|
|
+ FROM_HERE,
|
|
|
|
+ base::BindOnce(&NotificationCallback, base::RetainedRef(print_job_),
|
|
|
|
+ JobEventDetails::USER_INIT_CANCELED, 0,
|
|
|
|
+ base::RetainedRef(document_)));
|
|
|
|
+ }
|
2019-08-24 01:14:23 +00:00
|
|
|
std::move(callback).Run(printing_context_->TakeAndResetSettings(), result);
|
2019-06-12 19:34:07 +00:00
|
|
|
}
|
|
|
|
|
2018-10-13 01:57:04 +00:00
|
|
|
diff --git a/chrome/browser/printing/print_view_manager_base.cc b/chrome/browser/printing/print_view_manager_base.cc
|
2021-05-14 01:21:36 +00:00
|
|
|
index f6084545a8acf1485d862a2366eee1da56d0a565..e2882c8b4fbb5402066c9132ed5ebed138ed777c 100644
|
2018-10-13 01:57:04 +00:00
|
|
|
--- a/chrome/browser/printing/print_view_manager_base.cc
|
|
|
|
+++ b/chrome/browser/printing/print_view_manager_base.cc
|
2021-02-09 20:16:21 +00:00
|
|
|
@@ -28,10 +28,10 @@
|
2018-11-09 03:42:34 +00:00
|
|
|
#include "chrome/browser/printing/print_view_manager_common.h"
|
|
|
|
#include "chrome/browser/printing/printer_query.h"
|
|
|
|
#include "chrome/browser/profiles/profile.h"
|
|
|
|
-#include "chrome/browser/ui/simple_message_box.h"
|
|
|
|
-#include "chrome/browser/ui/webui/print_preview/printer_handler.h"
|
2018-10-13 01:57:04 +00:00
|
|
|
#include "chrome/common/pref_names.h"
|
2021-02-09 20:16:21 +00:00
|
|
|
+#if 0
|
|
|
|
#include "chrome/grit/generated_resources.h"
|
|
|
|
+#endif
|
2018-10-13 01:57:04 +00:00
|
|
|
#include "components/prefs/pref_service.h"
|
|
|
|
#include "components/printing/browser/print_composite_client.h"
|
2021-02-09 20:16:21 +00:00
|
|
|
#include "components/printing/browser/print_manager_utils.h"
|
|
|
|
@@ -46,6 +46,7 @@
|
2018-11-09 03:42:34 +00:00
|
|
|
#include "content/public/browser/render_process_host.h"
|
|
|
|
#include "content/public/browser/render_view_host.h"
|
|
|
|
#include "content/public/browser/web_contents.h"
|
|
|
|
+#include "electron/grit/electron_resources.h"
|
|
|
|
#include "mojo/public/cpp/system/buffer.h"
|
|
|
|
#include "printing/buildflags/buildflags.h"
|
2018-11-09 07:16:43 +00:00
|
|
|
#include "printing/metafile_skia.h"
|
2021-05-14 01:21:36 +00:00
|
|
|
@@ -110,6 +111,8 @@ crosapi::mojom::PrintJobPtr PrintJobToMojom(
|
|
|
|
#endif
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2021-03-15 18:32:18 +00:00
|
|
|
void ShowWarningMessageBox(const std::u16string& message) {
|
2018-10-13 01:57:04 +00:00
|
|
|
+ LOG(ERROR) << "Invalid printer settings " << message;
|
|
|
|
+#if 0
|
|
|
|
// Runs always on the UI thread.
|
|
|
|
static bool is_dialog_shown = false;
|
|
|
|
if (is_dialog_shown)
|
2021-05-14 01:21:36 +00:00
|
|
|
@@ -118,6 +121,7 @@ void ShowWarningMessageBox(const std::u16string& message) {
|
2018-10-13 01:57:04 +00:00
|
|
|
base::AutoReset<bool> auto_reset(&is_dialog_shown, true);
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2021-03-15 18:32:18 +00:00
|
|
|
chrome::ShowWarningMessageBox(nullptr, std::u16string(), message);
|
2019-07-03 01:22:09 +00:00
|
|
|
+#endif
|
2018-10-13 01:57:04 +00:00
|
|
|
}
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2018-10-13 01:57:04 +00:00
|
|
|
#if BUILDFLAG(ENABLE_PRINT_PREVIEW)
|
2021-05-14 01:21:36 +00:00
|
|
|
@@ -256,7 +260,9 @@ void UpdatePrintSettingsReplyOnIO(
|
2020-10-28 00:33:04 +00:00
|
|
|
DCHECK(printer_query);
|
|
|
|
auto params = mojom::PrintPagesParams::New();
|
|
|
|
params->params = mojom::PrintParams::New();
|
|
|
|
- if (printer_query->last_status() == PrintingContext::OK) {
|
|
|
|
+ // We call update without first printing from defaults,
|
|
|
|
+ // so the last printer status will still be defaulted to PrintingContext::FAILED
|
|
|
|
+ if (printer_query) {
|
|
|
|
RenderParamsFromPrintSettings(printer_query->settings(),
|
|
|
|
params->params.get());
|
|
|
|
params->params->document_cookie = printer_query->cookie();
|
2021-05-14 01:21:36 +00:00
|
|
|
@@ -382,12 +388,14 @@ PrintViewManagerBase::PrintViewManagerBase(content::WebContents* web_contents)
|
2020-09-21 08:00:36 +00:00
|
|
|
: PrintManager(web_contents),
|
2019-07-24 22:58:51 +00:00
|
|
|
queue_(g_browser_process->print_job_manager()->queue()) {
|
2018-10-13 01:57:04 +00:00
|
|
|
DCHECK(queue_);
|
2020-10-19 21:31:25 +00:00
|
|
|
+#if 0 // Printing is always enabled.
|
2018-10-13 01:57:04 +00:00
|
|
|
Profile* profile =
|
|
|
|
Profile::FromBrowserContext(web_contents->GetBrowserContext());
|
|
|
|
printing_enabled_.Init(
|
|
|
|
prefs::kPrintingEnabled, profile->GetPrefs(),
|
2019-07-03 01:22:09 +00:00
|
|
|
base::BindRepeating(&PrintViewManagerBase::UpdatePrintingEnabled,
|
|
|
|
weak_ptr_factory_.GetWeakPtr()));
|
|
|
|
+#endif
|
2018-10-13 01:57:04 +00:00
|
|
|
}
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2018-10-13 01:57:04 +00:00
|
|
|
PrintViewManagerBase::~PrintViewManagerBase() {
|
2021-05-14 01:21:36 +00:00
|
|
|
@@ -395,7 +403,10 @@ PrintViewManagerBase::~PrintViewManagerBase() {
|
2018-10-13 01:57:04 +00:00
|
|
|
DisconnectFromCurrentPrintJob();
|
|
|
|
}
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2018-10-13 01:57:04 +00:00
|
|
|
-bool PrintViewManagerBase::PrintNow(content::RenderFrameHost* rfh) {
|
|
|
|
+bool PrintViewManagerBase::PrintNow(content::RenderFrameHost* rfh,
|
2019-11-08 18:01:50 +00:00
|
|
|
+ bool silent,
|
|
|
|
+ base::Value settings,
|
|
|
|
+ CompletionCallback callback) {
|
2018-10-13 01:57:04 +00:00
|
|
|
DisconnectFromCurrentPrintJob();
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2020-05-26 20:06:26 +00:00
|
|
|
// Don't print / print preview crashed tabs.
|
2021-05-14 01:21:36 +00:00
|
|
|
@@ -403,7 +414,14 @@ bool PrintViewManagerBase::PrintNow(content::RenderFrameHost* rfh) {
|
2019-11-05 23:41:20 +00:00
|
|
|
return false;
|
|
|
|
|
2018-10-13 01:57:04 +00:00
|
|
|
SetPrintingRFH(rfh);
|
2019-11-05 23:41:20 +00:00
|
|
|
- GetPrintRenderFrame(rfh)->PrintRequestedPages();
|
2018-11-09 03:42:34 +00:00
|
|
|
+ callback_ = std::move(callback);
|
2019-11-08 18:01:50 +00:00
|
|
|
+
|
|
|
|
+ if (!callback_.is_null()) {
|
|
|
|
+ registrar_.Add(this, chrome::NOTIFICATION_PRINT_JOB_EVENT,
|
|
|
|
+ content::NotificationService::AllSources());
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ GetPrintRenderFrame(rfh)->PrintRequestedPages(silent, std::move(settings));
|
2019-11-05 23:41:20 +00:00
|
|
|
return true;
|
2018-10-13 01:57:04 +00:00
|
|
|
}
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2021-05-14 01:21:36 +00:00
|
|
|
@@ -524,9 +542,9 @@ void PrintViewManagerBase::StartLocalPrintJob(
|
2018-11-09 03:42:34 +00:00
|
|
|
void PrintViewManagerBase::UpdatePrintingEnabled() {
|
|
|
|
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
|
2018-10-13 01:57:04 +00:00
|
|
|
// The Unretained() is safe because ForEachFrame() is synchronous.
|
2018-11-09 03:42:34 +00:00
|
|
|
- web_contents()->ForEachFrame(base::BindRepeating(
|
|
|
|
- &PrintViewManagerBase::SendPrintingEnabled, base::Unretained(this),
|
2018-10-13 01:57:04 +00:00
|
|
|
- printing_enabled_.GetValue()));
|
2018-11-09 03:42:34 +00:00
|
|
|
+ web_contents()->ForEachFrame(
|
|
|
|
+ base::BindRepeating(&PrintViewManagerBase::SendPrintingEnabled,
|
|
|
|
+ base::Unretained(this), true));
|
2018-10-13 01:57:04 +00:00
|
|
|
}
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2018-10-13 01:57:04 +00:00
|
|
|
void PrintViewManagerBase::NavigationStopped() {
|
2021-05-14 01:21:36 +00:00
|
|
|
@@ -643,12 +661,13 @@ void PrintViewManagerBase::DidPrintDocument(
|
2020-10-19 21:31:25 +00:00
|
|
|
void PrintViewManagerBase::GetDefaultPrintSettings(
|
|
|
|
GetDefaultPrintSettingsCallback callback) {
|
|
|
|
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
|
|
|
|
+#if 0 // Printing is always enabled.
|
|
|
|
if (!printing_enabled_.GetValue()) {
|
|
|
|
auto params = mojom::PrintParams::New();
|
|
|
|
GetDefaultPrintSettingsReply(std::move(callback), std::move(params));
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
-
|
|
|
|
+#endif
|
|
|
|
content::RenderFrameHost* render_frame_host =
|
|
|
|
print_manager_host_receivers_.GetCurrentTargetFrame();
|
|
|
|
|
2021-05-14 01:21:36 +00:00
|
|
|
@@ -665,11 +684,12 @@ void PrintViewManagerBase::UpdatePrintSettings(
|
2020-10-28 00:33:04 +00:00
|
|
|
base::Value job_settings,
|
|
|
|
UpdatePrintSettingsCallback callback) {
|
|
|
|
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
|
|
|
|
+ #if 0 // Printing is always enabled.
|
|
|
|
if (!printing_enabled_.GetValue()) {
|
|
|
|
UpdatePrintSettingsReply(std::move(callback), nullptr, false);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
-
|
|
|
|
+ #endif
|
|
|
|
if (!job_settings.FindIntKey(kSettingPrinterType)) {
|
|
|
|
UpdatePrintSettingsReply(std::move(callback), nullptr, false);
|
|
|
|
return;
|
2021-05-14 01:21:36 +00:00
|
|
|
@@ -709,7 +729,7 @@ void PrintViewManagerBase::PrintingFailed(int32_t cookie) {
|
2020-09-21 08:00:36 +00:00
|
|
|
PrintManager::PrintingFailed(cookie);
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2018-10-13 01:57:04 +00:00
|
|
|
#if BUILDFLAG(ENABLE_PRINT_PREVIEW)
|
2018-11-09 03:42:34 +00:00
|
|
|
- ShowPrintErrorDialog();
|
|
|
|
+ // ShowPrintErrorDialog();
|
2018-10-13 01:57:04 +00:00
|
|
|
#endif
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2018-10-13 01:57:04 +00:00
|
|
|
ReleasePrinterQuery();
|
2021-05-14 01:21:36 +00:00
|
|
|
@@ -721,6 +741,11 @@ void PrintViewManagerBase::PrintingFailed(int32_t cookie) {
|
2020-07-10 16:42:22 +00:00
|
|
|
}
|
|
|
|
|
2020-09-21 08:00:36 +00:00
|
|
|
void PrintViewManagerBase::ShowInvalidPrinterSettingsError() {
|
2020-07-10 16:42:22 +00:00
|
|
|
+ if (!callback_.is_null()) {
|
|
|
|
+ std::string cb_str = "Invalid printer settings";
|
|
|
|
+ std::move(callback_).Run(printing_succeeded_, cb_str);
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
base::ThreadTaskRunnerHandle::Get()->PostTask(
|
|
|
|
FROM_HERE, base::BindOnce(&ShowWarningMessageBox,
|
|
|
|
l10n_util::GetStringUTF16(
|
2021-05-14 01:21:36 +00:00
|
|
|
@@ -790,9 +815,13 @@ void PrintViewManagerBase::OnNotifyPrintJobEvent(
|
2019-06-12 19:34:07 +00:00
|
|
|
content::NotificationService::NoDetails());
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
- case JobEventDetails::USER_INIT_DONE:
|
|
|
|
- case JobEventDetails::DEFAULT_INIT_DONE:
|
|
|
|
case JobEventDetails::USER_INIT_CANCELED: {
|
2019-07-01 21:03:19 +00:00
|
|
|
+ printing_cancelled_ = true;
|
2019-06-12 19:34:07 +00:00
|
|
|
+ ReleasePrintJob();
|
|
|
|
+ break;
|
|
|
|
+ }
|
|
|
|
+ case JobEventDetails::USER_INIT_DONE:
|
|
|
|
+ case JobEventDetails::DEFAULT_INIT_DONE: {
|
|
|
|
NOTREACHED();
|
|
|
|
break;
|
|
|
|
}
|
2021-05-14 01:21:36 +00:00
|
|
|
@@ -901,8 +930,10 @@ bool PrintViewManagerBase::CreateNewPrintJob(
|
2019-06-12 19:34:07 +00:00
|
|
|
DCHECK(!quit_inner_loop_);
|
|
|
|
DCHECK(query);
|
|
|
|
|
|
|
|
- // Disconnect the current |print_job_|.
|
|
|
|
- DisconnectFromCurrentPrintJob();
|
2020-01-27 18:54:56 +00:00
|
|
|
+ if (callback_.is_null()) {
|
|
|
|
+ // Disconnect the current |print_job_| only when calling window.print()
|
|
|
|
+ DisconnectFromCurrentPrintJob();
|
|
|
|
+ }
|
2019-07-03 01:22:09 +00:00
|
|
|
|
2019-06-12 19:34:07 +00:00
|
|
|
// We can't print if there is no renderer.
|
2020-11-14 00:16:56 +00:00
|
|
|
if (!web_contents()->GetMainFrame()->GetRenderViewHost() ||
|
2021-05-14 01:21:36 +00:00
|
|
|
@@ -923,8 +954,6 @@ bool PrintViewManagerBase::CreateNewPrintJob(
|
2021-02-09 20:16:21 +00:00
|
|
|
/*source_id=*/"");
|
2020-05-26 20:06:26 +00:00
|
|
|
#endif
|
2019-09-18 19:58:00 +00:00
|
|
|
|
2019-06-12 19:34:07 +00:00
|
|
|
- registrar_.Add(this, chrome::NOTIFICATION_PRINT_JOB_EVENT,
|
|
|
|
- content::Source<PrintJob>(print_job_.get()));
|
|
|
|
printing_succeeded_ = false;
|
|
|
|
return true;
|
|
|
|
}
|
2021-05-14 01:21:36 +00:00
|
|
|
@@ -973,14 +1002,22 @@ void PrintViewManagerBase::ReleasePrintJob() {
|
2018-10-13 01:57:04 +00:00
|
|
|
content::RenderFrameHost* rfh = printing_rfh_;
|
|
|
|
printing_rfh_ = nullptr;
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2019-07-01 21:03:19 +00:00
|
|
|
+ if (!callback_.is_null()) {
|
2020-08-20 06:28:24 +00:00
|
|
|
+ registrar_.Remove(this, chrome::NOTIFICATION_PRINT_JOB_EVENT,
|
|
|
|
+ content::NotificationService::AllSources());
|
|
|
|
+
|
2019-07-01 21:03:19 +00:00
|
|
|
+ std::string cb_str = "";
|
|
|
|
+ if (!printing_succeeded_)
|
|
|
|
+ cb_str = printing_cancelled_ ? "cancelled" : "failed";
|
|
|
|
+ std::move(callback_).Run(printing_succeeded_, cb_str);
|
|
|
|
+ }
|
2018-10-13 01:57:04 +00:00
|
|
|
+
|
|
|
|
if (!print_job_)
|
|
|
|
return;
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2019-11-05 23:41:20 +00:00
|
|
|
if (rfh)
|
|
|
|
GetPrintRenderFrame(rfh)->PrintingDone(printing_succeeded_);
|
2019-06-12 19:34:07 +00:00
|
|
|
|
2019-08-05 13:19:01 +00:00
|
|
|
- registrar_.Remove(this, chrome::NOTIFICATION_PRINT_JOB_EVENT,
|
2019-06-12 19:34:07 +00:00
|
|
|
- content::Source<PrintJob>(print_job_.get()));
|
|
|
|
// Don't close the worker thread.
|
|
|
|
print_job_ = nullptr;
|
|
|
|
}
|
2021-05-14 01:21:36 +00:00
|
|
|
@@ -1016,7 +1053,7 @@ bool PrintViewManagerBase::RunInnerMessageLoop() {
|
2020-01-27 18:54:56 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
bool PrintViewManagerBase::OpportunisticallyCreatePrintJob(int cookie) {
|
|
|
|
- if (print_job_)
|
|
|
|
+ if (print_job_ && print_job_->document())
|
|
|
|
return true;
|
|
|
|
|
|
|
|
if (!cookie) {
|
2018-10-13 01:57:04 +00:00
|
|
|
diff --git a/chrome/browser/printing/print_view_manager_base.h b/chrome/browser/printing/print_view_manager_base.h
|
2021-05-14 01:21:36 +00:00
|
|
|
index 62f4dc6083a13dd68ca510982a8073216d4f4b24..89ce604d8363c3a4d7b2f206da20167d9e722927 100644
|
2018-10-13 01:57:04 +00:00
|
|
|
--- a/chrome/browser/printing/print_view_manager_base.h
|
|
|
|
+++ b/chrome/browser/printing/print_view_manager_base.h
|
2021-03-16 14:01:00 +00:00
|
|
|
@@ -38,6 +38,8 @@ class PrintJob;
|
2018-11-09 03:42:34 +00:00
|
|
|
class PrintQueriesQueue;
|
|
|
|
class PrinterQuery;
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2019-07-01 21:03:19 +00:00
|
|
|
+using CompletionCallback = base::OnceCallback<void(bool, const std::string&)>;
|
2018-11-09 03:42:34 +00:00
|
|
|
+
|
|
|
|
// Base class for managing the print commands for a WebContents.
|
|
|
|
class PrintViewManagerBase : public content::NotificationObserver,
|
|
|
|
public PrintManager {
|
2021-03-16 14:01:00 +00:00
|
|
|
@@ -47,7 +49,10 @@ class PrintViewManagerBase : public content::NotificationObserver,
|
2018-10-13 01:57:04 +00:00
|
|
|
// Prints the current document immediately. Since the rendering is
|
|
|
|
// asynchronous, the actual printing will not be completed on the return of
|
|
|
|
// this function. Returns false if printing is impossible at the moment.
|
|
|
|
- virtual bool PrintNow(content::RenderFrameHost* rfh);
|
|
|
|
+ virtual bool PrintNow(content::RenderFrameHost* rfh,
|
2019-11-08 18:01:50 +00:00
|
|
|
+ bool silent,
|
|
|
|
+ base::Value settings,
|
2018-11-09 03:42:34 +00:00
|
|
|
+ CompletionCallback callback);
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2018-10-13 01:57:04 +00:00
|
|
|
#if BUILDFLAG(ENABLE_PRINT_PREVIEW)
|
|
|
|
// Prints the document in |print_data| with settings specified in
|
2021-05-14 01:21:36 +00:00
|
|
|
@@ -216,9 +221,15 @@ class PrintViewManagerBase : public content::NotificationObserver,
|
2018-11-09 03:42:34 +00:00
|
|
|
// The current RFH that is printing with a system printing dialog.
|
2020-09-21 08:00:36 +00:00
|
|
|
content::RenderFrameHost* printing_rfh_ = nullptr;
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2019-06-12 19:34:07 +00:00
|
|
|
+ // Respond with success of the print job.
|
2018-11-09 03:42:34 +00:00
|
|
|
+ CompletionCallback callback_;
|
2018-10-13 01:57:04 +00:00
|
|
|
+
|
2018-11-09 03:42:34 +00:00
|
|
|
// Indication of success of the print job.
|
2020-09-21 08:00:36 +00:00
|
|
|
bool printing_succeeded_ = false;
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2019-07-01 21:03:19 +00:00
|
|
|
+ // Indication of whether the print job was manually cancelled
|
|
|
|
+ bool printing_cancelled_ = false;
|
|
|
|
+
|
|
|
|
// Set while running an inner message loop inside RenderAllMissingPagesNow().
|
|
|
|
// This means we are _blocking_ until all the necessary pages have been
|
|
|
|
// rendered or the print settings are being loaded.
|
2019-11-05 23:41:20 +00:00
|
|
|
diff --git a/components/printing/common/print.mojom b/components/printing/common/print.mojom
|
2021-05-14 01:21:36 +00:00
|
|
|
index bea375f1c23fdb6efdd6e0f7801e7bd087ddb7a3..f74c70d1c535384df1849b2d2841b27f5d0b25c6 100644
|
2019-11-05 23:41:20 +00:00
|
|
|
--- a/components/printing/common/print.mojom
|
|
|
|
+++ b/components/printing/common/print.mojom
|
2021-02-09 20:16:21 +00:00
|
|
|
@@ -271,7 +271,7 @@ interface PrintPreviewUI {
|
2019-11-05 23:41:20 +00:00
|
|
|
interface PrintRenderFrame {
|
|
|
|
// Tells the RenderFrame to switch the CSS to print media type, render every
|
|
|
|
// requested page, and then switch back the CSS to display media type.
|
|
|
|
- PrintRequestedPages();
|
2019-11-08 18:01:50 +00:00
|
|
|
+ PrintRequestedPages(bool silent, mojo_base.mojom.DictionaryValue settings);
|
2019-11-05 23:41:20 +00:00
|
|
|
|
|
|
|
// Tells the RenderFrame to switch the CSS to print media type, render every
|
|
|
|
// requested page using the print preview document's frame/node, and then
|
2018-10-13 01:57:04 +00:00
|
|
|
diff --git a/components/printing/renderer/print_render_frame_helper.cc b/components/printing/renderer/print_render_frame_helper.cc
|
2021-05-14 01:21:36 +00:00
|
|
|
index fb3cbc567e322d3fe0c755712dfc8964e7767760..46301119f29f828f734ed9e4a2f6dcd1d86f6f8d 100644
|
2018-10-13 01:57:04 +00:00
|
|
|
--- a/components/printing/renderer/print_render_frame_helper.cc
|
|
|
|
+++ b/components/printing/renderer/print_render_frame_helper.cc
|
2021-03-04 23:46:13 +00:00
|
|
|
@@ -38,6 +38,7 @@
|
2019-06-27 03:53:17 +00:00
|
|
|
#include "printing/metafile_skia.h"
|
2020-05-26 20:06:26 +00:00
|
|
|
#include "printing/mojom/print.mojom.h"
|
2021-02-09 20:16:21 +00:00
|
|
|
#include "printing/print_job_constants.h"
|
2019-06-27 03:53:17 +00:00
|
|
|
+#include "printing/print_settings.h"
|
|
|
|
#include "printing/units.h"
|
2020-08-15 01:51:28 +00:00
|
|
|
#include "third_party/blink/public/common/associated_interfaces/associated_interface_provider.h"
|
2019-09-18 19:58:00 +00:00
|
|
|
#include "third_party/blink/public/common/associated_interfaces/associated_interface_registry.h"
|
2021-05-05 23:26:17 +00:00
|
|
|
@@ -1176,7 +1177,8 @@ void PrintRenderFrameHelper::ScriptedPrint(bool user_initiated) {
|
2020-10-16 01:30:41 +00:00
|
|
|
if (!weak_this)
|
|
|
|
return;
|
|
|
|
|
|
|
|
- Print(web_frame, blink::WebNode(), PrintRequestType::kScripted);
|
|
|
|
+ Print(web_frame, blink::WebNode(), PrintRequestType::kScripted,
|
|
|
|
+ false /* silent */, base::DictionaryValue() /* new_settings */);
|
2021-05-05 23:26:17 +00:00
|
|
|
if (!weak_this)
|
|
|
|
return;
|
2020-09-21 08:00:36 +00:00
|
|
|
|
2021-05-05 23:26:17 +00:00
|
|
|
@@ -1207,7 +1209,7 @@ void PrintRenderFrameHelper::BindPrintRenderFrameReceiver(
|
2019-11-05 23:41:20 +00:00
|
|
|
receivers_.Add(this, std::move(receiver));
|
2018-10-13 01:57:04 +00:00
|
|
|
}
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2019-11-05 23:41:20 +00:00
|
|
|
-void PrintRenderFrameHelper::PrintRequestedPages() {
|
2019-11-08 18:01:50 +00:00
|
|
|
+void PrintRenderFrameHelper::PrintRequestedPages(bool silent, base::Value settings) {
|
2019-11-05 23:41:20 +00:00
|
|
|
ScopedIPC scoped_ipc(weak_ptr_factory_.GetWeakPtr());
|
2018-10-13 01:57:04 +00:00
|
|
|
if (ipc_nesting_level_ > 1)
|
|
|
|
return;
|
2021-05-05 23:26:17 +00:00
|
|
|
@@ -1222,7 +1224,7 @@ void PrintRenderFrameHelper::PrintRequestedPages() {
|
2020-10-16 01:30:41 +00:00
|
|
|
// that instead.
|
|
|
|
auto plugin = delegate_->GetPdfElement(frame);
|
2020-09-21 08:00:36 +00:00
|
|
|
|
2020-10-16 01:30:41 +00:00
|
|
|
- Print(frame, plugin, PrintRequestType::kRegular);
|
|
|
|
+ Print(frame, plugin, PrintRequestType::kRegular, silent, std::move(settings));
|
2020-09-21 08:00:36 +00:00
|
|
|
|
2019-11-05 23:41:20 +00:00
|
|
|
if (!render_frame_gone_)
|
2020-10-16 01:30:41 +00:00
|
|
|
frame->DispatchAfterPrintEvent();
|
2021-05-14 01:21:36 +00:00
|
|
|
@@ -1253,7 +1255,8 @@ void PrintRenderFrameHelper::PrintForSystemDialog() {
|
2020-10-16 01:30:41 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
Print(frame, print_preview_context_.source_node(),
|
|
|
|
- PrintRequestType::kRegular);
|
|
|
|
+ PrintRequestType::kRegular, false,
|
|
|
|
+ base::DictionaryValue());
|
2019-11-05 23:41:20 +00:00
|
|
|
if (!render_frame_gone_)
|
2020-09-21 08:00:36 +00:00
|
|
|
print_preview_context_.DispatchAfterPrintEvent();
|
2018-10-13 01:57:04 +00:00
|
|
|
// WARNING: |this| may be gone at this point. Do not do any more work here and
|
2021-05-05 23:26:17 +00:00
|
|
|
@@ -1300,6 +1303,8 @@ void PrintRenderFrameHelper::PrintPreview(base::Value settings) {
|
2018-10-13 01:57:04 +00:00
|
|
|
if (ipc_nesting_level_ > 1)
|
|
|
|
return;
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2018-10-13 01:57:04 +00:00
|
|
|
+ blink::WebLocalFrame* frame = render_frame()->GetWebFrame();
|
|
|
|
+ print_preview_context_.InitWithFrame(frame);
|
|
|
|
print_preview_context_.OnPrintPreview();
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2020-06-22 17:35:10 +00:00
|
|
|
if (print_preview_context_.IsForArc()) {
|
2021-05-05 23:26:17 +00:00
|
|
|
@@ -1835,7 +1840,8 @@ void PrintRenderFrameHelper::PrintNode(const blink::WebNode& node) {
|
2020-08-15 01:51:28 +00:00
|
|
|
return;
|
2018-11-09 03:42:34 +00:00
|
|
|
|
|
|
|
Print(duplicate_node.GetDocument().GetFrame(), duplicate_node,
|
2020-10-16 01:30:41 +00:00
|
|
|
- PrintRequestType::kRegular);
|
2020-09-21 08:00:36 +00:00
|
|
|
+ PrintRequestType::kRegular, false /* silent */,
|
2020-10-16 01:30:41 +00:00
|
|
|
+ base::DictionaryValue() /* new_settings */);
|
2018-11-09 03:42:34 +00:00
|
|
|
// Check if |this| is still valid.
|
2020-08-15 01:51:28 +00:00
|
|
|
if (!weak_this)
|
2018-11-09 03:42:34 +00:00
|
|
|
return;
|
2021-05-05 23:26:17 +00:00
|
|
|
@@ -1850,7 +1856,9 @@ void PrintRenderFrameHelper::PrintNode(const blink::WebNode& node) {
|
2020-10-16 01:30:41 +00:00
|
|
|
|
|
|
|
void PrintRenderFrameHelper::Print(blink::WebLocalFrame* frame,
|
|
|
|
const blink::WebNode& node,
|
|
|
|
- PrintRequestType print_request_type) {
|
|
|
|
+ PrintRequestType print_request_type,
|
|
|
|
+ bool silent,
|
|
|
|
+ base::Value settings) {
|
2018-10-13 01:57:04 +00:00
|
|
|
// If still not finished with earlier print request simply ignore.
|
|
|
|
if (prep_frame_view_)
|
2020-10-16 01:30:41 +00:00
|
|
|
return;
|
2021-05-05 23:26:17 +00:00
|
|
|
@@ -1858,7 +1866,7 @@ void PrintRenderFrameHelper::Print(blink::WebLocalFrame* frame,
|
2019-02-26 21:35:27 +00:00
|
|
|
FrameReference frame_ref(frame);
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2020-09-21 08:00:36 +00:00
|
|
|
uint32_t expected_page_count = 0;
|
2018-10-13 01:57:04 +00:00
|
|
|
- if (!CalculateNumberOfPages(frame, node, &expected_page_count)) {
|
2019-11-08 18:01:50 +00:00
|
|
|
+ if (!CalculateNumberOfPages(frame, node, &expected_page_count, base::Value::AsDictionaryValue(settings))) {
|
2018-10-13 01:57:04 +00:00
|
|
|
DidFinishPrinting(FAIL_PRINT_INIT);
|
|
|
|
return; // Failed to init print page settings.
|
|
|
|
}
|
2021-05-05 23:26:17 +00:00
|
|
|
@@ -1877,8 +1885,41 @@ void PrintRenderFrameHelper::Print(blink::WebLocalFrame* frame,
|
2020-09-21 08:00:36 +00:00
|
|
|
print_pages_params_->params->print_scaling_option;
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2018-10-13 01:57:04 +00:00
|
|
|
auto self = weak_ptr_factory_.GetWeakPtr();
|
2021-01-12 23:31:23 +00:00
|
|
|
- mojom::PrintPagesParamsPtr print_settings = GetPrintSettingsFromUser(
|
|
|
|
+ mojom::PrintPagesParamsPtr print_settings;
|
|
|
|
+
|
|
|
|
+ if (silent) {
|
|
|
|
+ print_settings = mojom::PrintPagesParams::New();
|
|
|
|
+ print_settings->params = mojom::PrintParams::New(
|
2020-09-21 08:00:36 +00:00
|
|
|
+ print_pages_params_->params->page_size,
|
|
|
|
+ print_pages_params_->params->content_size,
|
|
|
|
+ print_pages_params_->params->printable_area,
|
|
|
|
+ print_pages_params_->params->margin_top,
|
|
|
|
+ print_pages_params_->params->margin_left,
|
|
|
|
+ print_pages_params_->params->page_orientation,
|
|
|
|
+ print_pages_params_->params->dpi,
|
|
|
|
+ print_pages_params_->params->scale_factor,
|
|
|
|
+ print_pages_params_->params->document_cookie,
|
|
|
|
+ print_pages_params_->params->selection_only,
|
|
|
|
+ print_pages_params_->params->supports_alpha_blend,
|
|
|
|
+ print_pages_params_->params->preview_ui_id,
|
|
|
|
+ print_pages_params_->params->preview_request_id,
|
|
|
|
+ print_pages_params_->params->is_first_request,
|
|
|
|
+ print_pages_params_->params->print_scaling_option,
|
|
|
|
+ print_pages_params_->params->print_to_pdf,
|
|
|
|
+ print_pages_params_->params->display_header_footer,
|
|
|
|
+ print_pages_params_->params->title,
|
|
|
|
+ print_pages_params_->params->url,
|
|
|
|
+ print_pages_params_->params->header_template,
|
|
|
|
+ print_pages_params_->params->footer_template,
|
|
|
|
+ print_pages_params_->params->rasterize_pdf,
|
|
|
|
+ print_pages_params_->params->should_print_backgrounds,
|
|
|
|
+ print_pages_params_->params->printed_doc_type,
|
|
|
|
+ print_pages_params_->params->prefer_css_page_size,
|
|
|
|
+ print_pages_params_->params->pages_per_sheet);
|
2021-01-12 23:31:23 +00:00
|
|
|
+ } else {
|
|
|
|
+ print_settings = GetPrintSettingsFromUser(
|
|
|
|
frame_ref.GetFrame(), node, expected_page_count, print_request_type);
|
2020-09-21 08:00:36 +00:00
|
|
|
+ }
|
2018-10-13 01:57:04 +00:00
|
|
|
// Check if |this| is still valid.
|
|
|
|
if (!self)
|
|
|
|
return;
|
2021-05-05 23:26:17 +00:00
|
|
|
@@ -2127,7 +2168,9 @@ void PrintRenderFrameHelper::IPCProcessed() {
|
2020-10-16 01:30:41 +00:00
|
|
|
}
|
2018-10-13 01:57:04 +00:00
|
|
|
}
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2018-10-13 01:57:04 +00:00
|
|
|
-bool PrintRenderFrameHelper::InitPrintSettings(bool fit_to_paper_size) {
|
|
|
|
+bool PrintRenderFrameHelper::InitPrintSettings(
|
|
|
|
+ bool fit_to_paper_size,
|
2018-11-09 03:42:34 +00:00
|
|
|
+ const base::DictionaryValue& new_settings) {
|
2020-09-21 08:00:36 +00:00
|
|
|
mojom::PrintPagesParams settings;
|
|
|
|
settings.params = mojom::PrintParams::New();
|
2020-10-16 01:30:41 +00:00
|
|
|
GetPrintManagerHost()->GetDefaultPrintSettings(&settings.params);
|
2021-05-05 23:26:17 +00:00
|
|
|
@@ -2151,12 +2194,14 @@ bool PrintRenderFrameHelper::InitPrintSettings(bool fit_to_paper_size) {
|
2018-11-09 03:42:34 +00:00
|
|
|
return result;
|
|
|
|
}
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2018-11-09 03:42:34 +00:00
|
|
|
-bool PrintRenderFrameHelper::CalculateNumberOfPages(blink::WebLocalFrame* frame,
|
|
|
|
- const blink::WebNode& node,
|
2020-09-21 08:00:36 +00:00
|
|
|
- uint32_t* number_of_pages) {
|
2018-11-09 03:42:34 +00:00
|
|
|
+bool PrintRenderFrameHelper::CalculateNumberOfPages(
|
|
|
|
+ blink::WebLocalFrame* frame,
|
|
|
|
+ const blink::WebNode& node,
|
2020-09-21 08:00:36 +00:00
|
|
|
+ uint32_t* number_of_pages,
|
2018-11-09 03:42:34 +00:00
|
|
|
+ const base::DictionaryValue& settings) {
|
2018-10-13 01:57:04 +00:00
|
|
|
DCHECK(frame);
|
2019-01-16 18:07:52 +00:00
|
|
|
bool fit_to_paper_size = !IsPrintingNodeOrPdfFrame(frame, node);
|
2018-10-13 01:57:04 +00:00
|
|
|
- if (!InitPrintSettings(fit_to_paper_size)) {
|
2018-11-09 03:42:34 +00:00
|
|
|
+ if (!InitPrintSettings(fit_to_paper_size, settings)) {
|
2018-10-13 01:57:04 +00:00
|
|
|
notify_browser_of_print_failure_ = false;
|
2020-09-21 08:00:36 +00:00
|
|
|
GetPrintManagerHost()->ShowInvalidPrinterSettingsError();
|
2018-10-13 01:57:04 +00:00
|
|
|
return false;
|
2021-05-05 23:26:17 +00:00
|
|
|
@@ -2527,18 +2572,7 @@ void PrintRenderFrameHelper::RequestPrintPreview(PrintPreviewRequestType type) {
|
2021-02-09 20:16:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
bool PrintRenderFrameHelper::CheckForCancel() {
|
|
|
|
- const mojom::PrintParams& print_params = *print_pages_params_->params;
|
|
|
|
- bool cancel = false;
|
|
|
|
-
|
|
|
|
- if (!GetPrintManagerHost()->CheckForCancel(print_params.preview_ui_id,
|
|
|
|
- print_params.preview_request_id,
|
|
|
|
- &cancel)) {
|
|
|
|
- cancel = true;
|
|
|
|
- }
|
|
|
|
-
|
|
|
|
- if (cancel)
|
|
|
|
- notify_browser_of_print_failure_ = false;
|
|
|
|
- return cancel;
|
|
|
|
+ return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool PrintRenderFrameHelper::PreviewPageRendered(
|
2018-10-13 01:57:04 +00:00
|
|
|
diff --git a/components/printing/renderer/print_render_frame_helper.h b/components/printing/renderer/print_render_frame_helper.h
|
2021-05-14 01:21:36 +00:00
|
|
|
index 6a1fa397ec36b970d610fa30f6e4d6b4f8b7b3d6..6043c98774a68d39da665371cdb00ded00350f61 100644
|
2018-10-13 01:57:04 +00:00
|
|
|
--- a/components/printing/renderer/print_render_frame_helper.h
|
|
|
|
+++ b/components/printing/renderer/print_render_frame_helper.h
|
2020-12-14 18:57:36 +00:00
|
|
|
@@ -231,7 +231,7 @@ class PrintRenderFrameHelper
|
2019-11-05 23:41:20 +00:00
|
|
|
mojo::PendingAssociatedReceiver<mojom::PrintRenderFrame> receiver);
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2019-11-05 23:41:20 +00:00
|
|
|
// printing::mojom::PrintRenderFrame:
|
|
|
|
- void PrintRequestedPages() override;
|
2019-11-08 18:01:50 +00:00
|
|
|
+ void PrintRequestedPages(bool silent, base::Value settings) override;
|
2018-10-13 01:57:04 +00:00
|
|
|
#if BUILDFLAG(ENABLE_PRINT_PREVIEW)
|
2021-05-14 01:21:36 +00:00
|
|
|
void PrintForSystemDialog() override;
|
2020-05-26 20:06:26 +00:00
|
|
|
void SetPrintPreviewUI(
|
2020-12-14 18:57:36 +00:00
|
|
|
@@ -298,7 +298,9 @@ class PrintRenderFrameHelper
|
2020-10-16 01:30:41 +00:00
|
|
|
// WARNING: |this| may be gone after this method returns.
|
2018-10-13 01:57:04 +00:00
|
|
|
void Print(blink::WebLocalFrame* frame,
|
|
|
|
const blink::WebNode& node,
|
2020-10-16 01:30:41 +00:00
|
|
|
- PrintRequestType print_request_type);
|
|
|
|
+ PrintRequestType print_request_type,
|
2018-11-09 03:42:34 +00:00
|
|
|
+ bool silent,
|
2020-10-16 01:30:41 +00:00
|
|
|
+ base::Value settings);
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2018-10-13 01:57:04 +00:00
|
|
|
// Notification when printing is done - signal tear-down/free resources.
|
2020-10-16 01:30:41 +00:00
|
|
|
void DidFinishPrinting(PrintingResult result);
|
2020-12-14 18:57:36 +00:00
|
|
|
@@ -307,12 +309,14 @@ class PrintRenderFrameHelper
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2018-10-13 01:57:04 +00:00
|
|
|
// Initialize print page settings with default settings.
|
|
|
|
// Used only for native printing workflow.
|
|
|
|
- bool InitPrintSettings(bool fit_to_paper_size);
|
|
|
|
+ bool InitPrintSettings(bool fit_to_paper_size,
|
2018-11-09 03:42:34 +00:00
|
|
|
+ const base::DictionaryValue& settings);
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2018-10-13 01:57:04 +00:00
|
|
|
// Calculate number of pages in source document.
|
2018-11-09 03:42:34 +00:00
|
|
|
bool CalculateNumberOfPages(blink::WebLocalFrame* frame,
|
|
|
|
const blink::WebNode& node,
|
2020-09-21 08:00:36 +00:00
|
|
|
- uint32_t* number_of_pages);
|
|
|
|
+ uint32_t* number_of_pages,
|
2018-11-09 03:42:34 +00:00
|
|
|
+ const base::DictionaryValue& settings);
|
2018-10-24 18:24:11 +00:00
|
|
|
|
2018-10-13 01:57:04 +00:00
|
|
|
#if BUILDFLAG(ENABLE_PRINT_PREVIEW)
|
|
|
|
// Set options for print preset from source PDF document.
|
2019-08-07 14:47:24 +00:00
|
|
|
diff --git a/printing/printing_context.cc b/printing/printing_context.cc
|
2021-05-14 01:21:36 +00:00
|
|
|
index 30fa5344771c7e558ba44177429c551cba3b03e8..29d7e4a020989af699a25f69a4ee5ced70cb70bb 100644
|
2019-08-07 14:47:24 +00:00
|
|
|
--- a/printing/printing_context.cc
|
|
|
|
+++ b/printing/printing_context.cc
|
2020-10-16 01:30:41 +00:00
|
|
|
@@ -96,7 +96,6 @@ PrintingContext::Result PrintingContext::UsePdfSettings() {
|
2019-08-07 14:47:24 +00:00
|
|
|
|
|
|
|
PrintingContext::Result PrintingContext::UpdatePrintSettings(
|
|
|
|
base::Value job_settings) {
|
|
|
|
- ResetSettings();
|
2020-09-21 08:00:36 +00:00
|
|
|
{
|
|
|
|
std::unique_ptr<PrintSettings> settings =
|
|
|
|
PrintSettingsFromJobSettings(job_settings);
|
2019-08-07 14:47:24 +00:00
|
|
|
diff --git a/printing/printing_context.h b/printing/printing_context.h
|
2021-05-14 01:21:36 +00:00
|
|
|
index 5c300fa414fbb8688674aed114543e602cdb96db..ba6d0bbce4edcb1a6e05108e4e83fc6ba5894bb4 100644
|
2019-08-07 14:47:24 +00:00
|
|
|
--- a/printing/printing_context.h
|
|
|
|
+++ b/printing/printing_context.h
|
2021-05-04 03:13:46 +00:00
|
|
|
@@ -133,12 +133,12 @@ class COMPONENT_EXPORT(PRINTING) PrintingContext {
|
2019-08-07 14:47:24 +00:00
|
|
|
|
|
|
|
int job_id() const { return job_id_; }
|
|
|
|
|
|
|
|
- protected:
|
|
|
|
- explicit PrintingContext(Delegate* delegate);
|
|
|
|
-
|
|
|
|
// Reinitializes the settings for object reuse.
|
|
|
|
void ResetSettings();
|
|
|
|
|
|
|
|
+ protected:
|
|
|
|
+ explicit PrintingContext(Delegate* delegate);
|
|
|
|
+
|
|
|
|
// Does bookkeeping when an error occurs.
|
|
|
|
PrintingContext::Result OnError();
|
|
|
|
|