2019-08-29 06:50:14 +00:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
From: Jeremy Apthorp <nornagon@nornagon.net>
|
|
|
|
Date: Wed, 28 Aug 2019 12:21:25 -0700
|
|
|
|
Subject: expose SetUserAgent on NetworkContext
|
|
|
|
|
|
|
|
Applying
|
|
|
|
https://chromium-review.googlesource.com/c/chromium/src/+/1585083 before
|
|
|
|
it's merged. There may end up being a better way of doing this, or the
|
|
|
|
patch may be merged upstream, at which point this patch should be
|
|
|
|
removed.
|
|
|
|
|
|
|
|
diff --git a/net/url_request/static_http_user_agent_settings.h b/net/url_request/static_http_user_agent_settings.h
|
|
|
|
index 0ccfe130f00ec3b6c75cd8ee04d5a2777e1fd00c..653829457d58bf92057cc36aa8a289703d8b0577 100644
|
|
|
|
--- a/net/url_request/static_http_user_agent_settings.h
|
|
|
|
+++ b/net/url_request/static_http_user_agent_settings.h
|
|
|
|
@@ -26,13 +26,17 @@ class NET_EXPORT StaticHttpUserAgentSettings : public HttpUserAgentSettings {
|
|
|
|
accept_language_ = new_accept_language;
|
|
|
|
}
|
|
|
|
|
|
|
|
+ void set_user_agent(const std::string& new_user_agent) {
|
|
|
|
+ user_agent_ = new_user_agent;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
// HttpUserAgentSettings implementation
|
|
|
|
std::string GetAcceptLanguage() const override;
|
|
|
|
std::string GetUserAgent() const override;
|
|
|
|
|
|
|
|
private:
|
|
|
|
std::string accept_language_;
|
|
|
|
- const std::string user_agent_;
|
|
|
|
+ std::string user_agent_;
|
|
|
|
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(StaticHttpUserAgentSettings);
|
|
|
|
};
|
|
|
|
diff --git a/services/network/network_context.cc b/services/network/network_context.cc
|
2020-10-28 00:33:04 +00:00
|
|
|
index 12d4c84230994b1ef2e4914945d1f3617c54eb0c..3206163070281a00d13e95f22215af789cb1214c 100644
|
2019-08-29 06:50:14 +00:00
|
|
|
--- a/services/network/network_context.cc
|
|
|
|
+++ b/services/network/network_context.cc
|
2020-10-28 00:33:04 +00:00
|
|
|
@@ -1091,6 +1091,13 @@ void NetworkContext::SetNetworkConditions(
|
2019-08-29 06:50:14 +00:00
|
|
|
std::move(network_conditions));
|
|
|
|
}
|
|
|
|
|
|
|
|
+void NetworkContext::SetUserAgent(const std::string& new_user_agent) {
|
|
|
|
+ // This may only be called on NetworkContexts created with a constructor that
|
|
|
|
+ // calls ApplyContextParamsToBuilder.
|
|
|
|
+ DCHECK(user_agent_settings_);
|
|
|
|
+ user_agent_settings_->set_user_agent(new_user_agent);
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
void NetworkContext::SetAcceptLanguage(const std::string& new_accept_language) {
|
|
|
|
// This may only be called on NetworkContexts created with the constructor
|
|
|
|
// that calls MakeURLRequestContext().
|
|
|
|
diff --git a/services/network/network_context.h b/services/network/network_context.h
|
2020-10-28 00:33:04 +00:00
|
|
|
index 95d1aa8cdaf6e0417475bcf95fed28cb2867431c..d081918cf278d1d7b7168b4caeb8264c7e503453 100644
|
2019-08-29 06:50:14 +00:00
|
|
|
--- a/services/network/network_context.h
|
|
|
|
+++ b/services/network/network_context.h
|
2020-10-28 00:33:04 +00:00
|
|
|
@@ -246,6 +246,7 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) NetworkContext
|
2019-08-29 06:50:14 +00:00
|
|
|
void CloseIdleConnections(CloseIdleConnectionsCallback callback) override;
|
|
|
|
void SetNetworkConditions(const base::UnguessableToken& throttling_profile_id,
|
|
|
|
mojom::NetworkConditionsPtr conditions) override;
|
|
|
|
+ void SetUserAgent(const std::string& new_user_agent) override;
|
|
|
|
void SetAcceptLanguage(const std::string& new_accept_language) override;
|
|
|
|
void SetEnableReferrers(bool enable_referrers) override;
|
2020-10-28 00:33:04 +00:00
|
|
|
#if BUILDFLAG(IS_ASH)
|
2019-08-29 06:50:14 +00:00
|
|
|
diff --git a/services/network/public/mojom/network_context.mojom b/services/network/public/mojom/network_context.mojom
|
2020-10-28 00:33:04 +00:00
|
|
|
index 19a76ea08c4301c6cb10bc65c1a49ac0e93c3c5e..c6e9b42a85d25e613dbe5431db08430c87799e0a 100644
|
2019-08-29 06:50:14 +00:00
|
|
|
--- a/services/network/public/mojom/network_context.mojom
|
|
|
|
+++ b/services/network/public/mojom/network_context.mojom
|
2020-10-28 00:33:04 +00:00
|
|
|
@@ -1062,6 +1062,9 @@ interface NetworkContext {
|
2019-08-29 06:50:14 +00:00
|
|
|
SetNetworkConditions(mojo_base.mojom.UnguessableToken throttling_profile_id,
|
|
|
|
NetworkConditions? conditions);
|
|
|
|
|
|
|
|
+ // Updates the user agent to be used for requests.
|
|
|
|
+ SetUserAgent(string new_user_agent);
|
|
|
|
+
|
|
|
|
// Updates the Accept-Language header to be used for requests.
|
|
|
|
SetAcceptLanguage(string new_accept_language);
|
|
|
|
|
|
|
|
diff --git a/services/network/test/test_network_context.h b/services/network/test/test_network_context.h
|
2020-10-28 00:33:04 +00:00
|
|
|
index 3c5e139c9c40fc2844084c48f531ca40041f6112..c27e79d6175c8394681904e144a1925b92794200 100644
|
2019-08-29 06:50:14 +00:00
|
|
|
--- a/services/network/test/test_network_context.h
|
|
|
|
+++ b/services/network/test/test_network_context.h
|
2020-10-28 00:33:04 +00:00
|
|
|
@@ -108,6 +108,7 @@ class TestNetworkContext : public mojom::NetworkContext {
|
2019-08-29 06:50:14 +00:00
|
|
|
void CloseIdleConnections(CloseIdleConnectionsCallback callback) override {}
|
|
|
|
void SetNetworkConditions(const base::UnguessableToken& throttling_profile_id,
|
|
|
|
mojom::NetworkConditionsPtr conditions) override {}
|
|
|
|
+ void SetUserAgent(const std::string& new_user_agent) override {}
|
|
|
|
void SetAcceptLanguage(const std::string& new_accept_language) override {}
|
|
|
|
void SetEnableReferrers(bool enable_referrers) override {}
|
2020-10-28 00:33:04 +00:00
|
|
|
#if BUILDFLAG(IS_ASH)
|