1 line
42 KiB
Text
1 line
42 KiB
Text
|
{"status":200,"url":"https://api.github.com/repos/electron/electron/issues/20214/comments?per_page=100","headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","cache-control":"private, max-age=60, s-maxage=60","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 26 May 2020 16:31:14 GMT","etag":"W/\"3a1b7642c1edb42f6a13611136ff55a5\"","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"200 OK","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding, Accept, X-Requested-With","x-accepted-oauth-scopes":"","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"C1E4:508A:20B53:39898:5ECD444B","x-oauth-scopes":"repo","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4970","x-ratelimit-reset":"1590510696","x-xss-protection":"1; mode=block"},"data":[{"url":"https://api.github.com/repos/electron/electron/issues/comments/530855479","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-530855479","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":530855479,"node_id":"MDEyOklzc3VlQ29tbWVudDUzMDg1NTQ3OQ==","user":{"login":"nornagon","id":172800,"node_id":"MDQ6VXNlcjE3MjgwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/172800?v=4","gravatar_id":"","url":"https://api.github.com/users/nornagon","html_url":"https://github.com/nornagon","followers_url":"https://api.github.com/users/nornagon/followers","following_url":"https://api.github.com/users/nornagon/following{/other_user}","gists_url":"https://api.github.com/users/nornagon/gists{/gist_id}","starred_url":"https://api.github.com/users/nornagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nornagon/subscriptions","organizations_url":"https://api.github.com/users/nornagon/orgs","repos_url":"https://api.github.com/users/nornagon/repos","events_url":"https://api.github.com/users/nornagon/events{/privacy}","received_events_url":"https://api.github.com/users/nornagon/received_events","type":"User","site_admin":false},"created_at":"2019-09-12T14:35:55Z","updated_at":"2019-09-12T14:35:55Z","author_association":"MEMBER","body":"I did some preliminary performance testing. The numbers below are the average time taken, in milliseconds, to send a Uint8Array buffer of a given size, across 200 calls to `send()`.\r\n\r\nWith the existing mojo-based `base::Value` serialization:\r\n```\r\n200 x 2k: 0.42\r\n200 x 4k: 0.60\r\n200 x 8k: 0.93\r\n200 x 16k: 1.61\r\n200 x 32k: 2.88\r\n200 x 64k: 5.50\r\n200 x 128k: 10.74\r\n200 x 256k: 21.07\r\n200 x 512k: 42.62\r\n```\r\n\r\nWith this PR, using v8's ValueSerializer:\r\n```\r\n200 x 2k: 0.44\r\n200 x 4k: 0.55\r\n200 x 8k: 0.76\r\n200 x 16k: 1.08\r\n200 x 32k: 1.90\r\n200 x 64k: 3.44\r\n200 x 128k: 6.53\r\n200 x 256k: 12.59\r\n200 x 512k: 23.99\r\n```\r\n\r\n\r\nSo this seems to be a little less than twice as fast for this use case."},{"url":"https://api.github.com/repos/electron/electron/issues/comments/530916907","html_url":"https://github.com/electron/electron/pull/20214#issuecomment-530916907","issue_url":"https://api.github.com/repos/electron/electron/issues/20214","id":530916907,"node_id":"MDEyOklzc3VlQ29tbWVudDUzMDkxNjkwNw==","user":{"login":"nornagon","id":172800,"node_id":"MDQ6VXNlcjE3MjgwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/172800?v=4","gravatar_id":"","url":"https://api.github.com/users/nornagon","html_url":"https://github.com/nornagon","followers_url":"https://api.github.com/users/nornagon/followers","following_url":"https://api.github.com/users/nornagon/fol
|