2019-08-29 06:50:14 +00:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
From: Jeremy Apthorp <nornagon@nornagon.net>
|
|
|
|
Date: Wed, 28 Aug 2019 12:21:25 -0700
|
|
|
|
Subject: expose SetUserAgent on NetworkContext
|
|
|
|
|
|
|
|
Applying
|
|
|
|
https://chromium-review.googlesource.com/c/chromium/src/+/1585083 before
|
|
|
|
it's merged. There may end up being a better way of doing this, or the
|
|
|
|
patch may be merged upstream, at which point this patch should be
|
|
|
|
removed.
|
|
|
|
|
|
|
|
diff --git a/net/url_request/static_http_user_agent_settings.h b/net/url_request/static_http_user_agent_settings.h
|
2022-10-03 20:21:00 +00:00
|
|
|
index 0ab8187b0db8ae6db46d81738f653a2bc4c566f6..de3d55e85c22317f7f9375eb94d0d5d41b0dbd3b 100644
|
2019-08-29 06:50:14 +00:00
|
|
|
--- a/net/url_request/static_http_user_agent_settings.h
|
|
|
|
+++ b/net/url_request/static_http_user_agent_settings.h
|
2021-11-24 08:45:59 +00:00
|
|
|
@@ -30,13 +30,17 @@ class NET_EXPORT StaticHttpUserAgentSettings : public HttpUserAgentSettings {
|
2019-08-29 06:50:14 +00:00
|
|
|
accept_language_ = new_accept_language;
|
|
|
|
}
|
|
|
|
|
|
|
|
+ void set_user_agent(const std::string& new_user_agent) {
|
|
|
|
+ user_agent_ = new_user_agent;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
// HttpUserAgentSettings implementation
|
|
|
|
std::string GetAcceptLanguage() const override;
|
|
|
|
std::string GetUserAgent() const override;
|
|
|
|
|
|
|
|
private:
|
|
|
|
std::string accept_language_;
|
|
|
|
- const std::string user_agent_;
|
|
|
|
+ std::string user_agent_;
|
|
|
|
};
|
2021-10-21 18:51:36 +00:00
|
|
|
|
|
|
|
} // namespace net
|
2019-08-29 06:50:14 +00:00
|
|
|
diff --git a/services/network/network_context.cc b/services/network/network_context.cc
|
2024-08-02 14:02:11 +00:00
|
|
|
index 0d6d4d646bd6e7c187b5174edff2ddb0c51d7867..deb9e51c9c6a185dbd45fabe7e7b7454e8870026 100644
|
2019-08-29 06:50:14 +00:00
|
|
|
--- a/services/network/network_context.cc
|
|
|
|
+++ b/services/network/network_context.cc
|
2024-08-02 14:02:11 +00:00
|
|
|
@@ -1728,6 +1728,13 @@ void NetworkContext::SetNetworkConditions(
|
2019-08-29 06:50:14 +00:00
|
|
|
std::move(network_conditions));
|
|
|
|
}
|
|
|
|
|
|
|
|
+void NetworkContext::SetUserAgent(const std::string& new_user_agent) {
|
|
|
|
+ // This may only be called on NetworkContexts created with a constructor that
|
|
|
|
+ // calls ApplyContextParamsToBuilder.
|
|
|
|
+ DCHECK(user_agent_settings_);
|
|
|
|
+ user_agent_settings_->set_user_agent(new_user_agent);
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
void NetworkContext::SetAcceptLanguage(const std::string& new_accept_language) {
|
|
|
|
// This may only be called on NetworkContexts created with the constructor
|
|
|
|
// that calls MakeURLRequestContext().
|
|
|
|
diff --git a/services/network/network_context.h b/services/network/network_context.h
|
2024-08-02 14:02:11 +00:00
|
|
|
index b0df50eca7d4bed289940ebdf968a36fd891297b..02c6fabb412cfbf3c33602d29a0e2d52d375a855 100644
|
2019-08-29 06:50:14 +00:00
|
|
|
--- a/services/network/network_context.h
|
|
|
|
+++ b/services/network/network_context.h
|
chore: bump chromium to 128.0.6611.0 (main) (#42779)
* chore: bump chromium in DEPS to 128.0.6577.0
* chore: bump chromium in DEPS to 128.0.6579.0
* 5675706: Reland "Reland "Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al""""
https://chromium-review.googlesource.com/c/chromium/src/+/5675706
* 5668597: [PDF Ink Signatures] Prompt download menu on save when there are edits
https://chromium-review.googlesource.com/c/chromium/src/+/5668597
* 5677014: Reland "Pull data_sharing_sdk from CIPD"
https://chromium-review.googlesource.com/c/chromium/src/+/5677014
* chore: fixup patch indices
* chore: bump chromium in DEPS to 128.0.6581.0
* chore: bump chromium in DEPS to 128.0.6583.0
* update patches
* 5455480: [Extensions] Allow service worker requests to continue without a cert
https://chromium-review.googlesource.com/c/chromium/src/+/5455480
* try to get some debugging output from script/push-patch.js
* chore: bump chromium in DEPS to 128.0.6585.0
* chore: bump chromium in DEPS to 128.0.6587.0
* update patches
* chore: bump chromium in DEPS to 128.0.6589.0
* more patch work
* maybe over here?
* chore: update patches
* 5673207: [HTTPS Upgrades] Disable in captive portal login webview
https://chromium-review.googlesource.com/c/chromium/src/+/5673207
* 5636785: Extensions: WAR: manifest.json's use_dynamic_url requires a dynamic url
https://chromium-review.googlesource.com/c/chromium/src/+/5636785
* chore: bump chromium in DEPS to 128.0.6591.0
* 5665458: Trigger WN2 page when feature is enabled
https://chromium-review.googlesource.com/c/chromium/src/+/5665458
* update patches
* chore: bump chromium in DEPS to 128.0.6593.0
* chore: bump chromium in DEPS to 128.0.6595.0
* chore: bump chromium in DEPS to 128.0.6597.0
* (patch update) 5694586: [compile hints] Remove the usage of v8::Isolate::SetJavaScriptCompileHintsMagicEnabledCallback API
https://chromium-review.googlesource.com/c/chromium/src/+/5694586
* update patches
* 5691287: Reland "Change blink::WebKeyboardEvent to use std::array in is members"
https://chromium-review.googlesource.com/c/chromium/src/+/5691287
The code changed here is modeled after code in `content/renderer/pepper/event_conversion.cc` that was also modified in this CL, so I took the same approach.
* 5529018: Cleanup EnableWebHidOnExtensionServiceWorker flag
https://chromium-review.googlesource.com/c/chromium/src/+/5529018
* 5526324: [Code Health] Add deprecation comment for base::SupportsWeakPtr.
https://chromium-review.googlesource.com/c/chromium/src/+/5526324
Note that this CL actually does make `SupportsWeakPtr` strictly restricted to existing implementations, no new ones. We could add a patch to add ourselves to this list, but it looks like we'll have to refactor this anyways in the near future. Since the refactor seems straightforward, let's try that first.
* chore: bump chromium in DEPS to 128.0.6598.0
* chore: update patches
* 5704737: Rename ExclusiveAccessContext::GetActiveWebContents to avoid conflict
https://chromium-review.googlesource.com/c/chromium/src/+/5704737
* chore: bump chromium in DEPS to 128.0.6601.0
* chore: update patches
* Add `base::StringPiece` header includes
Chromium is working on replacing `base::StringPiece` with `std::string_view`. (See the Chromium Bug below.) They're currently running mass codemods (across many multiple changes) to replace uses of `StringPiece` with `string_view`, including removing the header include for `StringPiece` in those files. This cascades down to our files that were implicitly depending on those includes through some other include.
They're on track to eventually deprecate and remove `StringPiece` so our code should be converted, but that can be done as an upgrade follow-up task. For now, adding the header back to files that need it should suffice for minimal upgrade changes.
Chromium Bug: https://issues.chromium.org/issues/40506050
* 5702737: GlobalRequestID: Avoid unwanted inlining and narrowing int conversions
https://chromium-review.googlesource.com/c/chromium/src/+/5702737
contender for smallest commit 2024
* 5706534: Rename GlobalFeatures to GlobalDesktopFeatures.
https://chromium-review.googlesource.com/c/chromium/src/+/5706534
* 5691321: ui: remove params variants of SelectFile listener functions
https://chromium-review.googlesource.com/c/chromium/src/+/5691321
* 5714949: [Extensions] Display re-enable dialog for MV2 disabled stage
https://chromium-review.googlesource.com/c/chromium/src/+/5714949
* chore: update libc++ filenames
* patch: disable scope reuse & associated dchecks in v8 (hopefully temp, upgrade follow-up)
* fixup! Add `base::StringPiece` header includes
* update MAS patch
5710330: Add crash keys to debug NativeWidgetMacNSWindowBorderlessFrame exception
https://chromium-review.googlesource.com/c/chromium/src/+/5710330
* chore: bump chromium in DEPS to 128.0.6603.0
* chore: update patches
* 5713258: Reland "Preparation for decoupling creation/initialization of context"
https://chromium-review.googlesource.com/c/chromium/src/+/5713258
When destroying a context, it must already be shutdown, and this change enforces it with a new CHECK.
We were overriding `BrowserContextKeyedServiceFactory::BrowserContextShutdown` with an empty implementation, which differed from the default implementation that notifies the `KeyedServiceFactory` that the context has shutdown. Since we were missing this notification, the CHECK would later trip when the service was being destoryed because it was not registered as shutdown when it was shutdown.
* chore: bump chromium in DEPS to 128.0.6605.2
* chore: update patches
* refactor: linux open/save dialog patch
Our existing implementation was relying on an opaque `void* params` parameter that was passed through `ui::SelectFileDialog`.
Recently, that parameter has been getting removed:
- 5691321: ui: remove params variants of SelectFile listener functions | https://chromium-review.googlesource.com/c/chromium/src/+/5691321
- 5709097: ui: remove SelectFileDialog impl params | https://chromium-review.googlesource.com/c/chromium/src/+/5709097
- https://issues.chromium.org/issues/340178601 "reconsider SelectFileDialog"
This restructures the patch to work with mostly the same mechanics, but directly on the `ui::SelectFileDialog` object. This nets us some wins in terms of a smaller patch.
* 5713262: DevTools UI binding AIDA client event returns response
https://chromium-review.googlesource.com/c/chromium/src/+/5713262
* fixup! refactor: linux open/save dialog patch
* chore: bump chromium in DEPS to 128.0.6606.0
* chore: update patches
* fixup! refactor: linux open/save dialog patch
* chore: bump chromium in DEPS to 128.0.6607.0
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5722937
* fix: pwd error in electron-test, nan-test
fix: unshallow depot_tools before 3-way apply
* chore: e patches all
* fixup! fix: pwd error in electron-test, nan-test
* chore: bump chromium in DEPS to 128.0.6609.0
* chore: bump chromium in DEPS to 128.0.6611.0
* chore: update patches
* chore: update libcxx filenames
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
2024-07-23 15:59:44 +00:00
|
|
|
@@ -315,6 +315,7 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) NetworkContext
|
2019-08-29 06:50:14 +00:00
|
|
|
void CloseIdleConnections(CloseIdleConnectionsCallback callback) override;
|
|
|
|
void SetNetworkConditions(const base::UnguessableToken& throttling_profile_id,
|
|
|
|
mojom::NetworkConditionsPtr conditions) override;
|
|
|
|
+ void SetUserAgent(const std::string& new_user_agent) override;
|
|
|
|
void SetAcceptLanguage(const std::string& new_accept_language) override;
|
|
|
|
void SetEnableReferrers(bool enable_referrers) override;
|
2023-11-28 21:40:12 +00:00
|
|
|
#if BUILDFLAG(IS_CT_SUPPORTED)
|
2019-08-29 06:50:14 +00:00
|
|
|
diff --git a/services/network/public/mojom/network_context.mojom b/services/network/public/mojom/network_context.mojom
|
2024-08-02 14:02:11 +00:00
|
|
|
index 1686353217d288c2faaef98f8cd445baf8ee0df5..bfb21675e01fb3e04e7a56e045d10d3e2196c81e 100644
|
2019-08-29 06:50:14 +00:00
|
|
|
--- a/services/network/public/mojom/network_context.mojom
|
|
|
|
+++ b/services/network/public/mojom/network_context.mojom
|
2024-07-29 13:37:35 +00:00
|
|
|
@@ -1299,6 +1299,9 @@ interface NetworkContext {
|
2019-08-29 06:50:14 +00:00
|
|
|
SetNetworkConditions(mojo_base.mojom.UnguessableToken throttling_profile_id,
|
|
|
|
NetworkConditions? conditions);
|
|
|
|
|
|
|
|
+ // Updates the user agent to be used for requests.
|
|
|
|
+ SetUserAgent(string new_user_agent);
|
|
|
|
+
|
|
|
|
// Updates the Accept-Language header to be used for requests.
|
|
|
|
SetAcceptLanguage(string new_accept_language);
|
|
|
|
|
|
|
|
diff --git a/services/network/test/test_network_context.h b/services/network/test/test_network_context.h
|
2024-07-29 13:37:35 +00:00
|
|
|
index edb9e10bca66bc93c274652574360dacadf02949..d9cad3b22a53c361ae94eeead94a52e2dbdbaf52 100644
|
2019-08-29 06:50:14 +00:00
|
|
|
--- a/services/network/test/test_network_context.h
|
|
|
|
+++ b/services/network/test/test_network_context.h
|
2024-07-29 13:37:35 +00:00
|
|
|
@@ -153,6 +153,7 @@ class TestNetworkContext : public mojom::NetworkContext {
|
2019-08-29 06:50:14 +00:00
|
|
|
void CloseIdleConnections(CloseIdleConnectionsCallback callback) override {}
|
|
|
|
void SetNetworkConditions(const base::UnguessableToken& throttling_profile_id,
|
|
|
|
mojom::NetworkConditionsPtr conditions) override {}
|
|
|
|
+ void SetUserAgent(const std::string& new_user_agent) override {}
|
|
|
|
void SetAcceptLanguage(const std::string& new_accept_language) override {}
|
|
|
|
void SetEnableReferrers(bool enable_referrers) override {}
|
2023-11-28 21:40:12 +00:00
|
|
|
#if BUILDFLAG(IS_CT_SUPPORTED)
|