2023-09-11 12:51:54 +00:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
|
From: clavin <clavin@electronjs.org>
|
2024-01-02 18:59:47 +00:00
|
|
|
Date: Mon, 11 Dec 2023 20:43:34 -0300
|
2023-09-11 12:51:54 +00:00
|
|
|
Subject: fix: activate background material on windows
|
|
|
|
|
|
|
|
|
|
This patch adds a condition to the HWND message handler to allow windows
|
|
|
|
|
with translucent background materials to become activated.
|
|
|
|
|
|
2024-01-02 18:59:47 +00:00
|
|
|
It also ensures the lParam of WM_NCACTIVATE is set to -1 so as to not repaint
|
|
|
|
|
the client area, which can lead to a title bar incorrectly being displayed in
|
|
|
|
|
frameless windows.
|
|
|
|
|
|
2023-09-11 12:51:54 +00:00
|
|
|
This patch likely can't be upstreamed as-is, as Chromium doesn't have
|
|
|
|
|
this use case in mind currently.
|
|
|
|
|
|
|
|
|
|
diff --git a/ui/views/win/hwnd_message_handler.cc b/ui/views/win/hwnd_message_handler.cc
|
2024-04-15 22:10:32 +00:00
|
|
|
index 06788213d588c488386aecaecf323f690fa69f93..65d7bc75fcd99cf63d1425aedc06a821cf428107 100644
|
2023-09-11 12:51:54 +00:00
|
|
|
--- a/ui/views/win/hwnd_message_handler.cc
|
|
|
|
|
+++ b/ui/views/win/hwnd_message_handler.cc
|
2024-04-15 22:10:32 +00:00
|
|
|
@@ -906,13 +906,13 @@ void HWNDMessageHandler::FrameTypeChanged() {
|
2023-09-11 12:51:54 +00:00
|
|
|
|
|
|
|
|
void HWNDMessageHandler::PaintAsActiveChanged() {
|
|
|
|
|
if (!delegate_->HasNonClientView() || !delegate_->CanActivate() ||
|
|
|
|
|
- !delegate_->HasFrame() ||
|
|
|
|
|
+ (!delegate_->HasFrame() && !is_translucent_) ||
|
|
|
|
|
(delegate_->GetFrameMode() == FrameMode::CUSTOM_DRAWN)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
2024-01-02 18:59:47 +00:00
|
|
|
|
|
|
|
|
DefWindowProcWithRedrawLock(WM_NCACTIVATE, delegate_->ShouldPaintAsActive(),
|
|
|
|
|
- 0);
|
|
|
|
|
+ delegate_->HasFrame() ? 0 : -1);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void HWNDMessageHandler::SetWindowIcons(const gfx::ImageSkia& window_icon,
|
2024-04-15 22:10:32 +00:00
|
|
|
@@ -2260,17 +2260,18 @@ LRESULT HWNDMessageHandler::OnNCActivate(UINT message,
|
2024-01-02 18:59:47 +00:00
|
|
|
if (IsVisible())
|
|
|
|
|
delegate_->SchedulePaint();
|
|
|
|
|
|
|
|
|
|
- // Calling DefWindowProc is only necessary if there's a system frame being
|
|
|
|
|
- // drawn. Otherwise it can draw an incorrect title bar and cause visual
|
|
|
|
|
- // corruption.
|
|
|
|
|
- if (!delegate_->HasFrame() ||
|
|
|
|
|
+ // If the window is translucent, it may have the Mica background.
|
|
|
|
|
+ // In that case, it's necessary to call |DefWindowProc|, but we can
|
|
|
|
|
+ // pass -1 in the lParam to prevent any non-client area elements from
|
|
|
|
|
+ // being displayed.
|
|
|
|
|
+ if ((!delegate_->HasFrame() && !is_translucent_) ||
|
|
|
|
|
delegate_->GetFrameMode() == FrameMode::CUSTOM_DRAWN) {
|
|
|
|
|
SetMsgHandled(TRUE);
|
|
|
|
|
return TRUE;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return DefWindowProcWithRedrawLock(WM_NCACTIVATE, paint_as_active || active,
|
|
|
|
|
- 0);
|
|
|
|
|
+ delegate_->HasFrame() ? 0 : -1);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
LRESULT HWNDMessageHandler::OnNCCalcSize(BOOL mode, LPARAM l_param) {
|
