60 lines
2.4 KiB
Diff
60 lines
2.4 KiB
Diff
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Omer Katz <omerkatz@chromium.org>
|
||
|
|
Date: Thu, 19 Sep 2024 10:50:09 +0200
|
||
|
|
Subject: cli: remove deprecated V8 flag
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
Remove the `--huge-max-old-generation-size` V8 flag from the
|
||
|
|
`NODE_OPTIONS` allowlist. That flag was recently deprecated (it
|
||
|
|
currently remains as nop, see crrev.com/c/5831467) and will soon be
|
||
|
|
completely removed.
|
||
|
|
|
||
|
|
PR-URL: https://github.com/nodejs/node/pull/54761
|
||
|
|
Reviewed-By: Richard Lau <rlau@redhat.com>
|
||
|
|
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
||
|
|
Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
||
|
|
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
|
||
|
|
|
||
|
|
diff --git a/doc/api/cli.md b/doc/api/cli.md
|
||
|
|
index 8f32a44ad41314dce2e4b58b318e4b5a7530b802..10dc8da655690d1ce020474256b2134fb881fa39 100644
|
||
|
|
--- a/doc/api/cli.md
|
||
|
|
+++ b/doc/api/cli.md
|
||
|
|
@@ -2810,7 +2810,6 @@ V8 options that are allowed are:
|
||
|
|
* `--abort-on-uncaught-exception`
|
||
|
|
* `--disallow-code-generation-from-strings`
|
||
|
|
* `--enable-etw-stack-walking`
|
||
|
|
-* `--huge-max-old-generation-size`
|
||
|
|
* `--interpreted-frames-native-stack`
|
||
|
|
* `--jitless`
|
||
|
|
* `--max-old-space-size`
|
||
|
|
diff --git a/src/node_options.cc b/src/node_options.cc
|
||
|
|
index 409c6e3918e3ef7c9d35f87e093cb965cb889dd7..eefdf7a48ed3ddebda3b6771b2d103455d2c8d70 100644
|
||
|
|
--- a/src/node_options.cc
|
||
|
|
+++ b/src/node_options.cc
|
||
|
|
@@ -854,11 +854,6 @@ PerIsolateOptionsParser::PerIsolateOptionsParser(
|
||
|
|
"disallow eval and friends",
|
||
|
|
V8Option{},
|
||
|
|
kAllowedInEnvvar);
|
||
|
|
- AddOption("--huge-max-old-generation-size",
|
||
|
|
- "increase default maximum heap size on machines with 16GB memory "
|
||
|
|
- "or more",
|
||
|
|
- V8Option{},
|
||
|
|
- kAllowedInEnvvar);
|
||
|
|
AddOption("--jitless",
|
||
|
|
"disable runtime allocation of executable memory",
|
||
|
|
V8Option{},
|
||
|
|
diff --git a/test/parallel/test-cli-node-options.js b/test/parallel/test-cli-node-options.js
|
||
|
|
index 4d659a7b212441963a8b8be35ad0d44440842380..6f90230a3a2a105b9eb8f5a57eaf94c7cc64215f 100644
|
||
|
|
--- a/test/parallel/test-cli-node-options.js
|
||
|
|
+++ b/test/parallel/test-cli-node-options.js
|
||
|
|
@@ -69,7 +69,6 @@ if (common.hasCrypto) {
|
||
|
|
// V8 options
|
||
|
|
expect('--abort_on-uncaught_exception', 'B\n');
|
||
|
|
expect('--disallow-code-generation-from-strings', 'B\n');
|
||
|
|
-expect('--huge-max-old-generation-size', 'B\n');
|
||
|
|
expect('--jitless', 'B\n');
|
||
|
|
expect('--max-old-space-size=0', 'B\n');
|
||
|
|
expect('--max-semi-space-size=0', 'B\n');
|