2021-07-02 00:56:29 +00:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
|
From: Cheng Zhao <zcbenz@gmail.com>
|
|
|
|
|
Date: Thu, 4 Oct 2018 14:57:02 -0700
|
|
|
|
|
Subject: fix: also propagate fullscreen state for outer frame
|
|
|
|
|
|
|
|
|
|
When entering fullscreen with Element.requestFullscreen in child frames,
|
|
|
|
|
the parent frame should also enter fullscreen mode too. Chromium handles
|
|
|
|
|
this for iframes, but not for webviews as they are essentially main
|
|
|
|
|
frames instead of child frames.
|
|
|
|
|
|
|
|
|
|
This patch makes webviews propagate the fullscreen state to embedder.
|
|
|
|
|
|
|
|
|
|
Note that we also need to manually update embedder's
|
|
|
|
|
`api::WebContents::IsFullscreenForTabOrPending` value.
|
|
|
|
|
|
|
|
|
|
diff --git a/content/browser/renderer_host/render_frame_host_impl.cc b/content/browser/renderer_host/render_frame_host_impl.cc
|
2023-07-16 14:14:43 +00:00
|
|
|
index 99fb67d9d2e9c0018fef2df765de1d8546bbb93d..0c0e7a0269ad029238c5a58ef6ec7326df30b355 100644
|
2021-07-02 00:56:29 +00:00
|
|
|
--- a/content/browser/renderer_host/render_frame_host_impl.cc
|
|
|
|
|
+++ b/content/browser/renderer_host/render_frame_host_impl.cc
|
2023-07-16 14:14:43 +00:00
|
|
|
@@ -7217,6 +7217,17 @@ void RenderFrameHostImpl::EnterFullscreen(
|
2022-07-20 11:03:34 +00:00
|
|
|
}
|
2021-07-02 00:56:29 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
+ // Entering fullscreen from webview should also notify its outer frame.
|
|
|
|
|
+ if (frame_tree_node()->render_manager()->IsMainFrameForInnerDelegate()) {
|
|
|
|
|
+ RenderFrameProxyHost* outer_proxy =
|
|
|
|
|
+ frame_tree_node()->render_manager()->GetProxyToOuterDelegate();
|
|
|
|
|
+ DCHECK(outer_proxy);
|
2022-07-20 11:03:34 +00:00
|
|
|
+ if (outer_proxy->is_render_frame_proxy_live()) {
|
|
|
|
|
+ outer_proxy->GetAssociatedRemoteFrame()->WillEnterFullscreen(
|
|
|
|
|
+ options.Clone());
|
|
|
|
|
+ }
|
2021-07-02 00:56:29 +00:00
|
|
|
+ }
|
|
|
|
|
+
|
2022-06-27 20:50:08 +00:00
|
|
|
// Focus the window if another frame may have delegated the capability.
|
|
|
|
|
if (had_fullscreen_token && !GetView()->HasFocus())
|
|
|
|
|
GetView()->Focus();
|
