2021-02-17 00:11:07 +09:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
|
From: Cheng Zhao <zcbenz@gmail.com>
|
|
|
|
|
Date: Thu, 20 Sep 2018 17:45:47 -0700
|
|
|
|
|
Subject: fix: disable unload metrics
|
|
|
|
|
|
|
|
|
|
Chromium introduced unload metrics in:
|
|
|
|
|
https://chromium-review.googlesource.com/c/chromium/src/+/2314877
|
|
|
|
|
|
|
|
|
|
Which would cause some DCHECKs to assert in Electron:
|
|
|
|
|
https://github.com/electron/electron/issues/27717
|
|
|
|
|
|
|
|
|
|
And it would then crash and make some tests fail:
|
|
|
|
|
crashReporter module should send minidump when sandboxed renderer crashes api-crash-reporter-spec.ts 643 ms
|
|
|
|
|
Error message:
|
|
|
|
|
ptype: expected 'browser' to equal 'renderer'
|
|
|
|
|
Error stack trace:
|
|
|
|
|
AssertionError: ptype: expected 'browser' to equal 'renderer'
|
2022-08-16 12:23:13 -07:00
|
|
|
at checkCrash (electron\spec\api-crash-reporter-spec.ts:39:35)
|
|
|
|
|
at Context.<anonymous> (electron\spec\api-crash-reporter-spec.ts:154:7)
|
2021-02-17 00:11:07 +09:00
|
|
|
at runMicrotasks (<anonymous>)
|
|
|
|
|
at processTicksAndRejections (internal/process/task_queues.js:93:5)
|
|
|
|
|
|
|
|
|
|
This patch temporarily disables the metrics so we can have green CI, and we
|
|
|
|
|
should continue seeking for a real fix.
|
|
|
|
|
|
|
|
|
|
diff --git a/content/browser/renderer_host/navigator.cc b/content/browser/renderer_host/navigator.cc
|
2025-02-07 11:14:12 -05:00
|
|
|
index 12e7d81dcdaa1c0f5d5dbcad0ebbe4c9a8105e05..bba22cd1107e0970ada8b0b54cd12623142a55ed 100644
|
2021-02-17 00:11:07 +09:00
|
|
|
--- a/content/browser/renderer_host/navigator.cc
|
|
|
|
|
+++ b/content/browser/renderer_host/navigator.cc
|
2025-02-07 11:14:12 -05:00
|
|
|
@@ -1463,6 +1463,7 @@ void Navigator::RecordNavigationMetrics(
|
2021-02-17 00:11:07 +09:00
|
|
|
.InMilliseconds());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
+#if 0
|
|
|
|
|
// If this is a same-process navigation and we have timestamps for unload
|
|
|
|
|
// durations, fill those metrics out as well.
|
|
|
|
|
if (params.unload_start && params.unload_end &&
|
2025-02-07 11:14:12 -05:00
|
|
|
@@ -1512,6 +1513,7 @@ void Navigator::RecordNavigationMetrics(
|
2021-02-17 00:11:07 +09:00
|
|
|
first_before_unload_start_time)
|
|
|
|
|
.InMilliseconds());
|
|
|
|
|
}
|
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
|
|
builder.Record(ukm::UkmRecorder::Get());
|
2023-02-03 12:43:42 +01:00
|
|
|
metrics_data_.reset();
|
