2018-10-24 18:24:11 +00:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
2018-09-21 00:30:26 +00:00
|
|
|
From: Cheng Zhao <zcbenz@gmail.com>
|
|
|
|
Date: Thu, 20 Sep 2018 17:47:44 -0700
|
|
|
|
Subject: gin_enable_disable_v8_platform.patch
|
|
|
|
|
2019-12-13 17:18:45 +00:00
|
|
|
We don't use gin to create the V8 platform, because we need to inject Node
|
|
|
|
things.
|
2018-09-21 00:30:26 +00:00
|
|
|
|
2018-09-14 05:02:16 +00:00
|
|
|
diff --git a/gin/isolate_holder.cc b/gin/isolate_holder.cc
|
2022-02-25 18:17:35 +00:00
|
|
|
index 00190da513499e6275d19bd99b6502db246cd33d..f273749bd026abb287ba33e03208a286e80a57a1 100644
|
2018-09-14 05:02:16 +00:00
|
|
|
--- a/gin/isolate_holder.cc
|
|
|
|
+++ b/gin/isolate_holder.cc
|
2022-02-25 18:17:35 +00:00
|
|
|
@@ -121,9 +121,10 @@ IsolateHolder::~IsolateHolder() {
|
2018-09-14 05:02:16 +00:00
|
|
|
void IsolateHolder::Initialize(ScriptMode mode,
|
|
|
|
v8::ArrayBuffer::Allocator* allocator,
|
2021-11-24 08:45:59 +00:00
|
|
|
const intptr_t* reference_table,
|
|
|
|
- const std::string js_command_line_flags) {
|
|
|
|
+ const std::string js_command_line_flags,
|
2018-09-14 05:02:16 +00:00
|
|
|
+ bool create_v8_platform) {
|
|
|
|
CHECK(allocator);
|
2021-11-24 08:45:59 +00:00
|
|
|
- V8Initializer::Initialize(mode, js_command_line_flags);
|
|
|
|
+ V8Initializer::Initialize(mode, js_command_line_flags, create_v8_platform);
|
2018-09-14 05:02:16 +00:00
|
|
|
g_array_buffer_allocator = allocator;
|
|
|
|
g_reference_table = reference_table;
|
|
|
|
}
|
|
|
|
diff --git a/gin/public/isolate_holder.h b/gin/public/isolate_holder.h
|
2022-02-25 18:17:35 +00:00
|
|
|
index 1e36669dfb275b8a7c4913c8465bd299c548ed3a..178023d52c9e8ef716ee215e7a243b1800357818 100644
|
2018-09-14 05:02:16 +00:00
|
|
|
--- a/gin/public/isolate_holder.h
|
|
|
|
+++ b/gin/public/isolate_holder.h
|
2022-02-25 18:17:35 +00:00
|
|
|
@@ -102,7 +102,8 @@ class GIN_EXPORT IsolateHolder {
|
2018-09-14 05:02:16 +00:00
|
|
|
static void Initialize(ScriptMode mode,
|
|
|
|
v8::ArrayBuffer::Allocator* allocator,
|
2021-11-24 08:45:59 +00:00
|
|
|
const intptr_t* reference_table = nullptr,
|
|
|
|
- const std::string js_command_line_flags = {});
|
|
|
|
+ const std::string js_command_line_flags = {},
|
2018-09-14 05:02:16 +00:00
|
|
|
+ bool create_v8_platform = true);
|
|
|
|
|
2021-07-26 16:02:16 +00:00
|
|
|
// Returns whether `Initialize` has already been invoked in the process.
|
|
|
|
// Initialization is a one-way operation (i.e., this method cannot return
|
2018-09-14 05:02:16 +00:00
|
|
|
diff --git a/gin/v8_initializer.cc b/gin/v8_initializer.cc
|
2022-04-12 11:19:14 +00:00
|
|
|
index 6996e07dd19c0fa29fe658c6cb33adc60969e63e..ee480cc557db3bfd4ff9428324151d071ad1f444 100644
|
2018-09-14 05:02:16 +00:00
|
|
|
--- a/gin/v8_initializer.cc
|
|
|
|
+++ b/gin/v8_initializer.cc
|
2022-04-12 11:19:14 +00:00
|
|
|
@@ -351,7 +351,8 @@ void SetFlags(IsolateHolder::ScriptMode mode,
|
2018-09-14 05:02:16 +00:00
|
|
|
|
|
|
|
// static
|
2021-11-24 08:45:59 +00:00
|
|
|
void V8Initializer::Initialize(IsolateHolder::ScriptMode mode,
|
|
|
|
- const std::string js_command_line_flags) {
|
|
|
|
+ const std::string js_command_line_flags,
|
2018-09-14 05:02:16 +00:00
|
|
|
+ bool create_v8_platform) {
|
|
|
|
static bool v8_is_initialized = false;
|
|
|
|
if (v8_is_initialized)
|
|
|
|
return;
|
2022-04-12 11:19:14 +00:00
|
|
|
@@ -361,7 +362,8 @@ void V8Initializer::Initialize(IsolateHolder::ScriptMode mode,
|
2022-03-25 01:39:03 +00:00
|
|
|
// See https://crbug.com/v8/11043
|
|
|
|
SetFlags(mode, js_command_line_flags);
|
2018-09-14 05:02:16 +00:00
|
|
|
|
|
|
|
- v8::V8::InitializePlatform(V8Platform::Get());
|
|
|
|
+ if (create_v8_platform)
|
|
|
|
+ v8::V8::InitializePlatform(V8Platform::Get());
|
|
|
|
|
2021-11-24 08:45:59 +00:00
|
|
|
// Set this early on as some initialization steps, such as the initialization
|
|
|
|
// of the virtual memory cage, already use V8's random number generator.
|
2018-09-14 05:02:16 +00:00
|
|
|
diff --git a/gin/v8_initializer.h b/gin/v8_initializer.h
|
2022-02-10 02:58:52 +00:00
|
|
|
index beeedc5737f6e60dde123200fbb6430a40366577..17ee4c894e89b7d2d12377475a5dd01910b61312 100644
|
2018-09-14 05:02:16 +00:00
|
|
|
--- a/gin/v8_initializer.h
|
|
|
|
+++ b/gin/v8_initializer.h
|
2021-11-24 08:45:59 +00:00
|
|
|
@@ -29,7 +29,8 @@ class GIN_EXPORT V8Initializer {
|
2018-09-14 05:02:16 +00:00
|
|
|
public:
|
|
|
|
// This should be called by IsolateHolder::Initialize().
|
2021-11-24 08:45:59 +00:00
|
|
|
static void Initialize(IsolateHolder::ScriptMode mode,
|
|
|
|
- const std::string js_command_line_flags = {});
|
|
|
|
+ const std::string js_command_line_flags = {},
|
2018-09-14 05:02:16 +00:00
|
|
|
+ bool create_v8_platform = true);
|
|
|
|
|
|
|
|
// Get address and size information for currently loaded snapshot.
|
|
|
|
// If no snapshot is loaded, the return values are null for addresses
|