2024-09-30 14:54:44 +02:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
From: Charles Kerr <charles@charleskerr.com>
|
|
|
|
Date: Sat, 28 Sep 2024 17:33:51 -0500
|
|
|
|
Subject: chore: partial revert of
|
|
|
|
https://chromium-review.googlesource.com/c/chromium/src/+/5894233
|
|
|
|
|
|
|
|
The `CHECK_EQ()` being removed here is failing in the Chromium roll.
|
|
|
|
I experimented with backporting the `CHECK_EQ()` to `main` and it's
|
|
|
|
failing there as well, so some pre-existing behavior in Electron is
|
|
|
|
incompatible with this assertion.
|
|
|
|
|
|
|
|
I will file an upgrades-followup-task issue in Electron and try to
|
|
|
|
track down the source of this problem & figure out if we can fix it
|
|
|
|
by changing something in Electron.
|
|
|
|
|
|
|
|
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
|
2025-04-25 14:53:51 +09:00
|
|
|
index 30ed2f38b7d2b7909bcab3fc593ef635e72a96e1..e288cf5bfd3dfa1a2ca499293130c582ae8c354b 100644
|
2024-09-30 14:54:44 +02:00
|
|
|
--- a/content/browser/web_contents/web_contents_impl.cc
|
|
|
|
+++ b/content/browser/web_contents/web_contents_impl.cc
|
2025-04-24 17:18:38 +09:00
|
|
|
@@ -5037,7 +5037,7 @@ FrameTree* WebContentsImpl::CreateNewWindow(
|
2025-01-10 10:52:34 -06:00
|
|
|
: IsGuest();
|
|
|
|
// While some guest types do not have a guest SiteInstance, the ones that
|
|
|
|
// don't all override WebContents creation above.
|
|
|
|
- CHECK_EQ(source_site_instance->IsGuest(), is_guest);
|
|
|
|
+ // CHECK_EQ(source_site_instance->IsGuest(), is_guest);
|
2024-09-30 14:54:44 +02:00
|
|
|
|
|
|
|
// We usually create the new window in the same BrowsingInstance (group of
|
2025-01-10 10:52:34 -06:00
|
|
|
// script-related windows), by passing in the current SiteInstance. However,
|