2023-11-21 18:53:21 +00:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
From: Samuel Attard <samuel.r.attard@gmail.com>
|
|
|
|
Date: Thu, 20 Sep 2018 17:48:49 -0700
|
|
|
|
Subject: mas: avoid private macOS API usage
|
|
|
|
|
|
|
|
* Use the stub killring file when building blink
|
|
|
|
* Remove usage of the following private APIs
|
|
|
|
* abort_report_np
|
|
|
|
* pthread_fchdir_np
|
|
|
|
* pthread_chdir_np
|
|
|
|
* SetApplicationIsDaemon
|
|
|
|
* _LSSetApplicationLaunchServicesServerConnectionStatus
|
|
|
|
* AreDeviceAndUserJoinedToDomain
|
|
|
|
* _CFIsObjC
|
|
|
|
* AudioDeviceDuck
|
|
|
|
* NSNextStepFrame
|
|
|
|
* NSThemeFrame
|
|
|
|
* NSTextInputReplacementRangeAttributeName
|
|
|
|
* NSAccessibilityRemoteUIElement is unnecessary for Electron's use-case. We use it
|
|
|
|
for progressive web apps (where the AXTree is in the browser process, but macOS
|
|
|
|
needs to think it's coming from the PWA process). I think it can just be chopped
|
|
|
|
out -- if there are any side-effects, we should be able to work around them.
|
|
|
|
* CAContext removal
|
|
|
|
* For apps that spend a lot of time watching video (especially fullscreen video),
|
|
|
|
the power/battery usage will likely increase 1.5x to 2x. For something that is,
|
|
|
|
e.g, scrolling, it'll be smaller, more like 1.15x or 1.25x.
|
|
|
|
|
|
|
|
In terms of performance, the impact will likely be fairly small -- any app that
|
|
|
|
could hit 60fps before will likely still be able to hit 60fps. There may even be
|
|
|
|
cases where performance improves when disabling remote CoreAnimation (remote
|
|
|
|
CoreAnimation is really only about battery usage).
|
|
|
|
* CTFontDescriptorIsSystemUIFont is a private API, we're using an
|
|
|
|
_interesting_ technique in the MAS build to determine if the font is a
|
|
|
|
system font by checking if it's kCTFontPriorityAttribute is set to
|
|
|
|
system priority.
|
|
|
|
|
|
|
|
diff --git a/base/BUILD.gn b/base/BUILD.gn
|
2024-09-18 01:12:11 +00:00
|
|
|
index 3466b284fdfde67ad3370f25b90c7af981725ec5..84ed6049736b1a1eb0ff0830d79d3c9302578098 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/base/BUILD.gn
|
|
|
|
+++ b/base/BUILD.gn
|
2024-09-18 01:12:11 +00:00
|
|
|
@@ -1040,6 +1040,7 @@ component("base") {
|
2024-09-17 08:38:56 +00:00
|
|
|
"//build:ios_buildflags",
|
|
|
|
"//build/config/compiler:compiler_buildflags",
|
|
|
|
"//third_party/modp_b64",
|
|
|
|
+ "//electron/build/config:generate_mas_config",
|
2023-11-21 18:53:21 +00:00
|
|
|
]
|
2024-09-17 08:38:56 +00:00
|
|
|
if (!is_nacl) {
|
|
|
|
# Used by metrics/crc32, except on NaCl builds.
|
2023-11-21 18:53:21 +00:00
|
|
|
diff --git a/base/enterprise_util_mac.mm b/base/enterprise_util_mac.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
index 4bf9a3c27e05c6635b2beb8e880b5b43dbed61b5..f328fbb49c45991f44a9c75325491d0873746b61 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/base/enterprise_util_mac.mm
|
|
|
|
+++ b/base/enterprise_util_mac.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -16,6 +16,7 @@
|
|
|
|
#include "base/strings/string_split.h"
|
|
|
|
#include "base/strings/string_util.h"
|
|
|
|
#include "base/strings/sys_string_conversions.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
|
|
|
|
namespace base {
|
|
|
|
|
|
|
|
@@ -116,6 +117,14 @@ DeviceUserDomainJoinState AreDeviceAndUserJoinedToDomain() {
|
2023-11-21 18:53:21 +00:00
|
|
|
DeviceUserDomainJoinState state{.device_joined = false,
|
|
|
|
.user_joined = false};
|
|
|
|
|
|
|
|
+#if IS_MAS_BUILD()
|
|
|
|
+ return state;
|
|
|
|
+ }();
|
|
|
|
+
|
|
|
|
+ return state;
|
|
|
|
+}
|
|
|
|
+#else
|
|
|
|
+
|
|
|
|
@autoreleasepool {
|
|
|
|
ODSession* session = [ODSession defaultSession];
|
|
|
|
if (session == nil) {
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -219,5 +228,6 @@ DeviceUserDomainJoinState AreDeviceAndUserJoinedToDomain() {
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
return state;
|
|
|
|
}
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
} // namespace base
|
|
|
|
diff --git a/base/process/launch_mac.cc b/base/process/launch_mac.cc
|
2024-09-17 08:38:56 +00:00
|
|
|
index 87e06c32c70f7c9515c93196260bbd6c6268a59a..8134f5e2de9b09bca200614e05cfb9661e917868 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/base/process/launch_mac.cc
|
|
|
|
+++ b/base/process/launch_mac.cc
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -21,13 +21,19 @@
|
2023-11-21 18:53:21 +00:00
|
|
|
#include "base/threading/scoped_blocking_call.h"
|
|
|
|
#include "base/threading/thread_restrictions.h"
|
|
|
|
#include "base/trace_event/base_tracing.h"
|
2024-09-17 08:38:56 +00:00
|
|
|
+#include "electron/mas.h"
|
2023-11-21 18:53:21 +00:00
|
|
|
+#if IS_MAS_BUILD()
|
|
|
|
+#include <sys/syscall.h>
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
extern "C" {
|
|
|
|
// Changes the current thread's directory to a path or directory file
|
|
|
|
// descriptor.
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
int pthread_chdir_np(const char* dir);
|
|
|
|
|
|
|
|
int pthread_fchdir_np(int fd);
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
int responsibility_spawnattrs_setdisclaim(posix_spawnattr_t attrs,
|
|
|
|
int disclaim);
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -99,13 +105,27 @@ class PosixSpawnFileActions {
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
#if !BUILDFLAG(IS_MAC)
|
|
|
|
int ChangeCurrentThreadDirectory(const char* path) {
|
|
|
|
+#if IS_MAS_BUILD()
|
|
|
|
+ #pragma clang diagnostic push
|
|
|
|
+ #pragma clang diagnostic ignored "-Wdeprecated-declarations"
|
|
|
|
+ return syscall(SYS___pthread_chdir, path);
|
|
|
|
+ #pragma clang diagnostic pop
|
|
|
|
+#else
|
|
|
|
return pthread_chdir_np(path);
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
// The recommended way to unset a per-thread cwd is to set a new value to an
|
|
|
|
// invalid file descriptor, per libpthread-218.1.3/private/private.h.
|
|
|
|
int ResetCurrentThreadDirectory() {
|
|
|
|
+#if IS_MAS_BUILD()
|
|
|
|
+ #pragma clang diagnostic push
|
|
|
|
+ #pragma clang diagnostic ignored "-Wdeprecated-declarations"
|
|
|
|
+ return syscall(SYS___pthread_fchdir, -1);
|
|
|
|
+ #pragma clang diagnostic pop
|
|
|
|
+#else
|
|
|
|
return pthread_fchdir_np(-1);
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -229,7 +249,7 @@ Process LaunchProcess(const std::vector<std::string>& argv,
|
2023-11-21 18:53:21 +00:00
|
|
|
file_actions.Inherit(STDERR_FILENO);
|
|
|
|
}
|
|
|
|
|
|
|
|
-#if BUILDFLAG(IS_MAC)
|
|
|
|
+#if 0
|
|
|
|
if (options.disclaim_responsibility) {
|
|
|
|
DPSXCHECK(responsibility_spawnattrs_setdisclaim(attr.get(), 1));
|
|
|
|
}
|
|
|
|
diff --git a/base/process/process_info_mac.cc b/base/process/process_info_mac.cc
|
2024-09-17 08:38:56 +00:00
|
|
|
index 94a028be3c315edc0056408ab9ab41b6b001a1c1..abf9003bc71506d389ff77dc708c897113bba412 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/base/process/process_info_mac.cc
|
|
|
|
+++ b/base/process/process_info_mac.cc
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -4,19 +4,27 @@
|
|
|
|
|
|
|
|
#include "base/process/process_info.h"
|
|
|
|
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
+
|
|
|
|
#include <stdio.h>
|
2023-11-21 18:53:21 +00:00
|
|
|
#include <stdlib.h>
|
|
|
|
#include <unistd.h>
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
extern "C" {
|
|
|
|
pid_t responsibility_get_pid_responsible_for_pid(pid_t);
|
|
|
|
}
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
namespace base {
|
|
|
|
|
|
|
|
bool IsProcessSelfResponsible() {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
const pid_t pid = getpid();
|
|
|
|
return responsibility_get_pid_responsible_for_pid(pid) == pid;
|
|
|
|
+#else
|
|
|
|
+ return true;
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace base
|
|
|
|
diff --git a/components/os_crypt/sync/BUILD.gn b/components/os_crypt/sync/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
index 3b81e00e1535ec729a521b83fe2471985d177e5c..094f52fd80bd91be4e705a457d12ea89271dc037 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/components/os_crypt/sync/BUILD.gn
|
|
|
|
+++ b/components/os_crypt/sync/BUILD.gn
|
2024-02-21 20:27:05 +00:00
|
|
|
@@ -46,6 +46,7 @@ component("os_crypt") {
|
2023-11-21 18:53:21 +00:00
|
|
|
"os_crypt_mac.mm",
|
|
|
|
]
|
2024-01-25 17:46:30 +00:00
|
|
|
deps += [ "//crypto:mock_apple_keychain" ]
|
2024-09-17 08:38:56 +00:00
|
|
|
+ deps += ["//electron/build/config:generate_mas_config"]
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (is_win) {
|
2024-09-17 08:38:56 +00:00
|
|
|
diff --git a/components/os_crypt/sync/keychain_password_mac.mm b/components/os_crypt/sync/keychain_password_mac.mm
|
|
|
|
index e7a65e97b51d93bff864889813317fb7c6ffc846..bb1fc0c99164ae4bdaaaa78e87c30e88932a928c 100644
|
|
|
|
--- a/components/os_crypt/sync/keychain_password_mac.mm
|
|
|
|
+++ b/components/os_crypt/sync/keychain_password_mac.mm
|
|
|
|
@@ -13,6 +13,7 @@
|
|
|
|
#include "base/rand_util.h"
|
|
|
|
#include "build/branding_buildflags.h"
|
|
|
|
#include "crypto/apple_keychain.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
|
|
|
|
using crypto::AppleKeychain;
|
|
|
|
|
2023-11-21 18:53:21 +00:00
|
|
|
diff --git a/components/remote_cocoa/app_shim/BUILD.gn b/components/remote_cocoa/app_shim/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
index b7a2dede5c5e9a797d10627b7d804064bf13b3f4..df0a36405396372aad2affe602e41b5923b80322 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/components/remote_cocoa/app_shim/BUILD.gn
|
|
|
|
+++ b/components/remote_cocoa/app_shim/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -87,6 +87,7 @@ component("app_shim") {
|
|
|
|
"//ui/gfx",
|
|
|
|
"//ui/gfx/geometry",
|
|
|
|
"//ui/strings:ui_strings_grit",
|
|
|
|
+ "//electron/build/config:generate_mas_config",
|
|
|
|
]
|
|
|
|
frameworks = [
|
|
|
|
"Cocoa.framework",
|
2023-11-21 18:53:21 +00:00
|
|
|
diff --git a/components/remote_cocoa/app_shim/application_bridge.mm b/components/remote_cocoa/app_shim/application_bridge.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
index e9f4e5131238b9fb5f1b4b3e90a0cb84a7fc15b4..8b5f4cae3123ac5480ad73f0c873fca0d62f7c9f 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/components/remote_cocoa/app_shim/application_bridge.mm
|
|
|
|
+++ b/components/remote_cocoa/app_shim/application_bridge.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -12,6 +12,7 @@
|
|
|
|
#include "components/remote_cocoa/app_shim/native_widget_ns_window_bridge.h"
|
|
|
|
#include "components/remote_cocoa/app_shim/native_widget_ns_window_host_helper.h"
|
|
|
|
#include "components/system_media_controls/mac/remote_cocoa/system_media_controls_bridge.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#include "mojo/public/cpp/bindings/associated_remote.h"
|
|
|
|
#include "mojo/public/cpp/bindings/self_owned_receiver.h"
|
|
|
|
#include "ui/accelerated_widget_mac/window_resize_helper_mac.h"
|
|
|
|
@@ -51,6 +52,7 @@
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
// NativeWidgetNSWindowHostHelper:
|
|
|
|
id GetNativeViewAccessible() override {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
if (!remote_accessibility_element_) {
|
2024-02-29 09:31:13 +00:00
|
|
|
base::ProcessId browser_pid = base::kNullProcessId;
|
2023-11-21 18:53:21 +00:00
|
|
|
std::vector<uint8_t> element_token;
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -61,6 +63,9 @@ id GetNativeViewAccessible() override {
|
2023-11-21 18:53:21 +00:00
|
|
|
ui::RemoteAccessibility::GetRemoteElementFromToken(element_token);
|
|
|
|
}
|
|
|
|
return remote_accessibility_element_;
|
|
|
|
+#else
|
|
|
|
+ return nil;
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
void DispatchKeyEvent(ui::KeyEvent* event) override {
|
|
|
|
bool event_handled = false;
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -99,7 +104,9 @@ void GetWordAt(const gfx::Point& location_in_content,
|
2023-11-21 18:53:21 +00:00
|
|
|
mojo::AssociatedRemote<mojom::TextInputHost> text_input_host_remote_;
|
|
|
|
|
|
|
|
std::unique_ptr<NativeWidgetNSWindowBridge> bridge_;
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
NSAccessibilityRemoteUIElement* __strong remote_accessibility_element_;
|
|
|
|
+#endif
|
|
|
|
};
|
|
|
|
|
|
|
|
} // namespace
|
|
|
|
diff --git a/components/remote_cocoa/app_shim/browser_native_widget_window_mac.mm b/components/remote_cocoa/app_shim/browser_native_widget_window_mac.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
index 53553a707a646012c50b0bd2d0ffd8d4dbd67e11..e306511e15fd2a522748c3f90c78aab8dde4238e 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/components/remote_cocoa/app_shim/browser_native_widget_window_mac.mm
|
|
|
|
+++ b/components/remote_cocoa/app_shim/browser_native_widget_window_mac.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -8,7 +8,9 @@
|
|
|
|
|
2023-11-21 18:53:21 +00:00
|
|
|
#include "components/remote_cocoa/app_shim/native_widget_ns_window_bridge.h"
|
|
|
|
#include "components/remote_cocoa/common/native_widget_ns_window_host.mojom.h"
|
2024-09-17 08:38:56 +00:00
|
|
|
+#include "electron/mas.h"
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
@interface NSWindow (PrivateBrowserNativeWidgetAPI)
|
|
|
|
+ (Class)frameViewClassForStyleMask:(NSUInteger)windowStyle;
|
|
|
|
@end
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -65,10 +67,13 @@ - (BOOL)_shouldCenterTrafficLights {
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
@end
|
|
|
|
|
|
|
|
+#endif // MAS_BUILD
|
|
|
|
+
|
|
|
|
@implementation BrowserNativeWidgetWindow
|
|
|
|
|
|
|
|
// NSWindow (PrivateAPI) overrides.
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
+ (Class)frameViewClassForStyleMask:(NSUInteger)windowStyle {
|
|
|
|
// - NSThemeFrame and its subclasses will be nil if it's missing at runtime.
|
|
|
|
if ([BrowserWindowFrame class])
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -115,6 +120,8 @@ - (BOOL)_usesCustomDrawing {
|
2023-11-21 18:53:21 +00:00
|
|
|
return NO;
|
|
|
|
}
|
|
|
|
|
|
|
|
+#endif // MAS_BUILD
|
|
|
|
+
|
|
|
|
// Handle "Move focus to the window toolbar" configured in System Preferences ->
|
|
|
|
// Keyboard -> Shortcuts -> Keyboard. Usually Ctrl+F5. The argument (|unknown|)
|
|
|
|
// tends to just be nil.
|
|
|
|
diff --git a/components/remote_cocoa/app_shim/native_widget_mac_frameless_nswindow.mm b/components/remote_cocoa/app_shim/native_widget_mac_frameless_nswindow.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
index 3a815ebf505bd95fa7f6b61ba433d98fbfe20225..149de0175c2ec0e41e3ba40caad7019ca87386d6 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/components/remote_cocoa/app_shim/native_widget_mac_frameless_nswindow.mm
|
|
|
|
+++ b/components/remote_cocoa/app_shim/native_widget_mac_frameless_nswindow.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -4,6 +4,10 @@
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
#import "components/remote_cocoa/app_shim/native_widget_mac_frameless_nswindow.h"
|
|
|
|
|
2024-09-17 08:38:56 +00:00
|
|
|
+#include "electron/mas.h"
|
|
|
|
+
|
2023-11-21 18:53:21 +00:00
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
+
|
|
|
|
@interface NSWindow (PrivateAPI)
|
|
|
|
+ (Class)frameViewClassForStyleMask:(NSUInteger)windowStyle;
|
|
|
|
@end
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -18,8 +22,12 @@ - (CGFloat)_titlebarHeight {
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
@end
|
|
|
|
|
|
|
|
+#endif // MAS_BUILD
|
|
|
|
+
|
|
|
|
@implementation NativeWidgetMacFramelessNSWindow
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
+
|
|
|
|
+ (Class)frameViewClassForStyleMask:(NSUInteger)windowStyle {
|
|
|
|
if ([NativeWidgetMacFramelessNSWindowFrame class]) {
|
|
|
|
return [NativeWidgetMacFramelessNSWindowFrame class];
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -27,4 +35,6 @@ + (Class)frameViewClassForStyleMask:(NSUInteger)windowStyle {
|
2023-11-21 18:53:21 +00:00
|
|
|
return [super frameViewClassForStyleMask:windowStyle];
|
|
|
|
}
|
|
|
|
|
|
|
|
+#endif // MAS_BUILD
|
|
|
|
+
|
|
|
|
@end
|
|
|
|
diff --git a/components/remote_cocoa/app_shim/native_widget_mac_nswindow.h b/components/remote_cocoa/app_shim/native_widget_mac_nswindow.h
|
2024-09-17 08:38:56 +00:00
|
|
|
index 945b01f2132547fa0f6a97ee4895994c500d1410..864f93f7c4159abc63e1535195fbf9d112558b91 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/components/remote_cocoa/app_shim/native_widget_mac_nswindow.h
|
|
|
|
+++ b/components/remote_cocoa/app_shim/native_widget_mac_nswindow.h
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -9,6 +9,7 @@
|
|
|
|
|
|
|
|
#include "base/apple/foundation_util.h"
|
|
|
|
#include "components/remote_cocoa/app_shim/remote_cocoa_app_shim_export.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#import "ui/base/cocoa/command_dispatcher.h"
|
|
|
|
|
|
|
|
namespace remote_cocoa {
|
|
|
|
@@ -17,6 +18,7 @@ class NativeWidgetNSWindowBridge;
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
@protocol WindowTouchBarDelegate;
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
// Weak lets Chrome launch even if a future macOS doesn't have the below classes
|
|
|
|
WEAK_IMPORT_ATTRIBUTE
|
|
|
|
@interface NSNextStepFrame : NSView
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -33,6 +35,7 @@ REMOTE_COCOA_APP_SHIM_EXPORT
|
2023-11-21 18:53:21 +00:00
|
|
|
REMOTE_COCOA_APP_SHIM_EXPORT
|
|
|
|
@interface NativeWidgetMacNSWindowTitledFrame : NSThemeFrame
|
|
|
|
@end
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
// The NSWindow used by BridgedNativeWidget. Provides hooks into AppKit that
|
|
|
|
// can only be accomplished by overriding methods.
|
|
|
|
diff --git a/components/remote_cocoa/app_shim/native_widget_mac_nswindow.mm b/components/remote_cocoa/app_shim/native_widget_mac_nswindow.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
index 2aa2bd8d68c08359461254875f02fc37f8693058..5d5584d22ead9730876fae2fc3971982ae7f61bb 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/components/remote_cocoa/app_shim/native_widget_mac_nswindow.mm
|
|
|
|
+++ b/components/remote_cocoa/app_shim/native_widget_mac_nswindow.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -26,6 +26,7 @@
|
|
|
|
#import "components/remote_cocoa/app_shim/views_nswindow_delegate.h"
|
|
|
|
#import "components/remote_cocoa/app_shim/window_touch_bar_delegate.h"
|
|
|
|
#include "components/remote_cocoa/common/native_widget_ns_window_host.mojom.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#import "ui/base/cocoa/user_interface_item_command_handler.h"
|
|
|
|
#import "ui/base/cocoa/window_size_constants.h"
|
|
|
|
|
|
|
|
@@ -111,14 +112,18 @@ void OrderChildWindow(NSWindow* child_window,
|
chore: bump chromium to 128.0.6611.0 (main) (#42779)
* chore: bump chromium in DEPS to 128.0.6577.0
* chore: bump chromium in DEPS to 128.0.6579.0
* 5675706: Reland "Reland "Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al""""
https://chromium-review.googlesource.com/c/chromium/src/+/5675706
* 5668597: [PDF Ink Signatures] Prompt download menu on save when there are edits
https://chromium-review.googlesource.com/c/chromium/src/+/5668597
* 5677014: Reland "Pull data_sharing_sdk from CIPD"
https://chromium-review.googlesource.com/c/chromium/src/+/5677014
* chore: fixup patch indices
* chore: bump chromium in DEPS to 128.0.6581.0
* chore: bump chromium in DEPS to 128.0.6583.0
* update patches
* 5455480: [Extensions] Allow service worker requests to continue without a cert
https://chromium-review.googlesource.com/c/chromium/src/+/5455480
* try to get some debugging output from script/push-patch.js
* chore: bump chromium in DEPS to 128.0.6585.0
* chore: bump chromium in DEPS to 128.0.6587.0
* update patches
* chore: bump chromium in DEPS to 128.0.6589.0
* more patch work
* maybe over here?
* chore: update patches
* 5673207: [HTTPS Upgrades] Disable in captive portal login webview
https://chromium-review.googlesource.com/c/chromium/src/+/5673207
* 5636785: Extensions: WAR: manifest.json's use_dynamic_url requires a dynamic url
https://chromium-review.googlesource.com/c/chromium/src/+/5636785
* chore: bump chromium in DEPS to 128.0.6591.0
* 5665458: Trigger WN2 page when feature is enabled
https://chromium-review.googlesource.com/c/chromium/src/+/5665458
* update patches
* chore: bump chromium in DEPS to 128.0.6593.0
* chore: bump chromium in DEPS to 128.0.6595.0
* chore: bump chromium in DEPS to 128.0.6597.0
* (patch update) 5694586: [compile hints] Remove the usage of v8::Isolate::SetJavaScriptCompileHintsMagicEnabledCallback API
https://chromium-review.googlesource.com/c/chromium/src/+/5694586
* update patches
* 5691287: Reland "Change blink::WebKeyboardEvent to use std::array in is members"
https://chromium-review.googlesource.com/c/chromium/src/+/5691287
The code changed here is modeled after code in `content/renderer/pepper/event_conversion.cc` that was also modified in this CL, so I took the same approach.
* 5529018: Cleanup EnableWebHidOnExtensionServiceWorker flag
https://chromium-review.googlesource.com/c/chromium/src/+/5529018
* 5526324: [Code Health] Add deprecation comment for base::SupportsWeakPtr.
https://chromium-review.googlesource.com/c/chromium/src/+/5526324
Note that this CL actually does make `SupportsWeakPtr` strictly restricted to existing implementations, no new ones. We could add a patch to add ourselves to this list, but it looks like we'll have to refactor this anyways in the near future. Since the refactor seems straightforward, let's try that first.
* chore: bump chromium in DEPS to 128.0.6598.0
* chore: update patches
* 5704737: Rename ExclusiveAccessContext::GetActiveWebContents to avoid conflict
https://chromium-review.googlesource.com/c/chromium/src/+/5704737
* chore: bump chromium in DEPS to 128.0.6601.0
* chore: update patches
* Add `base::StringPiece` header includes
Chromium is working on replacing `base::StringPiece` with `std::string_view`. (See the Chromium Bug below.) They're currently running mass codemods (across many multiple changes) to replace uses of `StringPiece` with `string_view`, including removing the header include for `StringPiece` in those files. This cascades down to our files that were implicitly depending on those includes through some other include.
They're on track to eventually deprecate and remove `StringPiece` so our code should be converted, but that can be done as an upgrade follow-up task. For now, adding the header back to files that need it should suffice for minimal upgrade changes.
Chromium Bug: https://issues.chromium.org/issues/40506050
* 5702737: GlobalRequestID: Avoid unwanted inlining and narrowing int conversions
https://chromium-review.googlesource.com/c/chromium/src/+/5702737
contender for smallest commit 2024
* 5706534: Rename GlobalFeatures to GlobalDesktopFeatures.
https://chromium-review.googlesource.com/c/chromium/src/+/5706534
* 5691321: ui: remove params variants of SelectFile listener functions
https://chromium-review.googlesource.com/c/chromium/src/+/5691321
* 5714949: [Extensions] Display re-enable dialog for MV2 disabled stage
https://chromium-review.googlesource.com/c/chromium/src/+/5714949
* chore: update libc++ filenames
* patch: disable scope reuse & associated dchecks in v8 (hopefully temp, upgrade follow-up)
* fixup! Add `base::StringPiece` header includes
* update MAS patch
5710330: Add crash keys to debug NativeWidgetMacNSWindowBorderlessFrame exception
https://chromium-review.googlesource.com/c/chromium/src/+/5710330
* chore: bump chromium in DEPS to 128.0.6603.0
* chore: update patches
* 5713258: Reland "Preparation for decoupling creation/initialization of context"
https://chromium-review.googlesource.com/c/chromium/src/+/5713258
When destroying a context, it must already be shutdown, and this change enforces it with a new CHECK.
We were overriding `BrowserContextKeyedServiceFactory::BrowserContextShutdown` with an empty implementation, which differed from the default implementation that notifies the `KeyedServiceFactory` that the context has shutdown. Since we were missing this notification, the CHECK would later trip when the service was being destoryed because it was not registered as shutdown when it was shutdown.
* chore: bump chromium in DEPS to 128.0.6605.2
* chore: update patches
* refactor: linux open/save dialog patch
Our existing implementation was relying on an opaque `void* params` parameter that was passed through `ui::SelectFileDialog`.
Recently, that parameter has been getting removed:
- 5691321: ui: remove params variants of SelectFile listener functions | https://chromium-review.googlesource.com/c/chromium/src/+/5691321
- 5709097: ui: remove SelectFileDialog impl params | https://chromium-review.googlesource.com/c/chromium/src/+/5709097
- https://issues.chromium.org/issues/340178601 "reconsider SelectFileDialog"
This restructures the patch to work with mostly the same mechanics, but directly on the `ui::SelectFileDialog` object. This nets us some wins in terms of a smaller patch.
* 5713262: DevTools UI binding AIDA client event returns response
https://chromium-review.googlesource.com/c/chromium/src/+/5713262
* fixup! refactor: linux open/save dialog patch
* chore: bump chromium in DEPS to 128.0.6606.0
* chore: update patches
* fixup! refactor: linux open/save dialog patch
* chore: bump chromium in DEPS to 128.0.6607.0
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5722937
* fix: pwd error in electron-test, nan-test
fix: unshallow depot_tools before 3-way apply
* chore: e patches all
* fixup! fix: pwd error in electron-test, nan-test
* chore: bump chromium in DEPS to 128.0.6609.0
* chore: bump chromium in DEPS to 128.0.6611.0
* chore: update patches
* chore: update libcxx filenames
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
2024-07-23 15:59:44 +00:00
|
|
|
|
2023-11-21 18:53:21 +00:00
|
|
|
} // namespace
|
|
|
|
|
chore: bump chromium to 128.0.6611.0 (main) (#42779)
* chore: bump chromium in DEPS to 128.0.6577.0
* chore: bump chromium in DEPS to 128.0.6579.0
* 5675706: Reland "Reland "Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al""""
https://chromium-review.googlesource.com/c/chromium/src/+/5675706
* 5668597: [PDF Ink Signatures] Prompt download menu on save when there are edits
https://chromium-review.googlesource.com/c/chromium/src/+/5668597
* 5677014: Reland "Pull data_sharing_sdk from CIPD"
https://chromium-review.googlesource.com/c/chromium/src/+/5677014
* chore: fixup patch indices
* chore: bump chromium in DEPS to 128.0.6581.0
* chore: bump chromium in DEPS to 128.0.6583.0
* update patches
* 5455480: [Extensions] Allow service worker requests to continue without a cert
https://chromium-review.googlesource.com/c/chromium/src/+/5455480
* try to get some debugging output from script/push-patch.js
* chore: bump chromium in DEPS to 128.0.6585.0
* chore: bump chromium in DEPS to 128.0.6587.0
* update patches
* chore: bump chromium in DEPS to 128.0.6589.0
* more patch work
* maybe over here?
* chore: update patches
* 5673207: [HTTPS Upgrades] Disable in captive portal login webview
https://chromium-review.googlesource.com/c/chromium/src/+/5673207
* 5636785: Extensions: WAR: manifest.json's use_dynamic_url requires a dynamic url
https://chromium-review.googlesource.com/c/chromium/src/+/5636785
* chore: bump chromium in DEPS to 128.0.6591.0
* 5665458: Trigger WN2 page when feature is enabled
https://chromium-review.googlesource.com/c/chromium/src/+/5665458
* update patches
* chore: bump chromium in DEPS to 128.0.6593.0
* chore: bump chromium in DEPS to 128.0.6595.0
* chore: bump chromium in DEPS to 128.0.6597.0
* (patch update) 5694586: [compile hints] Remove the usage of v8::Isolate::SetJavaScriptCompileHintsMagicEnabledCallback API
https://chromium-review.googlesource.com/c/chromium/src/+/5694586
* update patches
* 5691287: Reland "Change blink::WebKeyboardEvent to use std::array in is members"
https://chromium-review.googlesource.com/c/chromium/src/+/5691287
The code changed here is modeled after code in `content/renderer/pepper/event_conversion.cc` that was also modified in this CL, so I took the same approach.
* 5529018: Cleanup EnableWebHidOnExtensionServiceWorker flag
https://chromium-review.googlesource.com/c/chromium/src/+/5529018
* 5526324: [Code Health] Add deprecation comment for base::SupportsWeakPtr.
https://chromium-review.googlesource.com/c/chromium/src/+/5526324
Note that this CL actually does make `SupportsWeakPtr` strictly restricted to existing implementations, no new ones. We could add a patch to add ourselves to this list, but it looks like we'll have to refactor this anyways in the near future. Since the refactor seems straightforward, let's try that first.
* chore: bump chromium in DEPS to 128.0.6598.0
* chore: update patches
* 5704737: Rename ExclusiveAccessContext::GetActiveWebContents to avoid conflict
https://chromium-review.googlesource.com/c/chromium/src/+/5704737
* chore: bump chromium in DEPS to 128.0.6601.0
* chore: update patches
* Add `base::StringPiece` header includes
Chromium is working on replacing `base::StringPiece` with `std::string_view`. (See the Chromium Bug below.) They're currently running mass codemods (across many multiple changes) to replace uses of `StringPiece` with `string_view`, including removing the header include for `StringPiece` in those files. This cascades down to our files that were implicitly depending on those includes through some other include.
They're on track to eventually deprecate and remove `StringPiece` so our code should be converted, but that can be done as an upgrade follow-up task. For now, adding the header back to files that need it should suffice for minimal upgrade changes.
Chromium Bug: https://issues.chromium.org/issues/40506050
* 5702737: GlobalRequestID: Avoid unwanted inlining and narrowing int conversions
https://chromium-review.googlesource.com/c/chromium/src/+/5702737
contender for smallest commit 2024
* 5706534: Rename GlobalFeatures to GlobalDesktopFeatures.
https://chromium-review.googlesource.com/c/chromium/src/+/5706534
* 5691321: ui: remove params variants of SelectFile listener functions
https://chromium-review.googlesource.com/c/chromium/src/+/5691321
* 5714949: [Extensions] Display re-enable dialog for MV2 disabled stage
https://chromium-review.googlesource.com/c/chromium/src/+/5714949
* chore: update libc++ filenames
* patch: disable scope reuse & associated dchecks in v8 (hopefully temp, upgrade follow-up)
* fixup! Add `base::StringPiece` header includes
* update MAS patch
5710330: Add crash keys to debug NativeWidgetMacNSWindowBorderlessFrame exception
https://chromium-review.googlesource.com/c/chromium/src/+/5710330
* chore: bump chromium in DEPS to 128.0.6603.0
* chore: update patches
* 5713258: Reland "Preparation for decoupling creation/initialization of context"
https://chromium-review.googlesource.com/c/chromium/src/+/5713258
When destroying a context, it must already be shutdown, and this change enforces it with a new CHECK.
We were overriding `BrowserContextKeyedServiceFactory::BrowserContextShutdown` with an empty implementation, which differed from the default implementation that notifies the `KeyedServiceFactory` that the context has shutdown. Since we were missing this notification, the CHECK would later trip when the service was being destoryed because it was not registered as shutdown when it was shutdown.
* chore: bump chromium in DEPS to 128.0.6605.2
* chore: update patches
* refactor: linux open/save dialog patch
Our existing implementation was relying on an opaque `void* params` parameter that was passed through `ui::SelectFileDialog`.
Recently, that parameter has been getting removed:
- 5691321: ui: remove params variants of SelectFile listener functions | https://chromium-review.googlesource.com/c/chromium/src/+/5691321
- 5709097: ui: remove SelectFileDialog impl params | https://chromium-review.googlesource.com/c/chromium/src/+/5709097
- https://issues.chromium.org/issues/340178601 "reconsider SelectFileDialog"
This restructures the patch to work with mostly the same mechanics, but directly on the `ui::SelectFileDialog` object. This nets us some wins in terms of a smaller patch.
* 5713262: DevTools UI binding AIDA client event returns response
https://chromium-review.googlesource.com/c/chromium/src/+/5713262
* fixup! refactor: linux open/save dialog patch
* chore: bump chromium in DEPS to 128.0.6606.0
* chore: update patches
* fixup! refactor: linux open/save dialog patch
* chore: bump chromium in DEPS to 128.0.6607.0
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5722937
* fix: pwd error in electron-test, nan-test
fix: unshallow depot_tools before 3-way apply
* chore: e patches all
* fixup! fix: pwd error in electron-test, nan-test
* chore: bump chromium in DEPS to 128.0.6609.0
* chore: bump chromium in DEPS to 128.0.6611.0
* chore: update patches
* chore: update libcxx filenames
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
2024-07-23 15:59:44 +00:00
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
@interface NSNextStepFrame (Private)
|
|
|
|
- (instancetype)initWithFrame:(NSRect)frame
|
|
|
|
styleMask:(NSUInteger)styleMask
|
|
|
|
owner:(id)owner;
|
|
|
|
@end
|
|
|
|
+#endif
|
|
|
|
|
2023-11-21 18:53:21 +00:00
|
|
|
@interface NSWindow (Private)
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
+ (Class)frameViewClassForStyleMask:(NSWindowStyleMask)windowStyle;
|
|
|
|
+#endif
|
|
|
|
- (BOOL)hasKeyAppearance;
|
|
|
|
- (long long)_resizeDirectionForMouseLocation:(CGPoint)location;
|
|
|
|
- (BOOL)_isConsideredOpenForPersistentState;
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -157,6 +162,8 @@ - (void)cr_mouseDownOnFrameView:(NSEvent*)event {
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
@end
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
+
|
|
|
|
@implementation NativeWidgetMacNSWindowTitledFrame
|
|
|
|
- (void)mouseDown:(NSEvent*)event {
|
|
|
|
if (self.window.isMovable)
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -184,6 +191,8 @@ - (BOOL)usesCustomDrawing {
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
@end
|
|
|
|
|
|
|
|
+#endif // MAS_BUILD
|
|
|
|
+
|
|
|
|
@implementation NativeWidgetMacNSWindow {
|
|
|
|
@private
|
|
|
|
CommandDispatcher* __strong _commandDispatcher;
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -374,6 +383,8 @@ - (NSAccessibilityRole)accessibilityRole {
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
// NSWindow overrides.
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
+
|
|
|
|
+ (Class)frameViewClassForStyleMask:(NSWindowStyleMask)windowStyle {
|
|
|
|
if (windowStyle & NSWindowStyleMaskTitled) {
|
|
|
|
if (Class customFrame = [NativeWidgetMacNSWindowTitledFrame class])
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -385,6 +396,8 @@ + (Class)frameViewClassForStyleMask:(NSWindowStyleMask)windowStyle {
|
2023-11-21 18:53:21 +00:00
|
|
|
return [super frameViewClassForStyleMask:windowStyle];
|
|
|
|
}
|
|
|
|
|
|
|
|
+#endif
|
|
|
|
+
|
|
|
|
- (BOOL)_isTitleHidden {
|
|
|
|
bool shouldShowWindowTitle = YES;
|
|
|
|
if (_bridge)
|
|
|
|
diff --git a/components/remote_cocoa/app_shim/native_widget_ns_window_bridge.mm b/components/remote_cocoa/app_shim/native_widget_ns_window_bridge.mm
|
2024-09-18 01:12:11 +00:00
|
|
|
index 285a406e8cec06bf3beeca81b32e6561528279f9..a82a3653253b8a362d6ae3be41cbaaa017f757ca 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/components/remote_cocoa/app_shim/native_widget_ns_window_bridge.mm
|
|
|
|
+++ b/components/remote_cocoa/app_shim/native_widget_ns_window_bridge.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -41,6 +41,7 @@
|
|
|
|
#import "components/remote_cocoa/app_shim/views_nswindow_delegate.h"
|
|
|
|
#import "components/remote_cocoa/app_shim/window_move_loop.h"
|
|
|
|
#include "components/remote_cocoa/common/native_widget_ns_window_host.mojom.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#include "mojo/public/cpp/bindings/self_owned_receiver.h"
|
|
|
|
#include "net/cert/x509_util_apple.h"
|
|
|
|
#include "ui/accelerated_widget_mac/window_resize_helper_mac.h"
|
2024-09-18 01:12:11 +00:00
|
|
|
@@ -643,10 +644,12 @@ NSUInteger CountBridgedWindows(NSArray* child_windows) {
|
2023-11-21 18:53:21 +00:00
|
|
|
// this should be treated as an error and caught early.
|
|
|
|
CHECK(bridged_view_);
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
// Send the accessibility tokens for the NSView now that it exists.
|
|
|
|
host_->SetRemoteAccessibilityTokens(
|
|
|
|
ui::RemoteAccessibility::GetTokenForLocalElement(window_),
|
|
|
|
ui::RemoteAccessibility::GetTokenForLocalElement(bridged_view_));
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
// Beware: This view was briefly removed (in favor of a bare CALayer) in
|
|
|
|
// https://crrev.com/c/1236675. The ordering of unassociated layers relative
|
|
|
|
diff --git a/components/viz/service/BUILD.gn b/components/viz/service/BUILD.gn
|
2024-09-18 01:12:11 +00:00
|
|
|
index 853a95c65674b1011898c64445024bdc30c9709b..2f36496cf77258fe7e7b5eb7c93c6c53ff55abd0 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/components/viz/service/BUILD.gn
|
|
|
|
+++ b/components/viz/service/BUILD.gn
|
2024-09-18 01:12:11 +00:00
|
|
|
@@ -371,6 +371,7 @@ viz_component("service") {
|
2023-11-21 18:53:21 +00:00
|
|
|
"frame_sinks/external_begin_frame_source_mac.h",
|
|
|
|
]
|
|
|
|
}
|
2024-09-17 08:38:56 +00:00
|
|
|
+ deps += ["//electron/build/config:generate_mas_config"]
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (is_android || use_ozone) {
|
2024-09-18 01:12:11 +00:00
|
|
|
@@ -645,6 +646,7 @@ viz_source_set("unit_tests") {
|
2023-11-21 18:53:21 +00:00
|
|
|
"display_embedder/software_output_device_mac_unittest.mm",
|
|
|
|
]
|
|
|
|
frameworks = [ "IOSurface.framework" ]
|
2024-09-17 08:38:56 +00:00
|
|
|
+ deps += ["//electron/build/config:generate_mas_config"]
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (is_win) {
|
|
|
|
diff --git a/content/app_shim_remote_cocoa/ns_view_bridge_factory_impl.mm b/content/app_shim_remote_cocoa/ns_view_bridge_factory_impl.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
index dbf334caa3a6d10017b69ad76802e389a011436b..da828823e8195cc9e497866363c9af93dcd4ec3f 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/content/app_shim_remote_cocoa/ns_view_bridge_factory_impl.mm
|
|
|
|
+++ b/content/app_shim_remote_cocoa/ns_view_bridge_factory_impl.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -15,6 +15,7 @@
|
|
|
|
#include "content/common/web_contents_ns_view_bridge.mojom.h"
|
|
|
|
#include "content/public/browser/remote_cocoa.h"
|
|
|
|
#include "content/public/browser/render_widget_host_view_mac_delegate.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#include "mojo/public/cpp/bindings/associated_receiver.h"
|
|
|
|
#include "mojo/public/cpp/bindings/associated_remote.h"
|
|
|
|
#include "mojo/public/cpp/bindings/pending_associated_receiver.h"
|
|
|
|
@@ -63,7 +64,9 @@ explicit RenderWidgetHostNSViewBridgeOwner(
|
2024-02-29 09:31:13 +00:00
|
|
|
const RenderWidgetHostNSViewBridgeOwner&) = delete;
|
|
|
|
|
|
|
|
private:
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
NSAccessibilityRemoteUIElement* __strong remote_accessibility_element_;
|
|
|
|
+#endif
|
|
|
|
void OnMojoDisconnect() { delete this; }
|
|
|
|
|
|
|
|
std::unique_ptr<blink::WebCoalescedInputEvent> TranslateEvent(
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -75,6 +78,7 @@ explicit RenderWidgetHostNSViewBridgeOwner(
|
2024-02-29 09:31:13 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
id GetAccessibilityElement() override {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
if (!remote_accessibility_element_) {
|
|
|
|
base::ProcessId browser_pid = base::kNullProcessId;
|
|
|
|
std::vector<uint8_t> element_token;
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -85,6 +89,9 @@ id GetAccessibilityElement() override {
|
2024-02-29 09:31:13 +00:00
|
|
|
ui::RemoteAccessibility::GetRemoteElementFromToken(element_token);
|
|
|
|
}
|
|
|
|
return remote_accessibility_element_;
|
|
|
|
+#else
|
|
|
|
+ return nil;
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
// RenderWidgetHostNSViewHostHelper implementation.
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -103,8 +110,10 @@ id GetFocusedBrowserAccessibilityElement() override {
|
2024-02-21 20:27:05 +00:00
|
|
|
return [bridgedContentView accessibilityFocusedUIElement];
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
void SetAccessibilityWindow(NSWindow* window) override {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
host_->SetRemoteAccessibilityWindowToken(
|
|
|
|
ui::RemoteAccessibility::GetTokenForLocalElement(window));
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
2024-06-07 21:18:35 +00:00
|
|
|
void ForwardKeyboardEvent(const input::NativeWebKeyboardEvent& key_event,
|
2023-11-21 18:53:21 +00:00
|
|
|
diff --git a/content/app_shim_remote_cocoa/render_widget_host_view_cocoa.mm b/content/app_shim_remote_cocoa/render_widget_host_view_cocoa.mm
|
2024-09-18 01:12:11 +00:00
|
|
|
index 7b306925815201084a92db192d623b7d2f4d2691..348b538f286443b08bc979feaaa47a41c469cd4b 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/content/app_shim_remote_cocoa/render_widget_host_view_cocoa.mm
|
|
|
|
+++ b/content/app_shim_remote_cocoa/render_widget_host_view_cocoa.mm
|
2024-09-18 01:12:11 +00:00
|
|
|
@@ -35,6 +35,7 @@
|
2024-09-17 08:38:56 +00:00
|
|
|
#include "content/public/browser/browser_accessibility_state.h"
|
|
|
|
#import "content/public/browser/render_widget_host_view_mac_delegate.h"
|
|
|
|
#include "content/public/common/content_features.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#include "skia/ext/skia_utils_mac.h"
|
|
|
|
#include "third_party/blink/public/common/features.h"
|
|
|
|
#include "third_party/blink/public/mojom/input/input_handler.mojom.h"
|
|
|
|
@@ -2062,15 +2063,21 @@ - (NSAccessibilityRole)accessibilityRole {
|
2023-11-21 18:53:21 +00:00
|
|
|
// Since this implementation doesn't have to wait any IPC calls, this doesn't
|
|
|
|
// make any key-typing jank. --hbono 7/23/09
|
|
|
|
//
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
extern "C" {
|
|
|
|
extern NSString* NSTextInputReplacementRangeAttributeName;
|
|
|
|
}
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
- (NSArray*)validAttributesForMarkedText {
|
|
|
|
// This code is just copied from WebKit except renaming variables.
|
|
|
|
static NSArray* const kAttributes = @[
|
|
|
|
NSUnderlineStyleAttributeName, NSUnderlineColorAttributeName,
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
NSMarkedClauseSegmentAttributeName, NSTextInputReplacementRangeAttributeName
|
|
|
|
+#else
|
|
|
|
+ NSMarkedClauseSegmentAttributeName
|
|
|
|
+#endif
|
|
|
|
];
|
|
|
|
return kAttributes;
|
|
|
|
}
|
|
|
|
diff --git a/content/browser/BUILD.gn b/content/browser/BUILD.gn
|
2024-09-18 01:12:11 +00:00
|
|
|
index 4502ba5b27ebd7d5d97ba10d8da4844eb9a0f777..1d4c8a5cc261e8dbd8547c20989491129655f902 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/content/browser/BUILD.gn
|
|
|
|
+++ b/content/browser/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -319,6 +319,7 @@ source_set("browser") {
|
|
|
|
"//ui/strings:ax_strings",
|
|
|
|
"//ui/touch_selection",
|
|
|
|
"//v8:v8_version",
|
|
|
|
+ "//electron/build/config:generate_mas_config",
|
2023-11-21 18:53:21 +00:00
|
|
|
]
|
2024-09-17 08:38:56 +00:00
|
|
|
|
|
|
|
public_deps = [
|
2023-11-21 18:53:21 +00:00
|
|
|
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.h b/content/browser/renderer_host/render_widget_host_view_mac.h
|
2024-09-17 08:38:56 +00:00
|
|
|
index 2285564db47ef15eb9a83affd1e481b5671c3940..cf5e79a5540d8208c34579d7e8b5a5715abb1beb 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/content/browser/renderer_host/render_widget_host_view_mac.h
|
|
|
|
+++ b/content/browser/renderer_host/render_widget_host_view_mac.h
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -23,6 +23,7 @@
|
|
|
|
#include "content/browser/renderer_host/text_input_manager.h"
|
|
|
|
#include "content/common/content_export.h"
|
|
|
|
#include "content/common/render_widget_host_ns_view.mojom.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#include "mojo/public/cpp/bindings/associated_receiver.h"
|
|
|
|
#include "mojo/public/cpp/bindings/associated_remote.h"
|
|
|
|
#include "third_party/blink/public/mojom/webshare/webshare.mojom.h"
|
|
|
|
@@ -53,7 +54,9 @@ class CursorManager;
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
@protocol RenderWidgetHostViewMacDelegate;
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
@class NSAccessibilityRemoteUIElement;
|
|
|
|
+#endif
|
|
|
|
@class RenderWidgetHostViewCocoa;
|
|
|
|
|
2024-08-21 16:34:18 +00:00
|
|
|
namespace content {
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -684,9 +687,11 @@ class CONTENT_EXPORT RenderWidgetHostViewMac
|
2023-11-21 18:53:21 +00:00
|
|
|
// EnsureSurfaceSynchronizedForWebTest().
|
|
|
|
uint32_t latest_capture_sequence_number_ = 0u;
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
// Remote accessibility objects corresponding to the NSWindow that this is
|
|
|
|
// displayed to the user in.
|
|
|
|
NSAccessibilityRemoteUIElement* __strong remote_window_accessible_;
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
// Used to force the NSApplication's focused accessibility element to be the
|
|
|
|
// content::BrowserAccessibilityCocoa accessibility tree when the NSView for
|
|
|
|
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
|
2024-09-18 01:12:11 +00:00
|
|
|
index d0dc93a37fec9fc22373a6aa08f03feb2839fde0..ec6b6f8ef3bd314ff857588eef0f1725e9231179 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
|
|
|
|
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
|
2024-09-18 01:12:11 +00:00
|
|
|
@@ -48,6 +48,7 @@
|
2024-09-17 08:38:56 +00:00
|
|
|
#include "content/public/browser/render_widget_host.h"
|
|
|
|
#include "content/public/browser/web_contents.h"
|
|
|
|
#include "content/public/common/page_visibility_state.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#include "media/base/media_switches.h"
|
|
|
|
#include "skia/ext/platform_canvas.h"
|
|
|
|
#include "skia/ext/skia_utils_mac.h"
|
|
|
|
@@ -273,8 +274,10 @@
|
2023-11-21 18:53:21 +00:00
|
|
|
void RenderWidgetHostViewMac::MigrateNSViewBridge(
|
|
|
|
remote_cocoa::mojom::Application* remote_cocoa_application,
|
|
|
|
uint64_t parent_ns_view_id) {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
// Destroy the previous remote accessibility element.
|
|
|
|
remote_window_accessible_ = nil;
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
// Reset `ns_view_` before resetting `remote_ns_view_` to avoid dangling
|
|
|
|
// pointers. `ns_view_` gets reinitialized later in this method.
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -1637,8 +1640,10 @@ void CombineTextNodesAndMakeCallback(SpeechCallback callback,
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
gfx::NativeViewAccessible
|
|
|
|
RenderWidgetHostViewMac::AccessibilityGetNativeViewAccessibleForWindow() {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
if (remote_window_accessible_)
|
|
|
|
return remote_window_accessible_;
|
|
|
|
+#endif
|
|
|
|
return [GetInProcessNSView() window];
|
|
|
|
}
|
|
|
|
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -1687,9 +1692,11 @@ void CombineTextNodesAndMakeCallback(SpeechCallback callback,
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void RenderWidgetHostViewMac::SetAccessibilityWindow(NSWindow* window) {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
// When running in-process, just use the NSView's NSWindow as its own
|
|
|
|
// accessibility element.
|
|
|
|
remote_window_accessible_ = nil;
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
bool RenderWidgetHostViewMac::SyncIsWidgetForMainFrame(
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -2213,20 +2220,26 @@ void CombineTextNodesAndMakeCallback(SpeechCallback callback,
|
2024-02-29 09:31:13 +00:00
|
|
|
void RenderWidgetHostViewMac::GetRenderWidgetAccessibilityToken(
|
|
|
|
GetRenderWidgetAccessibilityTokenCallback callback) {
|
|
|
|
base::ProcessId pid = getpid();
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
id element_id = GetNativeViewAccessible();
|
|
|
|
std::vector<uint8_t> token =
|
|
|
|
ui::RemoteAccessibility::GetTokenForLocalElement(element_id);
|
|
|
|
std::move(callback).Run(pid, token);
|
|
|
|
+#else
|
|
|
|
+ std::move(callback).Run(pid, std::vector<uint8_t>());
|
|
|
|
+#endif
|
|
|
|
}
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
void RenderWidgetHostViewMac::SetRemoteAccessibilityWindowToken(
|
|
|
|
const std::vector<uint8_t>& window_token) {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
if (window_token.empty()) {
|
|
|
|
remote_window_accessible_ = nil;
|
|
|
|
} else {
|
|
|
|
remote_window_accessible_ =
|
|
|
|
ui::RemoteAccessibility::GetRemoteElementFromToken(window_token);
|
|
|
|
}
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
///////////////////////////////////////////////////////////////////////////////
|
|
|
|
diff --git a/content/common/BUILD.gn b/content/common/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
index 9f48c905f4abbb0f2e184299a915232cf6a0f6b0..83e1af29e9b035e54b447941d55b95eb960219f1 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/content/common/BUILD.gn
|
|
|
|
+++ b/content/common/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -287,6 +287,7 @@ source_set("common") {
|
|
|
|
"//ui/shell_dialogs",
|
|
|
|
"//url",
|
|
|
|
"//url/ipc:url_ipc",
|
|
|
|
+ "//electron/build/config:generate_mas_config",
|
2023-11-21 18:53:21 +00:00
|
|
|
]
|
|
|
|
|
2024-09-17 08:38:56 +00:00
|
|
|
defines = []
|
2023-11-21 18:53:21 +00:00
|
|
|
diff --git a/content/renderer/BUILD.gn b/content/renderer/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
index 2ac766d0149f0405b3fcad0ec1b6e0685ed3658c..2fc827605b134a3bf24438b42405f70a819dbd9b 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/content/renderer/BUILD.gn
|
|
|
|
+++ b/content/renderer/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -336,6 +336,7 @@ target(link_target_type, "renderer") {
|
|
|
|
"//ui/surface",
|
|
|
|
"//url",
|
|
|
|
"//v8",
|
|
|
|
+ "//electron/build/config:generate_mas_config",
|
|
|
|
]
|
|
|
|
allow_circular_includes_from = []
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
diff --git a/content/renderer/renderer_main_platform_delegate_mac.mm b/content/renderer/renderer_main_platform_delegate_mac.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
index d4db3b179725cb96bcbd0f73db7d52ef8b7522db..703b0f56a61abac51961bfd918b7349b943900de 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/content/renderer/renderer_main_platform_delegate_mac.mm
|
|
|
|
+++ b/content/renderer/renderer_main_platform_delegate_mac.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -7,12 +7,15 @@
|
|
|
|
#import <Cocoa/Cocoa.h>
|
|
|
|
|
|
|
|
#include "base/check_op.h"
|
|
|
|
+#include "electron/mas.h"
|
2023-11-21 18:53:21 +00:00
|
|
|
#include "sandbox/mac/seatbelt.h"
|
|
|
|
#include "sandbox/mac/system_services.h"
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
extern "C" {
|
|
|
|
CGError CGSSetDenyWindowServerConnections(bool);
|
|
|
|
}
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
namespace content {
|
|
|
|
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -22,6 +25,7 @@
|
2023-11-21 18:53:21 +00:00
|
|
|
// verifies there are no existing open connections), and then indicates that
|
|
|
|
// Chrome should continue execution without access to launchservicesd.
|
|
|
|
void DisableSystemServices() {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
// Tell the WindowServer that we don't want to make any future connections.
|
|
|
|
// This will return Success as long as there are no open connections, which
|
|
|
|
// is what we want.
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -30,6 +34,7 @@ void DisableSystemServices() {
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
sandbox::DisableLaunchServices();
|
|
|
|
sandbox::DisableCoreServicesCheckFix();
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace
|
|
|
|
diff --git a/content/renderer/theme_helper_mac.mm b/content/renderer/theme_helper_mac.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
index a119b4439bfb9218c7aaf09dca8e78527da7f20d..b184c58519f3b008901caf8ae516febc1242bd97 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/content/renderer/theme_helper_mac.mm
|
|
|
|
+++ b/content/renderer/theme_helper_mac.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -7,11 +7,13 @@
|
|
|
|
#include <Cocoa/Cocoa.h>
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
#include "base/strings/sys_string_conversions.h"
|
2024-09-17 08:38:56 +00:00
|
|
|
+#include "electron/mas.h"
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
extern "C" {
|
|
|
|
bool CGFontRenderingGetFontSmoothingDisabled(void);
|
|
|
|
}
|
|
|
|
-
|
|
|
|
+#endif
|
|
|
|
namespace content {
|
|
|
|
|
|
|
|
void SystemColorsDidChange(int aqua_color_variant) {
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -24,8 +26,18 @@ void SystemColorsDidChange(int aqua_color_variant) {
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
bool IsSubpixelAntialiasingAvailable() {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
// See https://trac.webkit.org/changeset/239306/webkit for more info.
|
|
|
|
return !CGFontRenderingGetFontSmoothingDisabled();
|
|
|
|
+#else
|
|
|
|
+ NSUserDefaults* defaults = [NSUserDefaults standardUserDefaults];
|
|
|
|
+ NSString *default_key = @"CGFontRenderingGetFontSmoothingDisabled";
|
|
|
|
+ // Check that key exists since boolForKey defaults to NO when the
|
|
|
|
+ // key is missing and this key in fact defaults to YES;
|
|
|
|
+ if ([defaults objectForKey:default_key] == nil)
|
|
|
|
+ return false;
|
|
|
|
+ return ![defaults boolForKey:default_key];
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace content
|
|
|
|
diff --git a/content/test/BUILD.gn b/content/test/BUILD.gn
|
2024-09-18 01:12:11 +00:00
|
|
|
index 41fc6a51fbc9eb66e153c4f80b189932c8380086..f351c8bce390ea86511a046859875cc2d4f70db8 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/content/test/BUILD.gn
|
|
|
|
+++ b/content/test/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -638,6 +638,7 @@ static_library("test_support") {
|
|
|
|
"//url",
|
|
|
|
"//url/mojom:url_mojom_gurl",
|
|
|
|
"//v8",
|
|
|
|
+ "//electron/build/config:generate_mas_config"
|
2023-11-21 18:53:21 +00:00
|
|
|
]
|
|
|
|
|
2024-09-17 08:38:56 +00:00
|
|
|
data_deps = [
|
2024-08-19 18:52:53 +00:00
|
|
|
@@ -1107,6 +1108,7 @@ static_library("browsertest_support") {
|
2023-11-30 15:23:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
configs += [ "//v8:external_startup_data" ]
|
2024-09-17 08:38:56 +00:00
|
|
|
+ deps += ["//electron/build/config:generate_mas_config"]
|
2023-11-30 15:23:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
mojom("content_test_mojo_bindings") {
|
2024-09-18 01:12:11 +00:00
|
|
|
@@ -1890,6 +1892,7 @@ test("content_browsertests") {
|
2024-09-17 08:38:56 +00:00
|
|
|
"//ui/shell_dialogs",
|
|
|
|
"//ui/snapshot",
|
|
|
|
"//ui/webui:test_support",
|
|
|
|
+ "//electron/build/config:generate_mas_config"
|
|
|
|
]
|
2023-11-21 18:53:21 +00:00
|
|
|
|
2024-09-17 08:38:56 +00:00
|
|
|
if (!(is_chromeos_ash && target_cpu == "arm64" && current_cpu == "arm")) {
|
2024-09-18 01:12:11 +00:00
|
|
|
@@ -3168,6 +3171,7 @@ test("content_unittests") {
|
2024-09-17 08:38:56 +00:00
|
|
|
"//ui/latency:test_support",
|
|
|
|
"//ui/shell_dialogs:shell_dialogs",
|
|
|
|
"//ui/webui:test_support",
|
|
|
|
+ "//electron/build/config:generate_mas_config"
|
|
|
|
]
|
2023-11-21 18:53:21 +00:00
|
|
|
|
2024-09-17 08:38:56 +00:00
|
|
|
if (enable_nocompile_tests) {
|
2023-11-21 18:53:21 +00:00
|
|
|
diff --git a/content/web_test/BUILD.gn b/content/web_test/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
index 99e612f705c5dff041454802033564085718260a..aa37555d9a9c0fda19d0096d035c245eca5ca0c6 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/content/web_test/BUILD.gn
|
|
|
|
+++ b/content/web_test/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -228,6 +228,7 @@ static_library("web_test_browser") {
|
|
|
|
"//ui/gl",
|
|
|
|
"//ui/shell_dialogs:shell_dialogs",
|
|
|
|
"//url",
|
|
|
|
+ "//electron/build/config:generate_mas_config"
|
|
|
|
]
|
2023-11-21 18:53:21 +00:00
|
|
|
|
2024-09-17 08:38:56 +00:00
|
|
|
# TODO(crbug.com/40139469): Blink test plugin must be migrated from PPAPI.
|
2023-11-21 18:53:21 +00:00
|
|
|
diff --git a/device/bluetooth/BUILD.gn b/device/bluetooth/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
index 82d4f2bf563f6bf489b1f257efb249ba4ec9a7f3..7ae5132961a01175d0d28004e5fc2e9cfb924bdd 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/device/bluetooth/BUILD.gn
|
|
|
|
+++ b/device/bluetooth/BUILD.gn
|
2024-08-08 22:16:59 +00:00
|
|
|
@@ -258,6 +258,7 @@ component("bluetooth") {
|
2023-11-21 18:53:21 +00:00
|
|
|
"IOKit.framework",
|
|
|
|
"Foundation.framework",
|
|
|
|
]
|
2024-09-17 08:38:56 +00:00
|
|
|
+ deps += ["//electron/build/config:generate_mas_config"]
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (is_mac) {
|
|
|
|
diff --git a/device/bluetooth/bluetooth_adapter_mac.mm b/device/bluetooth/bluetooth_adapter_mac.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
index fa86583a2d82c4076cfcf64cdc3f6bbb533b95d7..3e4bda0bc31431cb2cc0893d246be6bb54cfab83 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/device/bluetooth/bluetooth_adapter_mac.mm
|
|
|
|
+++ b/device/bluetooth/bluetooth_adapter_mac.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -38,7 +38,9 @@
|
|
|
|
#include "device/bluetooth/bluetooth_discovery_session_outcome.h"
|
2023-11-21 18:53:21 +00:00
|
|
|
#include "device/bluetooth/bluetooth_socket_mac.h"
|
|
|
|
#include "device/bluetooth/public/cpp/bluetooth_address.h"
|
2024-09-17 08:38:56 +00:00
|
|
|
+#include "electron/mas.h"
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
extern "C" {
|
|
|
|
// Undocumented IOBluetooth Preference API [1]. Used by `blueutil` [2] and
|
|
|
|
// `Karabiner` [3] to programmatically control the Bluetooth state. Calling the
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -52,6 +54,7 @@
|
2023-11-21 18:53:21 +00:00
|
|
|
// [4] https://support.apple.com/kb/PH25091
|
|
|
|
void IOBluetoothPreferenceSetControllerPowerState(int state);
|
|
|
|
}
|
|
|
|
+#endif
|
|
|
|
|
2024-07-02 07:51:33 +00:00
|
|
|
// A simple helper class that forwards any Bluetooth device connect notification
|
|
|
|
// to its wrapped |_adapter|.
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -161,8 +164,10 @@ bool IsDeviceSystemPaired(const std::string& device_address) {
|
2023-11-21 18:53:21 +00:00
|
|
|
: controller_state_function_(
|
|
|
|
base::BindRepeating(&BluetoothAdapterMac::GetHostControllerState,
|
|
|
|
base::Unretained(this))),
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
power_state_function_(
|
|
|
|
base::BindRepeating(IOBluetoothPreferenceSetControllerPowerState)),
|
|
|
|
+#endif
|
|
|
|
device_paired_status_callback_(
|
2024-01-03 08:52:49 +00:00
|
|
|
base::BindRepeating(&IsDeviceSystemPaired)) {
|
|
|
|
}
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -313,8 +318,12 @@ bool IsDeviceSystemPaired(const std::string& device_address) {
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
bool BluetoothAdapterMac::SetPoweredImpl(bool powered) {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
power_state_function_.Run(base::strict_cast<int>(powered));
|
|
|
|
return true;
|
|
|
|
+#else
|
|
|
|
+ return false;
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
base::WeakPtr<BluetoothLowEnergyAdapterApple>
|
|
|
|
diff --git a/gpu/ipc/service/BUILD.gn b/gpu/ipc/service/BUILD.gn
|
2024-09-18 01:12:11 +00:00
|
|
|
index 973cd337f2781271b4ca3e29db07939ec6917327..90658a336138e4e50f93c38f1c1f465c1c2bd4dc 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/gpu/ipc/service/BUILD.gn
|
|
|
|
+++ b/gpu/ipc/service/BUILD.gn
|
2024-06-07 21:18:35 +00:00
|
|
|
@@ -135,6 +135,7 @@ component("service") {
|
2023-11-21 18:53:21 +00:00
|
|
|
"QuartzCore.framework",
|
|
|
|
]
|
|
|
|
defines += [ "GL_SILENCE_DEPRECATION" ]
|
2024-09-17 08:38:56 +00:00
|
|
|
+ deps += ["//electron/build/config:generate_mas_config"]
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
if (is_ios) {
|
|
|
|
sources += [ "image_transport_surface_ios.mm" ]
|
|
|
|
diff --git a/gpu/ipc/service/image_transport_surface_overlay_mac.h b/gpu/ipc/service/image_transport_surface_overlay_mac.h
|
2024-09-17 08:38:56 +00:00
|
|
|
index 36322ddd3047f96569f35807541a37d3c6672b09..0121a780cf3b79fc1120c1b85cd5cd30c14968ef 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/gpu/ipc/service/image_transport_surface_overlay_mac.h
|
|
|
|
+++ b/gpu/ipc/service/image_transport_surface_overlay_mac.h
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -8,6 +8,7 @@
|
|
|
|
#include <vector>
|
|
|
|
|
|
|
|
#include "base/memory/weak_ptr.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#include "gpu/ipc/service/command_buffer_stub.h"
|
|
|
|
#include "gpu/ipc/service/image_transport_surface.h"
|
|
|
|
#include "ui/gfx/ca_layer_result.h"
|
|
|
|
@@ -23,7 +24,9 @@
|
2023-11-21 18:53:21 +00:00
|
|
|
#include "ui/display/types/display_constants.h"
|
|
|
|
#endif
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
@class CAContext;
|
|
|
|
+#endif
|
|
|
|
@class CALayer;
|
|
|
|
|
|
|
|
namespace ui {
|
|
|
|
diff --git a/media/audio/BUILD.gn b/media/audio/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
index 6f3b368103b05f07ae67da4c0307efe039b8dfce..c8b18509dc508fbb928b97830536d210b378bf73 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/media/audio/BUILD.gn
|
|
|
|
+++ b/media/audio/BUILD.gn
|
2024-08-02 14:02:11 +00:00
|
|
|
@@ -197,6 +197,7 @@ source_set("audio") {
|
2023-11-21 18:53:21 +00:00
|
|
|
"CoreMedia.framework",
|
|
|
|
]
|
|
|
|
weak_frameworks = [ "ScreenCaptureKit.framework" ] # macOS 13.0
|
2024-09-17 08:38:56 +00:00
|
|
|
+ deps += ["//electron/build/config:generate_mas_config"]
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (is_ios) {
|
2024-01-25 23:57:47 +00:00
|
|
|
diff --git a/media/audio/apple/audio_low_latency_input.cc b/media/audio/apple/audio_low_latency_input.cc
|
2024-09-17 08:38:56 +00:00
|
|
|
index 9b78f60304a0e487904fdb22c9e6d85a237ca96e..e639558d34edab3ba3b1bb4f502bd91405e58637 100644
|
2024-01-25 23:57:47 +00:00
|
|
|
--- a/media/audio/apple/audio_low_latency_input.cc
|
|
|
|
+++ b/media/audio/apple/audio_low_latency_input.cc
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -28,6 +28,7 @@
|
|
|
|
#include "base/strings/sys_string_conversions.h"
|
|
|
|
#include "base/time/time.h"
|
|
|
|
#include "base/trace_event/trace_event.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#include "media/audio/apple/audio_manager_apple.h"
|
|
|
|
#include "media/audio/apple/scoped_audio_unit.h"
|
|
|
|
#include "media/base/audio_bus.h"
|
|
|
|
@@ -39,19 +40,23 @@
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
namespace {
|
|
|
|
extern "C" {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
// See:
|
|
|
|
// https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/PAL/pal/spi/cf/CoreAudioSPI.h?rev=228264
|
|
|
|
OSStatus AudioDeviceDuck(AudioDeviceID inDevice,
|
|
|
|
Float32 inDuckedLevel,
|
|
|
|
const AudioTimeStamp* __nullable inStartTime,
|
|
|
|
Float32 inRampDuration) __attribute__((weak_import));
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
void UndoDucking(AudioDeviceID output_device_id) {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
if (AudioDeviceDuck != nullptr) {
|
|
|
|
// Ramp the volume back up over half a second.
|
|
|
|
AudioDeviceDuck(output_device_id, 1.0, nullptr, 0.5);
|
|
|
|
}
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
} // namespace
|
2024-01-11 06:33:40 +00:00
|
|
|
#endif
|
2023-11-21 18:53:21 +00:00
|
|
|
diff --git a/net/dns/BUILD.gn b/net/dns/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
index 5f4ff9ff8172d4ad282cc9c781f85118b8ba7d1a..cc85f488884f48df94198b7e4d4823946e750716 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/net/dns/BUILD.gn
|
|
|
|
+++ b/net/dns/BUILD.gn
|
2024-05-10 15:21:10 +00:00
|
|
|
@@ -187,6 +187,8 @@ source_set("dns") {
|
2023-11-21 18:53:21 +00:00
|
|
|
":host_resolver_manager",
|
|
|
|
":mdns_client",
|
|
|
|
]
|
|
|
|
+
|
2024-09-17 08:38:56 +00:00
|
|
|
+ deps += ["//electron/build/config:generate_mas_config"]
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
# The standard API of net/dns.
|
|
|
|
diff --git a/net/dns/dns_config_service_posix.cc b/net/dns/dns_config_service_posix.cc
|
2024-09-17 08:38:56 +00:00
|
|
|
index 70d5665ad7b9ef62370497636af919ede2508ad4..f4dc3e2b8053cdb3e8c439ab1a1d6369a8e6a7dc 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/net/dns/dns_config_service_posix.cc
|
|
|
|
+++ b/net/dns/dns_config_service_posix.cc
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -28,6 +28,7 @@
|
|
|
|
#include "base/threading/scoped_blocking_call.h"
|
|
|
|
#include "base/time/time.h"
|
|
|
|
#include "build/build_config.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#include "net/base/ip_endpoint.h"
|
|
|
|
#include "net/dns/dns_config.h"
|
|
|
|
#include "net/dns/dns_hosts.h"
|
|
|
|
@@ -135,8 +136,8 @@ class DnsConfigServicePosix::Watcher : public DnsConfigService::Watcher {
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
bool Watch() override {
|
|
|
|
CheckOnCorrectSequence();
|
|
|
|
-
|
|
|
|
bool success = true;
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
if (!config_watcher_.Watch(base::BindRepeating(&Watcher::OnConfigChanged,
|
|
|
|
base::Unretained(this)))) {
|
|
|
|
LOG(ERROR) << "DNS config watch failed to start.";
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -153,6 +154,7 @@ class DnsConfigServicePosix::Watcher : public DnsConfigService::Watcher {
|
2023-11-21 18:53:21 +00:00
|
|
|
success = false;
|
|
|
|
}
|
|
|
|
#endif // !BUILDFLAG(IS_IOS)
|
|
|
|
+#endif
|
|
|
|
return success;
|
|
|
|
}
|
|
|
|
|
|
|
|
diff --git a/sandbox/mac/BUILD.gn b/sandbox/mac/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
index 299a028f23314f479d2da8f914a5bdf34698d854..67a56a3b4c8fc524f1ec8cfec856f24d30402134 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/sandbox/mac/BUILD.gn
|
|
|
|
+++ b/sandbox/mac/BUILD.gn
|
|
|
|
@@ -39,6 +39,7 @@ component("seatbelt") {
|
|
|
|
]
|
|
|
|
public_deps = [ "//third_party/protobuf:protobuf_lite" ]
|
|
|
|
defines = [ "SEATBELT_IMPLEMENTATION" ]
|
2024-09-17 08:38:56 +00:00
|
|
|
+ deps += ["//electron/build/config:generate_mas_config"]
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
component("seatbelt_extension") {
|
|
|
|
@@ -52,6 +53,7 @@ component("seatbelt_extension") {
|
|
|
|
libs = [ "sandbox" ]
|
|
|
|
public_deps = [ "//base" ]
|
|
|
|
defines = [ "SEATBELT_IMPLEMENTATION" ]
|
2024-09-17 08:38:56 +00:00
|
|
|
+ deps += ["//electron/build/config:generate_mas_config"]
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
component("system_services") {
|
|
|
|
@@ -66,6 +68,7 @@ component("system_services") {
|
|
|
|
deps = [ ":seatbelt_export" ]
|
|
|
|
public_deps = [ "//base" ]
|
|
|
|
defines = [ "SEATBELT_IMPLEMENTATION" ]
|
2024-09-17 08:38:56 +00:00
|
|
|
+ deps += ["//electron/build/config:generate_mas_config"]
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
source_set("sandbox_unittests") {
|
|
|
|
diff --git a/sandbox/mac/sandbox_compiler.cc b/sandbox/mac/sandbox_compiler.cc
|
2024-09-17 08:38:56 +00:00
|
|
|
index f35d9ef2a2df3db8ecbf1d7b909c7b1cf33f3cd9..5d52330d1bd70cd7b97ee3360721f10c8447c717 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/sandbox/mac/sandbox_compiler.cc
|
|
|
|
+++ b/sandbox/mac/sandbox_compiler.cc
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -7,6 +7,7 @@
|
|
|
|
#include <string>
|
|
|
|
#include <vector>
|
|
|
|
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#include "sandbox/mac/seatbelt.h"
|
|
|
|
|
|
|
|
namespace sandbox {
|
|
|
|
@@ -47,6 +48,7 @@ bool SandboxCompiler::SetParameter(const std::string& key,
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
bool SandboxCompiler::CompileAndApplyProfile(std::string& error) {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
if (mode_ == Target::kSource) {
|
|
|
|
std::vector<const char*> params;
|
|
|
|
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -67,6 +69,9 @@ bool SandboxCompiler::CompileAndApplyProfile(std::string& error) {
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
+#else
|
|
|
|
+ return true;
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
bool SandboxCompiler::CompilePolicyToProto(mac::SandboxPolicy& policy,
|
|
|
|
diff --git a/sandbox/mac/sandbox_logging.cc b/sandbox/mac/sandbox_logging.cc
|
2024-09-17 08:38:56 +00:00
|
|
|
index 095c639b9893e885d8937e29ed7d47a7c28bc6b6..7e0cf9b9f94b16741358bdb45122f8b2bd68c0f9 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/sandbox/mac/sandbox_logging.cc
|
|
|
|
+++ b/sandbox/mac/sandbox_logging.cc
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -16,6 +16,7 @@
|
|
|
|
#include <string>
|
|
|
|
|
|
|
|
#include "build/build_config.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#include "sandbox/mac/sandbox_crash_message.h"
|
|
|
|
|
|
|
|
#if defined(ARCH_CPU_X86_64)
|
|
|
|
@@ -33,9 +34,11 @@
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
extern "C" {
|
|
|
|
void abort_report_np(const char*, ...);
|
|
|
|
}
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
namespace sandbox::logging {
|
|
|
|
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -76,9 +79,11 @@ void SendOsLog(Level level, const char* message) {
|
2023-11-21 18:53:21 +00:00
|
|
|
sandbox::crash_message::SetCrashMessage(message);
|
|
|
|
}
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
if (level == Level::FATAL) {
|
|
|
|
abort_report_np(message);
|
|
|
|
}
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
// |error| is strerror(errno) when a P* logging function is called. Pass
|
|
|
|
diff --git a/sandbox/mac/seatbelt.cc b/sandbox/mac/seatbelt.cc
|
2024-09-17 08:38:56 +00:00
|
|
|
index 15c835e118456394c0a00ac98c11241c14ca75bd..a16faabe2bd63a5e0fbe9082a3b4b7c8aa0ea064 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/sandbox/mac/seatbelt.cc
|
|
|
|
+++ b/sandbox/mac/seatbelt.cc
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -4,12 +4,14 @@
|
|
|
|
|
|
|
|
#include "sandbox/mac/seatbelt.h"
|
|
|
|
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
+
|
|
|
|
#include <errno.h>
|
|
|
|
#include <unistd.h>
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
extern "C" {
|
|
|
|
#include <sandbox.h>
|
|
|
|
-
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
int sandbox_init_with_parameters(const char* profile,
|
|
|
|
uint64_t flags,
|
|
|
|
const char* const parameters[],
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -40,13 +42,13 @@ sandbox_profile_t* sandbox_compile_string(const char* data,
|
2023-11-21 18:53:21 +00:00
|
|
|
char** error);
|
|
|
|
int sandbox_apply(sandbox_profile_t*);
|
|
|
|
void sandbox_free_profile(sandbox_profile_t*);
|
|
|
|
-
|
|
|
|
+#endif
|
|
|
|
} // extern "C"
|
|
|
|
|
|
|
|
namespace sandbox {
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
-
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
bool HandleSandboxResult(int rv, char* errorbuf, std::string* error) {
|
|
|
|
if (rv == 0) {
|
|
|
|
if (error)
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -74,36 +76,48 @@ bool HandleSandboxErrno(int rv, const char* message, std::string* error) {
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
-
|
|
|
|
+#endif
|
|
|
|
} // namespace
|
|
|
|
|
|
|
|
// static
|
|
|
|
Seatbelt::Parameters Seatbelt::Parameters::Create() {
|
|
|
|
Parameters params;
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
params.params_ = ::sandbox_create_params();
|
|
|
|
+#endif
|
|
|
|
return params;
|
|
|
|
}
|
|
|
|
|
|
|
|
Seatbelt::Parameters::Parameters() = default;
|
|
|
|
|
|
|
|
Seatbelt::Parameters::Parameters(Seatbelt::Parameters&& other) {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
params_ = std::exchange(other.params_, nullptr);
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
Seatbelt::Parameters& Seatbelt::Parameters::operator=(
|
|
|
|
Seatbelt::Parameters&& other) {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
params_ = std::exchange(other.params_, nullptr);
|
|
|
|
+#endif
|
|
|
|
return *this;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool Seatbelt::Parameters::Set(const char* key, const char* value) {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
return ::sandbox_set_param(params_, key, value) == 0;
|
|
|
|
+#else
|
|
|
|
+ return true;
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
Seatbelt::Parameters::~Parameters() {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
if (params_) {
|
|
|
|
::sandbox_free_params(params_);
|
|
|
|
}
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
// Initialize the static member variables.
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -114,6 +128,7 @@ const char* Seatbelt::kProfilePureComputation = kSBXProfilePureComputation;
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
// static
|
|
|
|
bool Seatbelt::Init(const char* profile, uint64_t flags, std::string* error) {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
// OS X deprecated these functions, but did not provide a suitable replacement,
|
|
|
|
// so ignore the deprecation warning.
|
|
|
|
#pragma clang diagnostic push
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -122,6 +137,9 @@ bool Seatbelt::Init(const char* profile, uint64_t flags, std::string* error) {
|
2023-11-21 18:53:21 +00:00
|
|
|
int rv = ::sandbox_init(profile, flags, &errorbuf);
|
|
|
|
return HandleSandboxResult(rv, errorbuf, error);
|
|
|
|
#pragma clang diagnostic pop
|
|
|
|
+#else
|
|
|
|
+ return true;
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
// static
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -129,10 +147,14 @@ bool Seatbelt::InitWithParams(const char* profile,
|
2023-11-21 18:53:21 +00:00
|
|
|
uint64_t flags,
|
|
|
|
const char* const parameters[],
|
|
|
|
std::string* error) {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
char* errorbuf = nullptr;
|
|
|
|
int rv =
|
|
|
|
::sandbox_init_with_parameters(profile, flags, parameters, &errorbuf);
|
|
|
|
return HandleSandboxResult(rv, errorbuf, error);
|
|
|
|
+#else
|
|
|
|
+ return true;
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
// static
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -140,6 +162,7 @@ bool Seatbelt::Compile(const char* profile,
|
2023-11-21 18:53:21 +00:00
|
|
|
const Seatbelt::Parameters& params,
|
|
|
|
std::string& compiled_profile,
|
|
|
|
std::string* error) {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
char* errorbuf = nullptr;
|
|
|
|
sandbox_profile_t* sandbox_profile =
|
|
|
|
::sandbox_compile_string(profile, params.params(), &errorbuf);
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -149,33 +172,44 @@ bool Seatbelt::Compile(const char* profile,
|
2023-11-21 18:53:21 +00:00
|
|
|
compiled_profile.assign(reinterpret_cast<const char*>(sandbox_profile->data),
|
|
|
|
sandbox_profile->size);
|
|
|
|
::sandbox_free_profile(sandbox_profile);
|
|
|
|
+#endif
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
// static
|
|
|
|
bool Seatbelt::ApplyCompiledProfile(const std::string& profile,
|
|
|
|
std::string* error) {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
sandbox_profile_t sbox_profile = {
|
|
|
|
.builtin = nullptr,
|
|
|
|
.data = reinterpret_cast<const uint8_t*>(profile.data()),
|
|
|
|
.size = profile.size()};
|
|
|
|
return HandleSandboxErrno(::sandbox_apply(&sbox_profile),
|
|
|
|
"sandbox_apply: ", error);
|
|
|
|
+#else
|
|
|
|
+ return true;
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
// static
|
|
|
|
void Seatbelt::FreeError(char* errorbuf) {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
// OS X deprecated these functions, but did not provide a suitable replacement,
|
|
|
|
// so ignore the deprecation warning.
|
|
|
|
#pragma clang diagnostic push
|
|
|
|
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
|
|
|
|
return ::sandbox_free_error(errorbuf);
|
|
|
|
#pragma clang diagnostic pop
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
// static
|
|
|
|
bool Seatbelt::IsSandboxed() {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
return ::sandbox_check(getpid(), NULL, 0);
|
|
|
|
+#else
|
|
|
|
+ return true;
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace sandbox
|
|
|
|
diff --git a/sandbox/mac/seatbelt_extension.cc b/sandbox/mac/seatbelt_extension.cc
|
2024-09-17 08:38:56 +00:00
|
|
|
index b3f017a8be25209a78ed6a1221abcdeeb7904752..64aacf0542cbb899b04a9f957b8d094e9c8669ff 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/sandbox/mac/seatbelt_extension.cc
|
|
|
|
+++ b/sandbox/mac/seatbelt_extension.cc
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -9,8 +9,10 @@
|
|
|
|
#include "base/check.h"
|
|
|
|
#include "base/memory/ptr_util.h"
|
2023-11-21 18:53:21 +00:00
|
|
|
#include "base/notreached.h"
|
2024-09-17 08:38:56 +00:00
|
|
|
+#include "electron/mas.h"
|
2023-11-21 18:53:21 +00:00
|
|
|
#include "sandbox/mac/seatbelt_extension_token.h"
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
// libsandbox private API.
|
|
|
|
extern "C" {
|
|
|
|
extern const char* APP_SANDBOX_READ;
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -22,6 +24,7 @@ char* sandbox_extension_issue_file(const char* type,
|
2023-11-21 18:53:21 +00:00
|
|
|
const char* path,
|
|
|
|
uint32_t flags);
|
|
|
|
}
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
namespace sandbox {
|
|
|
|
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -50,7 +53,11 @@ std::unique_ptr<SeatbeltExtension> SeatbeltExtension::FromToken(
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
bool SeatbeltExtension::Consume() {
|
|
|
|
DCHECK(!token_.empty());
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
handle_ = sandbox_extension_consume(token_.c_str());
|
|
|
|
+#else
|
|
|
|
+ handle_ = -1;
|
|
|
|
+#endif
|
|
|
|
return handle_ > 0;
|
|
|
|
}
|
|
|
|
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -62,7 +69,11 @@ bool SeatbeltExtension::ConsumePermanently() {
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
bool SeatbeltExtension::Revoke() {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
int rv = sandbox_extension_release(handle_);
|
|
|
|
+#else
|
|
|
|
+ int rv = -1;
|
|
|
|
+#endif
|
|
|
|
handle_ = 0;
|
|
|
|
token_.clear();
|
|
|
|
return rv == 0;
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -80,12 +91,14 @@ SeatbeltExtension::SeatbeltExtension(const std::string& token)
|
2023-11-21 18:53:21 +00:00
|
|
|
char* SeatbeltExtension::IssueToken(SeatbeltExtension::Type type,
|
|
|
|
const std::string& resource) {
|
|
|
|
switch (type) {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
case FILE_READ:
|
|
|
|
return sandbox_extension_issue_file(APP_SANDBOX_READ, resource.c_str(),
|
|
|
|
0);
|
|
|
|
case FILE_READ_WRITE:
|
|
|
|
return sandbox_extension_issue_file(APP_SANDBOX_READ_WRITE,
|
|
|
|
resource.c_str(), 0);
|
|
|
|
+#endif
|
|
|
|
default:
|
2024-06-07 21:18:35 +00:00
|
|
|
NOTREACHED_IN_MIGRATION();
|
2023-11-21 18:53:21 +00:00
|
|
|
return nullptr;
|
|
|
|
diff --git a/sandbox/mac/system_services.cc b/sandbox/mac/system_services.cc
|
2024-09-17 08:38:56 +00:00
|
|
|
index eb81a70e4d5d5cd3e6ae9b45f8cd1c795ea76c51..9921ccb10d3455600eddd85f77f10228016389af 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/sandbox/mac/system_services.cc
|
|
|
|
+++ b/sandbox/mac/system_services.cc
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -8,7 +8,9 @@
|
|
|
|
#include <CoreFoundation/CoreFoundation.h>
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
#include "base/apple/osstatus_logging.h"
|
2024-09-17 08:38:56 +00:00
|
|
|
+#include "electron/mas.h"
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
extern "C" {
|
|
|
|
OSStatus SetApplicationIsDaemon(Boolean isDaemon);
|
|
|
|
void _LSSetApplicationLaunchServicesServerConnectionStatus(
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -19,10 +21,12 @@ void _LSSetApplicationLaunchServicesServerConnectionStatus(
|
2023-11-21 18:53:21 +00:00
|
|
|
// https://github.com/WebKit/WebKit/blob/24aaedc770d192d03a07ba4a71727274aaa8fc07/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm#L840
|
|
|
|
void _CSCheckFixDisable();
|
|
|
|
} // extern "C"
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
namespace sandbox {
|
|
|
|
|
|
|
|
void DisableLaunchServices() {
|
|
|
|
+ #if !IS_MAS_BUILD()
|
|
|
|
// Allow the process to continue without a LaunchServices ASN. The
|
|
|
|
// INIT_Process function in HIServices will abort if it cannot connect to
|
|
|
|
// launchservicesd to get an ASN. By setting this flag, HIServices skips
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -36,10 +40,13 @@ void DisableLaunchServices() {
|
2023-11-21 18:53:21 +00:00
|
|
|
0, ^bool(CFDictionaryRef options) {
|
|
|
|
return false;
|
|
|
|
});
|
|
|
|
+ #endif
|
|
|
|
}
|
|
|
|
|
|
|
|
void DisableCoreServicesCheckFix() {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
_CSCheckFixDisable();
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace sandbox
|
|
|
|
diff --git a/third_party/blink/renderer/core/BUILD.gn b/third_party/blink/renderer/core/BUILD.gn
|
2024-09-18 01:12:11 +00:00
|
|
|
index 95cd6ecd6cfe070d9f0a4bbc299ca82872fddc9c..ecae890c47a4dda6474bb0c4711adc0136806301 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/third_party/blink/renderer/core/BUILD.gn
|
|
|
|
+++ b/third_party/blink/renderer/core/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -402,6 +402,7 @@ component("core") {
|
|
|
|
"//ui/gfx/geometry",
|
|
|
|
"//ui/gfx/geometry:geometry_skia",
|
|
|
|
"//ui/strings",
|
|
|
|
+ "//electron/build/config:generate_mas_config",
|
|
|
|
]
|
2023-11-21 18:53:21 +00:00
|
|
|
|
2024-09-17 08:38:56 +00:00
|
|
|
if (is_mac) {
|
2023-11-21 18:53:21 +00:00
|
|
|
diff --git a/third_party/blink/renderer/core/editing/build.gni b/third_party/blink/renderer/core/editing/build.gni
|
2024-09-18 01:12:11 +00:00
|
|
|
index 44e437c91135ec09c588a46e032bd6d3a12bab04..963e263a81b4eb9b3c53bebdcab1d1064b6113db 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/third_party/blink/renderer/core/editing/build.gni
|
|
|
|
+++ b/third_party/blink/renderer/core/editing/build.gni
|
2024-09-18 01:12:11 +00:00
|
|
|
@@ -356,10 +356,14 @@ blink_core_sources_editing = [
|
2023-11-21 18:53:21 +00:00
|
|
|
if (is_mac) {
|
|
|
|
blink_core_sources_editing += [
|
|
|
|
"commands/smart_replace_cf.cc",
|
|
|
|
- "kill_ring_mac.mm",
|
|
|
|
"substring_util.h",
|
|
|
|
"substring_util.mm",
|
|
|
|
]
|
|
|
|
+ if (is_mas_build) {
|
|
|
|
+ blink_core_sources_editing += [ "kill_ring_mac.mm" ]
|
|
|
|
+ } else {
|
|
|
|
+ blink_core_sources_editing += [ "kill_ring_none.cc" ]
|
|
|
|
+ }
|
|
|
|
} else {
|
|
|
|
blink_core_sources_editing += [ "kill_ring_none.cc" ]
|
|
|
|
}
|
|
|
|
diff --git a/ui/accelerated_widget_mac/BUILD.gn b/ui/accelerated_widget_mac/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
index 3ead42e14ad9d41a30c5637678a3ac49296ce2a6..07665bbefd34737bf6a8c3e79d70b066920788c9 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/ui/accelerated_widget_mac/BUILD.gn
|
|
|
|
+++ b/ui/accelerated_widget_mac/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -64,6 +64,7 @@ component("accelerated_widget_mac") {
|
|
|
|
"//ui/gfx",
|
|
|
|
"//ui/gfx/geometry",
|
|
|
|
"//ui/gl",
|
|
|
|
+ "//electron/build/config:generate_mas_config",
|
2023-11-21 18:53:21 +00:00
|
|
|
]
|
2024-09-17 08:38:56 +00:00
|
|
|
}
|
2023-11-21 18:53:21 +00:00
|
|
|
|
2024-04-15 22:10:32 +00:00
|
|
|
diff --git a/ui/accelerated_widget_mac/ca_layer_tree_coordinator.h b/ui/accelerated_widget_mac/ca_layer_tree_coordinator.h
|
2024-09-17 08:38:56 +00:00
|
|
|
index b11c365f42dd1ddc363de0d94c387b13ac65bef3..5da42beb20b514396287cc6dc5cba608e1660b2e 100644
|
2024-04-15 22:10:32 +00:00
|
|
|
--- a/ui/accelerated_widget_mac/ca_layer_tree_coordinator.h
|
|
|
|
+++ b/ui/accelerated_widget_mac/ca_layer_tree_coordinator.h
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -7,6 +7,7 @@
|
|
|
|
|
|
|
|
#include <queue>
|
|
|
|
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#include "ui/accelerated_widget_mac/accelerated_widget_mac_export.h"
|
|
|
|
#include "ui/accelerated_widget_mac/ca_renderer_layer_tree.h"
|
|
|
|
#include "ui/gfx/ca_layer_result.h"
|
|
|
|
@@ -14,7 +15,9 @@
|
2024-04-15 22:10:32 +00:00
|
|
|
#include "ui/gl/gl_surface.h"
|
|
|
|
#include "ui/gl/presenter.h"
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
@class CAContext;
|
|
|
|
+#endif
|
|
|
|
@class CALayer;
|
|
|
|
|
|
|
|
namespace ui {
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -110,7 +113,9 @@ class ACCELERATED_WIDGET_MAC_EXPORT CALayerTreeCoordinator {
|
2024-04-15 22:10:32 +00:00
|
|
|
// both the current tree and the pending trees.
|
|
|
|
size_t presented_ca_layer_trees_max_length_ = 2;
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
CAContext* __strong ca_context_;
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
// The root CALayer to display the current frame. This does not change
|
|
|
|
// over the lifetime of the object.
|
|
|
|
diff --git a/ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm b/ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
index b99461d52e3a62b58330691e65f9956748cfbf02..f0c3bb1b809a29eee3d990b0a8bbffddb7500895 100644
|
2024-04-15 22:10:32 +00:00
|
|
|
--- a/ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm
|
|
|
|
+++ b/ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -10,6 +10,7 @@
|
|
|
|
#include "base/mac/mac_util.h"
|
|
|
|
#include "base/task/single_thread_task_runner.h"
|
|
|
|
#include "base/trace_event/trace_event.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#include "ui/base/cocoa/animation_utils.h"
|
|
|
|
#include "ui/base/cocoa/remote_layer_api.h"
|
|
|
|
#include "ui/gfx/ca_layer_params.h"
|
|
|
|
@@ -33,6 +34,7 @@
|
2024-04-15 22:10:32 +00:00
|
|
|
new_presentation_feedback_timestamps_(
|
|
|
|
new_presentation_feedback_timestamps),
|
|
|
|
buffer_presented_callback_(buffer_presented_callback) {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
if (allow_remote_layers_) {
|
|
|
|
root_ca_layer_ = [[CALayer alloc] init];
|
|
|
|
#if BUILDFLAG(IS_MAC)
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -61,6 +63,7 @@
|
2024-04-15 22:10:32 +00:00
|
|
|
#endif
|
|
|
|
ca_context_.layer = root_ca_layer_;
|
|
|
|
}
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
CALayerTreeCoordinator::~CALayerTreeCoordinator() = default;
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -164,9 +167,13 @@
|
2024-04-15 22:10:32 +00:00
|
|
|
TRACE_EVENT_INSTANT2("test_gpu", "SwapBuffers", TRACE_EVENT_SCOPE_THREAD,
|
|
|
|
"GLImpl", static_cast<int>(gl::GetGLImplementation()),
|
|
|
|
"width", pixel_size_.width());
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
if (allow_remote_layers_) {
|
|
|
|
params.ca_context_id = [ca_context_ contextId];
|
|
|
|
} else {
|
|
|
|
+#else
|
|
|
|
+ if (true) {
|
|
|
|
+#endif
|
|
|
|
IOSurfaceRef io_surface = frame->layer_tree->GetContentIOSurface();
|
|
|
|
if (io_surface) {
|
|
|
|
DCHECK(!allow_remote_layers_);
|
2023-11-21 18:53:21 +00:00
|
|
|
diff --git a/ui/accelerated_widget_mac/display_ca_layer_tree.mm b/ui/accelerated_widget_mac/display_ca_layer_tree.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
index dcf493d62990018040a3f84b6f875af737bd2214..3d1c4dcc9ee0bbfdac15f40d9c74e9f342a59e39 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/ui/accelerated_widget_mac/display_ca_layer_tree.mm
|
|
|
|
+++ b/ui/accelerated_widget_mac/display_ca_layer_tree.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -12,6 +12,7 @@
|
|
|
|
#include "base/mac/mac_util.h"
|
|
|
|
#include "base/trace_event/trace_event.h"
|
|
|
|
#include "build/build_config.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#include "ui/base/cocoa/animation_utils.h"
|
|
|
|
#include "ui/base/cocoa/remote_layer_api.h"
|
|
|
|
#include "ui/gfx/geometry/dip_util.h"
|
|
|
|
@@ -121,6 +122,7 @@ - (void)setContentsChanged;
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void DisplayCALayerTree::GotCALayerFrame(uint32_t ca_context_id) {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
// Early-out if the remote layer has not changed.
|
|
|
|
if (remote_layer_.contextId == ca_context_id) {
|
|
|
|
return;
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -150,6 +152,9 @@ - (void)setContentsChanged;
|
2023-11-21 18:53:21 +00:00
|
|
|
[io_surface_layer_ removeFromSuperlayer];
|
|
|
|
io_surface_layer_ = nil;
|
|
|
|
}
|
|
|
|
+#else
|
|
|
|
+ NOTREACHED() << "Remote layer is being used in MAS build";
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
void DisplayCALayerTree::GotIOSurfaceFrame(
|
|
|
|
diff --git a/ui/accessibility/platform/BUILD.gn b/ui/accessibility/platform/BUILD.gn
|
2024-09-18 01:12:11 +00:00
|
|
|
index 2e24201fcdc1ec65688e2b08d28a74a218792af2..6085a8cde3df9a763e0eb63a9620f9971a3f57c8 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/ui/accessibility/platform/BUILD.gn
|
|
|
|
+++ b/ui/accessibility/platform/BUILD.gn
|
2024-09-18 01:12:11 +00:00
|
|
|
@@ -282,6 +282,7 @@ component("platform") {
|
2024-08-02 14:02:11 +00:00
|
|
|
"AppKit.framework",
|
|
|
|
"Foundation.framework",
|
2023-11-21 18:53:21 +00:00
|
|
|
]
|
2024-09-17 08:38:56 +00:00
|
|
|
+ deps += ["//electron/build/config:generate_mas_config"]
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
|
2024-06-07 21:18:35 +00:00
|
|
|
if (is_ios) {
|
2024-09-18 01:12:11 +00:00
|
|
|
diff --git a/ui/accessibility/platform/browser_accessibility_manager_mac.mm b/ui/accessibility/platform/browser_accessibility_manager_mac.mm
|
|
|
|
index 0e49b85487decd16c8aff018392744492f1ce52f..21aa421f3df1d5a6351c802cc1898a06c0fdd3fa 100644
|
|
|
|
--- a/ui/accessibility/platform/browser_accessibility_manager_mac.mm
|
|
|
|
+++ b/ui/accessibility/platform/browser_accessibility_manager_mac.mm
|
|
|
|
@@ -13,13 +13,16 @@
|
|
|
|
#include "base/task/single_thread_task_runner.h"
|
|
|
|
#include "base/task/task_traits.h"
|
|
|
|
#include "base/time/time.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#include "ui/accelerated_widget_mac/accelerated_widget_mac.h"
|
|
|
|
#include "ui/accessibility/ax_role_properties.h"
|
|
|
|
#include "ui/accessibility/platform/ax_platform_tree_manager_delegate.h"
|
|
|
|
#include "ui/accessibility/platform/ax_private_webkit_constants_mac.h"
|
|
|
|
#import "ui/accessibility/platform/browser_accessibility_cocoa.h"
|
|
|
|
#import "ui/accessibility/platform/browser_accessibility_mac.h"
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
#include "ui/base/cocoa/remote_accessibility_api.h"
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
|
|
|
|
@@ -227,6 +230,7 @@ void PostAnnouncementNotification(NSString* announcement,
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
BrowserAccessibilityManager* root_manager = GetManagerForRootFrame();
|
|
|
|
if (root_manager) {
|
|
|
|
BrowserAccessibilityManagerMac* root_manager_mac =
|
|
|
|
@@ -249,6 +253,7 @@ void PostAnnouncementNotification(NSString* announcement,
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
// Use native VoiceOver support for live regions.
|
|
|
|
BrowserAccessibilityCocoa* retained_node = native_node;
|
|
|
|
@@ -638,6 +643,7 @@ void PostAnnouncementNotification(NSString* announcement,
|
|
|
|
return window == [NSApp accessibilityFocusedWindow];
|
|
|
|
}
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
// TODO(accessibility): We need a solution to the problem described below.
|
|
|
|
// If the window is NSAccessibilityRemoteUIElement, there are some challenges:
|
|
|
|
// 1. NSApp is the browser which spawned the PWA, and what it considers the
|
|
|
|
@@ -666,6 +672,7 @@ void PostAnnouncementNotification(NSString* announcement,
|
|
|
|
if ([window isKindOfClass:[NSAccessibilityRemoteUIElement class]]) {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
2023-11-21 18:53:21 +00:00
|
|
|
diff --git a/ui/accessibility/platform/inspect/ax_transform_mac.mm b/ui/accessibility/platform/inspect/ax_transform_mac.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
index c8171f0527fe5194f0ea73b57c4444d4c630fbc4..c2ac4da580e3e7f749a0a4de1e859af62de11672 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/ui/accessibility/platform/inspect/ax_transform_mac.mm
|
|
|
|
+++ b/ui/accessibility/platform/inspect/ax_transform_mac.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -11,6 +11,7 @@
|
|
|
|
|
|
|
|
#include "base/apple/foundation_util.h"
|
|
|
|
#include "base/strings/sys_string_conversions.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#include "ui/accessibility/ax_range.h"
|
|
|
|
#include "ui/accessibility/platform/ax_platform_node.h"
|
|
|
|
#include "ui/accessibility/platform/ax_platform_node_cocoa.h"
|
|
|
|
@@ -111,6 +112,7 @@
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
// AXTextMarker
|
|
|
|
if (IsAXTextMarker(value)) {
|
|
|
|
return AXTextMarkerToBaseValue(value, indexer);
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -120,6 +122,7 @@
|
2023-11-21 18:53:21 +00:00
|
|
|
if (IsAXTextMarkerRange(value)) {
|
|
|
|
return AXTextMarkerRangeToBaseValue(value, indexer);
|
|
|
|
}
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
// Accessible object
|
|
|
|
if (AXElementWrapper::IsValidElement(value)) {
|
|
|
|
diff --git a/ui/base/BUILD.gn b/ui/base/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
index 64aca0117cd273bfcec0549e7b5b8ac77f2c91ce..511d12116f0d85fec6d7c2c9947e9c2e6fc98285 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/ui/base/BUILD.gn
|
|
|
|
+++ b/ui/base/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -380,6 +380,13 @@ component("base") {
|
2023-11-21 18:53:21 +00:00
|
|
|
sources += [ "resource/resource_bundle_lacros.cc" ]
|
|
|
|
}
|
|
|
|
|
|
|
|
+ if (is_mas_build) {
|
|
|
|
+ sources -= [
|
|
|
|
+ "cocoa/remote_accessibility_api.h",
|
|
|
|
+ "cocoa/remote_accessibility_api.mm",
|
|
|
|
+ ]
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
if (is_ios) {
|
|
|
|
sources += [
|
|
|
|
"device_form_factor_ios.mm",
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -531,6 +538,12 @@ component("base") {
|
|
|
|
"//url",
|
|
|
|
]
|
|
|
|
|
|
|
|
+ if (is_mac) {
|
|
|
|
+ deps += [
|
|
|
|
+ "//electron/build/config:generate_mas_config"
|
|
|
|
+ ]
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
if (is_debug || dcheck_always_on) {
|
|
|
|
deps += [ "//third_party/re2" ]
|
|
|
|
}
|
2023-11-21 18:53:21 +00:00
|
|
|
diff --git a/ui/base/cocoa/remote_accessibility_api.h b/ui/base/cocoa/remote_accessibility_api.h
|
2024-09-17 08:38:56 +00:00
|
|
|
index 3182458838aa96d34911280ab4c6c3aa4aa22d6d..6dc85c366b7e61c8bd0302e501c3223a19223313 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/ui/base/cocoa/remote_accessibility_api.h
|
|
|
|
+++ b/ui/base/cocoa/remote_accessibility_api.h
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -10,9 +10,12 @@
|
|
|
|
#include <vector>
|
|
|
|
|
|
|
|
#include "base/component_export.h"
|
|
|
|
+#include "electron/mas.h"
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
// NSAccessibilityRemoteUIElement is a private class in AppKit.
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
+
|
|
|
|
@interface NSAccessibilityRemoteUIElement : NSObject
|
|
|
|
+ (void)setRemoteUIApp:(BOOL)flag;
|
|
|
|
+ (BOOL)isRemoteUIApp;
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -38,4 +41,6 @@ class COMPONENT_EXPORT(UI_BASE) RemoteAccessibility {
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
} // namespace ui
|
|
|
|
|
|
|
|
+#endif // MAS_BUILD
|
|
|
|
+
|
|
|
|
#endif // UI_BASE_COCOA_REMOTE_ACCESSIBILITY_API_H_
|
|
|
|
diff --git a/ui/base/cocoa/remote_layer_api.h b/ui/base/cocoa/remote_layer_api.h
|
2024-09-17 08:38:56 +00:00
|
|
|
index 59dc2f82214cfd883b6ebef3b0fb25af6387a9cd..912c5252d1b30d943a1552739b9eef9a8eae2d7a 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/ui/base/cocoa/remote_layer_api.h
|
|
|
|
+++ b/ui/base/cocoa/remote_layer_api.h
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -9,6 +9,7 @@
|
|
|
|
|
|
|
|
#include "base/component_export.h"
|
|
|
|
#include "build/build_config.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
|
|
|
|
#if defined(__OBJC__)
|
|
|
|
#import <Foundation/Foundation.h>
|
|
|
|
@@ -17,6 +18,7 @@
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
#if BUILDFLAG(IS_MAC)
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
// The CGSConnectionID is used to create the CAContext in the process that is
|
|
|
|
// going to share the CALayers that it is rendering to another process to
|
|
|
|
// display.
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -68,6 +70,8 @@ extern NSString* const kCAContextIgnoresHitTest;
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
#endif // __OBJC__
|
|
|
|
|
|
|
|
+#endif // MAS_BUILD
|
|
|
|
+
|
|
|
|
namespace ui {
|
|
|
|
|
|
|
|
// This function will check if all of the interfaces listed above are supported
|
|
|
|
diff --git a/ui/base/cocoa/remote_layer_api.mm b/ui/base/cocoa/remote_layer_api.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
index fc25ba79d2b0e1acdb7ba54b89e7d6e16f94771b..de771ef414b9a69e331261524f08e9a12145ec60 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/ui/base/cocoa/remote_layer_api.mm
|
|
|
|
+++ b/ui/base/cocoa/remote_layer_api.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -5,11 +5,13 @@
|
|
|
|
#include "ui/base/cocoa/remote_layer_api.h"
|
|
|
|
|
|
|
|
#include "base/feature_list.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
|
|
|
|
#include <objc/runtime.h>
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
namespace ui {
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
namespace {
|
|
|
|
// Control use of cross-process CALayers to display content directly from the
|
|
|
|
// GPU process on Mac.
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -17,8 +19,10 @@
|
2023-11-21 18:53:21 +00:00
|
|
|
"RemoteCoreAnimationAPI",
|
|
|
|
base::FEATURE_ENABLED_BY_DEFAULT);
|
|
|
|
} // namespace
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
bool RemoteLayerAPISupported() {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
if (!base::FeatureList::IsEnabled(kRemoteCoreAnimationAPI))
|
|
|
|
return false;
|
|
|
|
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -55,6 +59,9 @@ bool RemoteLayerAPISupported() {
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
// If everything is there, we should be able to use the API.
|
|
|
|
return true;
|
|
|
|
+#else
|
|
|
|
+ return false;
|
|
|
|
+#endif // MAS_BUILD
|
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace
|
|
|
|
diff --git a/ui/display/BUILD.gn b/ui/display/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
index 333424e572626bd9c372ed88601a1e80b45fe511..dda2e07351a11b2e43cd115b8a5a66a579f86a61 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/ui/display/BUILD.gn
|
|
|
|
+++ b/ui/display/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -130,6 +130,12 @@ component("display") {
|
|
|
|
"//ui/gfx/geometry",
|
|
|
|
]
|
|
|
|
|
|
|
|
+ if (is_mac) {
|
|
|
|
+ deps += [
|
|
|
|
+ "//electron/build/config:generate_mas_config"
|
2023-11-21 18:53:21 +00:00
|
|
|
+ ]
|
2024-09-17 08:38:56 +00:00
|
|
|
+ }
|
|
|
|
+
|
|
|
|
if (is_ios) {
|
|
|
|
deps += [ "//build:ios_buildflags" ]
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
diff --git a/ui/display/mac/screen_mac.mm b/ui/display/mac/screen_mac.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
index 35b71abc95f83bb01dba3f69e2d69a026840b7a2..6a2ff6768f16e503657cdb7ff6be7587c45842ec 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/ui/display/mac/screen_mac.mm
|
|
|
|
+++ b/ui/display/mac/screen_mac.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -30,6 +30,7 @@
|
|
|
|
#include "base/trace_event/trace_event.h"
|
|
|
|
#include "build/build_config.h"
|
|
|
|
#include "components/device_event_log/device_event_log.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#include "ui/display/display.h"
|
|
|
|
#include "ui/display/display_change_notifier.h"
|
|
|
|
#include "ui/display/util/display_util.h"
|
|
|
|
@@ -176,7 +177,17 @@ DisplayMac BuildDisplayForScreen(NSScreen* screen) {
|
2023-11-21 18:53:21 +00:00
|
|
|
display.set_color_depth(Display::kDefaultBitsPerPixel);
|
|
|
|
display.set_depth_per_component(Display::kDefaultBitsPerComponent);
|
|
|
|
}
|
|
|
|
+#if IS_MAS_BUILD()
|
|
|
|
+ // This is equivalent to the CGDisplayUsesForceToGray() API as at 2018-08-06,
|
|
|
|
+ // but avoids usage of the private API.
|
|
|
|
+ CFStringRef app = CFSTR("com.apple.CoreGraphics");
|
|
|
|
+ CFStringRef key = CFSTR("DisplayUseForcedGray");
|
|
|
|
+ Boolean key_valid = false;
|
|
|
|
+ display.set_is_monochrome(
|
|
|
|
+ CFPreferencesGetAppBooleanValue(key, app, &key_valid));
|
|
|
|
+#else
|
|
|
|
display.set_is_monochrome(CGDisplayUsesForceToGray());
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
// Query the display's refresh rate.
|
2024-08-13 19:04:43 +00:00
|
|
|
if (@available(macos 12.0, *)) {
|
2023-11-21 18:53:21 +00:00
|
|
|
diff --git a/ui/gfx/BUILD.gn b/ui/gfx/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
index 5255116a8e8f897607e5c5df2875dbaf275ec919..5b53f9175e6076158fa2b2037eb2506b768d4601 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/ui/gfx/BUILD.gn
|
|
|
|
+++ b/ui/gfx/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -333,6 +333,12 @@ component("gfx") {
|
|
|
|
"//ui/base:ui_data_pack",
|
|
|
|
]
|
|
|
|
|
|
|
|
+ if (is_mac) {
|
|
|
|
+ deps += [
|
|
|
|
+ "//electron/build/config:generate_mas_config"
|
|
|
|
+ ]
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
if (!is_apple) {
|
2023-11-21 18:53:21 +00:00
|
|
|
sources += [
|
2024-09-17 08:38:56 +00:00
|
|
|
"platform_font_skia.cc",
|
2023-11-21 18:53:21 +00:00
|
|
|
diff --git a/ui/gfx/platform_font_mac.mm b/ui/gfx/platform_font_mac.mm
|
2024-09-18 01:12:11 +00:00
|
|
|
index 3d6b05a077d283f79afe06f6c51ac69662685e96..462dada7333a0150f4585a585a2b1572ccf8e77d 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/ui/gfx/platform_font_mac.mm
|
|
|
|
+++ b/ui/gfx/platform_font_mac.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -19,6 +19,7 @@
|
|
|
|
#include "base/numerics/safe_conversions.h"
|
|
|
|
#include "base/strings/sys_string_conversions.h"
|
|
|
|
#include "base/strings/utf_string_conversions.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#include "third_party/skia/include/ports/SkTypeface_mac.h"
|
|
|
|
#include "ui/gfx/canvas.h"
|
|
|
|
#include "ui/gfx/font.h"
|
|
|
|
@@ -28,9 +29,11 @@
|
2023-11-21 18:53:21 +00:00
|
|
|
|
|
|
|
using Weight = Font::Weight;
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
extern "C" {
|
|
|
|
bool CTFontDescriptorIsSystemUIFont(CTFontDescriptorRef);
|
|
|
|
}
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
|
2024-09-18 01:12:11 +00:00
|
|
|
@@ -250,7 +253,13 @@ CTFontRef SystemFontForConstructorOfType(
|
2023-11-21 18:53:21 +00:00
|
|
|
// TODO(avi, etienneb): Figure out this font stuff.
|
|
|
|
base::apple::ScopedCFTypeRef<CTFontDescriptorRef> descriptor(
|
|
|
|
CTFontCopyFontDescriptor(font));
|
|
|
|
+#if IS_MAS_BUILD()
|
|
|
|
+ CFNumberRef priority = (CFNumberRef)CTFontDescriptorCopyAttribute(descriptor.get(), (CFStringRef)kCTFontPriorityAttribute);
|
|
|
|
+ SInt64 v;
|
|
|
|
+ if (CFNumberGetValue(priority, kCFNumberSInt64Type, &v) && v == kCTFontPrioritySystem) {
|
|
|
|
+#else
|
|
|
|
if (CTFontDescriptorIsSystemUIFont(descriptor.get())) {
|
|
|
|
+#endif
|
|
|
|
// Assume it's the standard system font. The fact that this much is known is
|
|
|
|
// enough.
|
|
|
|
return PlatformFontMac::SystemFontType::kGeneral;
|
|
|
|
diff --git a/ui/views/BUILD.gn b/ui/views/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
index b2b1a783ac0c243ef5cf573b2e73af82b432fbf9..60aee1fd81e31b2ba43ec344990588921c9393a4 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/ui/views/BUILD.gn
|
|
|
|
+++ b/ui/views/BUILD.gn
|
2024-08-21 16:34:18 +00:00
|
|
|
@@ -722,6 +722,7 @@ component("views") {
|
2023-11-21 18:53:21 +00:00
|
|
|
"IOSurface.framework",
|
|
|
|
"QuartzCore.framework",
|
|
|
|
]
|
2024-09-17 08:38:56 +00:00
|
|
|
+ deps += ["//electron/build/config:generate_mas_config"]
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (is_win) {
|
2024-08-21 16:34:18 +00:00
|
|
|
@@ -1154,6 +1155,8 @@ source_set("test_support") {
|
2024-08-12 08:28:33 +00:00
|
|
|
"//ui/base/mojom:mojom",
|
2023-11-21 18:53:21 +00:00
|
|
|
]
|
|
|
|
|
2024-09-17 08:38:56 +00:00
|
|
|
+ deps += ["//electron/build/config:generate_mas_config"]
|
2023-11-21 18:53:21 +00:00
|
|
|
+
|
|
|
|
if (is_win) {
|
|
|
|
sources += [
|
|
|
|
"test/desktop_window_tree_host_win_test_api.cc",
|
|
|
|
diff --git a/ui/views/cocoa/native_widget_mac_ns_window_host.h b/ui/views/cocoa/native_widget_mac_ns_window_host.h
|
2024-09-17 08:38:56 +00:00
|
|
|
index 9879c3456c12e2b0f0d550df1062da4a50a8e89d..61f655d78d83665af1ded11526eac7c2cc9219d1 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/ui/views/cocoa/native_widget_mac_ns_window_host.h
|
|
|
|
+++ b/ui/views/cocoa/native_widget_mac_ns_window_host.h
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -18,6 +18,7 @@
|
|
|
|
#include "components/remote_cocoa/browser/scoped_cg_window_id.h"
|
|
|
|
#include "components/remote_cocoa/common/native_widget_ns_window.mojom.h"
|
|
|
|
#include "components/remote_cocoa/common/native_widget_ns_window_host.mojom.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#include "mojo/public/cpp/bindings/associated_receiver.h"
|
|
|
|
#include "mojo/public/cpp/bindings/associated_remote.h"
|
|
|
|
#include "ui/accelerated_widget_mac/accelerated_widget_mac.h"
|
|
|
|
@@ -32,7 +33,9 @@
|
2023-11-21 18:53:21 +00:00
|
|
|
#include "ui/views/window/dialog_observer.h"
|
|
|
|
|
|
|
|
@class NativeWidgetMacNSWindow;
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
@class NSAccessibilityRemoteUIElement;
|
|
|
|
+#endif
|
|
|
|
@class NSView;
|
|
|
|
|
|
|
|
namespace remote_cocoa {
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -483,10 +486,12 @@ class VIEWS_EXPORT NativeWidgetMacNSWindowHost
|
2023-11-21 18:53:21 +00:00
|
|
|
mojo::AssociatedRemote<remote_cocoa::mojom::NativeWidgetNSWindow>
|
|
|
|
remote_ns_window_remote_;
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
// Remote accessibility objects corresponding to the NSWindow and its root
|
|
|
|
// NSView.
|
|
|
|
NSAccessibilityRemoteUIElement* __strong remote_window_accessible_;
|
|
|
|
NSAccessibilityRemoteUIElement* __strong remote_view_accessible_;
|
|
|
|
+#endif
|
|
|
|
|
|
|
|
// Used to force the NSApplication's focused accessibility element to be the
|
|
|
|
// views::Views accessibility tree when the NSView for this is focused.
|
|
|
|
diff --git a/ui/views/cocoa/native_widget_mac_ns_window_host.mm b/ui/views/cocoa/native_widget_mac_ns_window_host.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
index 8b05cee4302216bf804320abc708d69379ab4a64..7ffc934e99944d185ba14c8c73fe7c53f0b3b5da 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/ui/views/cocoa/native_widget_mac_ns_window_host.mm
|
|
|
|
+++ b/ui/views/cocoa/native_widget_mac_ns_window_host.mm
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -21,6 +21,7 @@
|
|
|
|
#include "components/remote_cocoa/app_shim/native_widget_ns_window_bridge.h"
|
|
|
|
#include "components/remote_cocoa/browser/ns_view_ids.h"
|
|
|
|
#include "components/remote_cocoa/browser/window.h"
|
|
|
|
+#include "electron/mas.h"
|
|
|
|
#include "mojo/public/cpp/bindings/self_owned_associated_receiver.h"
|
|
|
|
#include "ui/accelerated_widget_mac/window_resize_helper_mac.h"
|
|
|
|
#include "ui/accessibility/accessibility_features.h"
|
|
|
|
@@ -349,7 +350,11 @@ void HandleAccelerator(const ui::Accelerator& accelerator,
|
2023-11-21 18:53:21 +00:00
|
|
|
NativeWidgetMacNSWindowHost::GetNativeViewAccessibleForNSView() const {
|
|
|
|
if (in_process_ns_window_bridge_)
|
|
|
|
return in_process_ns_window_bridge_->ns_view();
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
return remote_view_accessible_;
|
|
|
|
+#else
|
|
|
|
+ return nullptr;
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
gfx::NativeViewAccessible
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -364,7 +369,11 @@ void HandleAccelerator(const ui::Accelerator& accelerator,
|
2023-11-21 18:53:21 +00:00
|
|
|
return [in_process_ns_window_bridge_->ns_view() window];
|
|
|
|
}
|
|
|
|
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
return remote_window_accessible_;
|
|
|
|
+#else
|
|
|
|
+ return nullptr;
|
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
remote_cocoa::mojom::NativeWidgetNSWindow*
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -1333,9 +1342,11 @@ void HandleAccelerator(const ui::Accelerator& accelerator,
|
2024-04-15 22:10:32 +00:00
|
|
|
// for PWAs. However this breaks accessibility on in-process windows,
|
|
|
|
// so set it back to NO when a local window gains focus. See
|
|
|
|
// https://crbug.com/41485830.
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
if (is_key && features::IsAccessibilityRemoteUIAppEnabled()) {
|
|
|
|
[NSAccessibilityRemoteUIElement setRemoteUIApp:!!application_host_];
|
|
|
|
}
|
|
|
|
+#endif
|
|
|
|
// Explicitly set the keyboard accessibility state on regaining key
|
|
|
|
// window status.
|
|
|
|
if (is_key && is_content_first_responder)
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -1473,17 +1484,20 @@ void HandleAccelerator(const ui::Accelerator& accelerator,
|
2023-11-21 18:53:21 +00:00
|
|
|
void NativeWidgetMacNSWindowHost::SetRemoteAccessibilityTokens(
|
|
|
|
const std::vector<uint8_t>& window_token,
|
|
|
|
const std::vector<uint8_t>& view_token) {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
remote_window_accessible_ =
|
|
|
|
ui::RemoteAccessibility::GetRemoteElementFromToken(window_token);
|
|
|
|
remote_view_accessible_ =
|
2024-04-15 22:10:32 +00:00
|
|
|
ui::RemoteAccessibility::GetRemoteElementFromToken(view_token);
|
|
|
|
[remote_view_accessible_ setWindowUIElement:remote_window_accessible_];
|
|
|
|
[remote_view_accessible_ setTopLevelUIElement:remote_window_accessible_];
|
2023-11-21 18:53:21 +00:00
|
|
|
+#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
bool NativeWidgetMacNSWindowHost::GetRootViewAccessibilityToken(
|
2024-02-29 09:31:13 +00:00
|
|
|
base::ProcessId* pid,
|
2023-11-21 18:53:21 +00:00
|
|
|
std::vector<uint8_t>* token) {
|
|
|
|
+#if !IS_MAS_BUILD()
|
|
|
|
*pid = getpid();
|
|
|
|
id element_id = GetNativeViewAccessible();
|
|
|
|
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -1496,6 +1510,7 @@ void HandleAccelerator(const ui::Accelerator& accelerator,
|
2023-11-21 18:53:21 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
*token = ui::RemoteAccessibility::GetTokenForLocalElement(element_id);
|
|
|
|
+#endif
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
diff --git a/ui/views/controls/webview/BUILD.gn b/ui/views/controls/webview/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
index 111d6432586f47833dde50678b908c76ad88d37a..429ca4402652a2d89ead228d92971f0cb3b6222c 100644
|
2023-11-21 18:53:21 +00:00
|
|
|
--- a/ui/views/controls/webview/BUILD.gn
|
|
|
|
+++ b/ui/views/controls/webview/BUILD.gn
|
2024-09-17 08:38:56 +00:00
|
|
|
@@ -46,6 +46,12 @@ component("webview") {
|
|
|
|
"//url",
|
|
|
|
]
|
2023-11-21 18:53:21 +00:00
|
|
|
|
2024-09-17 08:38:56 +00:00
|
|
|
+ if (is_mac) {
|
|
|
|
+ deps += [
|
|
|
|
+ "//electron/build/config:generate_mas_config",
|
2023-11-21 18:53:21 +00:00
|
|
|
+ ]
|
2024-09-17 08:38:56 +00:00
|
|
|
+ }
|
|
|
|
+
|
|
|
|
public_deps = [
|
|
|
|
"//base",
|
|
|
|
"//content/public/browser",
|