2019-08-29 07:17:44 +00:00
|
|
|
import { expect } from 'chai'
|
|
|
|
import * as ChildProcess from 'child_process'
|
|
|
|
import * as path from 'path'
|
|
|
|
import { emittedOnce } from './events-helpers'
|
|
|
|
import { closeWindow } from './window-helpers'
|
2018-05-18 07:36:43 +00:00
|
|
|
|
2019-08-29 07:17:44 +00:00
|
|
|
import { webContents, TopLevelWindow, WebContentsView } from 'electron'
|
2018-05-18 07:36:43 +00:00
|
|
|
|
|
|
|
describe('WebContentsView', () => {
|
2019-08-29 07:17:44 +00:00
|
|
|
let w: TopLevelWindow
|
|
|
|
afterEach(() => closeWindow(w as any).then(() => { w = null as unknown as TopLevelWindow }))
|
2018-05-18 07:36:43 +00:00
|
|
|
|
|
|
|
it('can be used as content view', () => {
|
2019-08-29 07:17:44 +00:00
|
|
|
const web = (webContents as any).create({})
|
2018-09-13 16:10:51 +00:00
|
|
|
w = new TopLevelWindow({ show: false })
|
2018-05-18 07:36:43 +00:00
|
|
|
w.setContentView(new WebContentsView(web))
|
|
|
|
})
|
|
|
|
|
|
|
|
it('prevents adding same WebContents', () => {
|
2019-08-29 07:17:44 +00:00
|
|
|
const web = (webContents as any).create({})
|
2018-09-13 16:10:51 +00:00
|
|
|
w = new TopLevelWindow({ show: false })
|
2018-05-18 07:36:43 +00:00
|
|
|
w.setContentView(new WebContentsView(web))
|
2019-05-20 17:04:18 +00:00
|
|
|
expect(() => {
|
2018-05-18 07:36:43 +00:00
|
|
|
w.setContentView(new WebContentsView(web))
|
2019-05-20 17:04:18 +00:00
|
|
|
}).to.throw('The WebContents has already been added to a View')
|
2018-05-18 07:36:43 +00:00
|
|
|
})
|
2018-11-08 15:57:28 +00:00
|
|
|
|
|
|
|
describe('new WebContentsView()', () => {
|
|
|
|
it('does not crash on exit', async () => {
|
|
|
|
const appPath = path.join(__dirname, 'fixtures', 'api', 'leak-exit-webcontentsview.js')
|
2019-08-29 07:17:44 +00:00
|
|
|
const electronPath = process.execPath
|
2020-02-06 16:15:55 +00:00
|
|
|
const appProcess = ChildProcess.spawn(electronPath, ['--enable-logging', appPath])
|
|
|
|
let output = ''
|
|
|
|
appProcess.stdout.on('data', data => { output += data })
|
|
|
|
appProcess.stderr.on('data', data => { output += data })
|
2020-01-27 01:29:50 +00:00
|
|
|
const [code] = await emittedOnce(appProcess, 'exit')
|
2020-02-06 16:15:55 +00:00
|
|
|
if (code !== 0) {
|
|
|
|
console.log(code, output)
|
|
|
|
}
|
2018-11-08 15:57:28 +00:00
|
|
|
expect(code).to.equal(0)
|
|
|
|
})
|
|
|
|
})
|
2020-03-13 17:33:37 +00:00
|
|
|
|
|
|
|
function triggerGCByAllocation () {
|
|
|
|
const arr = []
|
|
|
|
for (let i = 0; i < 1000000; i++) {
|
|
|
|
arr.push([])
|
|
|
|
}
|
|
|
|
return arr
|
|
|
|
}
|
|
|
|
|
|
|
|
it(`doesn't crash when GCed during allocation`, (done) => {
|
|
|
|
const web = (webContents as any).create({})
|
|
|
|
// eslint-disable-next-line no-new
|
|
|
|
new WebContentsView(web)
|
|
|
|
setTimeout(() => {
|
|
|
|
// NB. the crash we're testing for is the lack of a current `v8::Context`
|
|
|
|
// when emitting an event in WebContents's destructor. V8 is inconsistent
|
|
|
|
// about whether or not there's a current context during garbage
|
|
|
|
// collection, and it seems that `v8Util.requestGarbageCollectionForTesting`
|
|
|
|
// causes a GC in which there _is_ a current context, so the crash isn't
|
|
|
|
// triggered. Thus, we force a GC by other means: namely, by allocating a
|
|
|
|
// bunch of stuff.
|
|
|
|
triggerGCByAllocation()
|
|
|
|
done()
|
|
|
|
})
|
|
|
|
})
|
2018-05-18 07:36:43 +00:00
|
|
|
})
|