2018-10-24 11:24:11 -07:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
2018-09-20 17:30:26 -07:00
|
|
|
From: Jeremy Apthorp <nornagon@nornagon.net>
|
|
|
|
|
Date: Thu, 20 Sep 2018 17:48:59 -0700
|
|
|
|
|
Subject: resource_file_conflict.patch
|
|
|
|
|
|
|
|
|
|
Resolve conflict between //chrome's .pak files and //electron's. The paths
|
|
|
|
|
that chrome code hardcodes require that we generate resources at these
|
|
|
|
|
paths, but GN throws errors if there are multiple targets that generate the
|
|
|
|
|
same files.
|
|
|
|
|
|
2018-11-07 07:11:01 -08:00
|
|
|
This is due to the hardcoded names here:
|
|
|
|
|
https://chromium.googlesource.com/chromium/src/+/69.0.3497.106/ui/base/resource/resource_bundle.cc#780
|
|
|
|
|
and here:
|
|
|
|
|
https://chromium.googlesource.com/chromium/src/+/69.0.3497.106/ui/base/resource/resource_bundle_mac.mm#50
|
|
|
|
|
|
|
|
|
|
This isn't needed on Mac because resource files are copied into the app bundle,
|
|
|
|
|
and are built in `$root_out_dir/electron_repack` (while Chromium's resources
|
|
|
|
|
target `$root_out_dir/repack`), but on Windows and Linux, the resource files go
|
|
|
|
|
directly in `$root_out_dir`, and so they conflict.
|
|
|
|
|
|
|
|
|
|
We don't actually ever generate Chromium's resource paks, but without this
|
|
|
|
|
patch, GN refuses to generate the ninja files:
|
|
|
|
|
|
|
|
|
|
ERROR at //tools/grit/repack.gni:35:3: Duplicate output file.
|
|
|
|
|
action(_repack_target_name) {
|
|
|
|
|
^----------------------------
|
|
|
|
|
Two or more targets generate the same output:
|
|
|
|
|
chrome_100_percent.pak
|
|
|
|
|
|
|
|
|
|
This is can often be fixed by changing one of the target names, or by
|
|
|
|
|
setting an output_name on one of them.
|
|
|
|
|
|
|
|
|
|
Collisions:
|
|
|
|
|
//chrome:packed_resources_100_percent
|
|
|
|
|
//electron:packed_resources_100_percent
|
|
|
|
|
|
|
|
|
|
See //tools/grit/repack.gni:35:3: Collision.
|
|
|
|
|
action(_repack_target_name) {
|
|
|
|
|
^----------------------------
|
|
|
|
|
|
|
|
|
|
Some alternatives to this patch:
|
|
|
|
|
|
|
|
|
|
1. Refactor upstream in such a way that the "chrome" pak names were
|
|
|
|
|
configurable, for instance by adding a method to ResourceBundle::Delegate that
|
|
|
|
|
LoadChromeResources would check.
|
|
|
|
|
2. Pass a Delegate that overrides `GetPathForResourcePack`, check for the
|
|
|
|
|
`chrome_{100,200}_percent.pak` filenames, and rewrite them to
|
|
|
|
|
`electron_{100,200}_percent.pak`.
|
|
|
|
|
3. Initialize the resource bundle with DO_NOT_LOAD_COMMON_RESOURCES and load
|
|
|
|
|
the paks ourselves.
|
2019-01-12 06:30:43 +05:30
|
|
|
|
2018-11-07 07:11:01 -08:00
|
|
|
None of these options seems like a substantial maintainability win over this patch to me (@nornagon).
|
|
|
|
|
|
2018-09-13 22:02:16 -07:00
|
|
|
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
|
2025-08-05 21:45:37 -04:00
|
|
|
index 84fea80c038c44333d3bf6553d0ef1d6c3920357..3713bfab32418551a569a1ce306ba59525c6fa99 100644
|
2018-09-13 22:02:16 -07:00
|
|
|
--- a/chrome/BUILD.gn
|
|
|
|
|
+++ b/chrome/BUILD.gn
|
2025-07-21 11:55:08 -07:00
|
|
|
@@ -1539,7 +1539,7 @@ if (is_chrome_branded && !is_android) {
|
2019-01-08 15:59:47 -08:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
-if (!is_android) {
|
|
|
|
|
+if (!is_android && !is_electron_build) {
|
|
|
|
|
chrome_paks("packed_resources") {
|
|
|
|
|
if (is_mac) {
|
|
|
|
|
output_dir = "$root_gen_dir/repack"
|
2025-07-21 11:55:08 -07:00
|
|
|
@@ -1585,6 +1585,12 @@ repack("browser_tests_pak") {
|
2025-02-21 14:46:51 -08:00
|
|
|
deps = [ "//chrome/test/data/webui:resources" ]
|
2018-09-13 22:02:16 -07:00
|
|
|
}
|
|
|
|
|
|
2018-09-15 17:10:18 +05:30
|
|
|
+if (is_electron_build) {
|
2018-09-13 22:02:16 -07:00
|
|
|
+ group("packed_resources") {
|
|
|
|
|
+ public_deps = [ "//electron:packed_resources" ]
|
|
|
|
|
+ }
|
|
|
|
|
+}
|
2019-01-08 15:59:47 -08:00
|
|
|
+
|
2025-02-21 14:46:51 -08:00
|
|
|
group("strings") {
|
|
|
|
|
public_deps = [
|
|
|
|
|
"//chrome/app:branded_strings",
|
