2018-10-24 18:24:11 +00:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
2018-09-21 00:30:26 +00:00
|
|
|
From: Cheng Zhao <zcbenz@gmail.com>
|
|
|
|
Date: Thu, 20 Sep 2018 17:45:03 -0700
|
|
|
|
Subject: blink_local_frame.patch
|
|
|
|
|
|
|
|
According to electron/electron#3699, it is unreliable to use |unload|
|
|
|
|
event for process.exit('exit'), so we have to do that in
|
|
|
|
willReleaseScriptContext.
|
|
|
|
|
2021-01-12 23:31:23 +00:00
|
|
|
Refs changes in:
|
|
|
|
* https://codereview.chromium.org/1657583002
|
|
|
|
* https://chromium-review.googlesource.com/c/chromium/src/+/2596880
|
|
|
|
* https://chromium-review.googlesource.com/c/chromium/src/+/2597169
|
2018-09-21 00:30:26 +00:00
|
|
|
|
2021-01-12 23:31:23 +00:00
|
|
|
This patch reverts the changes to fix associated crashes in Electron.
|
2018-09-21 00:30:26 +00:00
|
|
|
|
2021-01-12 23:31:23 +00:00
|
|
|
diff --git a/third_party/blink/renderer/core/frame/frame.cc b/third_party/blink/renderer/core/frame/frame.cc
|
2024-02-14 17:33:32 +00:00
|
|
|
index 2432d2dba67540f8cdd8e5466a813693ff2d6683..ed9863e6a9870f45b2f688b1a9228c176d498307 100644
|
2021-01-12 23:31:23 +00:00
|
|
|
--- a/third_party/blink/renderer/core/frame/frame.cc
|
|
|
|
+++ b/third_party/blink/renderer/core/frame/frame.cc
|
2023-03-20 11:06:57 +00:00
|
|
|
@@ -125,14 +125,6 @@ bool Frame::Detach(FrameDetachType type) {
|
2021-01-12 23:31:23 +00:00
|
|
|
|
|
|
|
DCHECK(!IsDetached());
|
|
|
|
|
|
|
|
- // TODO(dcheng): FocusController::FrameDetached() *should* fire JS events,
|
|
|
|
- // hence the above check for `client_` being null. However, when this was
|
|
|
|
- // previously placed before the `FrameDetached()` call, nothing crashes, which
|
|
|
|
- // is suspicious. Investigate if we really don't need to fire JS events--and
|
|
|
|
- // if we don't, move `forbid_scripts` up to be instantiated sooner and
|
|
|
|
- // simplify this code.
|
|
|
|
- ScriptForbiddenScope forbid_scripts;
|
|
|
|
-
|
|
|
|
if (type == FrameDetachType::kRemove) {
|
|
|
|
if (provisional_frame_) {
|
|
|
|
provisional_frame_->Detach(FrameDetachType::kRemove);
|
2023-03-20 11:06:57 +00:00
|
|
|
@@ -156,6 +148,14 @@ bool Frame::Detach(FrameDetachType type) {
|
2021-01-12 23:31:23 +00:00
|
|
|
GetWindowProxyManager()->ClearForSwap();
|
|
|
|
}
|
|
|
|
|
|
|
|
+ // TODO(dcheng): FocusController::FrameDetached() *should* fire JS events,
|
|
|
|
+ // hence the above check for `client_` being null. However, when this was
|
|
|
|
+ // previously placed before the `FrameDetached()` call, nothing crashes, which
|
|
|
|
+ // is suspicious. Investigate if we really don't need to fire JS events--and
|
|
|
|
+ // if we don't, move `forbid_scripts` up to be instantiated sooner and
|
|
|
|
+ // simplify this code.
|
|
|
|
+ ScriptForbiddenScope forbid_scripts;
|
|
|
|
+
|
|
|
|
// After this, we must no longer talk to the client since this clears
|
|
|
|
// its owning reference back to our owning LocalFrame.
|
|
|
|
client_->Detached(type);
|
2018-09-14 05:02:16 +00:00
|
|
|
diff --git a/third_party/blink/renderer/core/frame/local_frame.cc b/third_party/blink/renderer/core/frame/local_frame.cc
|
2024-03-05 16:47:48 +00:00
|
|
|
index d7fc8c4b7edea486e1aff43287bb5ae6be168868..bf57ea36b37c5cb9441b2b62ae3ac020c297b495 100644
|
2018-09-14 05:02:16 +00:00
|
|
|
--- a/third_party/blink/renderer/core/frame/local_frame.cc
|
|
|
|
+++ b/third_party/blink/renderer/core/frame/local_frame.cc
|
2024-03-05 16:47:48 +00:00
|
|
|
@@ -683,10 +683,6 @@ bool LocalFrame::DetachImpl(FrameDetachType type) {
|
2018-09-14 05:02:16 +00:00
|
|
|
}
|
2020-09-21 08:00:36 +00:00
|
|
|
DCHECK(!view_ || !view_->IsAttached());
|
2018-09-14 05:02:16 +00:00
|
|
|
|
|
|
|
- // This is the earliest that scripting can be disabled:
|
|
|
|
- // - FrameLoader::Detach() can fire XHR abort events
|
|
|
|
- // - Document::Shutdown() can dispose plugins which can run script.
|
|
|
|
- ScriptForbiddenScope forbid_script;
|
|
|
|
if (!Client())
|
2021-01-12 23:31:23 +00:00
|
|
|
return false;
|
|
|
|
|
2024-03-05 16:47:48 +00:00
|
|
|
@@ -734,6 +730,11 @@ bool LocalFrame::DetachImpl(FrameDetachType type) {
|
2021-01-12 23:31:23 +00:00
|
|
|
DCHECK(!view_->IsAttached());
|
|
|
|
Client()->WillBeDetached();
|
2018-09-14 05:02:16 +00:00
|
|
|
|
|
|
|
+ // This is the earliest that scripting can be disabled:
|
|
|
|
+ // - FrameLoader::Detach() can fire XHR abort events
|
|
|
|
+ // - Document::Shutdown() can dispose plugins which can run script.
|
|
|
|
+ ScriptForbiddenScope forbid_script;
|
2021-01-12 23:31:23 +00:00
|
|
|
+
|
2018-09-14 05:02:16 +00:00
|
|
|
// TODO(crbug.com/729196): Trace why LocalFrameView::DetachFromLayout crashes.
|
|
|
|
CHECK(!view_->IsAttached());
|
2021-01-12 23:31:23 +00:00
|
|
|
SetView(nullptr);
|