mirrors/dotnet-installer
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions
dotnet-installer/test
History
Peter Huene f9b939fe89
Fix MSBuild invocation to quote property option values. 
This commit ensures that any `/property` option's value is surrounded by quotes
to allow MSBuild to properly interpret special characters like semicolons.

Users familiar with MSBuild expect `/property:Name="Value"` to handle
semicolons. However, since `dotnet` parses the command line first, the
quotes get processed by its command line parser.  This results in
`/property:Name=Value` being passed to MSBuild, which will not parse a "Value"
containing a semicolon correctly.

Since it is safe to always quote the property value for this option, this fix
simply ensures that the value is surrounded by quotes.

This fixes the issue for all commands that forward arguments to MSBuild.

Fixes #7791.
2018-04-26 14:38:21 -07:00
..
ArgumentForwardingTests Merge remote-tracking branch 'dotnet/release/15.5' into merges/release/15.5-to-master-20171206-080040 2017-12-07 09:55:12 -08:00
ArgumentsReflector Merge remote-tracking branch 'dotnet/release/15.5' into merges/release/15.5-to-master-20171206-080040 2017-12-07 09:55:12 -08:00
binding-redirects.Tests Merge remote-tracking branch 'dotnet/release/15.5' into merges/release/15.5-to-master-20171206-080040 2017-12-07 09:55:12 -08:00
crossgen.Tests Merge remote-tracking branch 'dotnet/release/15.5' into merges/release/15.5-to-master-20171206-080040 2017-12-07 09:55:12 -08:00
dotnet-add-package.Tests Merge remote-tracking branch 'dotnet/release/15.5' into merges/release/15.5-to-master-20171206-080040 2017-12-07 09:55:12 -08:00
dotnet-add-reference.Tests Add support for accepting directories to add and remove reference commands. 2017-12-07 17:23:31 -08:00
dotnet-back-compat.Tests Merge remote-tracking branch 'dotnet/release/15.5' into merges/release/15.5-to-master-20171206-080040 2017-12-07 09:55:12 -08:00
dotnet-build.Tests Adds Microsoft.Docker.Sdk to CLI 2018-01-17 11:12:19 -08:00
dotnet-clean.Tests Merge remote-tracking branch 'dotnet/release/15.5' into merges/release/15.5-to-master-20171206-080040 2017-12-07 09:55:12 -08:00
dotnet-help.Tests Better help text on dotnet tool 2018-04-16 10:51:43 -07:00
dotnet-install-tool.Tests Change command order for tools (#8862) 2018-03-21 19:12:32 -07:00
dotnet-list-reference.Tests Change command order for tools (#8862) 2018-03-21 19:12:32 -07:00
dotnet-migrate.Tests Fix project type GUIDs when adding projects to solution files. 2018-03-22 21:32:39 -07:00
dotnet-msbuild.Tests Fix MSBuild invocation to quote property option values. 2018-04-26 14:38:21 -07:00
dotnet-new.Tests Re-activate templating test. 2018-03-12 13:16:45 -07:00
dotnet-nuget.UnitTests Merge remote-tracking branch 'dotnet/release/15.5' into merges/release/15.5-to-master-20171206-080040 2017-12-07 09:55:12 -08:00
dotnet-pack.Tests Merge remote-tracking branch 'dotnet/release/15.5' into merges/release/15.5-to-master-20171206-080040 2017-12-07 09:55:12 -08:00
dotnet-publish.Tests Add test cases per PR feedback 2018-04-05 17:58:38 -07:00
dotnet-remove-package.Tests Merge remote-tracking branch 'dotnet/release/15.5' into merges/release/15.5-to-master-20171206-080040 2017-12-07 09:55:12 -08:00
dotnet-remove-reference.Tests Add support for accepting directories to add and remove reference commands. 2017-12-07 17:23:31 -08:00
dotnet-restore.Tests Merge remote-tracking branch 'dotnet/release/15.5' into merges/release/15.5-to-master-20171206-080040 2017-12-07 09:55:12 -08:00
dotnet-run.Tests Try shorter test names 2018-03-23 10:30:47 -07:00
dotnet-sln-add.Tests Fix project type GUIDs when adding projects to solution files. 2018-03-22 21:32:39 -07:00
dotnet-sln-list.Tests Merge remote-tracking branch 'dotnet/release/15.5' into merges/release/15.5-to-master-20171206-080040 2017-12-07 09:55:12 -08:00
dotnet-sln-remove.Tests Write UTF-8 BOM for solution files. 2017-12-08 14:34:26 -08:00
dotnet-store.Tests Merge remote-tracking branch 'dotnet/release/15.5' into merges/release/15.5-to-master-20171206-080040 2017-12-07 09:55:12 -08:00
dotnet-test.Tests Merge remote-tracking branch 'dotnet/release/15.5' into merges/release/15.5-to-master-20171206-080040 2017-12-07 09:55:12 -08:00
dotnet-vstest.Tests Merge remote-tracking branch 'dotnet/release/15.5' into merges/release/15.5-to-master-20171206-080040 2017-12-07 09:55:12 -08:00
dotnet.Tests Merge pull request #9079 from wli3/help-text-02 2018-04-17 12:21:39 -07:00
EndToEnd Add latest patch versions to BundledVersions.props, and tests to make sure that they are up to date 2018-03-30 11:32:36 -07:00
InsertionTests bundled DotnetTool (#8606) 2018-02-16 13:32:29 -08:00
Installer Move some projects to netstandard2.0 (#8692) 2018-02-27 13:59:59 -08:00
Microsoft.DotNet.Cli.Sln.Internal.Tests Merge remote-tracking branch 'dotnet/release/15.5' into merges/release/15.5-to-master-20171206-080040 2017-12-07 09:55:12 -08:00
Microsoft.DotNet.Cli.Utils.Tests Add TryGetMostFitRuntimeIdentifier (#8997) 2018-04-06 17:39:58 -07:00
Microsoft.DotNet.Configurer.UnitTests consume bring your own shim(byos) (#9018) 2018-04-10 15:42:50 -07:00
Microsoft.DotNet.MSBuildSdkResolver.Tests Removing left over comment. 2018-03-13 10:19:44 -07:00
Microsoft.DotNet.ShellShim.Tests consume bring your own shim(byos) (#9018) 2018-04-10 15:42:50 -07:00
Microsoft.DotNet.TestFramework Move some projects to netstandard2.0 (#8692) 2018-02-27 13:59:59 -08:00
Microsoft.DotNet.ToolPackage.Tests consume bring your own shim(byos) (#9018) 2018-04-10 15:42:50 -07:00
Microsoft.DotNet.Tools.Tests.ComponentMocks consume bring your own shim(byos) (#9018) 2018-04-10 15:42:50 -07:00
Microsoft.DotNet.Tools.Tests.Utilities consume bring your own shim(byos) (#9018) 2018-04-10 15:42:50 -07:00
msbuild.IntegrationTests Make the default verbosity for dotnet clean normal. This way we can get some meaningful output out of the command. 2018-03-01 14:09:06 -08:00
Msbuild.Tests.Utilities Merge remote-tracking branch 'dotnet/release/15.5' into merges/release/15.5-to-master-20171206-080040 2017-12-07 09:55:12 -08:00
MsBuildScript.Tests Fixing the URLs for the msbuildscript.tests to use the new asp.net runtime folder as well. 2018-02-15 12:58:21 -08:00
Directory.Build.props Support new artifacts layout in tests and other build logic 2017-08-24 15:49:13 -07:00
Microsoft.DotNet.Cli.Tests.sln bundled DotnetTool (#8606) 2018-02-16 13:32:29 -08:00