d693228ff8
Noticed in https://github.com/dotnet/installer/pull/18409 that errors aren't propagated which resulted in builds not to fail.
The fix here is to use `OnError` in the correct target (but only when using the minimal console log feature) and not set `IgnoreStandardErrorWarningFormat=true` on the Exec task that invokes the repo build script.
I also cleaned targets up as those introduced unnecessary complexity and logged in cases when they shouldn't (i.e. in dotnet.proj or package-source-build.proj).
This affected runtime which errors after 30s of building because of RuntimeOS and BaseOS being passed in in-correctly. Regressed with cca2b7bede (diff-86602308e6bb519266bc2f224ea65e39589d273804d40ad0f9c6e0eea2a263dc). Fixed that in runtime.proj. Kudos to Alexander who made the fix. I just copied it in form his CI PR.
30 lines
1.3 KiB
XML
30 lines
1.3 KiB
XML
<Project Sdk="Microsoft.NET.Sdk">
|
|
|
|
<PropertyGroup>
|
|
<LogVerbosityOptOut>true</LogVerbosityOptOut>
|
|
|
|
<BuildArgs>$(BuildArgs) /p:PackageProjectUrl=https://github.com/dotnet/sdk</BuildArgs>
|
|
<BuildArgs>$(BuildArgs) /p:PortableRid=$(PortableRid)</BuildArgs>
|
|
<BuildArgs>$(BuildArgs) /p:TargetRid=$(TargetRid)</BuildArgs>
|
|
|
|
<!-- Just like mono, arm does not support NativeAot -->
|
|
<BuildArgs Condition="'$(BuildArchitecture)' == 'arm'">$(BuildArgs) /p:NativeAotSupported=false</BuildArgs>
|
|
<BuildArgs>$(BuildArgs) $(FlagParameterPrefix)v $(LogVerbosity)</BuildArgs>
|
|
</PropertyGroup>
|
|
|
|
<ItemGroup>
|
|
<RepositoryReference Include="arcade" />
|
|
<RepositoryReference Include="runtime" />
|
|
<RepositoryReference Include="msbuild" />
|
|
<RepositoryReference Include="source-build-externals" Condition="'$(DotNetBuildSourceOnly)' == 'true'" />
|
|
<RepositoryReference Include="nuget-client" />
|
|
<RepositoryReference Include="roslyn-analyzers" />
|
|
<RepositoryReference Include="vstest" />
|
|
<RepositoryReference Include="fsharp" />
|
|
<RepositoryReference Include="format" />
|
|
<RepositoryReference Include="deployment-tools" />
|
|
<RepositoryReference Include="razor" />
|
|
<RepositoryReference Include="windowsdesktop" Condition="'$(TargetOS)' == 'windows'" />
|
|
</ItemGroup>
|
|
|
|
</Project>
|