63a6ed35e1
Fixes: https://github.com/dotnet/source-build/issues/4344 https://github.com/dotnet/runtime/pull/100595 introduced two issues: - Lower MSBuild version dependency - 17.8.3, instead of 17.8.5. This caused transitive package downgrade errors. - Source-build dependency for MSBuild, in runtime repo. This caused downgrade of MSBuild repo in VMR, from 17.8.5 to 17.8.3. Besides removing direct package references, the fix is to add a direct MSBuild source-build dependency in `installer` repo. I'm also adding the missing MSBuild dependencies to runtime, for proper PVP flow. Without the explicit dependencies, my validation build was hitting an issue with `Microsoft.Build.Framework` package downgrade in `src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks.csproj`: ``` /vmr/src/runtime/artifacts/source-build/self/src/src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks.csproj : error NU1605: Warning As Error: Detected package downgrade: Microsoft.Build.Framework from 17.8.5 to 17.8.3. Reference the package directly from the project to select a different version. [/vmr/src/runtime/artifacts/source-build/self/src/Build.proj] /vmr/src/runtime/artifacts/source-build/self/src/src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks.csproj : error NU1605: Microsoft.NET.Sdk.WebAssembly.Pack.Tasks -> Microsoft.Build 17.8.5 -> Microsoft.Build.Framework (>= 17.8.5) [/vmr/src/runtime/artifacts/source-build/self/src/Build.proj] /vmr/src/runtime/artifacts/source-build/self/src/src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks.csproj : error NU1605: Microsoft.NET.Sdk.WebAssembly.Pack.Tasks -> Microsoft.Build.Framework (>= 17.8.3) [/vmr/src/runtime/artifacts/source-build/self/src/Build.proj] ``` Fully validated with an internal pipeline run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2436369&view=results |
||
---|---|---|
.. | ||
BuildConfiguration | ||
common | ||
loc | ||
pipelines | ||
_prettyprint.sh | ||
AfterSigning.targets | ||
build-pr.yml | ||
Build.props | ||
build.yml | ||
configure-toolset.ps1 | ||
configure-toolset.sh | ||
CopyToLatest.cmd | ||
core-sdk-build-env.sh | ||
core-sdk-test-env.bat | ||
core-sdk-test-env.sh | ||
install-scancode.sh | ||
Key.snk | ||
localization.yml | ||
ManualVersions.props | ||
native.proj | ||
Publishing.props | ||
restore-toolset.ps1 | ||
restore-toolset.sh | ||
sdl-tsa-vars.config | ||
SignCheckExclusionsFile.txt | ||
Signing.props | ||
SourceBuild.props | ||
SourceBuildPrebuiltBaseline.xml | ||
TestVersions.props | ||
version.csproj | ||
Version.Details.xml | ||
Versions.props | ||
vmr-sync.sh |