4b82852d56
* Updating the version of msbuild to 15.1.0-preview-000516-03 * Remove test that assumes props/targets imports The test ItAddsRefBetweenImports validated that the MSBuild XML model contained new project references between the props and targets imports. While useful be fore the SDK attribute, the test no longer adds value since the SDK is added implicitly, guaranteeing it wraps the remaining project contents. * Move MSBuild to 15.1.0-preview-000509-03 This is the last msbuild version prior to the change of MSBuild's dependencies to include .NET 1.1 components. * Move MSBuild invocations to use dirs.props/dirs.tasks * Put back the test targets. We'll unify later. * Remove dirs.props props from templates msbuild invocation
684 lines
31 KiB
C#
684 lines
31 KiB
C#
// Copyright (c) .NET Foundation and contributors. All rights reserved.
|
|
// Licensed under the MIT license. See LICENSE file in the project root for full license information.
|
|
|
|
using FluentAssertions;
|
|
using Microsoft.Build.Construction;
|
|
using Microsoft.DotNet.Tools.Test.Utilities;
|
|
using Msbuild.Tests.Utilities;
|
|
using System;
|
|
using System.IO;
|
|
using System.Linq;
|
|
using Xunit;
|
|
|
|
namespace Microsoft.DotNet.Cli.Add.Reference.Tests
|
|
{
|
|
public class GivenDotnetAddReference : TestBase
|
|
{
|
|
private const string HelpText = @".NET Add Project to Project reference Command
|
|
|
|
Usage: dotnet add <PROJECT> reference [options] [args]
|
|
|
|
Arguments:
|
|
<PROJECT> The project file to operate on. If a file is not specified, the command will search the current directory for one.
|
|
|
|
Options:
|
|
-h|--help Show help information
|
|
-f|--framework <FRAMEWORK> Add reference only when targetting a specific framework
|
|
|
|
Additional Arguments:
|
|
Project to project references to add
|
|
";
|
|
|
|
const string FrameworkNet451Arg = "-f net451";
|
|
const string ConditionFrameworkNet451 = "== 'net451'";
|
|
const string FrameworkNetCoreApp10Arg = "-f netcoreapp1.0";
|
|
const string ConditionFrameworkNetCoreApp10 = "== 'netcoreapp1.0'";
|
|
const string ProjectNotCompatibleErrorMessageRegEx = "Project `[^`]*` cannot be added due to incompatible targeted frameworks between the two projects\\. Please review the project you are trying to add and verify that is compatible with the following targets\\:";
|
|
const string ProjectDoesNotTargetFrameworkErrorMessageRegEx = "Project `[^`]*` does not target framework `[^`]*`.";
|
|
static readonly string[] DefaultFrameworks = new string[] { "netcoreapp1.0", "net451" };
|
|
|
|
private TestSetup Setup([System.Runtime.CompilerServices.CallerMemberName] string callingMethod = nameof(Setup), string identifier = "")
|
|
{
|
|
return new TestSetup(
|
|
TestAssets.Get(TestSetup.TestGroup, TestSetup.ProjectName)
|
|
.CreateInstance(callingMethod: callingMethod, identifier: identifier)
|
|
.WithSourceFiles()
|
|
.Root
|
|
.FullName);
|
|
}
|
|
|
|
private ProjDir NewDir([System.Runtime.CompilerServices.CallerMemberName] string callingMethod = nameof(NewDir), string identifier = "")
|
|
{
|
|
return new ProjDir(TestAssetsManager.CreateTestDirectory(callingMethod: callingMethod, identifier: identifier).Path);
|
|
}
|
|
|
|
private ProjDir NewLib([System.Runtime.CompilerServices.CallerMemberName] string callingMethod = nameof(NewDir), string identifier = "")
|
|
{
|
|
var dir = NewDir(callingMethod: callingMethod, identifier: identifier);
|
|
|
|
try
|
|
{
|
|
new NewCommand()
|
|
.WithWorkingDirectory(dir.Path)
|
|
.ExecuteWithCapturedOutput("-t Lib")
|
|
.Should().Pass();
|
|
}
|
|
catch (System.ComponentModel.Win32Exception e)
|
|
{
|
|
throw new Exception($"Intermittent error in `dotnet new` occurred when running it in dir `{dir.Path}`\nException:\n{e}");
|
|
}
|
|
|
|
return dir;
|
|
}
|
|
|
|
private static void SetTargetFrameworks(ProjDir proj, string[] frameworks)
|
|
{
|
|
var csproj = proj.CsProj();
|
|
csproj.AddProperty("TargetFrameworks", string.Join(";", frameworks));
|
|
csproj.Save();
|
|
}
|
|
|
|
private ProjDir NewLibWithFrameworks([System.Runtime.CompilerServices.CallerMemberName] string callingMethod = nameof(NewDir), string identifier = "")
|
|
{
|
|
var ret = NewLib(callingMethod: callingMethod, identifier: identifier);
|
|
SetTargetFrameworks(ret, DefaultFrameworks);
|
|
return ret;
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData("--help")]
|
|
[InlineData("-h")]
|
|
public void WhenHelpOptionIsPassedItPrintsUsage(string helpArg)
|
|
{
|
|
var cmd = new AddReferenceCommand().Execute(helpArg);
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().BeVisuallyEquivalentTo(HelpText);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData("")]
|
|
[InlineData("unknownCommandName")]
|
|
public void WhenNoCommandIsPassedItPrintsError(string commandName)
|
|
{
|
|
var cmd = new DotnetCommand()
|
|
.ExecuteWithCapturedOutput($"add {commandName}");
|
|
cmd.Should().Fail();
|
|
cmd.StdErr.Should().Be("Required command was not provided.");
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenTooManyArgumentsArePassedItPrintsError()
|
|
{
|
|
var cmd = new AddReferenceCommand()
|
|
.WithProject("one two three")
|
|
.Execute("proj.csproj");
|
|
cmd.ExitCode.Should().NotBe(0);
|
|
cmd.StdErr.Should().Be("Unrecognized command or argument 'two'");
|
|
cmd.StdOut.Should().Be("Specify --help for a list of available options and commands.");
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData("idontexist.csproj")]
|
|
[InlineData("ihave?inv@lid/char\\acters")]
|
|
public void WhenNonExistingProjectIsPassedItPrintsErrorAndUsage(string projName)
|
|
{
|
|
var setup = Setup();
|
|
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.WithProject(projName)
|
|
.Execute($"\"{setup.ValidRefCsprojPath}\"");
|
|
cmd.ExitCode.Should().NotBe(0);
|
|
cmd.StdErr.Should().Be($"Could not find project or directory `{projName}`.");
|
|
cmd.StdOut.Should().BeVisuallyEquivalentTo(HelpText);
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenBrokenProjectIsPassedItPrintsErrorAndUsage()
|
|
{
|
|
string projName = "Broken/Broken.csproj";
|
|
var setup = Setup();
|
|
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.WithProject(projName)
|
|
.Execute($"\"{setup.ValidRefCsprojPath}\"");
|
|
cmd.ExitCode.Should().NotBe(0);
|
|
cmd.StdErr.Should().Be("Project `Broken/Broken.csproj` is invalid.");
|
|
cmd.StdOut.Should().BeVisuallyEquivalentTo(HelpText);
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenMoreThanOneProjectExistsInTheDirectoryItPrintsErrorAndUsage()
|
|
{
|
|
var setup = Setup();
|
|
|
|
var workingDir = Path.Combine(setup.TestRoot, "MoreThanOne");
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(workingDir)
|
|
.Execute($"\"{setup.ValidRefCsprojRelToOtherProjPath}\"");
|
|
cmd.ExitCode.Should().NotBe(0);
|
|
cmd.StdErr.Should().Be($"Found more than one project in `{workingDir + Path.DirectorySeparatorChar}`. Please specify which one to use.");
|
|
cmd.StdOut.Should().BeVisuallyEquivalentTo(HelpText);
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenNoProjectsExistsInTheDirectoryItPrintsErrorAndUsage()
|
|
{
|
|
var setup = Setup();
|
|
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.Execute($"\"{setup.ValidRefCsprojPath}\"");
|
|
cmd.ExitCode.Should().NotBe(0);
|
|
cmd.StdErr.Should().Be($"Could not find any project in `{setup.TestRoot + Path.DirectorySeparatorChar}`.");
|
|
cmd.StdOut.Should().BeVisuallyEquivalentTo(HelpText);
|
|
}
|
|
|
|
[Fact]
|
|
public void ItAddsRefWithoutCondAndPrintsStatus()
|
|
{
|
|
var lib = NewLibWithFrameworks();
|
|
var setup = Setup();
|
|
|
|
int noCondBefore = lib.CsProj().NumberOfItemGroupsWithoutCondition();
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.WithProject(lib.CsProjPath)
|
|
.Execute($"\"{setup.ValidRefCsprojPath}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().Be("Reference `DotnetAddP2PProjects\\ValidRef\\ValidRef.csproj` added to the project.");
|
|
cmd.StdErr.Should().BeEmpty();
|
|
var csproj = lib.CsProj();
|
|
csproj.NumberOfItemGroupsWithoutCondition().Should().Be(noCondBefore + 1);
|
|
csproj.NumberOfProjectReferencesWithIncludeContaining(setup.ValidRefCsprojName).Should().Be(1);
|
|
}
|
|
|
|
[Fact]
|
|
public void ItAddsRefWithCondAndPrintsStatus()
|
|
{
|
|
var lib = NewLibWithFrameworks();
|
|
var setup = Setup();
|
|
|
|
int condBefore = lib.CsProj().NumberOfItemGroupsWithConditionContaining(ConditionFrameworkNet451);
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.WithProject(lib.CsProjPath)
|
|
.Execute($"{FrameworkNet451Arg} \"{setup.ValidRefCsprojPath}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().Be("Reference `DotnetAddP2PProjects\\ValidRef\\ValidRef.csproj` added to the project.");
|
|
cmd.StdErr.Should().BeEmpty();
|
|
var csproj = lib.CsProj();
|
|
csproj.NumberOfItemGroupsWithConditionContaining(ConditionFrameworkNet451).Should().Be(condBefore + 1);
|
|
csproj.NumberOfProjectReferencesWithIncludeAndConditionContaining(setup.ValidRefCsprojName, ConditionFrameworkNet451).Should().Be(1);
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenRefWithoutCondIsPresentItAddsDifferentRefWithoutCond()
|
|
{
|
|
var lib = NewLibWithFrameworks();
|
|
var setup = Setup();
|
|
|
|
new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.WithProject(lib.CsProjPath)
|
|
.Execute($"\"{setup.LibCsprojPath}\"")
|
|
.Should().Pass();
|
|
|
|
int noCondBefore = lib.CsProj().NumberOfItemGroupsWithoutCondition();
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(lib.Path)
|
|
.WithProject(lib.CsProjName)
|
|
.Execute($"\"{setup.ValidRefCsprojPath}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().Be("Reference `DotnetAddP2PProjects\\ValidRef\\ValidRef.csproj` added to the project.");
|
|
var csproj = lib.CsProj();
|
|
csproj.NumberOfItemGroupsWithoutCondition().Should().Be(noCondBefore);
|
|
csproj.NumberOfProjectReferencesWithIncludeContaining(setup.ValidRefCsprojName).Should().Be(1);
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenRefWithCondIsPresentItAddsDifferentRefWithCond()
|
|
{
|
|
var lib = NewLibWithFrameworks();
|
|
var setup = Setup();
|
|
|
|
new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.WithProject(lib.CsProjPath)
|
|
.Execute($"{FrameworkNet451Arg} \"{setup.LibCsprojPath}\"")
|
|
.Should().Pass();
|
|
|
|
int condBefore = lib.CsProj().NumberOfItemGroupsWithConditionContaining(ConditionFrameworkNet451);
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.WithProject(lib.CsProjPath)
|
|
.Execute($"{FrameworkNet451Arg} \"{setup.ValidRefCsprojPath}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().Be("Reference `DotnetAddP2PProjects\\ValidRef\\ValidRef.csproj` added to the project.");
|
|
var csproj = lib.CsProj();
|
|
csproj.NumberOfItemGroupsWithConditionContaining(ConditionFrameworkNet451).Should().Be(condBefore);
|
|
csproj.NumberOfProjectReferencesWithIncludeAndConditionContaining(setup.ValidRefCsprojName, ConditionFrameworkNet451).Should().Be(1);
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenRefWithCondIsPresentItAddsRefWithDifferentCond()
|
|
{
|
|
var lib = NewLibWithFrameworks();
|
|
var setup = Setup();
|
|
|
|
new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.WithProject(lib.CsProjPath)
|
|
.Execute($"{FrameworkNetCoreApp10Arg} \"{setup.ValidRefCsprojPath}\"")
|
|
.Should().Pass();
|
|
|
|
int condBefore = lib.CsProj().NumberOfItemGroupsWithConditionContaining(ConditionFrameworkNet451);
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.WithProject(lib.CsProjPath)
|
|
.Execute($"{FrameworkNet451Arg} \"{setup.ValidRefCsprojPath}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().Be("Reference `DotnetAddP2PProjects\\ValidRef\\ValidRef.csproj` added to the project.");
|
|
var csproj = lib.CsProj();
|
|
csproj.NumberOfItemGroupsWithConditionContaining(ConditionFrameworkNet451).Should().Be(condBefore + 1);
|
|
csproj.NumberOfProjectReferencesWithIncludeAndConditionContaining(setup.ValidRefCsprojName, ConditionFrameworkNet451).Should().Be(1);
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenRefWithConditionIsPresentItAddsDifferentRefWithoutCond()
|
|
{
|
|
var lib = NewLibWithFrameworks();
|
|
var setup = Setup();
|
|
|
|
new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.WithProject(lib.CsProjPath)
|
|
.Execute($"{FrameworkNet451Arg} \"{setup.LibCsprojPath}\"")
|
|
.Should().Pass();
|
|
|
|
int noCondBefore = lib.CsProj().NumberOfItemGroupsWithoutCondition();
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.WithProject(lib.CsProjPath)
|
|
.Execute($"\"{setup.ValidRefCsprojPath}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().Be("Reference `DotnetAddP2PProjects\\ValidRef\\ValidRef.csproj` added to the project.");
|
|
var csproj = lib.CsProj();
|
|
csproj.NumberOfItemGroupsWithoutCondition().Should().Be(noCondBefore + 1);
|
|
csproj.NumberOfProjectReferencesWithIncludeContaining(setup.ValidRefCsprojName).Should().Be(1);
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenRefWithNoCondAlreadyExistsItDoesntDuplicate()
|
|
{
|
|
var lib = NewLibWithFrameworks();
|
|
var setup = Setup();
|
|
|
|
new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.WithProject(lib.CsProjPath)
|
|
.Execute($"\"{setup.ValidRefCsprojPath}\"")
|
|
.Should().Pass();
|
|
|
|
int noCondBefore = lib.CsProj().NumberOfItemGroupsWithoutCondition();
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(lib.Path)
|
|
.WithProject(lib.CsProjName)
|
|
.Execute($"\"{setup.ValidRefCsprojPath}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().Be("Project already has a reference to `DotnetAddP2PProjects\\ValidRef\\ValidRef.csproj`.");
|
|
|
|
var csproj = lib.CsProj();
|
|
csproj.NumberOfItemGroupsWithoutCondition().Should().Be(noCondBefore);
|
|
csproj.NumberOfProjectReferencesWithIncludeContaining(setup.ValidRefCsprojName).Should().Be(1);
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenRefWithCondOnItemAlreadyExistsItDoesntDuplicate()
|
|
{
|
|
var setup = Setup();
|
|
var proj = new ProjDir(Path.Combine(setup.TestRoot, "WithExistingRefCondOnItem"));
|
|
|
|
string contentBefore = proj.CsProjContent();
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(proj.Path)
|
|
.WithProject(proj.CsProjPath)
|
|
.Execute($"{FrameworkNet451Arg} \"{setup.LibCsprojRelPath}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().Be("Project already has a reference to `..\\Lib\\Lib.csproj`.");
|
|
proj.CsProjContent().Should().BeEquivalentTo(contentBefore);
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenRefWithCondOnItemGroupAlreadyExistsItDoesntDuplicate()
|
|
{
|
|
var lib = NewLibWithFrameworks();
|
|
var setup = Setup();
|
|
|
|
new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.WithProject(lib.CsProjPath)
|
|
.Execute($"{FrameworkNet451Arg} \"{setup.ValidRefCsprojPath}\"")
|
|
.Should().Pass();
|
|
|
|
var csprojContentBefore = lib.CsProjContent();
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.WithProject(lib.CsProjPath)
|
|
.Execute($"{FrameworkNet451Arg} \"{setup.ValidRefCsprojPath}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().Be("Project already has a reference to `DotnetAddP2PProjects\\ValidRef\\ValidRef.csproj`.");
|
|
lib.CsProjContent().Should().BeEquivalentTo(csprojContentBefore);
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenRefWithCondWithWhitespaceOnItemGroupExistsItDoesntDuplicate()
|
|
{
|
|
var setup = Setup();
|
|
var proj = new ProjDir(Path.Combine(setup.TestRoot, "WithExistingRefCondWhitespaces"));
|
|
|
|
string contentBefore = proj.CsProjContent();
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(proj.Path)
|
|
.WithProject(proj.CsProjName)
|
|
.Execute($"{FrameworkNet451Arg} \"{setup.LibCsprojRelPath}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().Be("Project already has a reference to `..\\Lib\\Lib.csproj`.");
|
|
proj.CsProjContent().Should().BeEquivalentTo(contentBefore);
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenRefWithoutCondAlreadyExistsInNonUniformItemGroupItDoesntDuplicate()
|
|
{
|
|
var setup = Setup();
|
|
var proj = new ProjDir(Path.Combine(setup.TestRoot, "WithRefNoCondNonUniform"));
|
|
|
|
string contentBefore = proj.CsProjContent();
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(proj.Path)
|
|
.WithProject(proj.CsProjName)
|
|
.Execute($"\"{setup.LibCsprojRelPath}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().Be("Project already has a reference to `..\\Lib\\Lib.csproj`.");
|
|
proj.CsProjContent().Should().BeEquivalentTo(contentBefore);
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenRefWithoutCondAlreadyExistsInNonUniformItemGroupItAddsDifferentRefInDifferentGroup()
|
|
{
|
|
var setup = Setup();
|
|
var proj = new ProjDir(Path.Combine(setup.TestRoot, "WithRefNoCondNonUniform"));
|
|
|
|
int noCondBefore = proj.CsProj().NumberOfItemGroupsWithoutCondition();
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.WithProject(proj.CsProjPath)
|
|
.Execute($"\"{setup.ValidRefCsprojPath}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().Be("Reference `..\\ValidRef\\ValidRef.csproj` added to the project.");
|
|
var csproj = proj.CsProj();
|
|
csproj.NumberOfItemGroupsWithoutCondition().Should().Be(noCondBefore + 1);
|
|
csproj.NumberOfProjectReferencesWithIncludeContaining(setup.ValidRefCsprojName).Should().Be(1);
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenRefWithCondAlreadyExistsInNonUniformItemGroupItDoesntDuplicate()
|
|
{
|
|
var setup = Setup();
|
|
var proj = new ProjDir(Path.Combine(setup.TestRoot, "WithRefCondNonUniform"));
|
|
|
|
string contentBefore = proj.CsProjContent();
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(proj.Path)
|
|
.WithProject(proj.CsProjName)
|
|
.Execute($"{FrameworkNet451Arg} \"{setup.LibCsprojRelPath}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().Be("Project already has a reference to `..\\Lib\\Lib.csproj`.");
|
|
proj.CsProjContent().Should().BeEquivalentTo(contentBefore);
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenRefWithCondAlreadyExistsInNonUniformItemGroupItAddsDifferentRefInDifferentGroup()
|
|
{
|
|
var setup = Setup();
|
|
var proj = new ProjDir(Path.Combine(setup.TestRoot, "WithRefCondNonUniform"));
|
|
|
|
int condBefore = proj.CsProj().NumberOfItemGroupsWithConditionContaining(ConditionFrameworkNet451);
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.WithProject(proj.CsProjPath)
|
|
.Execute($"{FrameworkNet451Arg} \"{setup.ValidRefCsprojPath}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().Be("Reference `..\\ValidRef\\ValidRef.csproj` added to the project.");
|
|
var csproj = proj.CsProj();
|
|
csproj.NumberOfItemGroupsWithConditionContaining(ConditionFrameworkNet451).Should().Be(condBefore + 1);
|
|
csproj.NumberOfProjectReferencesWithIncludeAndConditionContaining(setup.ValidRefCsprojName, ConditionFrameworkNet451).Should().Be(1);
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenEmptyItemGroupPresentItAddsRefInIt()
|
|
{
|
|
var setup = Setup();
|
|
var proj = new ProjDir(Path.Combine(setup.TestRoot, "EmptyItemGroup"));
|
|
|
|
int noCondBefore = proj.CsProj().NumberOfItemGroupsWithoutCondition();
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.WithProject(proj.CsProjPath)
|
|
.Execute($"\"{setup.ValidRefCsprojPath}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().Be("Reference `..\\ValidRef\\ValidRef.csproj` added to the project.");
|
|
var csproj = proj.CsProj();
|
|
csproj.NumberOfItemGroupsWithoutCondition().Should().Be(noCondBefore);
|
|
csproj.NumberOfProjectReferencesWithIncludeContaining(setup.ValidRefCsprojName).Should().Be(1);
|
|
}
|
|
|
|
[Fact]
|
|
public void ItAddsMultipleRefsNoCondToTheSameItemGroup()
|
|
{
|
|
const string OutputText = @"Reference `DotnetAddP2PProjects\Lib\Lib.csproj` added to the project.
|
|
Reference `DotnetAddP2PProjects\ValidRef\ValidRef.csproj` added to the project.";
|
|
|
|
var lib = NewLibWithFrameworks();
|
|
var setup = Setup();
|
|
|
|
int noCondBefore = lib.CsProj().NumberOfItemGroupsWithoutCondition();
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.WithProject(lib.CsProjPath)
|
|
.Execute($"\"{setup.LibCsprojPath}\" \"{setup.ValidRefCsprojPath}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().BeVisuallyEquivalentTo(OutputText);
|
|
var csproj = lib.CsProj();
|
|
csproj.NumberOfItemGroupsWithoutCondition().Should().Be(noCondBefore + 1);
|
|
csproj.NumberOfProjectReferencesWithIncludeContaining(setup.ValidRefCsprojName).Should().Be(1);
|
|
csproj.NumberOfProjectReferencesWithIncludeContaining(setup.LibCsprojName).Should().Be(1);
|
|
}
|
|
|
|
[Fact]
|
|
public void ItAddsMultipleRefsWithCondToTheSameItemGroup()
|
|
{
|
|
const string OutputText = @"Reference `DotnetAddP2PProjects\Lib\Lib.csproj` added to the project.
|
|
Reference `DotnetAddP2PProjects\ValidRef\ValidRef.csproj` added to the project.";
|
|
|
|
var lib = NewLibWithFrameworks();
|
|
var setup = Setup();
|
|
|
|
int noCondBefore = lib.CsProj().NumberOfItemGroupsWithConditionContaining(ConditionFrameworkNet451);
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.WithProject(lib.CsProjPath)
|
|
.Execute($"{FrameworkNet451Arg} \"{setup.LibCsprojPath}\" \"{setup.ValidRefCsprojPath}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().BeVisuallyEquivalentTo(OutputText);
|
|
var csproj = lib.CsProj();
|
|
csproj.NumberOfItemGroupsWithConditionContaining(ConditionFrameworkNet451).Should().Be(noCondBefore + 1);
|
|
csproj.NumberOfProjectReferencesWithIncludeAndConditionContaining(setup.ValidRefCsprojName, ConditionFrameworkNet451).Should().Be(1);
|
|
csproj.NumberOfProjectReferencesWithIncludeAndConditionContaining(setup.LibCsprojName, ConditionFrameworkNet451).Should().Be(1);
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenProjectNameIsNotPassedItFindsItAndAddsReference()
|
|
{
|
|
var lib = NewLibWithFrameworks();
|
|
var setup = Setup();
|
|
|
|
int noCondBefore = lib.CsProj().NumberOfItemGroupsWithoutCondition();
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(lib.Path)
|
|
.Execute($"\"{setup.ValidRefCsprojPath}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().Be("Reference `DotnetAddP2PProjects\\ValidRef\\ValidRef.csproj` added to the project.");
|
|
cmd.StdErr.Should().BeEmpty();
|
|
var csproj = lib.CsProj();
|
|
csproj.NumberOfItemGroupsWithoutCondition().Should().Be(noCondBefore + 1);
|
|
csproj.NumberOfProjectReferencesWithIncludeContaining(setup.ValidRefCsprojName).Should().Be(1);
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenPassedReferenceDoesNotExistItShowsAnError()
|
|
{
|
|
var lib = NewLibWithFrameworks();
|
|
|
|
var contentBefore = lib.CsProjContent();
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(lib.Path)
|
|
.WithProject(lib.CsProjName)
|
|
.Execute("\"IDoNotExist.csproj\"");
|
|
cmd.Should().Fail();
|
|
cmd.StdErr.Should().Be("Reference IDoNotExist.csproj does not exist.");
|
|
lib.CsProjContent().Should().BeEquivalentTo(contentBefore);
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenPassedMultipleRefsAndOneOfthemDoesNotExistItCancelsWholeOperation()
|
|
{
|
|
var lib = NewLibWithFrameworks();
|
|
var setup = Setup();
|
|
|
|
var contentBefore = lib.CsProjContent();
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.WithProject(lib.CsProjPath)
|
|
.Execute($"\"{setup.ValidRefCsprojPath}\" \"IDoNotExist.csproj\"");
|
|
cmd.Should().Fail();
|
|
cmd.StdErr.Should().Be("Reference IDoNotExist.csproj does not exist.");
|
|
lib.CsProjContent().Should().BeEquivalentTo(contentBefore);
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenPassedReferenceIsUsingSlashesItNormalizesItToBackslashes()
|
|
{
|
|
var lib = NewLibWithFrameworks();
|
|
var setup = Setup();
|
|
|
|
int noCondBefore = lib.CsProj().NumberOfItemGroupsWithoutCondition();
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(lib.Path)
|
|
.WithProject(lib.CsProjName)
|
|
.Execute($"\"{setup.ValidRefCsprojPath.Replace('\\', '/')}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().Be("Reference `DotnetAddP2PProjects\\ValidRef\\ValidRef.csproj` added to the project.");
|
|
cmd.StdErr.Should().BeEmpty();
|
|
var csproj = lib.CsProj();
|
|
csproj.NumberOfItemGroupsWithoutCondition().Should().Be(noCondBefore + 1);
|
|
csproj.NumberOfProjectReferencesWithIncludeContaining(setup.ValidRefCsprojRelPath.Replace('/', '\\')).Should().Be(1);
|
|
}
|
|
|
|
[Fact]
|
|
public void WhenReferenceIsRelativeAndProjectIsNotInCurrentDirectoryReferencePathIsFixed()
|
|
{
|
|
var setup = Setup();
|
|
var proj = new ProjDir(setup.LibDir);
|
|
|
|
int noCondBefore = proj.CsProj().NumberOfItemGroupsWithoutCondition();
|
|
var cmd = new AddReferenceCommand()
|
|
.WithWorkingDirectory(setup.TestRoot)
|
|
.WithProject(setup.LibCsprojPath)
|
|
.Execute($"\"{setup.ValidRefCsprojRelPath}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().Be("Reference `..\\ValidRef\\ValidRef.csproj` added to the project.");
|
|
cmd.StdErr.Should().BeEmpty();
|
|
var csproj = proj.CsProj();
|
|
csproj.NumberOfItemGroupsWithoutCondition().Should().Be(noCondBefore + 1);
|
|
csproj.NumberOfProjectReferencesWithIncludeContaining(setup.ValidRefCsprojRelToOtherProjPath.Replace('/', '\\')).Should().Be(1);
|
|
}
|
|
|
|
[Fact]
|
|
public void ItCanAddReferenceWithConditionOnCompatibleFramework()
|
|
{
|
|
var setup = Setup();
|
|
var lib = new ProjDir(setup.LibDir);
|
|
var net45lib = new ProjDir(Path.Combine(setup.TestRoot, "Net45Lib"));
|
|
|
|
int condBefore = lib.CsProj().NumberOfItemGroupsWithConditionContaining(ConditionFrameworkNet451);
|
|
var cmd = new AddReferenceCommand()
|
|
.WithProject(lib.CsProjPath)
|
|
.Execute($"{FrameworkNet451Arg} \"{net45lib.CsProjPath}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().Be("Reference `..\\Net45Lib\\Net45Lib.csproj` added to the project.");
|
|
var csproj = lib.CsProj();
|
|
csproj.NumberOfItemGroupsWithConditionContaining(ConditionFrameworkNet451).Should().Be(condBefore + 1);
|
|
csproj.NumberOfProjectReferencesWithIncludeAndConditionContaining(net45lib.CsProjName, ConditionFrameworkNet451).Should().Be(1);
|
|
}
|
|
|
|
[Fact]
|
|
public void ItCanAddRefWithoutCondAndTargetingSupersetOfFrameworksAndOneOfReferencesCompatible()
|
|
{
|
|
var setup = Setup();
|
|
var lib = new ProjDir(setup.LibDir);
|
|
var net452netcoreapp10lib = new ProjDir(Path.Combine(setup.TestRoot, "Net452AndNetCoreApp10Lib"));
|
|
|
|
int noCondBefore = net452netcoreapp10lib.CsProj().NumberOfItemGroupsWithoutCondition();
|
|
var cmd = new AddReferenceCommand()
|
|
.WithProject(net452netcoreapp10lib.CsProjPath)
|
|
.Execute($"\"{lib.CsProjPath}\"");
|
|
cmd.Should().Pass();
|
|
cmd.StdOut.Should().Be("Reference `..\\Lib\\Lib.csproj` added to the project.");
|
|
var csproj = net452netcoreapp10lib.CsProj();
|
|
csproj.NumberOfItemGroupsWithoutCondition().Should().Be(noCondBefore + 1);
|
|
csproj.NumberOfProjectReferencesWithIncludeContaining(lib.CsProjName).Should().Be(1);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData("net45")]
|
|
[InlineData("net40")]
|
|
[InlineData("netcoreapp1.1")]
|
|
[InlineData("nonexistingframeworkname")]
|
|
public void WhenFrameworkSwitchIsNotMatchingAnyOfTargetedFrameworksItPrintsError(string framework)
|
|
{
|
|
var setup = Setup();
|
|
var lib = new ProjDir(setup.LibDir);
|
|
var net45lib = new ProjDir(Path.Combine(setup.TestRoot, "Net45Lib"));
|
|
|
|
var csProjContent = lib.CsProjContent();
|
|
var cmd = new AddReferenceCommand()
|
|
.WithProject(lib.CsProjPath)
|
|
.Execute($"-f {framework} \"{net45lib.CsProjPath}\"");
|
|
cmd.Should().Fail();
|
|
cmd.StdErr.Should().Be($"Project `{setup.LibCsprojPath}` does not target framework `{framework}`.");
|
|
|
|
lib.CsProjContent().Should().BeEquivalentTo(csProjContent);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData("")]
|
|
[InlineData("-f net45")]
|
|
public void WhenIncompatibleFrameworkDetectedItPrintsError(string frameworkArg)
|
|
{
|
|
var setup = Setup();
|
|
var lib = new ProjDir(setup.LibDir);
|
|
var net45lib = new ProjDir(Path.Combine(setup.TestRoot, "Net45Lib"));
|
|
|
|
var csProjContent = net45lib.CsProjContent();
|
|
var cmd = new AddReferenceCommand()
|
|
.WithProject(net45lib.CsProjPath)
|
|
.Execute($"{frameworkArg} \"{lib.CsProjPath}\"");
|
|
cmd.Should().Fail();
|
|
cmd.StdErr.Should().MatchRegex(ProjectNotCompatibleErrorMessageRegEx);
|
|
cmd.StdErr.Should().MatchRegex(" - net45");
|
|
net45lib.CsProjContent().Should().BeEquivalentTo(csProjContent);
|
|
}
|
|
}
|
|
}
|