Commit graph

17 commits

Author SHA1 Message Date
Peter Huene
f9b939fe89
Fix MSBuild invocation to quote property option values.
This commit ensures that any `/property` option's value is surrounded by quotes
to allow MSBuild to properly interpret special characters like semicolons.

Users familiar with MSBuild expect `/property:Name="Value"` to handle
semicolons. However, since `dotnet` parses the command line first, the
quotes get processed by its command line parser.  This results in
`/property:Name=Value` being passed to MSBuild, which will not parse a "Value"
containing a semicolon correctly.

Since it is safe to always quote the property value for this option, this fix
simply ensures that the value is surrounded by quotes.

This fixes the issue for all commands that forward arguments to MSBuild.

Fixes #7791.
2018-04-26 14:38:21 -07:00
Livar Cunha
b1fca8c4d2 Replacing the short form version of implicit msbuild parameters with longform ones. 2018-04-02 22:54:51 -07:00
Livar Cunha
10289504a8 Replacing all implicit msbuild parameters from using a forward slash to using a dash. 2018-04-02 14:49:52 -07:00
Livar Cunha
7c37c9a069 Changing the /m /v:m default parameters to msbuild to -m and -v:m to avoid confusing that with files on unix machines. 2018-04-02 12:41:21 -07:00
Nick Guerrera
35b7ad2789 Use msbuild /restore instead of separate invocations where possible
It is not currently possible when there is a -f|--framework argument because
we cannot force a TargetFramework global property on to the restore evaluation.
Doing so completely breaks restore by applying the TargetFramework to all
projects transitively. The correct behavior is to restore for all frameworks,
then build/publish/etc for the given target framework. Achieving that still
requires two distinct msbuild invocations.

This also changes the verbosity of implicit restore from quiet to that
of the subsequent command (default=minimal). Similar to global properties,
we cannot specify a distinct console verbosity for the /restore portion of
the overall execution. For consistency, we apply the same verbosity change
to the case where we still use two separate msbuild invocations.

This also fixes an issue where the separate restore invocation's msbuild log
would be overwritten by the subsequent command execution. However, this remains
unfixed in the case where we still use two separate msbuild invocations.
2017-10-26 16:01:34 -07:00
Nick Guerrera
8fead788d7 Fix dotnet build /clp:NoSummary 2017-10-26 06:37:45 -07:00
jonsequitur
abfb877c5d update Microsoft.DotNet.Cli.CommandLineParser version for more selective option splitting 2017-03-23 17:12:35 -07:00
Piotr Puszkiewicz
03544ad0cd Build Unit Tests 2017-03-09 16:39:49 -08:00
Piotr Puszkiewicz
d55a8f8188 Add missing copyright headers to all cs files 2017-03-02 21:04:03 -08:00
Krzysztof Wicher
eddca32b2f add dotnet clean unit tests 2017-02-22 17:40:02 -08:00
Krzysztof Wicher
e6578eeb14 split msbuildforwardingapp unit tests with build invocation 2017-02-16 14:22:02 -08:00
Krzysztof Wicher
1b7d4e3200 split env var test 2017-02-16 14:22:02 -08:00
Krzysztof Wicher
39feabd941 patterns for environmental variables 2017-02-16 14:22:02 -08:00
Krzysztof Wicher
531b0136eb add tests for checking filename, working dir and validation of presence of environmental variables 2017-02-16 14:22:02 -08:00
Krzysztof Wicher
8ad8fe7e8e complete dotnet-build invocation test cases 2017-02-16 14:22:02 -08:00
Krzysztof Wicher
8ebc06da46 add more unit tests 2017-02-16 14:22:02 -08:00
Krzysztof Wicher
9c00966956 preview of single unit test for dotnet build 2017-02-16 14:22:02 -08:00