Commit graph

6 commits

Author SHA1 Message Date
Eric Erhardt
d98c1f8724 dotnet build raises errors MVC apps target net46.
The issue is when the ProjectContextBuilder sees a CompileTimePlaceholder "_._" file on a full framework, it assumes that dependency has to come from the "Reference Assemblies" directory.  If it can't be found there, an error is raised.  However, there are other reasons "_._" placeholders are created (when a NuGet package doesn't want its dependencies to be exposed in the Compile dependencies of its consumers). And these placeholders can exist for assemblies that aren't in the full framework - in this case System.Diagnostics.FileVersionInfo and others.

To fix this, if the reference can't be resolved from the "Reference Assemblies" folder, it is just skipped. If the compiler really needs that assembly, it will raise an error to the user.  Dotnet build shouldn't raise the error.

Fix #2906
2016-05-06 14:32:50 -05:00
Eric Erhardt
f2d917ed2e Execute 'csc' with working directory set to the project directory.
When using a ruleset with a relative path in buildOptions, csc can't
find the file because it is not working in the same directory as the
project.

Fix #2710
2016-05-01 22:46:03 -05:00
Eric Erhardt
e2dcb968eb Add tests for invoking dotnet XX project.json from in
a folder that contains the project.
2016-04-28 08:50:22 -05:00
Eric Erhardt
5c6bf47e10 Address PR feedback. 2016-04-27 17:23:28 -05:00
Eric Erhardt
2ed81240fa dotnet build fails with xmlDoc = true and spaces in the path.
Need to quote the xmlDoc argument to the csc compiler.

Fix #2600
2016-04-27 15:43:12 -05:00
Bryan Thornbury
7a7b524b34 add tests for a test app with unicode characters in the path 2016-04-26 09:36:25 -05:00