https://github.com/dotnet/arcade/pull/6051 fixed the issue where the install
scripts require matching names of files to directories. Remove the double
publish change introduced in 3.0
Co-authored-by: dotnet-bot <dotnet-bot@dotnetfoundation.org>
Set the asset manifest OS and change the name of the installers manifests.
Currently arcade defaults to using OS-Platform as the asset manifest file name.
Installer does a ton of building in docker containers, which ends up generating
many overlapping names. This is a symptom and also likely hiding some non-determinsm.
To fix, change the name of the blob asset manifest name to include a "-installers" suffix.
Then alter the property names around a bit so that AssetManifestOS is set
prior to publish.proj's publish target being run.
Makes the following artifacts non-shipping:
- template msis
- sdkplaceholders
- sdk-internal archives
For now these have been preserved as non-shipping rather than not published at all.
They all get packaged up in the VS insertion nupkgs, so I think in reality we don't need them at all.
* Publish productVersion sparsely
Do not publish the productVersion file in every leg. Publish only in win-x64,
so that we don't end up uploading it for every manifest. Publishing breaks in this scenario today.
This is a real bug in publishing, but we will probably tighten the restrictions in the
Publish to BAR step so that multi-publishign the same asset is an error.
Also remove the productCommit-* in cases where we have overlapping rids, which would cause the same problem
With newer versions of Microsoft.DotNet.Build.Tasks.Feed you don't need to pass a temporary path to the manifest. I.e., we can remove AssetsTemporaryDirectory and associated code.
* Simplify eng\publishing.props
With newer versions of Tasks.Feed and Arcade.SDK you don't need these lines.
* Let Arcade.SDK dictate the version of Tasks.Feed
* Publish SDK bits to a suffixed location
Also, when DropSuffix==true, copy all files that contain the stable sdk version to a file containing the non-stable file name
* Resolve named CAB collision; drop the CABs.
* Resolving naming convention warning: 8 chars plus {0} are allowed.
* Update src/redist/targets/packaging/windows/clisdk/dotnet.wxs
Co-Authored-By: Peter Huene <pehuene@microsoft.com>
