Mike Lorbetske
cfa0e5cbd4
First step to ingest template engine
...
Please do not merge yet
@piotrp @seancpeters @livarocc
2016-12-16 15:15:48 -08:00
Justin Goshi
45264edcd7
Merge branch 'rel/1.0.0' into dev/jgoshi/removeProj
2016-12-16 14:53:33 -08:00
Livar Cunha
2336cd7aa0
Fixing the help message.
2016-12-16 14:31:53 -08:00
Nick Guerrera
55f48ebdac
Merge pull request #5063 from nguerrera/xlf-update
...
Update xlf with new/removed/modified strings
2016-12-16 14:26:39 -08:00
Livar
af3cab66f4
Merge pull request #5034 from livarcocc/duplicate_resource_migration
...
Adding a Exclude @(EmbeddedResource) during migration to EmbeddedResources
2016-12-16 14:26:07 -08:00
Nick Guerrera
d54ee6ff82
Update xlf with new/removed/modified strings
2016-12-16 13:32:48 -08:00
Livar Cunha
d6d6fc612b
Added a unit test for cleaning empty targets.
...
Added a clean empty targets method to CleanOutputProjectRule that removes any targets without content inside of them from the csproj.
2016-12-16 13:31:42 -08:00
Justin Goshi
917154fd5d
Address PR comments
2016-12-16 13:27:41 -08:00
Nick Guerrera
ef08c401ef
Merge pull request #5051 from v-zbsail/localization
...
LOC CHECKIN | cli | HB 20161216
2016-12-16 13:24:56 -08:00
Livar Cunha
9fd4903bf3
Addressing code review comments and adding a test for dotnet --help.
2016-12-16 12:58:34 -08:00
Livar Cunha
5558e5f728
Changing the host verbosity flag to -d|--diagnostics from -v|--verbosity so that it is not confused with the verbs verbosity flag.
2016-12-16 12:58:34 -08:00
Livar
22d7a6ede0
Merge pull request #5056 from codito/patch-1
...
Fix no build option in dotnet test task
2016-12-16 12:41:32 -08:00
Justin Goshi
ae1e183e41
Complete the refactor and test improvements
2016-12-16 10:23:26 -08:00
Justin Goshi
82f5278d8a
Merge branch 'rel/1.0.0' into dev/jgoshi/removeProj
2016-12-16 08:44:38 -08:00
Justin Goshi
806d5a2589
Implement dotnet list projects ( #5027 )
...
* Implement dotnet list projects
* Address PR comments
* Fix build breaks
2016-12-16 06:41:47 -10:00
Arun Mahapatra
8a6f67a84b
Fix no build option in dotnet test task
2016-12-16 20:42:57 +05:30
Arun Mahapatra
f3a74f1162
Return non-zero exit code for test failure in multitargeted test project.
...
Treat the errors from vstest task as errors (instead of warnings) before continuing further.
Add asserts for exit code in tests for dotnet-test and dotnet-vstest.
2016-12-16 15:39:52 +05:30
Justin Goshi
023a899db0
WIP Refactor and improve tests
2016-12-16 01:04:09 -08:00
Zbyněk Sailer
8dcfd37755
LOC CHECKIN | cli | HB 20161216
2016-12-16 09:46:50 +01:00
Justin Goshi
20f2242947
Adding dotnet remove project tests
2016-12-15 15:48:04 -08:00
Justin Goshi
07ddddfa88
Implement dotnet remove proj
2016-12-15 13:40:46 -08:00
Livar Cunha
e710958b79
Adding a Exclude @(EmbeddedResource) during migration so that we don't get duplicate resources when building migrated apps.
2016-12-15 11:17:20 -08:00
Justin Goshi
441277ccfa
Implement dotnet add project ( #5022 )
...
* Implement dotnet add project
* Addressed PR comments
2016-12-14 13:53:11 -10:00
Livar
88ac88802b
Merge pull request #5016 from nguerrera/workaround-msbuild-path-issue
...
Work around msbuild bug that blocks git tool tasks in VS2017 prompt
2016-12-14 09:12:23 -08:00
Livar
e5955e8802
Merge pull request #5015 from dotnet/shanselman-patch-3
...
Removing duplicate space in "The Current OutputType is" usage
2016-12-14 09:12:12 -08:00
Livar
2491e6b883
Merge pull request #5011 from livarcocc/condition_exists
...
Migrating publishOptions to Content Update=""
2016-12-14 09:11:38 -08:00
Livar Cunha
56dd76bdb0
Adding Update under Content for BuildOptions as well, but limiting this change only to Web Apps at the moment, because regular SDK does not have Content Include=**/* in place yet.
2016-12-13 16:45:40 -08:00
Livar Cunha
a22f4be938
Adding a UpdateContextTransform that generates items with the Update attribute set instead of Include. Also, removed the Exists condition for published content, because now that we are using Update, that check is not needed. I left the option to set a condition on the metadata though.
2016-12-13 16:45:39 -08:00
Livar Cunha
84682562bf
Adding a condition to Content CopyToPublishDirectory to validate that the file exists before trying to copy it to output, to keep the same functionality as it existed in PJ. In MSBuild world, without this condition, CopyToPublishDirectory will fail.
2016-12-13 16:45:39 -08:00
Livar
0caae96daf
Merge pull request #5014 from dotnet/shanselman-patch-1
...
projetfactory -> "projectfactory"
2016-12-13 16:35:02 -08:00
Justin Goshi
76722fd403
Improve the help text ( #5002 )
...
* WIP Improve help text
* Improve help text
* Address PR comments
* Address PR comments
* Address PR comments
2016-12-13 14:31:35 -10:00
Nick Guerrera
9cf2d74c8b
Work around msbuild bug that blocks git tool tasks in VS2017 prompt
2016-12-13 16:12:01 -08:00
Scott Hanselman
c50aeb318e
Removing duplicate space in "The Current OutputType is" usage
...
Removing duplicate space in "The Current OutputType is" usage
The LocalizableStrings.RunCommandExceptionUnableToRun3 always has as trailing space. Every instances does. Here we are adding a SECOND space so the result is:
The current OutputType is 'Library'.
2016-12-13 14:52:03 -08:00
Scott Hanselman
8ece346385
projetfactory -> "projectfactory"
...
Mispelling that shows up with "-v diag"
2016-12-13 14:43:18 -08:00
Zlatko Knezevic
148351c12d
Adding checksum links to README.md ( #4986 )
...
Adding a link next to the SDK installer and binary download to link to checksums.
2016-12-13 14:16:16 -08:00
Piotr Puszkiewicz
2fbafe6f3f
Remove StreamForwarder from CLI tests ( #4936 )
...
* WiP
* Replace StreamForwarder with OutputDataReceived
* Add build logging around test execution
* add newlines
* Add handling for the null terminator while maintaining empty lines
* Extra Diag
* Verbose logging for VS Test Console
* Fix asset file locking tests
* Add testcommand timeout + improve dotnet-new tests
* WiP
* Welcome, JoSequ!
* Fix failing tests
* Clean out diagnostics writelines
* self-PR1
2016-12-13 14:15:35 -08:00
Justin Goshi
2b7e9b6524
Clean up sln reader/writer ( #5005 )
2016-12-13 06:45:00 -10:00
Zlatko Knezevic
d335b5de40
Changing dotnet-test options ( #4987 )
...
In Preview 3, the `dotnet test` options were not aligned with the CLI's
adopted format. This PR changes the options to be aligned. Where
possible/applicable, I have shortened the long options to a meaningful
mnemonic short version.
Fixes #4960
2016-12-12 23:29:29 -08:00
Livar
1a49787a1f
Merge pull request #4993 from livarcocc/cyclic_dependency_test
...
Adding a test that validates CLI templates don't depend on CLI packages.
2016-12-12 15:48:41 -08:00
Livar Cunha
e1965327e0
Adding a test that restores all c# templates and checks that none of them depend on a package produced by the CLI. I had to write this as a single test for all templates because it cuts the test time in about half to restore all the packages at once to the same folder than to clean and restore again everytime per template.
2016-12-09 16:11:57 -08:00
Livar
bd590f51e6
Emitting PackageId whenever we emit AssemblyName. We need to do this to preserve the behavior from PJ where the package id matched the containing PJ folder name. In MSBuild, PackageId will match AssemblyName, unless it is explicitly specified. ( #4990 )
2016-12-09 16:10:16 -08:00
Krzysztof Wicher
8eaec8715b
Merge pull request #4972 from krwq/p2p-compat-check
...
add compat checks to dotnet add
2016-12-09 15:32:15 -08:00
Krzysztof Wicher
524fe3cb6b
apply review feedback
2016-12-09 12:11:11 -08:00
Livar
08527184b2
Merge pull request #4979 from livarcocc/migrate_pj_without_frameworks
...
Show proper error message when migrating PJ without frameworks section.
2016-12-09 10:14:22 -08:00
Piotr Puszkiewicz
70c8ecbf16
Merge branch 'rel/1.0.0' into migrate_pj_without_frameworks
2016-12-09 00:30:36 -08:00
Livar
1fd99f1588
Merge rel/1.0.0-preview4 back into rel/1.0.0 ( #4974 )
...
* Updating the preview4 channel to rel-1.0.0-preview4
* Add more xlf files for new strings
* bundle fsharp sdk, only Sdk directory is required
* align f# console proj
* align f# lib template
* align f# mstest template
* align f# xunit template
* align f# web template
* fix mstest package version, aligned to c#
* remove unused directories from bundled sdks
* Adding a SdkNugetVersion property when invoking dotnet pack on test packages so that test packages can reference exact packages. We need that because of https://github.com/NuGet/Home/issues/4063 . Without it, pack creates the nuspec with a version like 1.0.0-version-, instead of 1.0.0-version-<version_used_in_build>, which leads to problems when restoring the tool. Like, it ends up restoring to the closest version of the package (oldest), instead of the latest.
* Update web template for Web SDK 154 (#4948 )
* Update WebSDK version
* Update web template to get rid of globs
https://github.com/aspnet/Templates/pull/735
* MSBuild to 15.1.458 (#4950 )
* Adding MigrateWebSdkRule to the DefaultMigrationRuleSet (#4963 )
* Adding MigrateWebSdkRule to the DefaultMigrationRuleSet and adding a E2E test to cover it.
* Do not migrate compile and EmbeddedResources for web application, because those are included in the Web Sdk already.
* Addressing code review comments
2016-12-09 00:30:02 -08:00
Livar Cunha
9bddb5bac7
Addressing code review comments.
2016-12-08 20:06:55 -08:00
Livar Cunha
bb1bceb8bb
When we had a project.json without frameworks, we were failing to show the appropriate error message because when we were generating the error message itself we tried to access the project context (which requires a framework in the PJ). This fix makes the ProjectContext optional to add the migration error.
2016-12-08 19:53:35 -08:00
Krzysztof Wicher
9a8d158e09
add test coverage
2016-12-08 16:23:21 -08:00
Krzysztof Wicher
21993e0129
fix dotnet-remove-p2p tests
2016-12-08 15:04:32 -08:00